From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 10D587803CD for ; Mon, 4 Dec 2023 07:20:13 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=b81mfVoEuN8Wo/CcDeXKt+M1fIA7Iz43lc5i8gW3VE0=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701674412; v=1; b=HMQoWHHhZKU/5S5I/rQS4bHmLLY8I86ssLyvRzTuM+BrSefnsG+nbt60/OXVq2UdoOEx94Kc W0ddCIf6jxtt7t+YuYmNt2bxyzRvnU9++pBbBGRVNb0Z5Xr06HNsNSFn1bIYifermZCntus75Xd 9++0VgwiyWGaIQPyDpyJ1FiU= X-Received: by 127.0.0.2 with SMTP id nmucYY7687511xVS57oWsgDs; Sun, 03 Dec 2023 23:20:12 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.67]) by mx.groups.io with SMTP id smtpd.web10.64303.1701674412211666467 for ; Sun, 03 Dec 2023 23:20:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GAyzEjWDSXTGNiHMEemhi7pE+/2xn8BpG0CbocKEX6cv7gAmy3qIhteK60LVcrzZu1Jkqs00/snQ0wWIMXH5kjeO+N8qfl3d9LdfsW/+16JOkowOCZO+JKC3S3nrJbr08Ad2DQLDxg5D39Rb2fjRN7n0u7X5pfzX3GF5emVZgzC+p/gVjWOFnlfro9Jgv28e5Q2bpfEQi18DS8vC/24ob0HKRshJD3e9SL2GEfXVrlqfQy1n9hag0IPNK/IBJ2U5NFseZvw8llXb6Je8DQ9P2Dg5oaorY4QzroPWNcb5xaQxr/U5/g1TQaGb9VtB1HPiLWdzXGuoIVHLAFfIqX3vlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mnjifU+d2ZM8dPjFEKef/jmsGkaIQ5wJ9xC6iQ6xKqI=; b=WAPDeTYWKV5rSMxvlF3YinYpxoGGkFg+A1pHMOQKXMAkEQ0+qQIpS+WfOkK+D3vZRQoUYpMLUFZ7rtOnO1+lL7cHDkmGJb6BSKMONoxrzc2KKr6gMW5zJIgyfIO9Z0mKP5yK7rkNuEYM155Se4soImeq80wysqEuaiUP8YmANlRaaOPKOO6LP1BocJEK92tRkqmbJUqPrcYNGKbx7vJL7BVCLYIB9IKhtdb9b/FiVrH/dttgyrukR7bPYSQb7m6y+UabgNjUaf5SxDh/sLgauf+NIiJOlybzrQKZBQc1DQa1qUfChhbEr8j1s4NR/5mwYreLOxz5t27pSqM04uUN7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by PH7PR12MB5688.namprd12.prod.outlook.com (2603:10b6:510:130::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.33; Mon, 4 Dec 2023 07:20:09 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::a78e:602e:415c:4cb4]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::a78e:602e:415c:4cb4%3]) with mapi id 15.20.7046.033; Mon, 4 Dec 2023 07:20:09 +0000 From: "Nickle Wang via groups.io" To: "abner.chang@amd.com" , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Mike Maslenkin Subject: Re: [edk2-devel] [PATCH V3 9/9] RedfishPkg/HostInterfaceBmcUsbNic: Fix potential memory corruption issue Thread-Topic: [PATCH V3 9/9] RedfishPkg/HostInterfaceBmcUsbNic: Fix potential memory corruption issue Thread-Index: AQHaIPMGpIg9Bwcwy0uxJW2u4QdSg7CYwrPA Date: Mon, 4 Dec 2023 07:20:08 +0000 Message-ID: References: <20231127053107.1686-1-abner.chang@amd.com> <20231127053107.1686-10-abner.chang@amd.com> In-Reply-To: <20231127053107.1686-10-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|PH7PR12MB5688:EE_ x-ms-office365-filtering-correlation-id: 85479b62-022a-4b64-5911-08dbf4997270 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: a9e0/l+s06+haUboED9u93bC7zDaF/Z9cSlIJK4X+NmErKI9iWFCtPpTrwBnUX/AGLzzECXOX2qTLX9ECyzsJ/9l75wkEcmZ+OJte82BT/0sJq2kM4bdWn0sjoj8bAsFq6TQcmAyn2dQKKaFTxThbzt5J/dTKBVE7qJY2ibf3IGdqJsXblGDET46cLSzAj5J1+RIXpZ72SY+6MjY8ZGfKZvnbhzL7GNKfWawz1gex6pikff9rK2GhK9MWLIYBhkTHzxKUBXTOmjLJK4q6WxNp24baFkC78krs1IzWD6d0IdXICXcgubOUL08ToiHAxs4+dP1n0xynKvXcLLAJQmr/87MzLcALpnMj9Y6DM8vQSu7Z+PaXEIop/A1khrLqHeRpJsXuxAu1HFGLGUR2Qn833C0vmm7GCi5za0971ONtCp0WWelXtQBP5d5lfKXW1Z6uZZ0vBv2vLMM2IlloFjU00vlgDOIG2omUXSzcU9ys2hPTaW7wLAtkaE3S6Ivr03/kY6rSg9yLa0HJxRdKHezf+LxMHrSvj6Bsf5AjY54KbqlJdoB+Ghm91GSVCC1InqNv1NB2TGd0k1aCVkFKB+wA3GyAgFKt5GpIlNRaNPkQeIC15GvCVvG6jQj0Z2V34I162fKdsSAGpDPD1f0YNo3YoQmGTaXYSyAdfBpe43IJqhJgp2MPX6ei187RUgZ4q8c x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?E58lDYlelNLIge4lfJeoQpct+dN1vbedSNZH4Ib4ek/Qt/HhskDz5IVw4VYZ?= =?us-ascii?Q?2b0lDRVuKakoikAB8/f8e1czMT6PGZnibiO3XlesBHr3QTywEUtN+4Rf16lp?= =?us-ascii?Q?Cq4zvSnQXjnyVvZMXgTy88MIFgyrQNlXpEYfGWjq0kb76zzkwjW5CnvbiXcH?= =?us-ascii?Q?DseqXM9FmJke9huMbIb88W16Ch5Bd/VI2GkON64KyPJPGrA/EW7KVBv0NA53?= =?us-ascii?Q?HTEOv12SG20AYODODJEY2DQCmtKcqPqWnzlQo/6mb5INBBfTM92hLcppIa2H?= =?us-ascii?Q?lm1LlgHipv30XgYNCDn9Lg+fSJ1BZjBNM7KCmfd38xwThyePDxCi7VET8BRS?= =?us-ascii?Q?u6zjIOFSYylksDHvaugczM9Gs5/Ffo6uHh2EjbYvNshRETfujaN+2hX40dm0?= =?us-ascii?Q?ZJpPsuyHRGcedxJmzanob+OEADUOCJ0XGCHWamt6rC6FxG+RUKnpbgHsdRI7?= =?us-ascii?Q?Q3Li8sgSfh9/phVCEwiSWz6Pwy6cvWKEql1DFSVBx6gNYYBXdttKBMWdQJcy?= =?us-ascii?Q?tsJG7t60iU/1aW2/7USrEd/tiXsyATm0fdo/zwCGnjpTMU/o6LEai49DlPGZ?= =?us-ascii?Q?49hOWBxAEZP/r6YjP4tNHXDYK5iCXJ+L8rzXHO5ea1D/6YHlBTWJEVYNlcXu?= =?us-ascii?Q?DFLU+cXfm0qpp9lzs/rNbzL8axryJ8D9+DV/ItXMOI2nHjyWSJ2O78s9esQ3?= =?us-ascii?Q?+u3qJJE8HBhav+L09dVdzhIvGZQjj+9CO6Y3PubgbYjGvhRPOq+uhoteIXZx?= =?us-ascii?Q?fdl49MFit770jSj6w7squByA1FnbPqGuU7QM8RVePxG9yJVXvFAPv8LNIX8k?= =?us-ascii?Q?WDx2s5jvFjuqpllVE6izcGdPjtoapdPqwS7qjEHIiM2yw4W6/eyW8cw2ZsJH?= =?us-ascii?Q?Scp9aROaaZjTk4DKsImypRemmO4SIrXaybg3sjkf+2SBg5oV9vOSO+AshnZ/?= =?us-ascii?Q?puu48uF68p0NRgiCnfbB64SO8bgsdEYdZHLGnd0py2hUr6UZwjgwkViZQSbl?= =?us-ascii?Q?iuJwHvEBm/HOJpbK1Zrp19rHJkVz5QvtgFQil8tg95gJtsRzxhpMXYSTbAUA?= =?us-ascii?Q?Gw1D5OnQ4qBkX7AtPl8/npVo1rRzTb+ozJEc7UzlIyoNfNHwbB9ouWvRHi66?= =?us-ascii?Q?cm+Rl4kI+pZJAkBofv1pVicodTXP6TinwE2L3jicEaQOzgQRMXY0sJCP1Pqr?= =?us-ascii?Q?lRqM8lob+GB94O7ZYnsfIZjIAXGV12w5rn5KjUtAbav6sbqQ959+Jt5ecpDe?= =?us-ascii?Q?UEg5aFrF+gATAExMR0Rws3fi2Gd1M1HSjssEzj7jMj0r9m0LiYgSqmM6zBX4?= =?us-ascii?Q?NERaer6DDdraN8T1CZSnaggPM40lcykN4uKmmcMZ/XXnhiINeRvXWN0EVrs1?= =?us-ascii?Q?AHSmhNAqjd6ObHYvbvi15liReU6mexlxF0Cl0OmAQgyNdflgA5HfXQaUCA4Z?= =?us-ascii?Q?s+CKkIpYLUV9WZD8Yn8/hGmx4qcAp2HZ1cFzomFXq/ESoUhba3IudYKtVBY0?= =?us-ascii?Q?JBuODbmZ+PAyy0q00JUlV0q3oC/g3sfuR9ZRewcI/OsIxPD7ImBlol0bVZRv?= =?us-ascii?Q?hkyNFH8Rk217PgCp6XN7xTwFGDXkRY8DZBSryRckd1iyJf02rFmZvaXyPR1S?= =?us-ascii?Q?XzhcSC6XZELJjoAkfuhqNEQ5JfiFfFrvNzFHgjjm7Kgt?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 85479b62-022a-4b64-5911-08dbf4997270 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Dec 2023 07:20:08.9859 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mXD65awzCD8IYPO2qBlygXScQB3cLOLIghXc8tukR5eRjXjMKjhBfKza5F71NqoidD3drj8gYcHGeC3keYaysA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5688 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: rCWlNKwie9s5ij25ZpwePVuhx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=HMQoWHHh; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: abner.chang@amd.com > Sent: Monday, November 27, 2023 1:31 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy ; > Mike Maslenkin > Subject: [PATCH V3 9/9] RedfishPkg/HostInterfaceBmcUsbNic: Fix potential > memory corruption issue >=20 > External email: Use caution opening links or attachments >=20 >=20 > From: Abner Chang >=20 > Wrong memory allocation issue may result in memory corruption. >=20 > Signed-off-by: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Cc: Mike Maslenkin > --- > .../PlatformHostInterfaceBmcUsbNicLib.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterf= ac > eBmcUsbNicLib.c > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterf= ac > eBmcUsbNicLib.c > index a1ce2dd3d93..2938d54da65 100644 > --- > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterf= ac > eBmcUsbNicLib.c > +++ b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostI > +++ nterfaceBmcUsbNicLib.c > @@ -1060,7 +1060,7 @@ IdentifyUsbNicBmcChannel ( >=20 > InitializeListHead (&BmcUsbNic->NextInstance); > BmcUsbNic->MacAddressSize =3D Snp->Mode->HwAddressSize; > - BmcUsbNic->MacAddress =3D AllocateZeroPool (sizeof (BmcUsbNic- > >MacAddressSize)); > + BmcUsbNic->MacAddress =3D AllocatePool (BmcUsbNic->MacAddressSize)= ; > if (BmcUsbNic->MacAddress =3D=3D NULL) { > DEBUG ((DEBUG_ERROR, " Failed to allocate memory for HW MAC > addresss.\n")); > FreePool (BmcUsbNic); > @@ -1133,7 +1133,7 @@ CheckBmcUsbNicOnHandles ( > (VOID **)&DevicePath > ); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, " Failed to locate device path on %d handl= e.\n", > __func__, Index)); > + DEBUG ((DEBUG_ERROR, " Failed to locate device path on %d handl= e.\n", > Index)); > continue; > } >=20 > -- > 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112016): https://edk2.groups.io/g/devel/message/112016 Mute This Topic: https://groups.io/mt/102824324/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-