From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7F250780091 for ; Thu, 23 Nov 2023 00:17:43 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=neVuEwpTHiJkXzT+sy3I2q4GhZmrBSeLZolyx7WhM6c=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700698662; v=1; b=Ijwy+amBTWJf/dXGKdjur6FDXdBqZwlEnHm++otODkT8hwkdehp329km338kiQB1YV1whknq iPCff7zsVK+Yt6i8cn/Wzug/0yQba1pmHibjymlcq97tflt46Q3nygeduJYBYbP5HkyIspxbZDW tDh97uWEdUkuh9t1dzFqf67E= X-Received: by 127.0.0.2 with SMTP id T6YhYY7687511xmkBJL9Wo3H; Wed, 22 Nov 2023 16:17:42 -0800 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.41]) by mx.groups.io with SMTP id smtpd.web11.79814.1700698661282457995 for ; Wed, 22 Nov 2023 16:17:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=amKsd7DSNuvST+I3M0/s7grg6ElxEpQdg7MAbGN6Pog4H45zPRahIwVVkVNtWJNMaZdN0QSksygGG+fQTzp2AdCCXHI/QwAsM/uHQYijS9brIH76A52d8z/g20mjYvlfEUCro+dl3HuJQChlZvryhh0cZstgsHtDuBl8wS6PAaPuX6ZjR7qvQQ/MRSS/xARgUBJm0KFlxa3Vi2NlrAFnpwUSAw4D9C2JQpeeKJRYjEBXmK8gaiFlNgP9sQiUB3Rmny7XgsaDkXW+jysbSANwGJhbgQwkNjBaACtJwPBBQ/1ci3bRFdw4t5aOYZVOOt3KvwTkYpTyL2XcgT3PxQEfbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=14/lWVG0UuRT62EPlcnQv9fZK1lK0rX/5BZ+/CCnVc0=; b=f9wxIh+wvWsbGhzBIREIXrZnlt7xWsKhtZ4fraLeT6//PJ2qBEz5B5eJTKt5HJmdRB1QA3COcx+jV7+KNgJelrGhpWUJb0mEEsqkP1Yw32g8MkBZNhzTk197EtY8xd/w36TO67m7f2L1ESiLGRFefDq1f6JthGPhCgoUVLQKXxpn4D1WHyx4kaP7813pLnh2Yifj5mExIE0p/rIG9UEnmjRQfE09OL1QCGTFz8Md4LzqKsLOL1t421ZkWRB/6GLewoSzSbUmV7YnMkFoaX1cf4isJgbe8G3Zd8qLCXCsIE2NQuMQ+0bL9Gr0BIX98vnIFK+y3cCeZlEE2ZU6JTfWoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by BL1PR12MB5143.namprd12.prod.outlook.com (2603:10b6:208:31b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.19; Thu, 23 Nov 2023 00:17:37 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::a78e:602e:415c:4cb4]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::a78e:602e:415c:4cb4%3]) with mapi id 15.20.7025.019; Thu, 23 Nov 2023 00:17:37 +0000 From: "Nickle Wang via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "abner.chang@amd.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH v2 1/3] RedfishPkg: fix memory leak in HiiUtilityLib Thread-Topic: [PATCH v2 1/3] RedfishPkg: fix memory leak in HiiUtilityLib Thread-Index: AQHaHaAv8WFI7qpbnUCeRu4P9cSMv7CHCRhA Date: Thu, 23 Nov 2023 00:17:37 +0000 Message-ID: References: <20231123000103.31216-1-mike.maslenkin@gmail.com> <20231123000103.31216-2-mike.maslenkin@gmail.com> In-Reply-To: <20231123000103.31216-2-mike.maslenkin@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|BL1PR12MB5143:EE_ x-ms-office365-filtering-correlation-id: 3ec69ffe-f9db-42bd-d72c-08dbebb998fc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: ID1k71mIdpZ/pSQyi5uJPb+n4mxl2IZo2O2YLI5+Ns+UieODVgoWFkt8p9PF1Bmbs98TCYv73oTf6l8wXw8k6y86d1e2VDYI3steFatg9w3fSjN/esgkg4zJR8Fdre5JKvE28I84axDIDYs7WAM1K60OYfwhGXHIXmwEdlY/cqEIu2yJpZh0WN8bVkYsJ4POlLCMl02/ixV1GdLAnJ6EwXgbpNsTZ91022YJeFI7apQz/kZo7uJ9l3SBf4oqWEhPVTksupVdcGV001TZTuidhhs9QuHCoJfPurjhDKHsCDTPwGGP4b4yKkue33dId7x35FzGdReh02CTrhFfvdyeV+x+Z0O6/75HE9RbUshViG7dXqen8oL2sj60C8JK0QvI5w7wn/K7I+N1wT9YSTzpIcGXOlxYmQOSFY9q8DkrOpMl7DUjOFVUQc0ojHiCBDl8HNOBD5HEQF7cigwm0l6/ylne3N98EILPb3CrakrkDc5c4xKEWuAkvay7buCza1nvK6ncMbZTRHFXvecZgliX0sGFrOI8swUMCAyf2CDcg6ZU0xF5rgYsDgbhwUQpkiZD4bu0OurvGlss/BR4fMXayoY2CVa4AovBcXH6bmHyXAuU000HIX7Xfi84rv8lpuTofnEnAirYViCV73/C/lsC4uOCTriyk7ouxmQ+B3JBjEA= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?d8F2Als7qp42PKZuq9ure/Wj5U65m9N4V8tZ98itp6hrptiA5Z6iN0L6aTP0?= =?us-ascii?Q?8d8kGzXVOC1faLHqddKp7NN3k4maf4CYwtUqbLL5egsLFNpBZtrjXFpvEW1R?= =?us-ascii?Q?KiNx6YEfMermxJVxoazg59ZlqrLDXd1GvNTc6hYf6BXlSh8F911B5cB2QxJX?= =?us-ascii?Q?uituhEUrK7dFPpFL54Nh26X7tyRB/CyU321GvHQgWH8isaB/1FOvd3Wy8Us4?= =?us-ascii?Q?6xX3Q2i6KQD5AMt1bZkVHW2giRUVX3YR5Sea9trBJYGj5sFWHsA25xtOYwiC?= =?us-ascii?Q?e0I4n2oA3pKXDrTW+LqzfbhYnzfZv17cpmgCiNXZs61qdlzhMMNkq8k41OuR?= =?us-ascii?Q?PtjQsCzU442MEyQYlm1Bevqg3IdAOn+PVYZfMZD64OpQN9bCK/l+aftbyyvY?= =?us-ascii?Q?OVPPsbc7J9eWDgoKg1cSl6VUKLvoUfNH7ymDldIxB89CG0Z1rzC+7cAC9OAi?= =?us-ascii?Q?X5zU6SWCJruuqDzQDTucaf50sHmCEYqZ5d+LKtmMO063dnkaJRoD6V3Z9yJB?= =?us-ascii?Q?L5MGv9aIdtnE8IvB0BSxEnYYE+QckkGoK9oQdGva+lTJibU21EdLuBUFyBiG?= =?us-ascii?Q?jJ0KZaaVCfpBz9RPwCsC+DJ1lo3DsYDimE6C4svPd0hyJwWZ9wVNvpgu69Dd?= =?us-ascii?Q?a0GfgA2eNVqPEcS91Sc4XaFcecLyViwmE10ofMK25ArKiiNraumhs3Cl1Bj9?= =?us-ascii?Q?KnMQm4cmbC/qHQPIy21v6StA48eV4M1bGONeTDJeM+bQ5QcrEtxQqDo5D4SL?= =?us-ascii?Q?9RZu33+eeYIBeel4taae3tJA2hckydMCzVzW8SpIxmQ7lyFDLpkY2iwCV0B6?= =?us-ascii?Q?k08owCNxCL1a5qnrAdqecg4bDubuvOZiKHTCthtgoRHPcgkvP+ur7yERKNs9?= =?us-ascii?Q?QNjD3N1Jk/NJ2zQ0U3alABgDVS+k/TnOYxqNlSotzNfI9V2iy9a2PHG82QKL?= =?us-ascii?Q?Ng8/Lw0K+TfUc2mnnv3nAJ4D9Yet9CznCza3Z+eOEi/sD/Uv0bezJhX9aW4k?= =?us-ascii?Q?LTcD09gjxvCn95g+EdCEDb1i5oY6ktiAXWklkCh5W+0t444QFEi1YFqh/kSV?= =?us-ascii?Q?e8icWvxQxV6IOLOxdXWegE5AqeMvTDYKO4yEesNNPNBOR6XQ0SzZMDqlxtI2?= =?us-ascii?Q?CxqUMs13JYdHGL9YtZMwQ8QZdE5TvUxzhraAkXZEwDb+Z9wK6V4S7WDl5pZl?= =?us-ascii?Q?XHIdVpjRchur6ax/J+j2P2uAxHQd3pwd6ke0iAcxPIGEmtPOYU4TP2XC2xU1?= =?us-ascii?Q?4IO5fU1/YJOniDM3zTaven1HCpsGEoDEZ9baemK6Qy6ZgUDwRqaS+/OR6xJ2?= =?us-ascii?Q?giTwgUoihxURD9C3Jl1YkAXR7UBeeKEtzHKyOzKiO6P5KOufZgzzqQaVqyau?= =?us-ascii?Q?OKuP4PlbDXAQiag5NJDRore7kdlJJkRQ0r1gkGFe9qU964FMltCDqAQNJWrS?= =?us-ascii?Q?GlBwG7sjomAAEGJRg4uBPQugyP5rnTKhNqhwQedv7FGTSmrtVbNj81VqR8gO?= =?us-ascii?Q?YmtdK2w8BC7mE88g/+p1SYtTD64eYcNFGsQtgibXPma3pQ/YOMNGouHNjlEF?= =?us-ascii?Q?ljjTIokf4fLqPfWGCa0=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ec69ffe-f9db-42bd-d72c-08dbebb998fc X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2023 00:17:37.0925 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SwvwyEsV5aRHDHO6o8ssj94sp3xd1QM3qz2VqOcofGcjxK23qqApi4M4kAlHA0e5LIVRuwuUEUCGNepo9ELxjg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5143 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: mDz6ta6RzVZZ6OVSTgAZSnBdx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Ijwy+amB; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks for fixing memory leak issue. Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: Mike Maslenkin > Sent: Thursday, November 23, 2023 8:01 AM > To: devel@edk2.groups.io > Cc: abner.chang@amd.com; Nickle Wang ; > igork@ami.com > Subject: [PATCH v2 1/3] RedfishPkg: fix memory leak in HiiUtilityLib >=20 > External email: Use caution opening links or attachments >=20 >=20 > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Mike Maslenkin > --- > RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c > b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c > index 168b4459844f..fd322c2086d8 100644 > --- a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c > +++ b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c > @@ -388,11 +388,13 @@ SetQuestionValue ( > Question->Value.BufferLen =3D Question->StorageWidth; >=20 > Question->Value.Buffer =3D AllocateZeroPool (Question->StorageW= idth); >=20 > if (Question->Value.Buffer =3D=3D NULL) { >=20 > + FreePool (TemString); >=20 > return EFI_OUT_OF_RESOURCES; >=20 > } >=20 >=20 >=20 > CopyMem (Question->Value.Buffer, TemString, StrSize (TemString)); >=20 > Src =3D Question->Value.Buffer; >=20 > + FreePool (TemString); >=20 > } else { >=20 > CopyMem (&Question->Value.Value, &QuestionValue->Value, sizeof > (EFI_IFR_TYPE_VALUE)); >=20 > Src =3D (UINT8 *)&Question->Value.Value; >=20 > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111631): https://edk2.groups.io/g/devel/message/111631 Mute This Topic: https://groups.io/mt/102759077/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-