From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 10926D8062F for ; Wed, 27 Mar 2024 07:39:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Ze8b+VdW4HvJxTQadf5HhagcsnFRspWlmjZJLAamacU=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1711525166; v=1; b=I/463bZYjzvXkRLqpI++AC/9hsO+Diskc2GIjlD3XbNCo6s4tsw+6DRiAKqaQGq/VcBszXEk qY6NbPgl5l33VgFFOhXFurVDzHNpQm63EAuQ/EEniZJJWsY2BrfaR0rV/2hkvRIpkGm5T036A+z wmbhMWWULBmCHNSizsea6pDv0FVYwbv0mT8EEr3jnKKJDME8rTupe+646CQEvUSvN5eFMCbbRos eZf/KD9DurrBgJ9e6aKfjwMuMTba0IKYgxthv1UOBsIEgQCW4kERqh3o4NfvZ+fit/7adobZGdW JDMsiZnvcVCXAkwF9dS9uzALGKuiKWAqQ61g+6CNZkfuw== X-Received: by 127.0.0.2 with SMTP id bmQ8YY7687511xWpK1G2lvUG; Wed, 27 Mar 2024 00:39:26 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.86]) by mx.groups.io with SMTP id smtpd.web11.31895.1711525165796951660 for ; Wed, 27 Mar 2024 00:39:26 -0700 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by SJ2PR12MB8158.namprd12.prod.outlook.com (2603:10b6:a03:4f7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.31; Wed, 27 Mar 2024 07:39:21 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::fef9:2c9c:21b5:6f50]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::fef9:2c9c:21b5:6f50%2]) with mapi id 15.20.7409.031; Wed, 27 Mar 2024 07:39:21 +0000 From: "Nickle Wang via groups.io" To: "abner.chang@amd.com" , "devel@edk2.groups.io" CC: Igor Kulchytskyy Subject: Re: [edk2-devel] [PATCH V2 4/6] RedfishPkg/RedfishPlatformConfigDxe: HII string is deleted unexpectedly Thread-Topic: [PATCH V2 4/6] RedfishPkg/RedfishPlatformConfigDxe: HII string is deleted unexpectedly Thread-Index: AQHaf5B7nCQbeaoa2EyUCyivWHll1bFLNH7w Date: Wed, 27 Mar 2024 07:39:21 +0000 Message-ID: References: <20240326151503.106-1-abner.chang@amd.com> <20240326151503.106-5-abner.chang@amd.com> In-Reply-To: <20240326151503.106-5-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|SJ2PR12MB8158:EE_ x-ms-office365-filtering-correlation-id: 286bf52d-23c1-4922-c793-08dc4e310446 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: SCd2Lgvzl87aghlGsfStdPmdj3M5Xf5AceTEJJ1ZIs6QJLsAhsG+dvuddgu/eeTwVgk3B8PIWcxxh8gV8ZBuVKvahEFoCcvpv5ERhkmUYCo0i9Ls9X6eRxRQIl9dimFBJNQ6dfUHJUJu+9z0FMsU3gA7ndh4ZFIYC0ahbhr03S3244y8TCiU6Nsl/acrRWeK8CrrUyemAdz9VtlFE+U8NxYydSezklO0AgAszAAff8wQnudU4cK3uDX6VBzv3JWg1vPFiBPrgJwlIItXgC4/0kzw5Gyxsnkgy01SUh4s4rghhJSvQoIPQQOrVzCQj0R0numhB2N7ymUCXTaHmdrkCxmHANZByrzR0Z8HcETfLiU1hX/Bp/XxHOsGlB71/hwJRz2xSxch5SF8eiZmBgudpMWrDchLqn+MY1b1OcJleYMZPK2xgpJMungv3d4Ipoz+tLDw69mmHv2CLQMgGFku1hvaVTuxeasUlm4Bqw/9xhurdyTP1XlhTMZ8WXsdZUYl8n70TXzRk8+jUCAMROTwUUsj9hMnYaOLBEV4kKcrLHRonyLXarITfSxZcUemPVdqU2mwGu7r/XzKMXSfQAJc0CMwVG5fAeISjd0f5Un2WyzgVujBCBbvbhmMEeX8TdiKg7Xl7Hkp9ziWRuysoYkAeaB9EJ8GFDFooMYtN2cLKuf4kiewB7C+rQpP1MrVA6JbU5YV/cbnGYClw7yBCYX3ug== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zRiYy/pMnWl/LDqKsSxHqVeI7Ll7j1yeRCRp2pVwxQhJVU9lM+k+19FcJur8?= =?us-ascii?Q?bnbs2xv7on7+HYoGCDioytDAC/zoYR3/ACbOcMpFdN/dLiOswjvs9Bd7Xra2?= =?us-ascii?Q?KMNUagU7+4lUymbxwVamlf97CmDRFFfNcGPFjNPGeSaFuhG9SDqJEH4uS0fw?= =?us-ascii?Q?hdu4Swp2i4ppZ1CCZ7x4bDYOvX9YEarqCCUnnvPKFKIDQMRSqvu4jLm0UM50?= =?us-ascii?Q?qz8VAyqFvfyqCnBdlRSY+K+01tUUdnhQDEEwwONCF1D9lz37CdHWUSWlgcXu?= =?us-ascii?Q?Al+BhlX0/PXXGh5onQlGLCF7MHfAraFWBzSL5hl4/jsXaC+A1BgwRo/vz4Ox?= =?us-ascii?Q?Jfed2Zm9z7QqjDlRfSzmpi7VsT0KbJDAOcrinD5d56yz7ED5szn1yulQKjDO?= =?us-ascii?Q?uHqovEJ27Wm3dXM89KG1hC8uH81BK6vENrwZjvWQmQ6hfwXH6f/bSl9+n4Xt?= =?us-ascii?Q?yjxwS7x+GbZuuo9Zq7K9DGpBgyMF34jkS1Gya9EKucTe4QgXjTp1wpnWYLsU?= =?us-ascii?Q?QUnVybsshXVPj/eU8Js0h+0v97PmJzZILpmU+ycvhP0W6sG84vX4Zjw3mAoE?= =?us-ascii?Q?dr58UDACsuwTSADetW2rNkDE2VnS89YpH56qu4yahZ3WW7usqn+aNu7Lh1/1?= =?us-ascii?Q?w3Nj+zuPLqdYuF2jof5/j8FyCM0zgW5BMWV/Jzsd9GCsVOTJWC2DwXAcMP3F?= =?us-ascii?Q?Cz6MthJ4GoCxEKx8JYPjK4hnegWhJttatnJsjWTXblC/zBYeJLSgNNwcDlUH?= =?us-ascii?Q?lu6hTecyJW+tEWgx6uYiFxqVltWB9OYETkPEct4GExFJ9MmF9Yyjd6eEn3a1?= =?us-ascii?Q?vNip7Sz7JO7OOkkQMmMsRn7cNXj1h99hWrRWLJXZh/OroZBWzcVIL3FByoWa?= =?us-ascii?Q?YajJ69VWUEEBXdY22g6XSrZfupZqBVIzvJfjxbb3Hz50X2k4kWBPEbiJ1FSc?= =?us-ascii?Q?RoOQoSW+u0gRPXXLz4gOJQ4pNQF+3g4Yfy28HGOjX1R+YaLKB+4QiVxqeSBU?= =?us-ascii?Q?/IQByz0ePgfcNY3rRTBMCa6XCd4qTjGOYXC3pc5zKsDGXoNq+9ki28ex1hvk?= =?us-ascii?Q?SSZQhDtmQyFKfcsEr2gPXxpUpsX/fjStKz4DoTKwWwSYeXuHY3eWJsaDjxlU?= =?us-ascii?Q?KsBG8pqB1JUoTvDd/syP8RliSn3WJ/RCtr/5sU+VT10zU0oG4nUj8iljOQ6E?= =?us-ascii?Q?2AK/sbOx+No+f/LemVljv1taofYksHu2kEJq7f3yHrKz3mCLuAWoZd6qDoq3?= =?us-ascii?Q?X1EEK/aIgch5iY51mvXR3UB/9lNFmqTVj+L9FTo8hzNG6S9BOgndJmPYdA16?= =?us-ascii?Q?elS1VjwN4BBkkgTzLyU5jWIW2PqB9UskACS//0k3Xi+l1teYcqMd6eHm2ZM7?= =?us-ascii?Q?4rObSn+CvWQw6R4duY0jfZcU2Fjz5jhlR4OHLX/0fsNd6fX+iUcOx9vgMqbG?= =?us-ascii?Q?MJS4uijWLJYBxkoUjRKn2nBeZZ3pU0ByEzihEGs2MUqe82XYkiTdfhPMJP1a?= =?us-ascii?Q?eObb6eISogC78GhlUUxZG5awo9BJzcozJ9Yn76zG18UfsqsOG7Yp/AqaRA/z?= =?us-ascii?Q?DSVQFhW2cMBArCRv5bU=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 286bf52d-23c1-4922-c793-08dc4e310446 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2024 07:39:21.1374 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3+1svMTWhmYRwCqzF1Eu4K9I1Zv8LruVYWFs+/6VGHAHopvCj7ZN/ka4HDOQsbAECZNHplKV6qVM6oAJUMTFCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8158 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 27 Mar 2024 00:39:26 -0700 Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: m9iiGQ1iH7B1rF8UJqK4V1L4x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="I/463bZY"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=pass (policy=none) header.from=groups.io Thanks for addressing this issue. Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: abner.chang@amd.com > Sent: Tuesday, March 26, 2024 11:15 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [PATCH V2 4/6] RedfishPkg/RedfishPlatformConfigDxe: HII string i= s > deleted unexpectedly >=20 > External email: Use caution opening links or attachments >=20 >=20 > From: Abner Chang >=20 > Add the condition check when delete HII string. > Only when the HiiStatement operand equal to "EFI_IFR_STRING_OP" > and the statement value type =3D EFI_IFR_TYPE_STRING. >=20 > Signed-off-by: Abner Chang > Co-authored-by: Nickle Wang > Cc: Igor Kulchytskyy > --- > .../RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe= .c > b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c > index 8a02c839035..d165799f9a1 100644 > --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c > +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c > @@ -1873,8 +1873,11 @@ RedfishPlatformConfigSetStatementCommon ( > DEBUG ((DEBUG_ERROR, "%a: failed to save question value: %r\n", __fu= nc__, > Status)); > } >=20 > - if (StatementValue->Value.string !=3D 0) { > - HiiDeleteString (StatementValue->Value.string, TargetStatement- > >ParentForm->ParentFormset->HiiHandle); > + if ((TargetStatement->HiiStatement->Operand =3D=3D EFI_IFR_STRING_OP) = && > (StatementValue->Type =3D=3D EFI_IFR_TYPE_STRING)) { > + if (StatementValue->Value.string !=3D 0) { > + // Delete HII string which was created for HII statement operand = =3D > EFI_IFR_STRING_OP and Type =3D EFI_IFR_TYPE_STRING. > + HiiDeleteString (StatementValue->Value.string, TargetStatement- > >ParentForm->ParentFormset->HiiHandle); > + } > } >=20 > return Status; > -- > 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117154): https://edk2.groups.io/g/devel/message/117154 Mute This Topic: https://groups.io/mt/105159786/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-