Re: [edk2-platforms][PATCH V2 07/14] ManageabilityPkg: Add definitions of MCTP

["Nickle Wang" <nicklew@nvidia.com>]

Reviewed-by: Nickle Wang <nicklew@nvidia.com>

Regards,
Nickle

> -----Original Message-----
> From: abner.chang@amd.com <abner.chang@amd.com>
> Sent: Tuesday, April 18, 2023 3:16 PM
> To: devel@edk2.groups.io
> Cc: Isaac Oram <isaac.w.oram@intel.com>; Abdul Lateef Attar
> <abdattar@amd.com>; Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy
> <igork@ami.com>
> Subject: [edk2-platforms][PATCH V2 07/14] ManageabilityPkg: Add definitions
> of MCTP
> 
> External email: Use caution opening links or attachments
> 
> 
> From: Abner Chang <abner.chang@amd.com>
> 
> Add definitions of MCTP manageability transport interface library.
> 
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Abdul Lateef Attar <abdattar@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> ---
>  Features/ManageabilityPkg/ManageabilityPkg.dec | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec
> b/Features/ManageabilityPkg/ManageabilityPkg.dec
> index 9c9f0d8232..6b198e6a3c 100644
> --- a/Features/ManageabilityPkg/ManageabilityPkg.dec
> +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec
> @@ -45,6 +45,7 @@
>    # Manageability Protocol IPMI
>    gManageabilityProtocolIpmiGuid    = { 0x36ACA47C, 0xCC80, 0x473B, { 0xAB,
> 0xEC, 0xF3, 0x98, 0xFF, 0x87, 0x74, 0x5B } }
>    # Manageability Protocol MCTP
> +  #  MCTP is a transport interface but also a protocol that can be trasmitted
> over other transport interfaces.
>    gManageabilityProtocolMctpGuid    = { 0x76FED8F1, 0x0BE5, 0x4269, { 0xA3,
> 0x1A, 0x38, 0x0F, 0x54, 0xF1, 0xA1, 0x8A } }
>    # Manageability Protocol PLDM
>    gManageabilityProtocolPldmGuid    = { 0x3958090D, 0x69DD, 0x4868, { 0x9C,
> 0x41, 0xC9, 0xAC, 0x31, 0xB5, 0x25, 0xC5 } }
> @@ -52,3 +53,18 @@
>  [Protocols]
>    gEdkiiPldmProtocolGuid                = { 0x60997616, 0xDB70, 0x4B5F, { 0x86,
> 0xA4, 0x09, 0x58, 0xA3, 0x71, 0x47, 0xB4 } }
>    gEdkiiPldmSmbiosTransferProtocolGuid  = { 0xFA431C3C, 0x816B, 0x4B32,
> { 0xA3, 0xE0, 0xAD, 0x9B, 0x7F, 0x64, 0x27, 0x2E } }
> +  gEdkiiMctpProtocolGuid                = { 0xE93465C1, 0x9A31, 0x4C96, { 0x92,
> 0x56, 0x22, 0x0A, 0xE1, 0x80, 0xB4, 0x1B } }
> +
> +[PcdsFixedAtBuild]
> +  ## This value is the MCTP Interface source and destination endpoint ID for
> transmiting MCTP message.
> +  # @Prompt MCTP source endpoint ID
> +
> +gManageabilityPkgTokenSpaceGuid.PcdMctpSourceEndpointId|0|UINT8|0x00
> 000
> +001
> +  # @Prompt MCTP destination endpoint ID
> +
> +gManageabilityPkgTokenSpaceGuid.PcdMctpDestinationEndpointId|0|UINT8|
> 0x
> +00000002
> +  ## This is the value of MCTP KCS I/O base address mode
> +  # @Prompt MCTP KCS I/O base address mode
> +
> +gManageabilityPkgTokenSpaceGuid.PcdMctpKcsMemoryMappedIo|0|BOOLEA
> N|0x00
> +000003
> +  ## This is the value of MCTP KCS I/O base address
> +  # @Prompt MCTP KCS (Memory mapped) I/O base address
> +
> +gManageabilityPkgTokenSpaceGuid.PcdMctpKcsBaseAddress|0xca2|UINT32|0
> x00
> +000004
> +
> --
> 2.37.1.windows.1