Re: [edk2-devel] [edk2-redfish-client][RFC PATCH 0/3] RedfishClientPkg: fix GetRedpathNodeByIndex()

["Nickle Wang via groups.io" <nicklew=nvidia.com@groups.io>]

Thanks, Mike!

I merged this pull request.

Regards,
Nickle

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Wednesday, March 27, 2024 5:19 AM
> To: Nickle Wang <nicklew@nvidia.com>
> Cc: Chang, Abner <Abner.Chang@amd.com>; devel@edk2.groups.io; Igor
> Kulchytskyy <igork@ami.com>
> Subject: Re: [edk2-redfish-client][RFC PATCH 0/3] RedfishClientPkg: fix
> GetRedpathNodeByIndex()
>
> External email: Use caution opening links or attachments
>
>
> Hi,
>
> I have updated patches with R-b and pushed it to PR
> https://github.co/
> m%2Ftianocore%2Fedk2-redfish-
> client%2Fpull%2F85&data=05%7C02%7Cnicklew%40nvidia.com%7Cb629e25259
> 1746cf422108dc4dda60d8%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0
> %7C638470847554354719%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw
> MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&s
> data=%2BcHo1%2B%2F5kopSeQxXQjbiXLctLbqeg5tzevhIH%2Bg3hv8%3D&reserv
> ed=0
>
> Thank you for the review!
>
> Regards,
> Mike
>
> On Tue, Mar 26, 2024 at 4:41 PM Nickle Wang <nicklew@nvidia.com> wrote:
> >
> > Thanks for your reminder, Abner. I verify this patch series on my system, and I
> don't see any issue.
> >
> >
> >
> > Hi @Mike Maslenkin, please add Abner and my reviewed-by to the commit
> messages. And we can merge the pull request.
> >
> >
> >
> > Thanks,
> >
> > Nickle
> >
> >
> >
> > > -----Original Message-----
> >
> > > From: Chang, Abner <Abner.Chang@amd.com>
> >
> > > Sent: Monday, March 25, 2024 10:13 AM
> >
> > > To: Mike Maslenkin <mike.maslenkin@gmail.com>; devel@edk2.groups.io
> >
> > > Cc: Igor Kulchytskyy <igork@ami.com>; Nickle Wang <nicklew@nvidia.com>
> >
> > > Subject: RE: [edk2-redfish-client][RFC PATCH 0/3] RedfishClientPkg: fix
> >
> > > GetRedpathNodeByIndex()
> >
> > >
> >
> > > External email: Use caution opening links or attachments
> >
> > >
> >
> > >
> >
> > > [AMD Official Use Only - General]
> >
> > >
> >
> > > For this patch set,  Reviewed-by: Abner Chang <abner.chang@amd.com>
> >
> > >
> >
> > > Hi Nickle, please also take a look at this change. Thanks Abner
> >
> > >
> >
> > > > -----Original Message-----
> >
> > > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> >
> > > > Sent: Saturday, March 23, 2024 8:01 PM
> >
> > > > To: devel@edk2.groups.io
> >
> > > > Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> >
> > > > <igork@ami.com>; Nickle Wang <nicklew@nvidia.com>; Mike Maslenkin
> >
> > > > <mike.maslenkin@gmail.com>
> >
> > > > Subject: [edk2-redfish-client][RFC PATCH 0/3] RedfishClientPkg: fix
> >
> > > > GetRedpathNodeByIndex()
> >
> > > >
> >
> > > > Caution: This message originated from an External Source. Use proper
> >
> > > > caution when opening attachments, clicking links, or responding.
> >
> > > >
> >
> > > >
> >
> > > > This set contains fixes for proper nodes handling in
> GetRedpathNodeByIndex().
> >
> > > > It fixes handling of nodes with Index different from 0, it removes
> >
> > > > leading '/' returned for section with Index = 0, also it fixes return
> >
> > > > of the last section.
> >
> > >
> >
> > > This set does not have any impact to
> >
> > > > existing code,
> >
> > > > because in all places this function is used to obtain the end of the first
> section.
> >
> > > > And actually returned pointer to the requested section is not used.
> >
> > > > The current usages is:
> >
> > > >    GetRedpathNodeByIndex (ConfigLangList.List[0].ConfigureLang, 0,
> >
> > > > &EndOfChar);
> >
> > > >
> >
> > > > and return of EndOfChar value is not affected by this set.
> >
> > > >
> >
> > > > Cc: Abner Chang <abner.chang@amd.com>
> >
> > > > Cc: Igor Kulchytskyy <igork@ami.com>
> >
> > > > Cc: Nickle Wang <nicklew@nvidia.com>
> >
> > > > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> >
> > > >
> >
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117287): https://edk2.groups.io/g/devel/message/117287
Mute This Topic: https://groups.io/mt/105101990/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-