From: "Nickle Wang via groups.io" <nicklew=nvidia.com@groups.io>
To: Mike Maslenkin <mike.maslenkin@gmail.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "abner.chang@amd.com" <abner.chang@amd.com>,
"igork@ami.com" <igork@ami.com>
Subject: Re: [edk2-devel] [PATCH v2 5/6] RedfishClientPkg: fix misprints in Readme.md
Date: Wed, 30 Aug 2023 01:51:45 +0000 [thread overview]
Message-ID: <MW4PR12MB7031AA4A40EC735AA6B4F054D9E6A@MW4PR12MB7031.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230829080112.12748-6-mike.maslenkin@gmail.com>
Reviewed-by: Nickle Wang <nicklew@nvidia.com>
Regards,
Nickle
> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Tuesday, August 29, 2023 4:01 PM
> To: devel@edk2.groups.io
> Cc: abner.chang@amd.com; Nickle Wang <nicklew@nvidia.com>;
> igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> Subject: [PATCH v2 5/6] RedfishClientPkg: fix misprints in Readme.md
>
> External email: Use caution opening links or attachments
>
>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> ---
> RedfishClientPkg/Readme.md | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/RedfishClientPkg/Readme.md b/RedfishClientPkg/Readme.md
> index 18a27633cf45..0aec0580aa5c 100644
> --- a/RedfishClientPkg/Readme.md
> +++ b/RedfishClientPkg/Readme.md
> @@ -40,7 +40,7 @@ Below are the block diagrams of UEFI Redfish Client EDK2
> Implementation.
> ![UEFI Redfish Client
> Implementation](https://nam11.safelinks.protection.outlook.com/?url=https%3A
> %2F%2Fgithub.com%2Fchangab%2Fedk2-staging%2Fblob%2Fedk2-redfish-
> client%2FRedfishClientPkg%2FDocuments%2FMedia%2FRedfishClientDriverStack
> .svg%3Fraw%3Dtrue&data=05%7C01%7Cnicklew%40nvidia.com%7Ceee05325db
> a24945583f08dba8662453%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0
> %7C638288928897098811%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw
> MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C
> &sdata=DlhlqaDQub6Cd9TD7M2sP9hchqAHAigsjy7Z%2FfohSXs%3D&reserved=0)
>
>
>
> ## EFI EDK2 Redfish Client Framework
>
> -The functionality of each block in the diagrams are described in belwo sections,
>
> +The functionality of each block in the diagrams are described in below sections,
>
>
>
> ### EDK2 Redfish Foundation ***[[1]](#[0])***
>
> EDK2 Redfish Redfish Foundation provides the facilities of communicating with
>
> @@ -68,7 +68,7 @@ project.
>
>
> ### EDK2 Redfish JSON Schema to C Structure Convertor ***[[3]](#[0])***
>
> This is the script auto-generated EDK2 drivers and libraries that provide the
>
> -Redfish schema naming based JSON to C structure and vise versa converters. C
>
> +Redfish schema naming based JSON to C structure and vice versa converters. C
>
> structure is another representation of Redfish properties other than JSON and
>
> CSDL(XML). The higher layer Redfish client application can deal with C structure
>
> instead of using JSON library to manipulate Redfish properties. The script
>
> @@ -85,7 +85,7 @@ sits between **JSON Schema to C Structure converters**
> and **EFI Platform
> Configuration to Redfish Protocol**. The Redfish feature driver gets and sets
>
> the platform configuration and incorporates it with Redfish JSON schema C
>
> structure to manipulate Redfish JSON resources. Then applies the settings from
>
> -Redfish service to platform configurations, or vise versa to update platform
>
> +Redfish service to platform configurations, or vice versa to update platform
>
> configurations to Redfish service. Both EDK2 Redfish Non-Collection and
>
> Collection Feature drivers are script auto-generated base on Redfish schema
>
> naming. The EDK2 Redfish Non-Collection feature driver manages the resource of
>
> --
> 2.32.0 (Apple Git-132)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108109): https://edk2.groups.io/g/devel/message/108109
Mute This Topic: https://groups.io/mt/101027007/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-08-30 1:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 8:01 [edk2-devel] [PATCH v2 0/6] RedfishClientPkg: fix issues with local variables Mike Maslenkin
2023-08-29 8:01 ` [edk2-devel] [PATCH v2 1/6] RedfishClientPkg: fix crash on access to uninialized list variable Mike Maslenkin
2023-08-30 1:47 ` Nickle Wang via groups.io
2023-08-31 3:28 ` Chang, Abner via groups.io
2023-08-29 8:01 ` [edk2-devel] [PATCH v2 2/6] RedfishClientPkg: fix access to uninitialized variable Mike Maslenkin
2023-08-30 1:48 ` Nickle Wang via groups.io
2023-08-29 8:01 ` [edk2-devel] [PATCH v2 3/6] RedfishClientPkg: fix leak of allocated Etag data Mike Maslenkin
2023-08-30 1:49 ` Nickle Wang via groups.io
2023-08-29 8:01 ` [edk2-devel] [PATCH v2 4/6] RedfishClientPkg: fix memory leak during EFI variables write Mike Maslenkin
2023-08-30 1:49 ` Nickle Wang via groups.io
2023-08-29 8:01 ` [edk2-devel] [PATCH v2 5/6] RedfishClientPkg: fix misprints in Readme.md Mike Maslenkin
2023-08-30 1:51 ` Nickle Wang via groups.io [this message]
2023-08-29 8:01 ` [edk2-devel] [PATCH v2 6/6] RedfishClientPkg: spelling fixes Mike Maslenkin
2023-08-30 1:52 ` Nickle Wang via groups.io
2023-08-30 15:30 ` Igor Kulchytskyy via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR12MB7031AA4A40EC735AA6B4F054D9E6A@MW4PR12MB7031.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox