From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8AFD4D80A14 for ; Wed, 27 Mar 2024 07:40:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=MGX+RQ4f8QMzJwVKCsRTRLdUQZJC+OjGvKvGsNXEvwA=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1711525203; v=1; b=PEFx+6rymXpDpcDV90tvDCCMD3v8iPWc7FOvZpRO2z+I+WEK+ELhITdKHBv76/gqFIaMeUcL gZ4zzEYY5hE1bq77OhE2wXoFtTvO7skG+6GIQ0PVcRQyp/YME2ilNe0Ms3KiOpmrCMGHocSegao DkYgcBhJ6A5qjtRYKWR1lJhCveAQ2H40qrAOZbz44l+j0U20tH8Cs0IFUD/XdW+jNiopcBn6n9Y nj9WLdQfoKD8N3Fwf5YndE5vuOk8zAi9ZxT9x/D2U2I5usiYLAGQbj1xQZ7DcIEGm2Y+GmR2xNX VvqfMCe8os46uVY9GKa5Lm1xqPF8tDK8P9/9bhXbLN0nw== X-Received: by 127.0.0.2 with SMTP id 5R1OYY7687511xSEJzRKtcKB; Wed, 27 Mar 2024 00:40:03 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.52]) by mx.groups.io with SMTP id smtpd.web11.31904.1711525202407661486 for ; Wed, 27 Mar 2024 00:40:02 -0700 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by SJ2PR12MB8158.namprd12.prod.outlook.com (2603:10b6:a03:4f7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.31; Wed, 27 Mar 2024 07:39:58 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::fef9:2c9c:21b5:6f50]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::fef9:2c9c:21b5:6f50%2]) with mapi id 15.20.7409.031; Wed, 27 Mar 2024 07:39:58 +0000 From: "Nickle Wang via groups.io" To: "devel@edk2.groups.io" , "abner.chang@amd.com" CC: Igor Kulchytskyy Subject: Re: [edk2-devel] [PATCH V2 6/6] RedfishPkg/RedfishPlatformConfigDxe: support menu path report Thread-Topic: [edk2-devel] [PATCH V2 6/6] RedfishPkg/RedfishPlatformConfigDxe: support menu path report Thread-Index: AQHaf5COo+QCOvwkZ0WEQOLsoNfKVLFLNMFw Date: Wed, 27 Mar 2024 07:39:58 +0000 Message-ID: References: <20240326151503.106-1-abner.chang@amd.com> <20240326151503.106-7-abner.chang@amd.com> In-Reply-To: <20240326151503.106-7-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|SJ2PR12MB8158:EE_ x-ms-office365-filtering-correlation-id: b1a611b5-373c-4402-3507-08dc4e311a9c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 6ExAibG+c5hbqKXOT+lOjsiqFKvx+YjVol6FNxbWwzD7LE5B14ooRmX9b8BkItnOcxbgphJ9+NEZN/6zglOYMc8lz0djpkpfcdZhiOGg89jdYpOHzkfOtd5exQSYVwsOkotBYhkfwFyT4UjTVrWK34WN63EStDcdrxPU8wCV8xipGBfM845HSLUZX8sWaU5tJ/cPZFaTI61jeaFrsm6hQLRgnnq9Tenkcyr/1QdKiuMXhsX9vvc+dy9MglDf69KOBA8O26AH6L03GzhkpH38ic9uA/bzIBJbf9ruwMlTEEf0pZ2hHGT6WeALAhZEoyEdEmmlzYTodwNlAv/WuNVb73tPbMK8SCtovaNaQCERmyUqhdwmCU/Kk0C146X4ijbgTONHZKxPrz2WVrWAGWMDXzxI6GqTNqOs/wRoRmwf/TCm5gSOjsqdh3WbOFgDR52wQMOdLnTPfKVVQubZ6bHiqi2iWaJlza15SPpk6jw7h2R8Mw6jXACGAwaqhX0ey9YHiQPE2H+6QmuoGF1tipu9r5u306ucbRu6vir0BFFZ+SxoTdohx5veuHIBhNKT4mRGKgyNz+AAcmX7Omp9xjySouHB7dv1NcLQNEHRCJE3i20oNamNT7DI83deY9bBbX6PzMya3c7n1RruohBbqIOMkkKaA25H6cFVQeGZF2sm0aA= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ayeqU3sKqcT+Vj1jy8adLag4AxHU1GDTukcC1tE/kVIZtf2u0LRHvkyZOsGK?= =?us-ascii?Q?cJl0vD1Eqdk0nO95NIFgQ8teIrlBzur46a82JxoBnaJM8dKy9Lpu3kEgtunJ?= =?us-ascii?Q?IMD36nfuK30wtnSVv6p5/qXuVfMIWMA39fhvzDNbexYDKZbQ2ECMxuqAGP1t?= =?us-ascii?Q?mzjAy8DKNxjkWHTiJEHHhq+8dhoyNzEHXt1dZ+mDG4tS23v9uJqZto1xNPhN?= =?us-ascii?Q?lwyOWNRBr82teYAW71Teiezs2n1QiUV9Oru8dPwsjS3kzp2QwGe6stM77HjV?= =?us-ascii?Q?tw0TuXZDD/2h2pEowu40bBRkuikHAQjWORJ8MK0m0blndg77yUU2D0spNS9R?= =?us-ascii?Q?f4B9+UykvPhpxf2hV7q70vD5+6Cdt4yzwr2/fXXgaGvYdG9wInZihwPhu9r8?= =?us-ascii?Q?QDwYTM3cZ4vcuqCjOiS+FvL/6+N9ifXCmccpTtaOrBdc/8ncf6ReySVEfpcp?= =?us-ascii?Q?6DJcxr6H2/d6QZrk7O6VCWUq1bexjFGI1x1j1UU7Ynmb/hF10WFi3SEyK4Nc?= =?us-ascii?Q?/EAmLdGGIt8PVpQityiWngg5TjbwrRgqptO36tnJDsBi8VqHTyZqyyx1RGKX?= =?us-ascii?Q?pQ2dV09VSe7hOpxc3cAMbGIKAnaXoJwtRHuzi8A8IPVpewUCuobaGO+44DyM?= =?us-ascii?Q?5HPjqIpdZa9O5BLbfRfMYLuTclFbQ/b1Sel1gzCbo+A+knMYYS1LxUOGUo7z?= =?us-ascii?Q?+YY9UL1ep+YQdKsnczyX8U2mORDl5urQuhLb2dpWMyS3+W7LdhyxqoaW9B0F?= =?us-ascii?Q?UJf+e4YiiFovZVSPfadQWsd/gvjFna+R8TpCIFsP8bxW6T++GuY6r398zfYo?= =?us-ascii?Q?Y4J9aflCdW59R3lJsmcqBnlVzAIFH5Ks2k86XNKoDJhDZUBujWGC2Z/dZTL9?= =?us-ascii?Q?cLmnR05HKLl+nDdWgBPFH3/KGhftqNHydBWZnpKFnEsMIti2hsHafq/cuMqC?= =?us-ascii?Q?uT4zhWvEAogSTzEw2GJ03dQsBSdNpX342cNkJH1iwavws9vRlx4Zw+foXbZu?= =?us-ascii?Q?89UCvaRILN61/1XocahmYWPpSjfJCHAcnC1XLHIxdUKH7nvkWtdwaSw2kRfL?= =?us-ascii?Q?9fFvz4HDbofRU6CEbogU+Ab65BOJD+3+XqtJrtHMjdulca93W0QUj5ngvFit?= =?us-ascii?Q?nUASYYpn7Cm9Elv3ng3hEzRSEM+hnCwibs0hd35XA+HvX7MXYLBs531KFHXd?= =?us-ascii?Q?hYyq3h5f/iR6JT7qlaErdb91OoAddGonC/Zmn3iFPh1kVt5JWr88Lzg70egm?= =?us-ascii?Q?94WimsdVG+yiClOaH0KTmKrp06O2i7vW6hTQxMZ2Tn/XE6hH3NDPl8YwUHVF?= =?us-ascii?Q?0ps92BZEMpQxF17ADD7wQV0jbXCskYUU5QAXriW0wjBgrLBQFNoOY8s4rfyO?= =?us-ascii?Q?QWT5DowK6UZ0yao/wQksFiSkr1PgN9DubGigw4Q05kziiFCHBIaMfORn+pYO?= =?us-ascii?Q?eNJOhnFvz67n2u4XsmbZ4++rVzQAHDKINk1p8Ka5DX0dd4XHGHw0uwed2je0?= =?us-ascii?Q?yPHzg/aIC8mfQQg8Ax09UW6p5flrys4Kta2rWbv3loAGZHiWj6fMgTE7dU46?= =?us-ascii?Q?zPINR5oOpwLwsxyMTnE=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1a611b5-373c-4402-3507-08dc4e311a9c X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2024 07:39:58.6122 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lTW32OyONh3yyR+I90Z+2sTFgMvmyG5tWe8NVAi1Qxpy/jh9mI2HJD/Ez4kdc4ej+w2+E3Le6EdaFt87Ogx4Xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8158 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 27 Mar 2024 00:40:02 -0700 Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: HlQzTBBwGhGCLs07GcVQfwzZx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=PEFx+6ry; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=pass (policy=none) header.from=groups.io Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chang, Abn= er > via groups.io > Sent: Tuesday, March 26, 2024 11:15 PM > To: devel@edk2.groups.io > Cc: Abner Chang ; Igor Kulchytskyy > Subject: [edk2-devel] [PATCH V2 6/6] RedfishPkg/RedfishPlatformConfigDxe: > support menu path report >=20 > External email: Use caution opening links or attachments >=20 >=20 > From: Nickle Wang >=20 > "MenuPath" is the attribute in BIOS attribute registry. To support report= ing this > attribute, we need to include the formset without x-uefi-redfish support = in > database. So driver can find menu path to target attribute in BIOS menu. >=20 > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Signed-off-by: Abner Chang > --- > .../RedfishPlatformConfigDxe.h | 8 +-- > .../RedfishPlatformConfigDxe.c | 8 +-- > .../RedfishPlatformConfigImpl.c | 51 +++++++++++++++---- > 3 files changed, 49 insertions(+), 18 deletions(-) >=20 > diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe= .h > b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.h > index 688f2067bff..8eb7b0dc2aa 100644 > --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.h > +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.h > @@ -2,7 +2,7 @@ > This file defines the EDKII Redfish Platform Config Protocol interface= . >=20 > (C) Copyright 2021 Hewlett Packard Enterprise Development LP
> - Copyright (c) 2022-2023, NVIDIA CORPORATION & AFFILIATES. All rights > reserved. > + Copyright (c) 2022-2024, NVIDIA CORPORATION & AFFILIATES. All rights > reserved. > Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved. >=20 > SPDX-License-Identifier: BSD-2-Clause-Patent @@ -49,8 +49,8 @@ // 2 > RedfishPlatformConfigDxe debug enablement must be set in > // PcdRedfishDebugCategory (defined in RedfishPkg.dec) > // > -// 3. The suborinate debug enablement for RedfishPlatformConfigDxe > -// must be set in PcdRedfishPlatformConfigDebugPropert (defined > +// 3. The subordinate debug enablement for RedfishPlatformConfigDxe > +// must be set in PcdRedfishPlatformConfigDebugProperty (defined > // in RedfishPkg.dec). > // > #define DEBUG_REDFISH_THIS_MODULE(DebugSubordinate, ...) \ @@ -116,7 > +116,7 @@ typedef struct { >=20 > #define REDFISH_MENU_PATH_SIZE 8 >=20 > -// Definitions of Redfish platform config capbility > +// Definitions of Redfish platform config capability > #define REDFISH_PLATFORM_CONFIG_BUILD_MENU_PATH 0x000000001 > #define REDFISH_PLATFORM_CONFIG_ALLOW_SUPPRESSED 0x000000002 >=20 > diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe= .c > b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c > index d165799f9a1..7821146e901 100644 > --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c > +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c > @@ -2016,7 +2016,7 @@ RedfishPlatformConfigProtocolGetConfigureLang ( > UINTN Index; > CHAR8 *FullSchema; >=20 > - DEBUG ((DEBUG_INFO, "%a: Harvest config language of %a_%a (Regex: > %s).\n", __func__, Schema, Version, RegexPattern)); > + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "%a: Harvest config language > + of %a_%a (Regex: %s).\n", __func__, Schema, Version, RegexPattern)); >=20 > if ((This =3D=3D NULL) || IS_EMPTY_STRING (Schema) || IS_EMPTY_STRING > (Version) || (Count =3D=3D NULL) || (ConfigureLangList =3D=3D NULL) || > IS_EMPTY_STRING (RegexPattern)) { > return EFI_INVALID_PARAMETER; > @@ -2103,7 +2103,7 @@ RELEASE_RESOURCE: > ReleaseStatementList (&StatementList); > } >=20 > - DEBUG ((DEBUG_INFO, "%a: exit.\n", __func__)); > + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "%a: exit.\n", __func__)); > return Status; > } >=20 > @@ -2318,7 +2318,7 @@ RedfishPlatformConfigProtocolGetAttribute ( > CHAR8 *FullSchema; > CHAR8 *Buffer; >=20 > - DEBUG ((DEBUG_INFO, "%a: Entry\n", __func__)); > + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "%a: Entry\n", __func__)); > if ((This =3D=3D NULL) || IS_EMPTY_STRING (Schema) || IS_EMPTY_STRING > (Version) || IS_EMPTY_STRING (ConfigureLang) || (AttributeValue =3D=3D NU= LL)) { > return EFI_INVALID_PARAMETER; > } > @@ -2395,7 +2395,7 @@ RELEASE_RESOURCE: > FreePool (FullSchema); > } >=20 > - DEBUG ((DEBUG_INFO, "%a: Exit\n", __func__)); > + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "%a: Exit\n", __func__)); > return Status; > } >=20 > diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImp= l.c > b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c > index 537ce09a2d3..86f3aa529c5 100644 > --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c > +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c > @@ -2,7 +2,7 @@ > The implementation of EDKII Redfish Platform Config Protocol. >=20 > (C) Copyright 2021-2022 Hewlett Packard Enterprise Development LP
> - Copyright (c) 2022-2023, NVIDIA CORPORATION & AFFILIATES. All rights > reserved. > + Copyright (c) 2022-2024, NVIDIA CORPORATION & AFFILIATES. All rights > reserved. > Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved. >=20 > SPDX-License-Identifier: BSD-2-Clause-Patent @@ -656,8 +656,10 @@ > GetStatementPrivateByConfigureLangRegex ( > ++StatementList->Count; > } > } else { > - DEBUG ((DEBUG_ERROR, "%a: HiiStatementPrivate->DescriptionSt= r is > NULL, x-uefi-string has something wrong.\n", __func__)); > - ASSERT (FALSE); > + if (!RedfishPlatformConfigFeatureProp > (REDFISH_PLATFORM_CONFIG_BUILD_MENU_PATH)) { > + DEBUG ((DEBUG_ERROR, "%a: HiiStatementPrivate->Description= Str is > NULL, x-uefi-string has something wrong.\n", __func__)); > + ASSERT (FALSE); > + } > } > } >=20 > @@ -754,6 +756,11 @@ GetStatementPrivateByConfigureLang ( > if (HiiStrCmp (TmpString, ConfigureLang) =3D=3D 0) { > return HiiStatementPrivate; > } > + } else { > + if (!RedfishPlatformConfigFeatureProp > (REDFISH_PLATFORM_CONFIG_BUILD_MENU_PATH)) { > + DEBUG ((DEBUG_ERROR, "%a: HiiStatementPrivate->Description= Str is > NULL, x-uefi-string has something wrong.\n", __func__)); > + ASSERT (FALSE); > + } > } > } >=20 > @@ -1440,7 +1447,7 @@ GetXuefiStringAndLangByStringId ( > StringIndex =3D StringId; > while (StringIndex >=3D X_UEFI_REDFISH_STRING_ARRAY_ENTRY_NUMBER) { > if (IsNodeAtEnd (&XuefiRedfishStringDatabase->XuefiRedfishStringAr= rays, > &StringArray->NextArray)) { > - goto ErrorEixt; > + goto ErrorExit; > } >=20 > StringArray =3D (REDFISH_X_UEFI_STRINGS_ARRAY *)GetNextNode > (&XuefiRedfishStringDatabase->XuefiRedfishStringArrays, &StringArray- > >NextArray); @@ -1477,8 +1484,8 @@ GetXuefiStringAndLangByStringId ( > ); > } >=20 > -ErrorEixt:; > - DEBUG ((DEBUG_ERROR, "%a: String ID (%d) is not in any x-uef-redfish s= tring > databases.\n", __func__, StringId)); > +ErrorExit:; > + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "%a: String ID (%d) is not in > +any x-uef-redfish string databases.\n", __func__, StringId)); > return EFI_NOT_FOUND; > } >=20 > @@ -1504,7 +1511,7 @@ BuildXUefiRedfishStringDatabase ( > UINTN TotalStringsAdded; > UINTN NumberPackageStrings; >=20 > - DEBUG ((DEBUG_INFO, "%a: Building x-uefi-redfish string database, HII > Formset GUID - %g.\n", __func__, FormsetPrivate->Guid)); > + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "%a: Building x-uefi-redfish > + string database, HII Formset GUID - %g.\n", __func__, > + FormsetPrivate->Guid)); >=20 > BufferSize =3D 0; > Status =3D mRedfishPlatformConfigPrivate->HiiDatabase->ExportPacka= geLists ( > @@ -1531,6 +1538,8 @@ BuildXUefiRedfishStringDatabase ( > FormsetPrivate-= >HiiPackageListHeader > ); > if (EFI_ERROR (Status)) { > + FreePool (FormsetPrivate->HiiPackageListHeader); > + FormsetPrivate->HiiPackageListHeader =3D NULL; > return; > } >=20 > @@ -1647,8 +1656,14 @@ LoadFormset ( > FormsetPrivate->DevicePathStr =3D ConvertDevicePathToText (HiiFormSet- > >DevicePath, FALSE, FALSE); > Status =3D GetSupportedSchema (FormsetPrivate->= HiiHandle, > &FormsetPrivate->SupportedSchema); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "%a: No x-uefi-redfish > configuration found on the formset - %g\n", __func__, FormsetPrivate->Gui= d)); > - return EFI_UNSUPPORTED; // Can't build AttributeRegistry Meni path w= ith > returning EFI_UNSUPPORTED. > + if (!RedfishPlatformConfigFeatureProp > (REDFISH_PLATFORM_CONFIG_BUILD_MENU_PATH)) { > + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "%a: No x-uefi-redfish > configuration found on the formset - %g\n", __func__, FormsetPrivate->Gui= d)); > + // > + // If there is no x-uefi-redfish language in this form-set, we don= 't add formset > + // since we don't need to build menu path for attribute registry. > + // > + return EFI_UNSUPPORTED; > + } > } else { > // Building x-uefi-redfish string database > BuildXUefiRedfishStringDatabase (FormsetPrivate); @@ -1734,7 +1749,2= 3 @@ > LoadFormset ( > // > InsertTailList (&HiiFormPrivate->StatementList, &HiiStatementPri= vate->Link); > } else { > - FreePool (HiiStatementPrivate); > + if (!RedfishPlatformConfigFeatureProp > (REDFISH_PLATFORM_CONFIG_BUILD_MENU_PATH)) { > + // > + // If there is no x-uefi-redfish language for this statement, = we don't add > this statement > + // since we don't need to build menu path for attribute regist= ry. > + // > + FreePool (HiiStatementPrivate); > + } else { > + // > + // This is not x-uefi-redfish string and we don't cache its st= ring for > searching Redfish configure language. > + // When caller wants the string, we will read English string b= y calling > HiiGetString(). > + // > + HiiStatementPrivate->DescriptionStr =3D NULL; > + // > + // Attach to statement list. > + // > + InsertTailList (&HiiFormPrivate->StatementList, &HiiStatementP= rivate- > >Link); > + } > } >=20 > HiiStatementLink =3D GetNextNode (&HiiForm->StatementListHead, > HiiStatementLink); > -- > 2.37.1.windows.1 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117156): https://edk2.groups.io/g/devel/message/117156 Mute This Topic: https://groups.io/mt/105159789/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-