From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 50636D801DE for ; Thu, 22 Feb 2024 09:16:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=q9SIqDqCH+ipMfb3OHS8l725ao2gsu2ELQ+77BcLZ2Q=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708593362; v=1; b=Q5aIGL+GpdzJJP4/ONhs+HKgt3KscUs+vIhpSsDJ2OHcBpYlUpLtu9MuPUf6/bS9CVWwF3Eu aNefLQM2/XJmzHvyowA/OPFL1W4uFE9AOt3xzH9bNrP3cpU7NZNa8XcHTAte/Ch/0AgLZ2+q78v 5K05zZro8OuHDCS37/OwLF9A= X-Received: by 127.0.0.2 with SMTP id fInBYY7687511xDzv4A9oicV; Thu, 22 Feb 2024 01:16:02 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.82]) by mx.groups.io with SMTP id smtpd.web10.9100.1708593362441345726 for ; Thu, 22 Feb 2024 01:16:02 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CA7tFOaiJZb2COQs3CHFiC/+67fRO4KHIyaAQu9hYe2XIuJc1klV3gEAOFH0m8dAEaz2Svi3Bq5GohctfDkUZPwkzyoatsgc+JwkMHEdt92gIo+Bv6kUSENkWpKm8DWBh5JP7yQnZ4NDN20rDJ/ulMApH0KREMJ7JCJDO06Z/E5CrEoMWnm8yaozyNvmxgpLoEbHsLRpjmsOuaszzHsQbITx2TgYT3SiXjxBJ7EVRZ80NsE8LOiGukGj2dLk+V7skqGQ9iChGVyJ2kznHRoe0cCAplI1sOxPPvKqd+h3thjq6erXd3YpUwTTtnda4L/2rFncwIGmpWVz2ZkWthaKVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gsI0WRS8kicwft0R3vHfdm3bUIeoyG/QebfjF3dghpQ=; b=Cyczak9czAkDH+v0rACgCzjnCwncSGTAI9moZvkjcZcr6Sr9tGaKMq3NalFXxxPEiF9diIn9jHn0BZjea79mV9U7qdUI4oYay0g/Ap88qEgz//RDuKVaPV7wK099fZnpgyrs2iFf4Lx2nwA0+WB8X3DAcuu008hr+9mCktf6J0dv+Y///6VdqTdpC67E/6lge6/n242x1/miw2nZrbqzfeoNtJ7R3xrY/aXE4oCAiSx2CYvsb7XCtRpV5rwGaLj/WxwI6R6zsdATP9RmOcQtdhlBMjgmmKSa1JmjXORPPXJVkSfFuo1Zn4FHmIJ0AruPIUBKv3gGREGxRVw/OduWgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by MW3PR12MB4521.namprd12.prod.outlook.com (2603:10b6:303:53::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.24; Thu, 22 Feb 2024 09:15:59 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::aa79:3ab0:fbcd:d61b]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::aa79:3ab0:fbcd:d61b%5]) with mapi id 15.20.7316.018; Thu, 22 Feb 2024 09:15:59 +0000 From: "Nickle Wang via groups.io" To: "Chang, Abner" , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nick Ramirez Subject: Re: [edk2-devel] [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external symbol issue Thread-Topic: [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external symbol issue Thread-Index: AQHaY8frA5J+3l8aDUyCtPEZHqTEGrEUDdrwgAIJw7A= Date: Thu, 22 Feb 2024 09:15:59 +0000 Message-ID: References: <20240220064153.28651-1-nicklew@nvidia.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=d1376242-3c78-4049-a8b4-421c4d78827d;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-02-21T02:07:23Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|MW3PR12MB4521:EE_ x-ms-office365-filtering-correlation-id: 6c78b8e7-be11-4851-64e1-08dc3386e22b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: BSiXRpsFwmUEZpsjkKhZ1R/KQe+uaStqGeiqcAofUwrJpqOyj94rHcp9rQhgRs5wdhzy9/f1zGrt1cV2GrDIpOEDMb+AIMiBm5bN7sXqDR8pSxWWMkh6oLOyNmYC6yJLpz89nV5n81vAmgWs7PF9/MR1hA5T4U/8qdb+gichJ8tZIUwBrvyDfUKegkr7Fn+VZWJxldoWRSiPri1k4TYrBIzCt0BkE+5J7PXnYh56aMCDZl6trKPsOnvW0iSfNv1HlroniJrFvHLph6nSc4XZvKLMp+K96NFPZ0PqNyL21vgzViOITllvUfn7qHTO4ZZIYxVMRsJ+XlX2Prat75fJy9nRyzvCZjPFEUHqwITx8O+TBxWGVlG60z9n2emF7erNhNRBxouqlQtqGes8e7nh3Zg+vpdpqjgSCNQjeDAHsKQikS1cgrlMMQoNq3QXfHg1kdsBW7sUnsMouep/+H8yO29mDqB8sA6+NVETZXNhE6nGWTVpXfJQXXs72AbXkOuLFbszyufKzWmMozVg79hRrI9FlSufmgbPKCuNbIfyaf3QJdXFSJwHSQRsnp048P7Rlo+91vWABNzK2u11NIXDr10Nm09oTWKfNTdNxLMnBPKH12SM0NZidOSgR7EjIbHO x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JhYW4Cm40QMzgMMdJKiLo5k63ArUTDNp7iAHDuWntnb9Fw/NbAZPMdCN2e0J?= =?us-ascii?Q?G/v9j+GopMm+e4kiDGOuKQX92GCMwIFZqxMfK22tzI0UZiH0kfDQn6FT9r2o?= =?us-ascii?Q?VrRgrhChy0mCJboJReDNjHrGgI2Q9hUSTcN5OwAXd/JrKdnxtXpPoVA2ib+8?= =?us-ascii?Q?vUb06RjgNR2SeqwqR5Kty4aeg1B26RAyGSK1vwfyKV/ZN3+kDGdaCBhudFfp?= =?us-ascii?Q?TDBSifgmsdlOejFwpnA10oL/cnLD2mBX74fQyAgKnSsfgby6LglurBAIVFeZ?= =?us-ascii?Q?RxvgkhnT/lsbe3I0VCWmUhA9pfeM4WVk88nmkk5Jt/brekxxYz9ws/dSS2Jd?= =?us-ascii?Q?yqR/75e04UyKYzafybZ51XWt8rn3C3oqLzelCZTE1r+GNNwofvxgE+4ZkhgX?= =?us-ascii?Q?T4TqA/MxRSGzUT8a/dbWCAMdTcQ8rDOsJypsJtt3RHi+CF3TCRAs7aXN1Rn0?= =?us-ascii?Q?OxQi5pFE/I+XZu4heICIYbIKmNfAl4mUBFc4NPDxz85/pczgBq07xvCnVIyk?= =?us-ascii?Q?J3xoSs1ner39EnfHYn4Cw+98AYQGh1hZ5xT5ZuVvb9edy7QwNYPGWkyjnGnf?= =?us-ascii?Q?EbMW6rm1m/HncAbAmYdOVVau588fIKm5LcNGRPb7PyCV6/UfkU9kOA30UN9o?= =?us-ascii?Q?hKOQ1sOjiIugfx1iQLcO3FCqikP2SoyND10EwEtHfG+GLtU/AyEriD75t3fD?= =?us-ascii?Q?pX8e/KX+Wn5wVb15FtRGDBP11aBvBeqG+9+Gfa4WiTc6RsJpqRKkX5z+Qo/b?= =?us-ascii?Q?TrpOddVwjqvur3QIbP0Vo+wOpFB0S2lVT3r83616Oa1XD4xqMIhs3xrJUdf6?= =?us-ascii?Q?ZLO2qki2Q2a/MFepIpc56FGT3gWSLOXrRj2yR8FqlI9GbeRigxeHbx8oZ7NL?= =?us-ascii?Q?J8r4XPpYOmdVW6gBU0d1b9fMPj1vYdzd1nVj/ekZsujNyXvYORakEwq9XBcX?= =?us-ascii?Q?jvRTgNInvqYVSfH7vzRVT0OmLVxRXHWCtPMhGbVXZA5s5nU4zYeDeHDLd3MN?= =?us-ascii?Q?0VQv9I8xNhglnsarCN0eeeT92Rz5nw4SogItTgB1liVMyrZYetBiDTwlRYvZ?= =?us-ascii?Q?pfX6BI6H+luhGh5egojiTr/y3mH+DCmUnZFQYBvVS6EQnZdp/CGzab8CuBwl?= =?us-ascii?Q?OjsDsENqRAL3/LS7EdIGIVM4XpWJQysq6T+NQ74gzHQQRb6XvuWRwKOkzNoU?= =?us-ascii?Q?6wKSvZe9/4OKxenThQXTBhHJyrbP6EDKonq7N5KtZ0e4e7zHsCDDrYh061um?= =?us-ascii?Q?XF+Gpy4NXsu2yo4wbUS0CEjdn8u97bkWyv8q/YaaYwLp/YBUDPupjs4Pouao?= =?us-ascii?Q?vmxttTqvEdVJLGaj7xsfISqIRrMLAf+es+p+LM6s0IRa1E8U3a8yXFzr4K97?= =?us-ascii?Q?VHqOTDr47ylhdmvC4O2Lh0A9p3E7qzmhrFyb61D0gNicreYtiV4zgDk6judq?= =?us-ascii?Q?muIRBa1ziXuvrEiNU6VY9TgulsoW8KB/bnK+6Nn5DE8CTScFb2Qb2Xi3g/je?= =?us-ascii?Q?Zdd0G0rdADj2Wls3wnqg+vR+wvH4uuPAN18Y5LhOigAs0q/Mhm+1AxDnv48p?= =?us-ascii?Q?gNF54Vlk4ZSSkXIOj+KIHglpqtS5koKNXg8YDcvWqpRatxM9YJfYxXE8gIqM?= =?us-ascii?Q?zAFJg93qSEpL3AYVbE6AM+6t5dTR6zSfWNw6T9hJnPF5?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c78b8e7-be11-4851-64e1-08dc3386e22b X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2024 09:15:59.2475 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zr6Ovszftj4j4+qNLBTB3VbkpUVIIO/UmCv20hAGs2aOjPMWJ4I24Gco2/VgoMJNFUhdIK3haedOcmOkbFqUvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4521 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: U2BQjI9GZ0ORzMPhzkjBLQrDx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Q5aIGL+G; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=pass (policy=none) header.from=groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi Abner, Please check v2 patch. I add the source location of MathFtol.c Thanks, Nickle > -----Original Message----- > From: Chang, Abner > Sent: Wednesday, February 21, 2024 10:10 AM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Igor Kulchytskyy ; Nick Ramirez > Subject: RE: [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved externa= l > symbol issue >=20 > External email: Use caution opening links or attachments >=20 >=20 > [AMD Official Use Only - General] >=20 > > -----Original Message----- > > From: Nickle Wang > > Sent: Tuesday, February 20, 2024 2:42 PM > > To: devel@edk2.groups.io > > Cc: Chang, Abner ; Igor Kulchytskyy > > ; Nick Ramirez > > Subject: [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external > > symbol issue > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > -Fix below compiler error reported in edk2 CI. > > ERROR - Linker #2001 from JsonLib.lib(load.obj) : unresolved external > > symbol __ftol2 -The file MathFtol.c is copied from IntrinsicLib in > > CryptoPkg. > > -Add MathFtol.c to EccCheck IgnoreFiles. > > > > Signed-off-by: Nickle Wang > > Cc: Abner Chang > > Cc: Igor Kulchytskyy > > Cc: Nick Ramirez > > --- > > .../RedfishCrtLib/RedfishCrtLib.inf | 7 +++- > > .../RedfishCrtLib/Ia32/MathFtol.c | 37 +++++++++++++++++++ > > RedfishPkg/RedfishPkg.ci.yaml | 2 + > > 3 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 > > RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c > > > > diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > > b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > > index 6ff5dba75c..3a5e309d1a 100644 > > --- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > > +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > > @@ -3,6 +3,7 @@ > > # > > # Copyright (c) 2019, Intel Corporation. All rights reserved.
# > > (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> > +# Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights > > reserved. > > # > > # SPDX-License-Identifier: BSD-2-Clause-Patent > > # > > @@ -23,6 +24,9 @@ > > [Sources] > > RedfishCrtLib.c > > > > +[Sources.IA32] > > + Ia32/MathFtol.c | MSFT > > + > > [LibraryClasses] > > BaseLib > > SortLib > > @@ -35,4 +39,5 @@ > > MdeModulePkg/MdeModulePkg.dec > > RedfishPkg/RedfishPkg.dec > > > > - > > +[BuildOptions] > > + MSFT:*_*_IA32_CC_FLAGS =3D /GL- > > diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c > > b/RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c > > new file mode 100644 > > index 0000000000..adfe249b1d > > --- /dev/null > > +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c > > @@ -0,0 +1,37 @@ > > +/** @file >=20 > Hi Nickle, > Could you please add the information here after @file about where this fi= le or the > source code come from, such as the location of original file? > Thanks > Abner >=20 >=20 > > + 64-bit Math Worker Function. > > + The 32-bit versions of C compiler generate calls to library > > + routines to handle 64-bit math. These functions use non-standard > > + calling > > conventions. > > + > > +Copyright (c) 2019, Intel Corporation. All rights reserved.
> > +SPDX-License-Identifier: BSD-2-Clause-Patent > > + > > +**/ > > + > > +/* > > + * Floating point to integer conversion. > > + */ > > +__declspec(naked) void > > +_ftol2 ( > > + void > > + ) > > +{ > > + _asm { > > + fistp qword ptr [esp-8] > > + mov edx, [esp-4] > > + mov eax, [esp-8] > > + ret > > + } > > +} > > + > > +__declspec(naked) void > > +_ftol2_sse ( > > + void > > + ) > > +{ > > + _asm { > > + fistp dword ptr [esp-4] > > + mov eax,[esp-4] > > + ret > > + } > > +} > > diff --git a/RedfishPkg/RedfishPkg.ci.yaml > > b/RedfishPkg/RedfishPkg.ci.yaml index 69b6bf39f5..b95e8bfdc7 100644 > > --- a/RedfishPkg/RedfishPkg.ci.yaml > > +++ b/RedfishPkg/RedfishPkg.ci.yaml > > @@ -2,6 +2,7 @@ > > # CI configuration for NetworkPkg > > # > > # (C) Copyright 2021 Hewlett Packard Enterprise Development LP
> > +# Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights > > reserved. > > # SPDX-License-Identifier: BSD-2-Clause-Patent ## { @@ -38,6 +39,7 > > @@ > > "PrivateInclude/Crt/string.h", > > "PrivateInclude/Crt/time.h", > > "PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c", > > + "PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c", > > "Include/Library/RedfishCrtLib.h", > > ## > > ## For jansson library open source > > -- > > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115780): https://edk2.groups.io/g/devel/message/115780 Mute This Topic: https://groups.io/mt/104463409/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-