Re: [PATCH 1/5] RedfishPkg: Correct variable type to prevent memory corruption

["Nickle Wang" <nicklew@nvidia.com>]

Reviewed-by: Nickle Wang <nicklew@nvidia.com>

Regards,
Nickle

> -----Original Message-----
> From: Minh Nguyen <minhnguyen@os.amperecomputing.com>
> Sent: Friday, April 14, 2023 4:19 PM
> To: devel@edk2.groups.io
> Cc: patches@amperecomputing.com; abner.chang@amd.com; Nickle Wang
> <nicklew@nvidia.com>; igork@ami.com; nhi@os.amperecomputing.com;
> tinhnguyen@os.amperecomputing.com; Vu Nguyen
> <vunguyen@os.amperecomputing.com>; Minh Nguyen
> <minhnguyen@os.amperecomputing.com>
> Subject: [PATCH 1/5] RedfishPkg: Correct variable type to prevent memory
> corruption
> 
> External email: Use caution opening links or attachments
> 
> 
> From: Vu Nguyen <vunguyen@os.amperecomputing.com>
> 
> Id will be casted by CoreOpenProtocol, declare this variable with a wrong type
> might result in the corruption of other local variables.
> 
> Signed-off-by: Minh Nguyen <minhnguyen@os.amperecomputing.com>
> ---
>  RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h
> b/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h
> index 4a9e9f7b81a4..6b94e5814c43 100644
> --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h
> +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h
> @@ -3,6 +3,7 @@
> 
>    Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
>    (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> +  Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR>
> 
>    SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> @@ -84,7 +85,7 @@ struct _RESTEX_SERVICE {
>    //
>    EFI_HANDLE                      HttpChildHandle;
> 
> -  UINT32                          Id;
> +  UINT32                          *Id;
> 
>    EFI_REST_EX_SERVICE_INFO        RestExServiceInfo;
>  };
> --
> 2.39.0