public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nickle Wang via groups.io" <nicklew=nvidia.com@groups.io>
To: Rebecca Cran <rebecca@bsdio.com>,
	Abner Chang <abner.chang@amd.com>,
	Igor Kulchytskyy <igork@ami.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] RedfishPlatformConfigDxe needs Depex on gEfiRegularExpressionProtocolGuid?
Date: Tue, 9 Jul 2024 03:53:47 +0000	[thread overview]
Message-ID: <MW4PR12MB7031B52D044C2CBEB1106932D9DB2@MW4PR12MB7031.namprd12.prod.outlook.com> (raw)
In-Reply-To: <be922e9f-ce4f-44d2-9670-749f9021b2a2@bsdio.com>

> Should the following change be made to make sure RegularExpressionDxe is
> loaded before RedfishPlatformConfigDxe?

It is ok that RegularExpressionDxe is loaded after RedfishPlatformConfigDxe because EfiCreateProtocolNotifyEvent() is used to get Regular expression protocol. And I don't have objection to add the dependency as you suggested to eliminate the false alarm.

Regards,
Nickle

> -----Original Message-----
> From: Rebecca Cran <rebecca@bsdio.com>
> Sent: Tuesday, July 9, 2024 4:25 AM
> To: Abner Chang <abner.chang@amd.com>; Nickle Wang <nicklew@nvidia.com>;
> Igor Kulchytskyy <igork@ami.com>
> Cc: devel@edk2.groups.io
> Subject: RedfishPlatformConfigDxe needs Depex on
> gEfiRegularExpressionProtocolGuid?
> 
> External email: Use caution opening links or attachments
> 
> 
> I noticed that RedfishPlatformConfigDxe prints an error message that it can't find
> EFI_REGULAR_EXPRESSION_PROTOCOL.
> 
> Should the following change be made to make sure RegularExpressionDxe is
> loaded before RedfishPlatformConfigDxe?
> 
> diff --git
> a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.inf
> b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.inf
> index 2db47c2cf..7490d89be 100644
> --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.inf
> +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.inf
> @@ -60,4 +60,4 @@
>    gEfiRedfishPkgTokenSpaceGuid.PcdRedfishPlatformConfigDebugProperty
> 
>   [Depex]
> -  TRUE
> +  gEfiRegularExpressionProtocolGuid^M
> 
> --
> Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119825): https://edk2.groups.io/g/devel/message/119825
Mute This Topic: https://groups.io/mt/107110826/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-07-09  3:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-08 20:25 [edk2-devel] RedfishPlatformConfigDxe needs Depex on gEfiRegularExpressionProtocolGuid? Rebecca Cran
2024-07-09  3:53 ` Nickle Wang via groups.io [this message]
2024-07-09 18:48   ` Rebecca Cran
2024-07-10  8:21     ` Nickle Wang via groups.io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW4PR12MB7031B52D044C2CBEB1106932D9DB2@MW4PR12MB7031.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox