From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (NAM04-MW2-obe.outbound.protection.outlook.com [40.107.101.66]) by mx.groups.io with SMTP id smtpd.web11.6101.1670382319589495161 for ; Tue, 06 Dec 2022 19:05:19 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=selector2 header.b=MQJYqtBx; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.101.66, mailfrom: nicklew@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lpbyuciBS65ziUAZSXN9QaQyzgANgBOsEXukSLdU9mrgSHntYvb/seUB/rZzAdpnMhNDrSwlp5tsxzeMk5EYDbLcs2GhpTi2sJqRiis4dalgnHBvlPlp6CgA+TyF8/vlo0difSYYGNntMuv2h5gGwJm1/ZYYGc12Yw0xLHyTo+kBPTLcfGS6Apy0WyRpJhwzMjxIo+VJ7PHynQ7OOR8O1rTdBLoH9TXxiWHIVOaBUN6YAn32t3e9TyzZVsH87QSbj6CbCMhUS5MJg+4lmeZsmMB8EppQtFjNuabMeFbu+t9L9cG9k3Lhp3hG4HFe/8TcFD4YLycHXM/mMyU29ImoPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k4F65x+cXSWqZ4n2TyU2vZ+1Tju68rNS7o6q2SQQYSQ=; b=K5tX0laftTE23rON44/mNe+3mhULTF2yC3GJmHUdYYGCh2GkRWe3Cn4fYIujYQqXVnptT7KjsTEr0uKCotRnLnLCk1GtB9xFjKLBBLDR468JOXuWFacQi5DfUpQOKeCbKipbVsQAeAadRhTEjQDlprKgmUeb/hdcW/DNlxwbdw9/fCCfV/wnljUAKSjG3KRK93jkmAasa4QqruHO1QETam6GzzFyTfBcUuvUGG+SMvAofw3OHG1zEyyVqLKw5wSobYvhEV2RccNMGBc4UMI6AS2njTfMtClwboqdScNyAeCNaq0Mh/xBA38W/5rRSPrBG65f2QWDp49kPOEkS3EaVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k4F65x+cXSWqZ4n2TyU2vZ+1Tju68rNS7o6q2SQQYSQ=; b=MQJYqtBxiC2yrNHXKod4s6/QQiqS3fB0zH2PnwlpcrAafD0T/jTPh7clh5IRe/WDh9yjyGLRj6+5/cYd+F77hNF3Aixdfn7xZtJbBNn7nSdw4jKqBNk8RTSykkq8dX65+h5S7JJlzjK34AnB5Kj+sMBesMwdocMXa3ge52AOsamYB05ZvPy7b55w6899YZInHj38hxjcTE0wei6pSkQaM2pwEHGvMApt9UTJDGGqnAmqnh3AXiufkUsQwYqMNgTnZGE3NX55DgrAQiyLFVJV0HsbV7fGxcCyxZM6JFrWJHBtsU2JnOj8HNqm8tXeK9EBhrwrJT0LnMQ7+4IBSmC0zA== Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by PH8PR12MB6866.namprd12.prod.outlook.com (2603:10b6:510:1c9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Wed, 7 Dec 2022 03:05:17 +0000 Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::6b34:f6ce:b778:4075]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::6b34:f6ce:b778:4075%8]) with mapi id 15.20.5880.013; Wed, 7 Dec 2022 03:05:17 +0000 From: "Nickle Wang" To: "devel@edk2.groups.io" , "igork@ami.com" , "Chang, Abner" , Michael D Kinney Subject: Re: [edk2-devel] [Patch 1/1] RedfishPkg: Remove overlapping private include path in DEC file Thread-Topic: [edk2-devel] [Patch 1/1] RedfishPkg: Remove overlapping private include path in DEC file Thread-Index: AQHZCQv3Eu63kegUCUuln8VhGZuNuK5ghhIAgABm4YCAANJNIA== Date: Wed, 7 Dec 2022 03:05:17 +0000 Message-ID: References: <20221206004446.12-1-michael.d.kinney@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|PH8PR12MB6866:EE_ x-ms-office365-filtering-correlation-id: 4490053a-7688-47ad-60cf-08dad7ffde2f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nWMKiguJbI4AC85f6rECMq0WzhgekpKsub2+Vo3y0PgcmxrCNB0K2mK82dpvQilEo0Rgm0Haw2YsGYC+os4KxtEX7PyFMcam7nNBmPkEiwo1uMRv2Wh7BVgckQ5fc2Spp+H+IAuEN9iWd7I1QLD7rzD/iExJ4nZXp+JGUwgp8+3ULI7nTZpBEzInP9AxiqbVjFa1ISs6LOadrfwDsCJ06FsY8mId7/AsZ+4JH3Zr/C1eoNjT3M/pV1ew0OMvKdtTEyug9clVNRcxEa6g7JPFAyB89HugWpeQIXdUNf/Hk32jxNnwPZq0GTCdv4BdfSBY0qWSIHdRjGbzPr4maxvOKoIlbZ+DBfYZG7gXQaNokTXbmJmIgJulLi84iCXY3OuUEXCXSjM79vlDlHfY4LJnXsutl+eiK5q+C8EZuSD5KOgXiT7DpYi+XpV8nMQgSkVQrXGDIEtKybb1Lx7ZJf74itKZKVsyrSj3IjJBNInwa1L4QJzyG9HR73KJlBIA0A1OAZtr7SY28LitqZ5ykB+IXhXEkm8r0pMjGEmHmpSyFR7V8MR3tH5Sziqt/M2dUtc376mAa6XvreiFz4Mz9taJuB+yH9yMscp/x1S6RTgSR06pI50B9VX+Le60vB8pk8Mt0qynIJZPMQauVfWbPsMSS1Q8soISEBs7DBKXp+soZaPyMZj2DCKpB/S6YUYHRTqou/f90GIAVCGMarNMXOaYPJO7Q41/E69Sv+dbHCPL82U= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR12MB7031.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(396003)(346002)(136003)(39860400002)(451199015)(52536014)(8936002)(8676002)(66446008)(5660300002)(2906002)(66946007)(41300700001)(71200400001)(66476007)(45080400002)(66556008)(316002)(64756008)(76116006)(110136005)(66899015)(40140700001)(33656002)(55016003)(76236004)(38100700002)(122000001)(166002)(86362001)(478600001)(186003)(83380400001)(7696005)(38070700005)(53546011)(9686003)(6506007)(26005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1lnJfi0dNDxjieAuIWK4YlcLwMUL1a19uu8g5/YhBDsctqjEnSAr9tqV5w05?= =?us-ascii?Q?bk5kfyfp9MscPx+hFqg3iVkrELqVKBX60nfwrmwD+AMWIiR34axpx6MwI7iV?= =?us-ascii?Q?QBgksUK3WkRiQkPCRdsPALd8BmyLKGysCDB4o+yDaI3Ypd/5UBYipnWMLIIL?= =?us-ascii?Q?z1PK5/aS3A5q/XIyu5EuKJgjwAS6dDVZ1QMdAEUSadx+4FyXYxtR+JK9so48?= =?us-ascii?Q?4yVs4TlfmO9XFoa7xhs/1gIvN3FdBQQ/gyY6hb80jrrLB5KRaFuYafyK8Jll?= =?us-ascii?Q?dxKUraUv3IHeNOdtpA0BiQSfhprfJ3SBpIcjNbZeX8gEUWn/oDUPCRhYnPl9?= =?us-ascii?Q?y6D9zqSZPwaxwDMh5t7I2DicDyekNtwjMJFTiW0eqLUL9Y4BMGwCBd3mehpB?= =?us-ascii?Q?F4JSuXba03IzeyVM1azyR/AOj8P+1xVvmR3N3ueNXFgqrwEIAfLfvybXsrPZ?= =?us-ascii?Q?v9sBMEYn/BLx7reFzv2l55zRK6dtGFy9bJPjYThAf87uk7xP6pSiKYVkyqj9?= =?us-ascii?Q?sW0LrubQs0KEQ2LoZ/gr069qyb05M1OhYyf4dJAadMcv5MZYYpHgrQy9g2jQ?= =?us-ascii?Q?0Dr5cZGkHwD19MBEAHcImUhLeFpg8WJrqH8JhKCDXYiK50Kk78+1UprWjSnM?= =?us-ascii?Q?fe5Qc3jkOlFJk0nq6dPc42tf/wUEMLUE4sg5dlqTIIiCvy3mQmPtjbUorIcb?= =?us-ascii?Q?uMPPHwJW/QrAUWILagC+/ZoRn8poZAkhKbBqmm3csy7zo+8OvZs2vXqrdqDf?= =?us-ascii?Q?8dHDBWZp6/6riY+hTshQmMRTpnJAoQNXvDSMPjCTpvk0balW05teEe7LZmUn?= =?us-ascii?Q?f3r1iF3jGf1c5gRJsgcoaYe4mz8aOg6Z0tFkd6XCdYcdWcB0/vHMA8QzyebM?= =?us-ascii?Q?hzSaTg9uzgunmvxKHjX34cSCevZNRA/FOFfizHdhKxfEJlc7W0pH2YtKkM1L?= =?us-ascii?Q?9Cx5AGDocC6y7YZkZFQkDaTFPeUqlsCHw7/6TNB2ChyJKkomSFUh9U7v2lC4?= =?us-ascii?Q?HxNACzLUvB6WU4/pAhVB0+C2LLaRmoIBOxN6GPPLhwgHeKMamanc7XEqRxY4?= =?us-ascii?Q?4hMVDKxIYZGHTpICnF0qzDtUoJb1nKO4xKaU9B5tKuxwncMU2y6X02TKhFgF?= =?us-ascii?Q?9OMuIV+zMdXJQZ1AAKIMwOYKgZ8I3WnAoupI8vfajkEMS9aI9pJJ6LlcO6m3?= =?us-ascii?Q?EoHHsZ8/ysQKdvZTt8cW93qDPt0hfzMB3diZSeVTsW+UbH38tXJVni46bjeL?= =?us-ascii?Q?wG8aFuQTUA869+gjwhSfnTPiPhrxlMtR2L+DdwiJlI/Oz+14NzJNxqZvMr52?= =?us-ascii?Q?j3Oe6QbiiapaYzeXOK4Yl3sohsGNEnyOW8To8YeipkOod9mbBxuu4K8XHPEo?= =?us-ascii?Q?NYJPy48ynk3V1fBG5SKHVRYHTTwi60E2VnU3LVXLXhcEdCaCWyiC9+54T7YT?= =?us-ascii?Q?QJ99vhXoAMBv8nrcYfQ2BguBYSDgVHnNBlA+HCNIM1r252b73CDclgT4pEr7?= =?us-ascii?Q?AOwTsuz0MGDdSkgG53z+tilcS/d7JYWkEh81+AAvLHT8g1/lwpFcRT8Jw0DX?= =?us-ascii?Q?1FYXg8fv7MYULxrNk9I=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4490053a-7688-47ad-60cf-08dad7ffde2f X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2022 03:05:17.0469 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Xk1V4f6jAzMeA7zLq1ex9uzeqoET2xOPX9AjnFFumo30s95IORW7JybySqQhMSyonHdTZowHH7SeEMZ8T12UbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6866 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR12MB7031B5FB0CB8EFA1B4523697D91A9MW4PR12MB7031namp_" --_000_MW4PR12MB7031B5FB0CB8EFA1B4523697D91A9MW4PR12MB7031namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nickle Wang Regards, Nickle From: devel@edk2.groups.io On Behalf Of Igor Kulchyt= skyy via groups.io Sent: Tuesday, December 6, 2022 10:32 PM To: Chang, Abner ; Michael D Kinney ; devel@edk2.groups.io Cc: Nickle Wang Subject: Re: [edk2-devel] [Patch 1/1] RedfishPkg: Remove overlapping privat= e include path in DEC file External email: Use caution opening links or attachments Reviewed-by: Igor Kulchytskyy > Get Outlook for Android ________________________________ From: Chang, Abner > Sent: Tuesday, December 6, 2022 3:23:56 AM To: Michael D Kinney >; devel@edk2.groups.io > Cc: Nickle Wang >; Igor Kulch= ytskyy > Subject: [EXTERNAL] RE: [Patch 1/1] RedfishPkg: Remove overlapping private = include path in DEC file **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** [AMD Official Use Only - General] Reviewed-by: Abner Chang > > -----Original Message----- > From: Michael D Kinney > > Sent: Tuesday, December 6, 2022 8:45 AM > To: devel@edk2.groups.io > Cc: Chang, Abner >; Nickl= e Wang > >; Igor Kulchytskyy > > Subject: [Patch 1/1] RedfishPkg: Remove overlapping private include path = in > DEC file > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Update ReadfishPkg.dec to remove PrivateInclude from the > [Includes.Common.Private] section. The PrivateInclude directory does not > contain any include files, and the PrivateInclude/Crt include path remain= ing in > the [Includes.Common.Private] section providing the include path required > to access the CRT related include files by components within the RedfishP= kg. > > Without this update, there are two forms of #include statements that can = be > used to include the CRT related include files. > Include files should only be available using one form of #include stateme= nts. > > Cc: Abner Chang > > Cc: Nickle Wang > > Cc: Igor Kulchytskyy > > Signed-off-by: Michael D Kinney > > --- > RedfishPkg/RedfishPkg.dec | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec index > 0aa26883e220..d2b189b13d8c 100644 > --- a/RedfishPkg/RedfishPkg.dec > +++ b/RedfishPkg/RedfishPkg.dec > @@ -17,7 +17,6 @@ [Includes] > Include > > [Includes.Common.Private] > - PrivateInclude # Private header files for C RTL. > PrivateInclude/Crt # Private header files for C RTL. > Library/JsonLib # Private header files for jansson > # configuration files. > -- > 2.37.1.windows.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . --_000_MW4PR12MB7031B5FB0CB8EFA1B4523697D91A9MW4PR12MB7031namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Reviewed-by: Nickle Wang <nicklew@nvidia.com><= o:p>

 

Regards,

Nickle

 

From: devel@edk2.groups.io <devel@edk2.gro= ups.io> On Behalf Of Igor Kulchytskyy via groups.io
Sent: Tuesday, December 6, 2022 10:32 PM
To: Chang, Abner <Abner.Chang@amd.com>; Michael D Kinney <m= ichael.d.kinney@intel.com>; devel@edk2.groups.io
Cc: Nickle Wang <nicklew@nvidia.com>
Subject: Re: [edk2-devel] [Patch 1/1] RedfishPkg: Remove overlapping= private include path in DEC file

 

External email: Use caution opening l= inks or attachments

 

Reviewed-by: Igor Kulchy= tskyy <igork@ami.com>

From: Chang, Abner <Abner.Chang@amd.com>
Sent: Tuesday, December 6, 2022 3:23:56 AM
To: Michael D Kinney <michael.d.kinney@intel.com>; devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Nickle Wang <nicklew@nv= idia.com>; Igor Kulchytskyy <igo= rk@ami.com>
Subject: [EXTERNAL] RE: [Patch 1/1] RedfishPkg: Remove overlapping p= rivate include path in DEC file

 


**CAUT= ION: The e-mail below is from an external source. Please exercise caution b= efore opening attachments, clicking links, or following guidance.**

[AMD Official Use Only - General]

Reviewed-by: Abner Chang <abner.c= hang@amd.com>

> -----Original Message-----
> From: Michael D Kinney <michael.d.kinney@intel.com>
> Sent: Tuesday, December 6, 2022 8:45 AM
> To: devel@edk2.groups.io > Cc: Chang, Abner <Abner.Chan= g@amd.com>; Nickle Wang
> <nicklew@nvidia.com>; = Igor Kulchytskyy <igork@ami.com>=
> Subject: [Patch 1/1] RedfishPkg: Remove overlapping private include pa= th in
> DEC file
>
> Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding.
>
>
> Update ReadfishPkg.dec to remove PrivateInclude from the
> [Includes.Common.Private] section.  The PrivateInclude directory = does not
> contain any include files, and the PrivateInclude/Crt include path rem= aining in
> the [Includes.Common.Private] section providing the include path requi= red
> to access the CRT related include files by components within the Redfi= shPkg.
>
> Without this update, there are two forms of #include statements that c= an be
> used to include the CRT related include files.
> Include files should only be available using one form of #include stat= ements.
>
> Cc: Abner Chang <abner.chang= @amd.com>
> Cc: Nickle Wang <nicklew@nvid= ia.com>
> Cc: Igor Kulchytskyy <igork@ami.co= m>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  RedfishPkg/RedfishPkg.dec | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec ind= ex
> 0aa26883e220..d2b189b13d8c 100644
> --- a/RedfishPkg/RedfishPkg.dec
> +++ b/RedfishPkg/RedfishPkg.dec
> @@ -17,7 +17,6 @@ [Includes]
>    Include
>
>  [Includes.Common.Private]
> -  PrivateInclude        =         # Private header files for C RTL= .
>    PrivateInclude/Crt     &nbs= p;      # Private header files for C RTL.
>    Library/JsonLib      &= nbsp;        # Private header files for = jansson
>            = ;            &n= bsp;         # configuration files.=
> --
> 2.37.1.windows.1

-The information contained in this message may be co= nfidential and proprietary to American Megatrends (AMI). This communication= is intended to be read only by the individual or entity to whom it is addr= essed or by their designee. If the reader of this message is not the intended recipient, you are on notice th= at any distribution of this message, in any form, is strictly prohibited. P= lease promptly notify the sender by reply e-mail or by telephone at 770-246= -8600, and then delete or destroy all copies of the transmission.

--_000_MW4PR12MB7031B5FB0CB8EFA1B4523697D91A9MW4PR12MB7031namp_--