From: "Nickle Wang via groups.io" <nicklew=nvidia.com@groups.io>
To: "abner.chang@amd.com" <abner.chang@amd.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Igor Kulchytskyy <igork@ami.com>
Subject: Re: [edk2-devel] [PATCH 0/5] [PATCH 0/5] Config language searching algorithm enhancement and the bug fixes
Date: Tue, 26 Mar 2024 12:09:15 +0000 [thread overview]
Message-ID: <MW4PR12MB7031BBE95A01D218B555E020D9352@MW4PR12MB7031.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20240322094313.79-1-abner.chang@amd.com>
Thanks for working on Redfish performance improvements, Abner. Per offline discussion, I have updated this patch series to support menu path reporting for BIOS attribute registry.
Please send version 2 patch series if you are ok with my modifications.
Thanks,
Nickle
> -----Original Message-----
> From: abner.chang@amd.com <abner.chang@amd.com>
> Sent: Friday, March 22, 2024 5:43 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
> Subject: [PATCH 0/5] [PATCH 0/5] Config language searching algorithm
> enhancement and the bug fixes
>
> External email: Use caution opening links or attachments
>
>
> From: Abner Chang <abner.chang@amd.com>
>
> PR # 5491
>
> In this patch set,
> 1 We enhance the config language searching algorithm.
> As the performance of searching config language using HII GetString is
> pretty slow. For the example, 1800 HII BIOS options takes over 30 mins
> to build up the metadata required for Redfish BIOS resource. With this
> improvement, it only takes 4 seconds.
>
> 2.Introduce the Redfish debug framework, there are three edk2 Redfish
> debug scopes.
> a. PcdDebugPrintErrorLevel, DEBUG_MANAGEABILITY to enable debug message
> for edk2 Redfish.
> b. PcdRedfishDebugCategory, enablement of individule edk2 Redfish
> component. Currently we only support RedfishPlatformConfigDxe
> module.
> c. PcdRedfishPlatformConfigDebugProperty, edk2 Redfish module debug
> scope. This PCD is used by RedfishPlatformConfigDxe debug enablement.
>
> 3 This patch set also fixes an issue that deletes HII string unexpectedly.
>
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Co-authored-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
>
> Abner Chang (4):
> RedfishPkg/RedfishDebugLib: Introduce Redfish DEBUG macro
> RedfishPkg/RedfishPlatformConfigDxe:Add RefishDebugLib support
> RedfishPkg/RedfishPlatformConfigDxe: HII string is deleted
> unexpectedly
> EmulatorPkg/Redfish: Use edk2 Redfish debug PCDs
>
> abnchang (1):
> RedfishPkg/RedfishPlatformConfigDxe: Config language searching
> optimization
>
> RedfishPkg/RedfishPkg.dec | 24 +
> EmulatorPkg/EmulatorPkg.dsc | 21 +
> .../RedfishDebugLib/RedfishDebugLib.inf | 4 +
> .../RedfishPlatformConfigDxe.inf | 8 +
> RedfishPkg/Include/Library/RedfishDebugLib.h | 43 +-
> .../RedfishPlatformConfigDxe.h | 46 +-
> .../RedfishPlatformConfigImpl.h | 131 ++-
> .../Library/RedfishDebugLib/RedfishDebugLib.c | 55 +-
> .../RedfishPlatformConfigCapability.c | 52 +
> .../RedfishPlatformConfigDxe.c | 89 +-
> .../RedfishPlatformConfigImpl.c | 894 ++++++++++++++++--
> 11 files changed, 1196 insertions(+), 171 deletions(-) create mode 100644
> RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigCapability.c
>
> --
> 2.37.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117109): https://edk2.groups.io/g/devel/message/117109
Mute This Topic: https://groups.io/mt/105082172/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2024-03-26 12:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 9:43 [edk2-devel] [PATCH 0/5] [PATCH 0/5] Config language searching algorithm enhancement and the bug fixes Chang, Abner via groups.io
2024-03-22 9:43 ` [edk2-devel] [PATCH 1/5] RedfishPkg/RedfishPlatformConfigDxe: Config language searching optimization Chang, Abner via groups.io
2024-03-22 9:43 ` [edk2-devel] [PATCH 2/5] RedfishPkg/RedfishDebugLib: Introduce Redfish DEBUG macro Chang, Abner via groups.io
2024-03-22 9:43 ` [edk2-devel] [PATCH 3/5] RedfishPkg/RedfishPlatformConfigDxe:Add RefishDebugLib support Chang, Abner via groups.io
2024-03-22 9:43 ` [edk2-devel] [PATCH 4/5] RedfishPkg/RedfishPlatformConfigDxe: HII string is deleted unexpectedly Chang, Abner via groups.io
2024-03-22 9:43 ` [edk2-devel] [PATCH 5/5] EmulatorPkg/Redfish: Use edk2 Redfish debug PCDs Chang, Abner via groups.io
2024-03-26 12:09 ` Nickle Wang via groups.io [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR12MB7031BBE95A01D218B555E020D9352@MW4PR12MB7031.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox