From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.60]) by mx.groups.io with SMTP id smtpd.web11.18497.1683876730500412172 for ; Fri, 12 May 2023 00:32:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=selector2 header.b=FauQ0db9; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.220.60, mailfrom: nicklew@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VYD2emlXMJAFg7FZkAzRNDho7erAZkh8K/WfI3idoRR1qT5Sfs7VIzIcWJQbE0kBHCU7+dGwlL/JmhIamjXyRL7Ja0NWvwNFHd8E4TGyjG99Q8TasJWzyfT4kPBHqi02vCQ03Du+yjSexV8L/2qlkbb5GcfJmzGTPatUlo9d7DiULNa/71i3KCPL+S1C+KCifTZdOPkOxCowZ4UZcAs+DRYNrMEicX8KJKOcte990qoOb8PFUdUam/8Kq1iQLPuBA4dRYvalYUuXiUlFUSaDTIdOlXIADugDrPMcYgZax2z87XGxuV3o2vzOnduTDROu8YVZ8Ry4KdD24aq4WIQlUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xCb/IWR5Wq31yzVaqDEGzdgZXk2LSYXuVEWcaUj6oiw=; b=TpaPPgSaQBjDmLSY3nbfRPG4FlMZghP9ex+mQ4AP2Qksjpzv4bFq8o5RvlT1SVrbaX5YDg4UKvoHilE0pq1IHLd9P5Kb3B2MMzfB36U3WqT2gNnn2TbDWhQXSsb52cJH4Iju2nc+gs/v3lVkfBuNuUW25bxee1YPMnhe2iUiqep+4HCudKAnoFa6c48+Lea6ZXn69SroQEbkNxPxKKrbRFKjKzbMGLUJ0DrAgddSR3wlO3UxZGrS3ptLQnN2JCi7Wab9QUQoQLyVxTUH9beIFL0XVvC6+JAGV0+YXlxJEWTP4GFyxFKQuFyjNtwfS30DkWGRquWGbZI9Yq1oZXSQTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xCb/IWR5Wq31yzVaqDEGzdgZXk2LSYXuVEWcaUj6oiw=; b=FauQ0db9HngWOS2DppW632Ulh3sdgzNL4yuTrJRN/T3PHxFiCcQfnPiQaFgYO3Z4vTF4HxD2uKeZ4fgqHUgCWpKTrEBdvr0cUGXClJTyo2ZHvAQ5sMH6dzOWsyeafc8wBaPuShOW/ePxyrSFcaXGsqmXnayEuI2xdwYK9hCe9uzLi4+A1o5LFj2xYy72fnu2wikgKfQBdXtB8gbhpSSyDN4XuFeBQtzJcaQpOEaI0ciFhF1nlbWcSFiDjmpR/d6s/PJiC2H0acqvxiK11VwLu8cDAyShyeqgd0dRojkrTNDZjFHbibTw+qUELko5RZTHOstaS2ePY1BqEQta/V6UgQ== Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.21; Fri, 12 May 2023 07:32:08 +0000 Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::d9df:b45b:2cc1:f017]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::d9df:b45b:2cc1:f017%5]) with mapi id 15.20.6387.023; Fri, 12 May 2023 07:32:08 +0000 From: "Nickle Wang" To: "abner.chang@amd.com" , "devel@edk2.groups.io" CC: Isaac Oram , Abdul Lateef Attar Subject: Re: [edk2-platforms][PATCH 2/2] ManageabilityPkg/IpmiOsWdt: Add to ManageabilityPkg Thread-Topic: [edk2-platforms][PATCH 2/2] ManageabilityPkg/IpmiOsWdt: Add to ManageabilityPkg Thread-Index: AQHZhIdMhQu9DKRljkSphz+dNo0XIq9WPknQ Date: Fri, 12 May 2023 07:32:08 +0000 Message-ID: References: <20230512040649.384-1-abner.chang@amd.com> <20230512040649.384-2-abner.chang@amd.com> In-Reply-To: <20230512040649.384-2-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|MW3PR12MB4409:EE_ x-ms-office365-filtering-correlation-id: c5509cf3-1275-4556-9b8f-08db52bafe3c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jAddf9kTa3j8YXACzhf0c4i9qc6p5p47ko/Q+AQ9w5V+hG6E3X5L2FDO6uDFl9bFjsRrtVgCapM/aNr2OKHWQZSoAgavGqYqfA1MmSqwj2yVkiqzPHRo1pQWq+wpe6Zcu4/hO2O/1WFrokqi/N8UXZjWd3D/Ho/eX+WCTsui3z5n2wnKrzaNaLyAvNkP8WXhPuIgL472NgkJ/VQfueQWZnnp/tTRg0NP8XPiEzld2WbINadsRB9r8Fwwz1bKRKjlzii7j5qGRypUNkqdKkHGNopP7KnLnjRaECpn0K0Fwb15iRYoD/btt4ifIDAtsRYhSmo9iuRoWaDKOapPRLQCGLYc0a4a+5ffpqgCvi5fYY6QweuGaTCFOD+qQ78wdU6R7nLvsGbfzyj4G6mUKHjt6dsNyG8LNaz2TliiwlBJadHgp1lO8WUQuT7gNS+Zs7cBS+gn4M22Ezj/wig2LK4h29mOz3P14ISydM9I6D0nsgkzF7ppQK9zdcsQJlAXinc0PR8Rn3gZJo3YnuzMbMdBVVx7NB5VdU5N0uqBaQOPKGGLufXxEvoD9VUNyMqNK+2OeUofApAy3Vcd4luUQ4SGERbqHmC6jlC2g88/eGswjPAySLW2iMZ+6FBmRmjfn4rc x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR12MB7031.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(6029001)(4636009)(396003)(366004)(346002)(376002)(39860400002)(136003)(451199021)(38070700005)(38100700002)(122000001)(33656002)(86362001)(7696005)(8936002)(8676002)(6506007)(478600001)(52536014)(5660300002)(26005)(316002)(71200400001)(55016003)(186003)(53546011)(2906002)(83380400001)(66446008)(64756008)(41300700001)(76116006)(66946007)(110136005)(54906003)(66476007)(66556008)(9686003)(4326008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BshD8sX5+slseuaq+A0jDnhoVEIuxQP7uJcwB/St0I0kffxoOkrvfYvJTBak?= =?us-ascii?Q?1oun32qMHJVwTRofrTdL6X7ellvfZzcsP5A9BY4FCPy71aGZ7+lFSAQ2Rj/e?= =?us-ascii?Q?r1oBnmnI+qBfFvV7WFclMsvCPXOuEUfEN2cPklV2Ztv/anQNyzEbEk6vwJEg?= =?us-ascii?Q?+Fz/uniJJaYc1fOTeBbFgUY/POWoIWIbzBGU1NRIYg5i/DOrdCloLkLvOvrk?= =?us-ascii?Q?URRVyLJ4ABSq3qpu6tCwbLGgNZIb1emQAvbRyB7Vk2tcnwFC3cSoPN9yYfUY?= =?us-ascii?Q?68PsBR3ezfCh5UgSRY8wSVD/EUGvvog1bI2kLmYiTTmxA4RRGwp7MG90rOJK?= =?us-ascii?Q?YGzkmJuIYjl87j2DxruWBSweuEGHLbUZfmxQwRRB1Vdsyo3RFuf6iVDakQda?= =?us-ascii?Q?xMQwoLqlrC8hcBDUt1PBarpbpUDtf8s1G4t+20g6y/FMuP4mXTS//RfuH3x8?= =?us-ascii?Q?hV0BbQDQ04AiNwRj2JsF9BfaD+MVmv8GwU+IeEw7f4JWiz8mW/1yyEVY1DSL?= =?us-ascii?Q?F9gDhiEdQqqTySZXFKbc247kby+rPU/adxuaTsUcUNsBgwtlwQrKFPY6Yk2X?= =?us-ascii?Q?obuT7vtfX6M6ycM0I/1/hL4BojYoDYVnfuMEQmBvnB21rPlyTMjlq0OEwQdM?= =?us-ascii?Q?trnFvrNpDpkRy7vY9z/5ZiYTG1sC0rSnSQZEFgo67NuwyU9ZDIJCvkBHFX8F?= =?us-ascii?Q?+aKpGKH9VoGW/Dpsgf9njPlDMoCXO5gIu7iA7d4mLF4jy61t6hGY8Zz01HNd?= =?us-ascii?Q?rMhR7art80SqWO5FF+4Kz67DLO/CXiBdp3fArqayxrWYgCSgAeL8a07o12SP?= =?us-ascii?Q?xMlxBorvxDS/NoaKye8hVdpAefytSrmc9LTDmLQDFJsOjKeuAH5WIU5uIuRc?= =?us-ascii?Q?+pYnG4JdtZtQn9U8u217cuu2DI404vPqDvTywiaKvmCNst378Ulek2Xa8NKy?= =?us-ascii?Q?i7aBSwbntjiV5kJ0rpv6+Zts42F2+tPfnTDKDic99tW1DCWeAj+zjd9dghjx?= =?us-ascii?Q?dKTAa8YcqBCxLt0Pq1uNAQNwPp70jkYhyW4b57yS+ePNWM9YwA3Y2/fKazKh?= =?us-ascii?Q?SgvFyoJJMxwU+0SmZQqWtXezrDFElDdaVy9oWy0v0hjbNYWI6md3vsnzIgFf?= =?us-ascii?Q?vOrlXR4VW9NrnGq48FWuSuz1yrw7tJPUusvnCWbbzLbqqZmv/ALtisvEUF1n?= =?us-ascii?Q?N44bO3OyIB/+4uP7VhMUMNEevsO4v3dkqNLcBTniGy6KMdlYDKCfpioPzgFz?= =?us-ascii?Q?lKNgIokON9JliDax/55UJei3PTCJAtdEXT1qABoSJcdnKwXXuX3QxZwylWZG?= =?us-ascii?Q?iAt89kHil8EkqRwod7MpSSsoCIj6oCtecNY//1ghaWv9r18nXwhLoJREBgol?= =?us-ascii?Q?OmNHGmlZt4FuVXdEcTpXBbOQhJ+8jU42I1mxMi/WgdlE8wr1BycIxB0+EzOJ?= =?us-ascii?Q?MmQB5aFZ1vwS1RqhuLDU1pFSLML2hbjcx5pnZ5rcMEBVswChEdSbNhlMvRst?= =?us-ascii?Q?5G+iskecKnlifkP3JHb94BSqvoOOtgc1QrKJiTPCX2p6rAA5pOTKTJPWAEvS?= =?us-ascii?Q?Ewf7whPGIB8q6zSNaco=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5509cf3-1275-4556-9b8f-08db52bafe3c X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2023 07:32:08.5549 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sLtSpJesfl7w2SvSl00NR6qv7X2zuaycOr6bDy4rBQTJoZpVWc9SCQZqQSUTKki5hqK5JPlAVyPwv1gyjacvKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4409 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: abner.chang@amd.com > Sent: Friday, May 12, 2023 12:07 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang > Subject: [edk2-platforms][PATCH 2/2] ManageabilityPkg/IpmiOsWdt: Add to > ManageabilityPkg >=20 > External email: Use caution opening links or attachments >=20 >=20 > From: Abner Chang >=20 > Add IpmiOsWdt to ManageabilityPkg. >=20 > Signed-off-by: Abner Chang > Cc: Isaac Oram > Cc: Abdul Lateef Attar > Cc: Nickle Wang > --- > Features/ManageabilityPkg/ManageabilityPkg.dec | 1 + > Features/ManageabilityPkg/Include/Manageability.dsc | 4 ++++ > Features/ManageabilityPkg/ManageabilityPkg.dsc | 2 ++ > Features/ManageabilityPkg/Include/PostMemory.fdf | 4 ++++ > 4 files changed, 11 insertions(+) >=20 > diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec > b/Features/ManageabilityPkg/ManageabilityPkg.dec > index 38813c5f48..0a1c527107 100644 > --- a/Features/ManageabilityPkg/ManageabilityPkg.dec > +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec > @@ -79,4 +79,5 @@ >=20 > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmEnable|FALSE|BO > OLEAN|0x10000004 >=20 > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable|FALSE|BO > OLEAN|0x10000005 >=20 > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmSmbiosTransferEna > ble|FALSE|BOOLEAN|0x10000006 > + > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiOsWdt|FALSE|BOO > LEAN|0x10000008 >=20 > diff --git a/Features/ManageabilityPkg/Include/Manageability.dsc > b/Features/ManageabilityPkg/Include/Manageability.dsc > index a432b0ff26..439f3be1ce 100644 > --- a/Features/ManageabilityPkg/Include/Manageability.dsc > +++ b/Features/ManageabilityPkg/Include/Manageability.dsc > @@ -51,3 +51,7 @@ > !if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable =3D=3D > TRUE > ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocolDxe.inf > !endif > + > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiOsWdt =3D=3D > TRUE > + ManageabilityPkg/Universal/IpmiOsWdt/OsWdt.inf > +!endif > diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dsc > b/Features/ManageabilityPkg/ManageabilityPkg.dsc > index e3baf27f2a..177c900360 100644 > --- a/Features/ManageabilityPkg/ManageabilityPkg.dsc > +++ b/Features/ManageabilityPkg/ManageabilityPkg.dsc > @@ -37,6 +37,7 @@ > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmEnable > |TRUE > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable > |TRUE >=20 > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmSmbiosTransferEna > ble|TRUE > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiOsWdt > |TRUE >=20 > # > # Include common libraries > @@ -53,5 +54,6 @@ >=20 > [LibraryClasses] >=20 > ManageabilityTransportLib|ManageabilityPkg/Library/BaseManageabilityTrans= p > ortNullLib/BaseManageabilityTransportNull.inf > + IpmiLib|MdeModulePkg/Library/BaseIpmiLibNull/BaseIpmiLibNull.inf >=20 > !include Include/Manageability.dsc > diff --git a/Features/ManageabilityPkg/Include/PostMemory.fdf > b/Features/ManageabilityPkg/Include/PostMemory.fdf > index 9100cb2646..1a2fed2253 100644 > --- a/Features/ManageabilityPkg/Include/PostMemory.fdf > +++ b/Features/ManageabilityPkg/Include/PostMemory.fdf > @@ -26,3 +26,7 @@ > !if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable =3D=3D > TRUE > INF ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocolDxe.inf > !endif > + > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiOsWdt =3D=3D > TRUE > + INF ManageabilityPkg/Universal/IpmiOsWdt/OsWdt.inf > +!endif > -- > 2.37.1.windows.1