Hi
@Mike Maslenkin,
May I have your reviewed-by if version 3 patch set look good to you?
Thanks,
Nickle
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nickle Wang
> via groups.io
> Sent: Tuesday, February 27, 2024 8:49 AM
> To: Mike Maslenkin <mike.maslenkin@gmail.com>
> Cc: devel@edk2.groups.io; Igor Kulchytskyy <igork@ami.com>; Abner Chang
> <abner.chang@amd.com>; Nick Ramirez <nramirez@nvidia.com>
> Subject: Re: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP
> protocol
>
> External email: Use caution opening links or attachments
>
>
> Thanks for your confirmation, Mike!
>
> Version 3 patch set is here: https://edk2.groups.io/g/devel/message/115985
>
> Regards,
> Nickle
>
> > -----Original Message-----
> > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > Sent: Tuesday, February 27, 2024 8:13 AM
> > To: Nickle Wang <nicklew@nvidia.com>
> > Cc: devel@edk2.groups.io; Igor Kulchytskyy <igork@ami.com>; Abner
> > Chang <abner.chang@amd.com>; Nick Ramirez <nramirez@nvidia.com>
> > Subject: Re: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish
> > HTTP protocol
> >
> > External email: Use caution opening links or attachments
> >
> >
> > Hii Nickle,
> >
> >
> > On Mon, Feb 26, 2024 at 4:44 PM Nickle Wang <nicklew@nvidia.com> wrote:
> > >
> > > Hi Mike,
> > >
> > > > So finally we have
> > > > HttpFreeHeaderFields (Response->Headers, Response->HeaderCount);
> > > > but
> > > > Response->HeaderCount does not count partially allocated elements. Right?
> > > >
> > > > To fix this, it is required to set *DstHeaderCount =
> > > > SrcHeaderCount unconditionally right after DstHeaders allocation,
> > > > and HttpFreeHeaderFields() will do the work then.
> > >
> > > I follow your suggestion to update DstHeaderCount right after
> > > DstHeaders is
> > allocated. So, HttpFreeHeaderFields can release headers correctly. I
> > also create a macro to implemented AsciiStrCpy. Please check below link to see
> my changes:
> > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi
> > > th
> > >
> >
> ub.com%2Ftianocore%2Fedk2%2Fcompare%2F0f391b1c2f988d90a3ac723b314a
> > c28b
> > >
> >
> a7b0b8df..f0fa1b8fdcd933beb52fd3127c2476443c00ef8d&data=05%7C02%7Cnic
> > k
> > >
> >
> lew%40nvidia.com%7Cf3870f71360e44f3b4e208dc3728ff87%7C43083d1572734
> > 0c1
> > >
> >
> b7db39efd9ccc17a%7C0%7C0%7C638445896465360452%7CUnknown%7CTWFp
> > bGZsb3d8
> > >
> >
> eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%
> > 7C0
> > >
> >
> %7C%7C%7C&sdata=K%2FEA2QWpk%2F8NHQ1QhzqkvQqao4db%2BILn1Jt%2BB
> > qQ5n1E%3D
> > > &reserved=0
> >
> > These changes looks good. Internal strings
> > initialization/deinitialization code much cleaner now and possible leak seems to
> have been fixed.
> >
> > Thank you!
> >
> > Regards,
> > Mike.
>
>
>
>