From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 029329419D6 for ; Mon, 11 Mar 2024 13:18:40 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=S2TrNfX/M4Td2STN0TaBAoGAU3p349LmBfGx6s/lWZo=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1710163119; v=1; b=Z3BKjh38oQ+7aKgK7wL2i0+6kr9pbGzVXdTr7y3F96eCCPgYevtyrrgv/rJy7kaR2eykRMOT 55ENnD4dxw1K4c2Lh9gCDwnSrrZmfg29OnkgAAIda7Norw83feY6ioSI3EOeCd5cf0WkkS9R7iv yLU+pdE/3rev3eJA7mMRKGn5ekLzvefwJSQDY/GCdLD7PoocGepvnpdO34LJweIfQvl5JjunBo+ qwGxumDRgtMuGt5xLmPbhcK16nuGuT9e28BoU4Ur8dZ4hIrZutN5Jd42/wPKyFBl/II3ltPXbRY eQ0RLjcUCHLrsa2mWK7/Zt3C/jtCxx5RqUMXRCIMK+PpQ== X-Received: by 127.0.0.2 with SMTP id O0R5YY7687511xy6Hs3YCNQy; Mon, 11 Mar 2024 06:18:39 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.41]) by mx.groups.io with SMTP id smtpd.web11.62682.1710163118540731685 for ; Mon, 11 Mar 2024 06:18:38 -0700 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by CYYPR12MB8750.namprd12.prod.outlook.com (2603:10b6:930:be::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.34; Mon, 11 Mar 2024 13:18:33 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::fef9:2c9c:21b5:6f50]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::fef9:2c9c:21b5:6f50%2]) with mapi id 15.20.7362.035; Mon, 11 Mar 2024 13:18:29 +0000 From: "Nickle Wang via groups.io" To: "devel@edk2.groups.io" , "mike.maslenkin@gmail.com" CC: Abner Chang , Igor Kulchytskyy Subject: Re: [edk2-devel] [PATCH 1/4][edk2-redfish-client] RedfishClientPkg: fix memory leak Thread-Topic: [edk2-devel] [PATCH 1/4][edk2-redfish-client] RedfishClientPkg: fix memory leak Thread-Index: AQHacteVseDydikYjkCnYWClP1t5srEyh4aA Date: Mon, 11 Mar 2024 06:18:38 -0700 Message-ID: References: <20240310104151.41355-1-mike.maslenkin@gmail.com> <20240310104151.41355-2-mike.maslenkin@gmail.com> In-Reply-To: <20240310104151.41355-2-mike.maslenkin@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|CYYPR12MB8750:EE_ x-ms-office365-filtering-correlation-id: 3d7a85c1-20a5-45aa-1fc9-08dc41cdbe35 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: QPJqsU32GlGs8JJe+bf7Nzi+7mRujQZ4DPhX+OSJ9FFNunB4iEY1uR9FNqU0ZgB47dO3J6DlTb8vw78XVorP8QltYXSKwFO1+6qRefSM6meachtxjpuNxUGGzRnu50KK7jqo0hudE++tNZQBW2VU4cUr2IHM4MfHyRzFEBIOYMT2LFgjBTw8jya+GE66T7lSX9io1Be/La5ZsthIpMuOM1UkMdhgfvwDPD9KS5jQodzmaGTyvM6oECP77BQNxjS6MIDQkaUsVXQacgXFYNJea6IgfvF+BKN9vPwAFVerGgwuCpzGO6kdnkvWBOJkvdZDvZRVHsAlCVE8MqlmZnhZR6Rf0baM6XxBl5Ha9pB/4/pLOeXMafKC0HvYnWhm8XkV7QVf6Xpxdg2CavRnmJEwqEwQhBqjJjPV5eoIQdQbXtvr+bXM5KbnecBcoT3PbgORarDE7NRgPyBjt091kKruT8ZhR5tVSc77aFXnnXWfrMFgIM5tmNNqpEbOsqHYnF6efPdLjwELIKybmKesSGjnuAcMteJgANwSLPiahcNY2pLAe1ZQg0f0uJAt/7C1ZHNx600IKClkJKCKdMEj9+Sqf+mi3mnV8RuPz854k1RJ+h5KF456X5g6EPl9wESsUG2RUtR8YWqFUnKrGlwXtYlaeoF+0JTcFXcytXgr5oi7D1g= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CmuuzLR+S2aDdB/g/VcHaDzTIr5SZgA5FD/JfnKTZvao8x/R2mntXn3LiJGL?= =?us-ascii?Q?VmdmKzCWQf3XxuQLlXqh7CUvhTQioP0KMF9CzF3pDFHNqumLrdMD6vM0AJQC?= =?us-ascii?Q?yP2rdGaWWLFEvMaS6UfHP7AMk5LzGuCU4wGgFSdr1Fjciu7Ca9p7G37pWM75?= =?us-ascii?Q?9aMz4KgsfLES/Kd8qMwaiyISdhrx6xBa1sJI56wpghZLq2gITg/xRiLtUK2/?= =?us-ascii?Q?BFdvXfQVwwnaOEvDb09wzxJQODN632pu5THt7moeCRBE/5hlAzN2fnC5o+Ph?= =?us-ascii?Q?Ryn57+k5+zDKcgSCUONAeJ5yI7RR7Fvxm+BNd0dPtY98n228/8xO2wdsbRbS?= =?us-ascii?Q?ucyVTMCijhZl+EB1kmW2heu4tjaQD7vm2Im3lN6lKUd5oWKAbD/aAZAqKMMO?= =?us-ascii?Q?XlJs5AZAle3n2i2wBY8uhSfuWL3MzM23TH4c0H/2BDJt9oRxl24UEXD4y9ie?= =?us-ascii?Q?08TBXzul8WRUyX4SnKEu/LbfzGL0TAH8DUrzwxgOFJGGZFPMeV1Ibluul3bf?= =?us-ascii?Q?e3DM3GtTvRj35+3/RYokAtMqx7b0VORw3BeJXfWsR9XTh2NDL8ghoVb42s7v?= =?us-ascii?Q?pkIzqNLvYbpifc50Z1Wdwxqsw9V1O1EMIEZgrwHwT4LrKGCWoqP3mNnYl+Br?= =?us-ascii?Q?1AHJyn7OpOd3nXyew70kj2ziNNPVqYkeBQGIQ08K7slbH80EHPmnSiangkXc?= =?us-ascii?Q?EzYeptZ+SnzWNVj1XmyguPCchTX9p/eup2fgCTY50qt9cGuf3T3g4g7kA73d?= =?us-ascii?Q?odA4BpkyMtNP5lH4aXIW0R0DCOUxz8Fac+C8fehvHce87T+SGRIgw/Wyhz9M?= =?us-ascii?Q?ichbvCL98smJgqopDAe3OfvXgXP9HWn18N1IIKzr8j3nMymy8ReLTbGz8enb?= =?us-ascii?Q?JhmtICNETLQhKws5xr4tbEewkxChiiQNzbGCK+m7jNRIBq6880UBlp0bjNX7?= =?us-ascii?Q?urRDobvpVpxN999xShCkPV0v9if8Lkicj02JnTuaO3s4qF8CWdfsMLoxW+5S?= =?us-ascii?Q?7KkJWdVujNQB6aIZAcr392ayyP654apPuI6O6zXGDb5ceQQoR1E1Xni7ub+s?= =?us-ascii?Q?RH/Z+yY1Nl2CYiqjTz/KCDdkIDh59OO95Tijpy+3aDJbtt6EpL2wFqrZ/ass?= =?us-ascii?Q?nT1xbEgRqB5PaU4mYh6Mg+FMw0AtDaZut99bQ+gpv4N3Dw9C3QV0gBCxCDyb?= =?us-ascii?Q?FEDBB+LTffJJBAQpysdImoVbrsWVjtch5UwwQRB/U+Kxj/SvciV7D4mX4M+5?= =?us-ascii?Q?Q2mNbhcUPRcx8f0XELsEQpwmhlCyUUxoUPPbEyBKyDWzU3Rl0ZwPBTZ8BtN8?= =?us-ascii?Q?+75mveu5g5D0P6bKIj/Yz+iMG9Qhc7yUzuHmmk/Gr1N9RDTJnQ/4R659rY8F?= =?us-ascii?Q?NY1BAq46Iy3bRCGXzvsaw/YfOx1bLWbTd+3YWpRqJfsP+uqwYBldpTcN/Lu4?= =?us-ascii?Q?JFaiC+xus9X4eZVB6ti/ASnSfXzyZ7o0YHAr7KIaHysv3mglNaPcktTCYPGx?= =?us-ascii?Q?HKU/EO2D5SerdrsVMug0PKMECe4swiaJxtrQQv5YGWdLL8T9V8aqxxUAmCeS?= =?us-ascii?Q?c18lsLukjbqmiclehXOVnUdCt7jH5k+64xLue0rI?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d7a85c1-20a5-45aa-1fc9-08dc41cdbe35 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2024 13:18:29.4407 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: X7mcq9BHlKXEZRTCIznhMblW3xr8xAxhwdlhuh8Rxuol/5bpRYPm2Z14M2DhlWk18Q1TlDkULrZNtQ/r6bzh4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8750 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: qqBtlqbJxrj0GX0fEyz7HmZ4x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=Z3BKjh38; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Mike > Maslenkin via groups.io > Sent: Sunday, March 10, 2024 6:42 PM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Abner Chang > ; Igor Kulchytskyy ; Nickle Wang > > Subject: [edk2-devel] [PATCH 1/4][edk2-redfish-client] RedfishClientPkg: = fix > memory leak >=20 > External email: Use caution opening links or attachments >=20 >=20 > This patch fixes leak of EFI_REDFISH_COMPUTERSYSTEMCOLLECTION instance > on error path. >=20 > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nickle Wang > Signed-off-by: Mike Maslenkin > --- > .../ComputerSystemCollectionDxe.c | 12 +++++++++--- > .../MemoryCollectionDxe/MemoryCollectionDxe.c | 11 ++++++++--- > 2 files changed, 17 insertions(+), 6 deletions(-) >=20 > diff --git > a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemCo > llectionDxe.c > b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemCo > llectionDxe.c > index 55a6d07dbf2e..3deefa824629 100644 > --- > a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemCo > llectionDxe.c > +++ b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyst > +++ emCollectionDxe.c > @@ -174,11 +174,13 @@ HandleCollectionResource ( > CollectionCs =3D Collection->ComputerSystemCollection; >=20 >=20 >=20 > if (*CollectionCs->Membersodata_count =3D=3D 0) { >=20 > - return EFI_NOT_FOUND; >=20 > + Status =3D EFI_NOT_FOUND; >=20 > + goto ON_RELEASE; >=20 > } >=20 >=20 >=20 > if (IsLinkEmpty (&CollectionCs->Members)) { >=20 > - return EFI_NOT_FOUND; >=20 > + Status =3D EFI_NOT_FOUND; >=20 > + goto ON_RELEASE; >=20 > } >=20 >=20 >=20 > List =3D GetFirstLink (&CollectionCs->Members); >=20 > @@ -206,12 +208,16 @@ HandleCollectionResource ( > List =3D GetNextLink (&CollectionCs->Members, List); >=20 > } >=20 >=20 >=20 > + Status =3D EFI_SUCCESS; >=20 > + >=20 > +ON_RELEASE: >=20 > + >=20 > // >=20 > // Release resource. >=20 > // >=20 > Private->JsonStructProtocol->DestoryStructure (Private->JsonStructProt= ocol, > (EFI_REST_JSON_STRUCTURE_HEADER *)Collection); >=20 >=20 >=20 > - return EFI_SUCCESS; >=20 > + return Status; >=20 > } >=20 >=20 >=20 > EFI_STATUS >=20 > diff --git > a/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c > b/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c > index d963fb52ad37..38f28f902715 100644 > --- a/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c > +++ b/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe. > +++ c > @@ -165,11 +165,13 @@ HandleCollectionResource ( > CollectionCs =3D Collection->MemoryCollection; >=20 >=20 >=20 > if (*CollectionCs->Membersodata_count =3D=3D 0) { >=20 > - return EFI_NOT_FOUND; >=20 > + Status =3D EFI_NOT_FOUND; >=20 > + goto ON_RELEASE; >=20 > } >=20 >=20 >=20 > if (IsLinkEmpty (&CollectionCs->Members)) { >=20 > - return EFI_NOT_FOUND; >=20 > + Status =3D EFI_NOT_FOUND; >=20 > + goto ON_RELEASE; >=20 > } >=20 >=20 >=20 > List =3D GetFirstLink (&CollectionCs->Members); >=20 > @@ -197,12 +199,15 @@ HandleCollectionResource ( > List =3D GetNextLink (&CollectionCs->Members, List); >=20 > } >=20 >=20 >=20 > + Status =3D EFI_SUCCESS; >=20 > + >=20 > +ON_RELEASE: >=20 > // >=20 > // Release resource. >=20 > // >=20 > Private->JsonStructProtocol->DestoryStructure (Private->JsonStructProt= ocol, > (EFI_REST_JSON_STRUCTURE_HEADER *)Collection); >=20 >=20 >=20 > - return EFI_SUCCESS; >=20 > + return Status; >=20 > } >=20 >=20 >=20 > EFI_STATUS >=20 > -- > 2.32.0 (Apple Git-132) >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#116565): https://edk2.groups.io/g/devel/message/11656= 5 > Mute This Topic: https://groups.io/mt/104841892/7129762 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [nicklew@nvidia.com] -= =3D-=3D- > =3D-=3D-=3D-=3D >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116624): https://edk2.groups.io/g/devel/message/116624 Mute This Topic: https://groups.io/mt/104841892/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-