From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 05688740035 for ; Wed, 11 Oct 2023 01:49:43 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6Q5KRNlUTc8HproPNT2F7y2IgkCPaGrFhEca1om2a6o=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1696988982; v=1; b=CHf9nKMdTwAfj7FF9pM4vVsEPqfKA/P7oI9i54y69PMPeKwPEQAsmeIPjgLiSlR6BRqud4xv FY5+rN/rPvI3fePumxxbv9gzXh+2blkzSxLJPdHH+zupV79k8u/NfZWmAWacAwArP2V2RebJkmk eQ+ublqmHzoSjHbkNYpF2kME= X-Received: by 127.0.0.2 with SMTP id SRUKYY7687511x18b3QQn0uk; Tue, 10 Oct 2023 18:49:42 -0700 X-Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.107.95.53]) by mx.groups.io with SMTP id smtpd.web10.7735.1696988976740696404 for ; Tue, 10 Oct 2023 18:49:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bAePcSQsR/WeWhWcUNCF1X7bx/GeOG5LdSHz4MUq9R2+EeULY4ytZaTjuFx9213Xx0lPFilDnQMQa5X1T/k80NZRYw527E1AqzC0KdJjxkTWTuXbPyo97+CGOkg9CfDvJrsvb1y0FrpLmOkLruhzh9tZsUVj99QOt5dj5+ngQIIJw4mbcRepw2cCnS3LfvThjSWzGxo68nmzZhSAjkUDtTnwvbzBnA+7uDzGgjqwW0QPqMJA5aNgdoLkj0ASsNQOgMB+xx7hwJR5i5+Nndls6zeLwSc8tTr6qN+3KW0KWtKU3dhd8avJUT6lUIzWy51KJL86pc0cy9WvuSKKPrm1RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sv/06EFNfV7CfbxMcehy6yPQ9JvCbZH0O4LSGJNPF3c=; b=N7mpaGSQ4xIVSxRir8Ll/rYVj7MY1KS1PRD+5Fykd+j+9XZvu/L7AYnNDRz6RS/YRTAkPbUt57x6kOA/+aqV+4vSqqLrSjOaHgnKI3LtbikaeORY/OC8JElKE7XNIKCfOUO6jhtnJcDkJwxdQuMrOYaCYU8Zjdc0YG5XgTt+ccSstT/zZ8vI3/pt5moOXctolRTEL+T+svk8u7JBrfdtsVgalbIEP3yzwQDE0nlwBScLitZIpLYw9kSMUrTIgL3W0OYTgfLvXAj67OvTlFHljz3JTRUqXkIrgCUo+5jOi5wLXiicOOHLP9p/mxBcaNUgGHZ5zM36X/TgHws7Us+RIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by BL1PR12MB5238.namprd12.prod.outlook.com (2603:10b6:208:31e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.38; Wed, 11 Oct 2023 01:49:33 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::f345:babc:2bc5:bfae]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::f345:babc:2bc5:bfae%4]) with mapi id 15.20.6863.032; Wed, 11 Oct 2023 01:49:32 +0000 From: "Nickle Wang via groups.io" To: "Chang, Abner" , Mike Maslenkin , "devel@edk2.groups.io" CC: "igork@ami.com" Subject: Re: [edk2-devel] [PATCH 8/9] RedfishClientPkg: fix pragma pack usage Thread-Topic: [PATCH 8/9] RedfishClientPkg: fix pragma pack usage Thread-Index: AQHZ8yA4zAL90pvJaUOHQRmz5pKbsbA1zrkAgA4U7sA= Date: Wed, 11 Oct 2023 01:49:32 +0000 Message-ID: References: <20230929215915.46616-1-mike.maslenkin@gmail.com> <20230929215915.46616-9-mike.maslenkin@gmail.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=f46730de-1a59-445e-a01b-bd2147803cfb;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-02T02:43:01Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|BL1PR12MB5238:EE_ x-ms-office365-filtering-correlation-id: b18fd158-0874-4c25-2f97-08dbc9fc50bf x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: f95xOTItuxdUYAYzWlGpBjz0KhgecmEcc5XO/Muj4PnTYkW6nBMrXwAxl5eCPGfaN+Mi5KmLFUmuyPDPpJtpti+djMP/lnOwPDRNZXSROqBxOQ1j3nF2DK2RItaC557RFQqYIWEDFqGryxwhFC5Wf8IqtlfD0fC1Qw6azyTJUw87sYHHmJUH3YptYD9R8IYWEF0AQ9jSPCFMybMspuDcIzXPk/CFotGhsbKiad8Av+H3DAY8mvXIAhccr4Iz3Fi258thQs9fczhOGZlKJ2oqTB1xl68zpHX3b37SV0eqXqWcenqQcx4AP9t4p2DGKfSJdTRNOLrDNfB8rA3pge8AQJXVDhK14v2fPXXn6AeTR1HEY+MNU1L88LuSsuws9S/3nXbkpDJYQCSZposptQkXLGdvJgomFfcmtJED7kCSfqqNeqEy5VWymWPHO/vidxI5lukd61nN4dQcNXXwzitZkQZR2YU7OxXl1Rz7oajwHeZnxMdSjPH8pwUSYMpoEmtkj5qPVfIwd8giX5ZOqxJO5Qca1atHhTDRfaEm0GS3ETXsUd3dcx4EZzhXDi9apQYChs7uytzEe+fB/SC2eNrzoFpsdU+DzubC/56aDrMDPOHb7gdy3h+RdZvt6xkc38CI x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?I0QNofyCyN2+3DPT0bAtoumV43npiqq/XGQdC/JMsX2mDkq97A9EfJAxylQn?= =?us-ascii?Q?34RCofwvkGp4tnFj4iJfjYogjnLw82Tq5wHQTgv2gDROGdefGQPFLtkpn0Z3?= =?us-ascii?Q?KCB2hPg9cdGjcTm8QOEeIaGN+5wP7qdD25TJnz5UMbJMS6yePUPwuk0Qximr?= =?us-ascii?Q?CWLnltb1Ng1TJpoQBLaR6IZwOlmVYz38s1hbkpjj9z7RCF/Kb0UFlJw4IjSk?= =?us-ascii?Q?fRI6CU924g90dGiFRRnDp+R5VM8AjokplgQOo7tiIQZ1BrpzrYzIGKgE8r/1?= =?us-ascii?Q?LwbWnc8lY0fKNJRfws0mDjshAKFyaYMQ8TA8xBoGksbwLNrw+KKJXgnasMJN?= =?us-ascii?Q?DpESu3ThjrOID44EVxuSXGRpEk9JlIk9jSTm/IpPZxv+eeZsEwT6OgheZhx9?= =?us-ascii?Q?2Kj3f0m3PGLnfMGViCRaLf1uYRZg889Z8WH87Q+PCYmn40dvPu4T7oDBTtiB?= =?us-ascii?Q?F0isGtBBCxpwBovp6dVmHswrSaC8yWo92JDbIAdTJpk8bdWxOy07gu6u0bin?= =?us-ascii?Q?wzJodSLkrHGT0OXixkaG4Ue4OVW1FeCv+3+vQ1wOwWJ7arjiJSqXj97itm9w?= =?us-ascii?Q?FqezfAMGWerKkSxzbMcYPvg/Tzj91gFmvE7LFwfGHJ8kWnejPxlA7pJ0L3nl?= =?us-ascii?Q?OTKoYJp9aOfko2ICZ81lCigXGotbIE7sNxs+3R0kmcQ5KXAHdTa0hgSQmFfP?= =?us-ascii?Q?LE192kA/l7CIwmOgOQPu5d1su2nCfArf33iqsuBH+pWcyy8lQs2y1fJzyeRj?= =?us-ascii?Q?sKnVqFo+u9gjbXYNaMMqjOGa4v0o1LkGDWsc8Y5Wr6l8RYZZ/9gQpyfAg0Rq?= =?us-ascii?Q?OLmDB9tVTaGUbGbAcXJmgosPxXbuyQvbFRMpOT+ZH+dMcrT6MnARB08+7GtF?= =?us-ascii?Q?Ix/hQRDGTfkvZ3P2nuuIG2awn8gqtXaWPQ/meQ/r6W7A3TzT6vnzuCJJ356P?= =?us-ascii?Q?arxZviaSSL8IP4IDgXSf8AkFbj7SIh/8KByZ0N6PEyUeW2aFqosevhsIx0mO?= =?us-ascii?Q?ssm1khi9Lmm50+bHuiRtgNjZvGqR8Hjj9OYkQLBz0k8/9P+NQSACMPmwu5zH?= =?us-ascii?Q?IGH/T6U9mKFJh9j8VmJD7XO0grpq1CkhWgzwMRi7EIYbbN+Cn/pDFLwA8F6G?= =?us-ascii?Q?/fI36R4+VW4y9RlLdrEKCRyruJxbB/X3JXMI8s0IcU6hVKx6hEXf74H8kqte?= =?us-ascii?Q?MKHBq6st/vd+2VVi+LghNdLQJg7l8auybSDw7DM+0YjUpGvzWlRuAhZz+5Wd?= =?us-ascii?Q?oBUd47h9wk9EKFYVQ/BOrxcYNpf+KxAUOzqstKMtH4cIzNsspZjfcdNSaEGT?= =?us-ascii?Q?Fph0RYeQ20akXnQgEC4K3kifAknpAaEgXC5ybfsagnAYjcf0XCh4epg6J4+O?= =?us-ascii?Q?y6ziftnBE9YvNi+gv998MsY2ePtiUbnFtPtIaxp3zc8o/mugsv5QV9vH3dOv?= =?us-ascii?Q?Wn+6SmGf/kVvy+BwH6NsfC0KyWSVpqgQXhudwSSh4nOai05ZN4DvaIKvyM9e?= =?us-ascii?Q?6rQCP1RglqbIptnDDHBoU3EEbbJG6U2gNGYlEDeVZFbHm95au2isGP6dPfAR?= =?us-ascii?Q?jEg0bn5KIwRY/faRU//IXotxv/TPloCzkNsfngchtAbSQJqhbayJe8s7G0kJ?= =?us-ascii?Q?hyL/Y6xYRdWZa0/xIRhG5ZNzhebPVKvr1196Z1NHzerc?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b18fd158-0874-4c25-2f97-08dbc9fc50bf X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2023 01:49:32.6109 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: e/fv2pEsefw83FT1TYdK3JLzJRvO7DHS4yr360ummdILW7U42Tcv5b7f25Iz1y1ppT2JffLXVaoN3hYhb++Ygw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5238 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 5EZ0mOx2uBNnTFw1QZ6hOhQ6x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=CHf9nKMd; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Sorry for my late response. > Do we need pack(1) for this structure? We can remove pack directive if w= e don't > need to have packed structure members. @nicklew@nvidia.com, could you > please confirm this? I see the use of "pack(1)" in EDK2 DriverSample.h. I think we can keep it. Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: Chang, Abner > Sent: Monday, October 2, 2023 10:45 AM > To: Mike Maslenkin ; devel@edk2.groups.io; Nick= le > Wang > Cc: igork@ami.com > Subject: RE: [PATCH 8/9] RedfishClientPkg: fix pragma pack usage >=20 > External email: Use caution opening links or attachments >=20 >=20 > [AMD Official Use Only - General] >=20 > > -----Original Message----- > > From: Mike Maslenkin > > Sent: Saturday, September 30, 2023 5:59 AM > > To: devel@edk2.groups.io > > Cc: Chang, Abner ; nicklew@nvidia.com; > > igork@ami.com; Mike Maslenkin > > Subject: [PATCH 8/9] RedfishClientPkg: fix pragma pack usage > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > Signed-off-by: Mike Maslenkin > > --- > > RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git > > a/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h > > b/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h > > index 7e1bc9cefbac..9d5b10a7e909 100644 > > --- a/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h > > +++ b/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h > > @@ -31,7 +31,7 @@ extern EFI_GUID gHiiToRedfishBiosFormsetGuid; > > #define ID_STRING_MAX 15 > > > > #define ID_STRING_MAX_WITH_TERMINATOR 16 > > > > > > > > -#pragma pack() > > > > +#pragma pack(1) > Do we need pack(1) for this structure? We can remove pack directive if w= e don't > need to have packed structure members. @nicklew@nvidia.com, could you > please confirm this? >=20 > Thanks > Abner >=20 >=20 > > > > > > > > // > > > > // Definiton of HII_TO_REDFISH_BIOS_VARSTORE_DATA > > > > @@ -44,4 +44,5 @@ typedef struct { > > UINT8 Reserved; > > > > } HII_TO_REDFISH_BIOS_EFI_VARSTORE_DATA; > > > > > > > > +#pragma pack() > > > > #endif > > > > -- > > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109505): https://edk2.groups.io/g/devel/message/109505 Mute This Topic: https://groups.io/mt/101667468/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-