From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.52]) by mx.groups.io with SMTP id smtpd.web10.18716.1683255312229463691 for ; Thu, 04 May 2023 19:55:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=selector2 header.b=jI1AABRk; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.94.52, mailfrom: nicklew@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FA4Nt3Hg6DQ0jBqeCV4i3R1czEaNYRASBs0+X7NeBsErj/XyeuPuEZTFErZnYBZSfcBPdcN8j1K4cDeEQMfbT+S0XWOP5gRWRDYua0p1Sr2bVQ93KpaVeU/DnESmtp4mZj72Z4rz2z+GOmbDN/N6Azt7dKoz77fIK0lQe+uqjwxJzm+NOJwVbWfzmujFyqAMgwNNI+wkB9pSn7C/bxxBVRz5zzMKl4R3jsWvm1OaCEeYtl8ipOQtFOzlgE2W9Nb+1fYgEgEhkuJBHgQZWhYOYRHalh3tx1aJfEpzpxHZO16su2sCIHUimClgVMbuuKk2yj6i+8QST+Bq/VBgx1jkTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vetf1bgKO0ILhRkf1Axkt0Gj1+Tp6qGW6OzpMD2kfvk=; b=bDpf+ju9PvStqCiZ3xeN41QuCiFOHEKIFg8LSHaBVYJG62/PkrwWFnLTqAsq5rIslBvMSoV5dsCuKNVSuORYM8GzDGgoVU7pTELIcHSBPmf+Ksp4+d2nobNBquu2Z9uGjRDYVrtdZS5P/EHCQLvL0YtvLhC1Ud+7o67L8/rwJlz+45efsBpjBACFrEVr6ZyFFqnLrtepLQuzWF8hd6OUZpiakYgnjeJtxYkvH9G4NLri06qkHVH/SV4LzbgWg2Cl7h8Vc9pOBzwwOvKgRpBckjxBlP9Ws+1QzHOIJsMdi6YyLKlUUAkfwY86RM7UwLgnU9aXNlBusXurM+n/Y5tP9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vetf1bgKO0ILhRkf1Axkt0Gj1+Tp6qGW6OzpMD2kfvk=; b=jI1AABRkloAOErGGQ1JFYzH5lvcmAtXlowzNBZt2UtQR1+ywnYWS6HgGyizVHvL2TtG63lyyedXDqrKDID6NPW2fqERChP64fboqcJikK37GIfX0EnxEc2FSX5si5MXQn2PYQvSlxFts86Cx8I7SvOUMMXhZ3cdL9DNglSmFw0Aq4QdnYHi8slMnHD0rlXwfE77QLghGht9/B7XmN587L5Nx67T6rSpPC6d1cMUfkMUjpZmAlEqQFbX0zh2dvU5QgdouYD1ex8cMmjx4V/qunDzNO8DxVpR/QRfiAqFEL6HlCdQlx5ITkZBVWnu2vd/xzo4yeDsKpK6WuUvfnv18cg== Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by DM4PR12MB8475.namprd12.prod.outlook.com (2603:10b6:8:190::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Fri, 5 May 2023 02:55:09 +0000 Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::d9df:b45b:2cc1:f017]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::d9df:b45b:2cc1:f017%5]) with mapi id 15.20.6363.026; Fri, 5 May 2023 02:55:09 +0000 From: "Nickle Wang" To: "abner.chang@amd.com" , "devel@edk2.groups.io" CC: Igor Kulchytskyy Subject: Re: [edk2-redfish-client][PATCH] RedfishClientPkg: Add converter helper library Thread-Topic: [edk2-redfish-client][PATCH] RedfishClientPkg: Add converter helper library Thread-Index: AQHZfvzb3pDANYd6IUG0S7v6QB170q9K++HQ Date: Fri, 5 May 2023 02:55:09 +0000 Message-ID: References: <20230505025338.1879-1-abner.chang@amd.com> In-Reply-To: <20230505025338.1879-1-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|DM4PR12MB8475:EE_ x-ms-office365-filtering-correlation-id: b936b445-7a10-44d0-5df0-08db4d142364 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gd3d0JWZE9N4y2D8a+DC2m9IQ0E05kTSZoNGRrsrGVfy2BqRFcf9yVQbWuOiCGTlGfco0njc+6zfU6cHKzwR2Vhj0ZpHI3v4Wih+E4syooXjY8vWZ0tSOgVnVGibSUY6yglRGFXClCg8IUl7AhTRLxPUIbebL82OmMbTym1mPBOSN/XPI1ER4L3SYXX/Utuis+B0jcoFTB+KG6wqKF8TOdjHHXUazSWs7jn+1RKTlgR+QrR9L/krK0qxzW8zbGwmMw5+wsJNtR1OjtZiXJ5JnDeMtwCP7I/xgz8CEJQkVBjFJDk8jV4mmEyYT8usBEzE3d8eltgKkip0nE88/cEPANWr2CPZ+M990EA+T2OMV251xK/1VitCM834dDnX4JWos84j2UJwGKsZJpcsbRkasuZUc/uL108rkC6O6r8L6JAUYvk3Q2puQ4Jp8aa0D1H3c3SyKYju7EmppPEL3iZ6lz3PwFi6r1FZu9x/09j3yqh1E2MrX2wYJ4UhSaB3IImJNv8URWYl8BUoV3z9ybUtUu8SXOFROrQv+x1lfL4xEJ2UU7W8rue+3olqIfISqoZhsWZHtZkk3BNB+1qDQ6LtWzbmLI8Ld7vroNGPhDrKUefLqUBSawuQBhqjwjl9kQXL x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR12MB7031.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(366004)(396003)(39860400002)(376002)(346002)(451199021)(83380400001)(110136005)(2906002)(4326008)(52536014)(478600001)(33656002)(5660300002)(316002)(55016003)(122000001)(66946007)(66476007)(41300700001)(38070700005)(8936002)(66446008)(66556008)(76116006)(64756008)(8676002)(86362001)(38100700002)(71200400001)(7696005)(186003)(9686003)(6506007)(53546011)(26005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?scLeMvj95BMbSJwzXb9rRfZwBL930ji6HKHeWA+M84Tr4lUoR9QMf1p1a8G7?= =?us-ascii?Q?thUFlM50C0RjNFVPXg0Dd1Tz4tG5uvWNRW8JrzKGJVwuqje3/WbMO1D5KDCO?= =?us-ascii?Q?pqOWoLLsDYpPJxjhL6bYAIPv2XB84aufmDd+owjGTpdlGn+/lFQK8D6gmPa7?= =?us-ascii?Q?/6msnplR2HmVz06fb8qQrG3Dceq79xOBtdF8o+ch9xrqoUxiusxS3gCcka1O?= =?us-ascii?Q?xZYS4OgK79GvzGLYbUSx2SszDd11RzcqpBUo0CfeNB3fDC+KOZ43JgyCgefS?= =?us-ascii?Q?HElEFobUqlnLjgUsom4pvjCTA6jKHDp0x5Hr99wwI62aP78npf9ZJXLA9JTh?= =?us-ascii?Q?Kkz9h6BFi+W0tQjFPobWsfCkkkC8n53gor00H5y1+1wWhyV9YKMmVxQSilG8?= =?us-ascii?Q?RdkcMOj0iFAYBTXlx+Cwc+5A5ckELaJCmb1u3ncLsjRrf1hNiQitLEl3EwPp?= =?us-ascii?Q?fo5rQ/xiGCSODrS3bEqk4hrPRkFR2F4lYvz5rSWlzcQPNxD7m6bM295lJQTZ?= =?us-ascii?Q?3BwMoDBUhQ9fGjXjx6aCcMaJ6/py93o4sykEm/UJshuIL5qbF2miLaw3/e+a?= =?us-ascii?Q?H0CRlac4C3b1OPNOsjmvepxpXuCxQJt2mqC/TTnCCDV2/md/2rZFNJhPom/o?= =?us-ascii?Q?z84V0h1Irk5eBl8pgFQ0jqqbjc4G0xl/ebceOv6cCS9KjYNTz90OZtfse/xv?= =?us-ascii?Q?6kou51ROzS31QtbYUyfaLTgelR3IcZ5ttvkYfY3+2W/P2BPkshAgL6sI3OLj?= =?us-ascii?Q?rlpXwg7ziiPjsfuyO5a5tXBNiKiAsGUfrZTUgtti2N0SmGvZ32fbQMadN4Zi?= =?us-ascii?Q?1C4fhEvEw0fbMFTQEYnOYwG3qQunhdvt+wbKyyx4VNIv6XzJsdpUsdixL6P9?= =?us-ascii?Q?52u7C8p724BbJNSoeaGmSoh2eILagGKflwpJVCqM6k4EDjH1uJube2eznReL?= =?us-ascii?Q?Yp7xqdCq7w5/pAlII9XOFhIQjSfcfa62t1PSGjlzT3Q675MIBiIFJrYtWFaQ?= =?us-ascii?Q?qOTswO6EC1oc7Rybrb8ukWjndcn4tFswZW/eX/QZvyzMwQOY27co1aretClu?= =?us-ascii?Q?EfIx/2LxxpIyWP8XCMbwjuumqi6fFvaFSospje+MLshrrd0Ntnp2BYhhwCEE?= =?us-ascii?Q?rKce8qMczGjlk57UV7LwQuiEvjT5BJ3R8MgP8MAEEfB8e9SLQn7YoyOuhdhk?= =?us-ascii?Q?ftZVjcdHGxT2lJPQUVOnFp1N/bvc7EzLyis6kHi1H7D4+XlZOj8yiRhVmO6i?= =?us-ascii?Q?ydaLubVmobmSr5r0RF5RAaV7ABqjAQyX3NbEzHbIMzT1ANMbMNGoqb4CTF0+?= =?us-ascii?Q?bV4dkPBIqUuXIE/FUPZceVecHW5E+c8QUSCj3QmMjOBDutbdTpkRRyPIuesD?= =?us-ascii?Q?58l66sVpP4GTZIIuHVC7OwW3GQQC0q92lEsEbc6Ymw8nmZVNMOcypvkm5B9i?= =?us-ascii?Q?kq4Hbj1HWCVrgtt5qrAC/wdtdLNd3K7fwU+SPT52Du/JldxREL8pxznn6iia?= =?us-ascii?Q?K70e0O8sj5Aa/WOQBioal+pl3p24nZ1HUOBvUXYY8a5GoDDqZT3RLQzpYxht?= =?us-ascii?Q?P+Ni8OE1YtH6clvYjGY=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b936b445-7a10-44d0-5df0-08db4d142364 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 May 2023 02:55:09.1107 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zRbg0nKLtoFDtCCujrX6Z9z7R1r77x+2owtPG5TSVRJEeHrvx5shARL8sMHgr/NJovVXvJobD/HoFzVhS94Rig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB8475 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nickle Wang No comments because this was reviewed in edk2-staging before. Regards, Nickle > -----Original Message----- > From: abner.chang@amd.com > Sent: Friday, May 5, 2023 10:54 AM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [edk2-redfish-client][PATCH] RedfishClientPkg: Add converter hel= per > library >=20 > External email: Use caution opening links or attachments >=20 >=20 > From: Abner Chang >=20 > Add the helper library of JSON to C structure converter common functions. >=20 > Signed-off-by: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > --- > RedfishClientPkg/RedfishClientLibs.dsc.inc | 1 + > .../ConverterCommonLib/ConverterCommonLib.inf | 44 +++++++++++++++++++ > .../ConverterCommonLib/RedfishCsCommon.h | 14 ++++++ > .../ConverterCommonLib/RedfishDataTypeDef.h | 14 ++++++ > 4 files changed, 73 insertions(+) > create mode 100644 > RedfishClientPkg/ConverterLib/edk2library/ConverterCommonLib/ConverterCo > mmonLib.inf > create mode 100644 > RedfishClientPkg/ConverterLib/edk2library/ConverterCommonLib/RedfishCsCo > mmon.h > create mode 100644 > RedfishClientPkg/ConverterLib/edk2library/ConverterCommonLib/RedfishDataT > ypeDef.h >=20 > diff --git a/RedfishClientPkg/RedfishClientLibs.dsc.inc > b/RedfishClientPkg/RedfishClientLibs.dsc.inc > index 4655dd7081..a23b9478af 100644 > --- a/RedfishClientPkg/RedfishClientLibs.dsc.inc > +++ b/RedfishClientPkg/RedfishClientLibs.dsc.inc > @@ -20,4 +20,5 @@ >=20 > RedfishFeatureUtilityLib|RedfishClientPkg/Library/RedfishFeatureUtilityLi= b/Redf > ishFeatureUtilityLib.inf >=20 > RedfishPlatformConfigLib|RedfishPkg/Library/RedfishPlatformConfigLib/Redf= ish > PlatformConfigLib.inf >=20 > RedfishContentCodingLib|RedfishPkg/Library/RedfishContentCodingLibNull/Re= d > fishContentCodingLibNull.inf > + > + ConverterCommonLib|RedfishClientPkg/ConverterLib/edk2library/Converter > + CommonLib/ConverterCommonLib.inf >=20 > diff --git > a/RedfishClientPkg/ConverterLib/edk2library/ConverterCommonLib/ConverterC > ommonLib.inf > b/RedfishClientPkg/ConverterLib/edk2library/ConverterCommonLib/ConverterC > ommonLib.inf > new file mode 100644 > index 0000000000..589c864815 > --- /dev/null > +++ b/RedfishClientPkg/ConverterLib/edk2library/ConverterCommonLib/Conve > +++ rterCommonLib.inf > @@ -0,0 +1,44 @@ > +## @file > +# This is the helper library of converter # # (C) Copyright 2021 > +Hewlett Packard Enterprise Development LP
# > +SPDX-License-Identifier: BSD-2-Clause-Patent # # [Defines] > +INF_VERSION =3D 0x00010006 > +BASE_NAME =3D ConverterCommonLib > +FILE_GUID =3D B70BDFAE-4D07-9B07-FD24-42AA235D6108 > +MODULE_TYPE =3D BASE > +VERSION_STRING =3D 1.0 > +LIBRARY_CLASS =3D ConverterCommonLib | DXE_DRIVER > DXE_RUNTIME_DRIVER UEFI_APPLICATION UEFI_DRIVER > +# > +# The following information is for reference only and not required by th= e build > tools. > +# > +# VALID_ARCHITECTURES =3D IA32 X64 IPF EBC RISCV64 > +# > + > +[Sources] > + ../../src/RedfishCsCommon.c > + ../../src/RedfishCsMemory.c > + > +[Packages] > + MdePkg/MdePkg.dec > + RedfishPkg/RedfishPkg.dec > + RedfishClientPkg/RedfishClientPkg.dec > + > +[LibraryClasses] > + BaseLib > + BaseMemoryLib > + DebugLib > + MemoryAllocationLib > + JsonLib > + > +[BuildOptions] > + # > + # Disables the following Visual Studio compiler warnings > + # so we do not break the build with /WX option: > + # C4706: assignment within conditional expression > + # > + MSFT:*_*_*_CC_FLAGS =3D /wd4706 > + > diff --git > a/RedfishClientPkg/ConverterLib/edk2library/ConverterCommonLib/RedfishCsC > ommon.h > b/RedfishClientPkg/ConverterLib/edk2library/ConverterCommonLib/RedfishCsC > ommon.h > new file mode 100644 > index 0000000000..8567284ee4 > --- /dev/null > +++ b/RedfishClientPkg/ConverterLib/edk2library/ConverterCommonLib/Redfi > +++ shCsCommon.h > @@ -0,0 +1,14 @@ > +/** @file > + Wrapper file for RedfishCsCommon.h > + > + (C) Copyright 2021 Hewlett Packard Enterprise Development LP
> + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#ifndef WRAPPER_REDFISH_CS_COMMON_H_ > +#define WRAPPER_REDFISH_CS_COMMON_H_ > + > +#include "../../include/RedfishCsCommon.h" > + > +#endif > diff --git > a/RedfishClientPkg/ConverterLib/edk2library/ConverterCommonLib/RedfishDat > aTypeDef.h > b/RedfishClientPkg/ConverterLib/edk2library/ConverterCommonLib/RedfishDat > aTypeDef.h > new file mode 100644 > index 0000000000..9d29342972 > --- /dev/null > +++ b/RedfishClientPkg/ConverterLib/edk2library/ConverterCommonLib/Redfi > +++ shDataTypeDef.h > @@ -0,0 +1,14 @@ > +/** @file > + Wrapper file for RedfishDataTypeDef.h > + > + (C) Copyright 2021 Hewlett Packard Enterprise Development LP
> + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#ifndef WRAPPER_REDFISH_DATA_TYPE_H_ > +#define WRAPPER_REDFISH_DATA_TYPE_H_ > + > +#include "../../include/RedfishDataTypeDef.h" > + > +#endif > -- > 2.37.1.windows.1