From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5B443AC12AA for ; Mon, 18 Sep 2023 13:15:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=UflyyEvhNErZxPlj/f0q2E1BylPRI+X89fuX8wYS+bA=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695042919; v=1; b=Qp/fyrXPxTY8mJyP+MeFUA4PO6dPdYCjHS1iKvKnRw6yYzQMwXVHRkeiLGxGGK8pdjIbZXZb M2SrYT9wZi9IqIqGx/61oit+DFFvS8NzsLIfc/yKYueyVY0jIVLD9iB840qEDECklb0aH4CFR7z ZfUFT1I+TfBliikLzWVHkqRU= X-Received: by 127.0.0.2 with SMTP id 1In0YY7687511xo8NXkOtJea; Mon, 18 Sep 2023 06:15:19 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.40]) by mx.groups.io with SMTP id smtpd.web10.50718.1695042918416140369 for ; Mon, 18 Sep 2023 06:15:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A6iSkTajWjggMAZzA1xfvBAvggL8IwCCO1fagsA3X4r52uImdJnnu+IfOSv6L0O3rqTNCSo+wi3Ix3x+7EMPOV7L2/rH5n/1BP7sQaYRkbKsP0jaMPBLtlJrgyHHOq6SdfaBREAB7QRDc06a99Gf89dYEHsSExn8UzGaokXGh6l+PBxdWK/5ziF1xsSkAS3RozPH97UlWI8UamBKZzOE0qoDfAzIcizY7gYMTfxClTPdCKVAzyQ3YdAh2pKP3XJYIHtV7B5Ms/qdChrsOHKdAr73xMuES5qI4mW4L3opZCCEER1BYNurvcmEy1/6oY9zIxBAGIsYUsUn8s2h0t0quQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Rw16ruNkRb2gy3e8XgpDjG+f2oDYSsXubQ2VECgPDDs=; b=HoIrJ9eOvBhkDcCzCBOfMNe4c8S/WqekgeOLSjfIIf0fam83rtrqxxS9ncqmPKkWMLF7M4JdljNIpPsBZk01+aHvS/VBhctfYGlUTZrZIavRDSMlp6ys0TsNTcgVzxZUy+VWPWAAdNyTK3gaYywRGnABnSGddM6LtrWZvssF/KcdG7IGW2bzBF7IXSbAdMYelv/j6IjSsDd4m9IEb0Y7E+nXBZb5g1j/DOKCj9Td0VM1q0vCYWlAPSRTNE71gGt+atF2PP7Ex4lPCc2nI4T97meaaavFihCL/BPt4q500ImxqxPrFhtGpwBfnQJWyccR3lsuRoBiBpE1X5AQlp1S2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by MN6PR12MB8544.namprd12.prod.outlook.com (2603:10b6:208:47f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.27; Mon, 18 Sep 2023 13:15:15 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::1390:de0a:6b46:9837]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::1390:de0a:6b46:9837%7]) with mapi id 15.20.6792.026; Mon, 18 Sep 2023 13:15:14 +0000 From: "Nickle Wang via groups.io" To: Mike Maslenkin CC: "devel@edk2.groups.io" , Abner Chang , Igor Kulchytskyy , Nick Ramirez Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller. Thread-Topic: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller. Thread-Index: AQHZvJVuLK1jQQyGZUe59F69qqdQVq/YJ1LQgABGogCASHzoIA== Date: Mon, 18 Sep 2023 13:15:13 +0000 Message-ID: References: <20230722081826.301-1-nicklew@nvidia.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|MN6PR12MB8544:EE_ x-ms-office365-filtering-correlation-id: c53c819e-5158-48ab-3498-08dbb8494aec x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 0Fu62oCJ1+XgKU4j75L5QE1/qSe3kHgN2SknPF79xdTI5+Ncspq6JKwLc5hlyHlhbTpEUwOVNLBrAD5PPU3H1ZXxXvIxtcCxg5au7gA8WOOVYkfuPGZ9QOgkkDddyK6KHKZQuwbPXXPlB20zh70T8+WsvoLLPR5SUlr6uzrer/O2qXn8zKEn8a2oi41BqosJZN0W4q9RtUTVAuWicdzkz27i69TXwtFUwun4MexvHf5oHBfR8kV6Yn0nGGFMryvnRjrPgEYfZEAz42HKFgj6+U4gxnJ4mGk6hyq8qTgyd7UUDVQfyDh4Fc418gE6fJC/Bw/BWh7ZCn+k3dft4AvhRaHBI3JjZmWOHRNogvzCF0JH8LIGfBpOwYyXepxlr321yOollVkxETAgpuH/FxS7FzNAL4FYf1OZeV+/p6Qsx4yIyhAIN/IADp9YDn2mnNp0ae9hrL/rESzvOhgb+Sgfg5uQ+BYwMDZxE8Ltr8OpOh6XfU2C3MQ7NNaxz87w4oWCOBL5vHF589PtDm43Z82CFqKVtesA/t7jy4EnQ/3InfG/knzXdE81vye/VTn62aSi4SBrfK510z2nSjJ9dIuaMNUOLM4b8pzw7wRd2LAywO0= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?v+UsrnIY8nyqnpgreWWDJVGXUvw8BwddRISanf/f9M8O7Y9z5JidDZMdLqbG?= =?us-ascii?Q?hE0ZW2C70Q83Wzq684baBWMhYS3hY+nh41i0957EPMBDWBNwQrXlnsMVc5rf?= =?us-ascii?Q?vAHLr/a5GtgLRiyMyR7GxxU3Ytp6XthBh8Q0oHPkyDxqT+EgQCeF0O2aC7Le?= =?us-ascii?Q?ab7pcZt1zMOJdK1U1IZhti/uK7SYbdqUHNR9uHadAKPWyx0Ya822joxlv5gD?= =?us-ascii?Q?jpiblkgOP82ZgTQWP3+kq9u8s3HLS91gN/Ox3uHcwvWOajdxoaMUXNBREku9?= =?us-ascii?Q?6Vh8spYSK77gj+Ek5yY08TPqklw+0nlKy9NHg6Tu/cOAzuYjDVRun40lrPH5?= =?us-ascii?Q?iLYf3gpz3CBQ3FO6HVYwnbdORjaee7OiuF9XjEGKWxyA3S00w9NPayGxJ2+c?= =?us-ascii?Q?wjoTvzh/jgwrPJxfC3NM+PE5rZyvJzvMRj5I28Et8EECMx4Mm6IxJFpxlYZg?= =?us-ascii?Q?UJe8QyRC0CRXfEChPk14pJgCnPPLBys0Uoymb7+BTPG96CpVqnPoSKCxs8DU?= =?us-ascii?Q?Rv1lVuKkJ2y6JbUbc7TPxqVK/z32skr/2DrBLR/1Bsloyp/KtLZ8jB1/hEyL?= =?us-ascii?Q?2y7QcbYMWPZoE0rhhqdhSzkQ6Xk5FaRrrHimI5fjs2qgen4VudxX4DjXg308?= =?us-ascii?Q?vwQ4RNBy890TmIK+320c1RuAnXOAzBEmA7UDJ90CowIdynfZcQsOYFVZvQrm?= =?us-ascii?Q?BZMapjndXlyJewq8IBTPiwd9Vszf0mMjA4s96v+hEfoHht8FXNkR+lVYeGzg?= =?us-ascii?Q?H1wuK65MlAwUtd/+otim4c4yNkpxTnKSrFBAgepFy0/tTRP7gu6YTuXhQ7Bc?= =?us-ascii?Q?hSujGLVGQMWqtMQmUMUj4LHu076nH1RnlO+h6OB3e1lueUqsuqafc6EcB9HP?= =?us-ascii?Q?09/WwLp7UQkRqnuJ+LCBqG/pIB9GfSMNhy+G73etPsDIpq8BROzbrX+BSFHJ?= =?us-ascii?Q?Va5WApG8fWj7HBH5u8Na3F0O5zMn5u06brPSPs6fxW458BOnDl0VGkoRYq7g?= =?us-ascii?Q?i5E3Jzk+P/3AzdLx4FY+20OtETjHZ19+yTYkjIdkpwZO5BMeLtrMpF9rUA8u?= =?us-ascii?Q?tW60qkAefkLUGbqGDpi09vHPasdRFKIze4u1TOYu2O+Gx5JopP/f5SsFCC5+?= =?us-ascii?Q?A/3e0Dc/g36bLmZyQPOv6YyB3Jr9CNbUgyb4ZQNGFJaMnUbCifyRZbmsmx5J?= =?us-ascii?Q?zC5R27+5W/cOL31JboFM2KpTflGQD+bzvAzEWOXu/8wUOZGOK5Rjp/oxYQRp?= =?us-ascii?Q?XKnsWa4OiW/N1bpFYEjlp2BTmnFiRkNBrqpT0DxWhzw+7+2gZQamdfNr9Zcc?= =?us-ascii?Q?NyopQ17pAuUPZd57BOej176sM7swGHMs45nGe8geIltULawO1/Xr4GAj/zTx?= =?us-ascii?Q?h0PB5l1VaQiEMyquno5nV6TwhRhSuD3azG/9RnrcyC2+PXdjdqxaDARQgeao?= =?us-ascii?Q?quDJdW8RravJwFoY/8HRIwrKcCEntwcn/KCdjomqB7zg27W+wDZQQvLlUPcD?= =?us-ascii?Q?8hAusbKpxKXcPaklV4uUKDFxuh5oRb3utMKtkOkZj27A4Z2ZQ52QpKm/6ikb?= =?us-ascii?Q?ir/oOQBKMnCIhWrHShw=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c53c819e-5158-48ab-3498-08dbb8494aec X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2023 13:15:13.1892 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0tTtVyn6fvDK7nrk4e9dQBSMOLscahx9zYQV5Bwh7IhgEfLd5cRWLJWzHb+Fkg4s3RT+FCR0j+Lw9FB/AHuJzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR12MB8544 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: qFWIxapeMYpwnSv9cvHoVmgux7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="Qp/fyrXP"; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Mike, Sorry for my late response. Version2 is here: https://edk2.groups.io/g/deve= l/message/108778 Please help me to review it while you have chance. Thanks, Nickle > -----Original Message----- > From: Mike Maslenkin > Sent: Thursday, August 3, 2023 6:16 PM > To: Nickle Wang > Cc: devel@edk2.groups.io; Abner Chang ; Igor > Kulchytskyy ; Nick Ramirez > Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTT= P > status code to caller. > > External email: Use caution opening links or attachments > > > Yes. I suggest not to release ResponseMessage->Body > > There is a function RestConfigFreeHttpMessage releasing Message->Body as = well > as Message->Data.Response > https://github.co/ > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L134&data=3D05%7C01%7Cni > cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157 > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DUWjhhvnVOQAF6TwHrjD%2FUxq > zvmKXviZDa%2FW6iyDZyC8%3D&reserved=3D0 > > called from: > https://github.co/ > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L555&data=3D05%7C01%7Cni > cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157 > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3D4KQJiTuPrYeiLHpe0IL5mxTG04n > m5W7nwPSPeE1MNoo%3D&reserved=3D0 > https://github.co/ > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L734&data=3D05%7C01%7Cni > cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157 > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DpPYswuNST%2BrOjNgSbfWVtGSF > G4OV%2BuIiy69Pb1VlxHg%3D&reserved=3D0 > https://github.co/ > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L921&data=3D05%7C01%7Cni > cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157 > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3Dl162YPCSVbXo%2Fz0tyC7WVK1Z > I4rvIEU%2F%2FdX79E8w8mY%3D&reserved=3D0 > https://github.co/ > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L1080&data=3D05%7C01%7Cn > icklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157 > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3Dw%2BsMb1C313iW3mAyd61r%2 > BVKLUkHO5%2BfdROfdT6dkgUU%3D&reserved=3D0 > > So I guess RestConfigFreeHttpMessage() makes a proper resource deallocati= on > otherwise patch introduces a memory leak for error handling path, for exa= mple > here: > https://github.co/ > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FRedfishRestExDxe > %2FRedfishRestExProtocol.c%23L429&data=3D05%7C01%7Cnicklew%40nvidia.com > %7C2da77c0b5cd947e5509808db940ac84a%7C43083d15727340c1b7db39efd9c > cc17a%7C0%7C0%7C638266546261240909%7CUnknown%7CTWFpbGZsb3d8eyJ > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3 > 000%7C%7C%7C&sdata=3Dkh65FknkTo6LcogwQ4fjIPjaFL6Cv6rv%2FtrO2njgxzg%3D > &reserved=3D0 > and > https://github.co/ > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FRedfishRestExDxe > %2FRedfishRestExProtocol.c%23L364&data=3D05%7C01%7Cnicklew%40nvidia.com > %7C2da77c0b5cd947e5509808db940ac84a%7C43083d15727340c1b7db39efd9c > cc17a%7C0%7C0%7C638266546261240909%7CUnknown%7CTWFpbGZsb3d8eyJ > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3 > 000%7C%7C%7C&sdata=3DOa8dIM9YxGdtkM60HiwgpoOqKPT9YaJms%2BE3RIlZd% > 2FE%3D&reserved=3D0 > and so on. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108779): https://edk2.groups.io/g/devel/message/108779 Mute This Topic: https://groups.io/mt/100292372/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-