From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 512F1780091 for ; Fri, 1 Dec 2023 12:18:13 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=kPxct3j44cNvHqDuVTmWsItyi3HdYWa+484apOP7I8w=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701433092; v=1; b=v1KJGhfAtlzL7DnPhzmz3HIDBMuXe5Bm8nc4/xm8cHsyolMraiCsn6MH2+cnH3AkGj4EvK/4 XyM0zwUMK/LIF9MiSQjvf9IV1Dc+FCJV9QMtHrAIC4q3Z9xh1nOeK+Mi1t59qJvJUMd9PeIcKMD +JPY0J+cqC9HZNCS6V8YxBRk= X-Received: by 127.0.0.2 with SMTP id bIDWYY7687511xXMDXstybQT; Fri, 01 Dec 2023 04:18:12 -0800 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.40]) by mx.groups.io with SMTP id smtpd.web10.21369.1701433091020678817 for ; Fri, 01 Dec 2023 04:18:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gRAN+cIRyMP5TTbB9zS10j7k9tvC56Xc/banJnaaMuWBIVV31CoFFWCljjXbHFeOkf1kcSO/yIOOCRj1xAUzHQpk9FlGF9lHMIQGxeATbcFCADSFTmv7WNnBMG1tWMADBjGfX1NkvO1XphZ+64nrw69Fnf2BA532Xl/sbALasb69AyxWVXRaNLvPGHxpoG+/ul9D/mmqKyIWu4pG0dSqMC4BL94A2b38zJEuzuepEPwnGaX4aTgfUTRSQKlsQ591hq8dXgAbUC24pcxi2TTKo/HEQfhq0f9DEf6aEv4Iaw7279IK1DNO8JeOQGVMmjrslrlxH4aFwFdGzGoA26Nw+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xj9Y1rUUz54hgDbPa27bbQyFFVvmJp7bZ3rSnAcJM4o=; b=mnZfn1+3NZOBXq6B+gYdLTexSZ8oh/SphoGXRhhfmsrHP+d9EWZgxU/vLcyRUSlR25PXxqusq32TXorVjZHoR7kdaVw+rXrjKJXpRiZe8WV5ueB88RQWmMkm545cyx7H8snuIZhlC/z51a6gftj2/YcqN94P8pXYvMt2wJShS+WWrIAtg6qWRmmQRqTRkZLKJa9rqvEkYYW4EOrD4JhCvlkcPlQxvqGFief1B8n51oFm1/XE3D4C+dF3hBzdVXQKGhwEcQ8HGuB7nfhy+sgXvnywBZZv9o9vkTMv+jajxQwi6iG+mbWsRF9nT3y15Enifm2VYcin8waZVk2hWitFSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by CYYPR12MB9013.namprd12.prod.outlook.com (2603:10b6:930:c2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.27; Fri, 1 Dec 2023 12:18:07 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::a78e:602e:415c:4cb4]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::a78e:602e:415c:4cb4%3]) with mapi id 15.20.7046.024; Fri, 1 Dec 2023 12:18:07 +0000 From: "Nickle Wang via groups.io" To: "devel@edk2.groups.io" , "Chang, Abner" CC: Igor Kulchytskyy , Mike Maslenkin Subject: Re: [edk2-devel] [PATCH] RedfishPkg/HostInterfaceBmcUsbNic: Set default Redfish service port Thread-Topic: [edk2-devel] [PATCH] RedfishPkg/HostInterfaceBmcUsbNic: Set default Redfish service port Thread-Index: AQHaIbuj1TmeJHlTv06I1Yxo4Kh3XrCUXV9w Date: Fri, 1 Dec 2023 12:18:07 +0000 Message-ID: References: <179BB23CC54A5653.22216@groups.io> In-Reply-To: <179BB23CC54A5653.22216@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|CYYPR12MB9013:EE_ x-ms-office365-filtering-correlation-id: 377d9b95-d632-46d2-942a-08dbf26793ac x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: B6hGtbi8zOAxRcfKHkTBMMUz0GON462g6D9DSzUe5XBkDL0mY0VskE0T1CIS17FLQsTaCCSh+IJjen+Y99v1QMai863kkUEkOmSZLCC8Tkg/iAt/jUQ3hTnocfwYNuvTlrP5DQGxBDeZFo25Jd5j/0pHg4IpAkeTAP9bNdTeKckiInjfw3FXNYL8XEkO5AcRVD70QJx5VYzPHtzIqPyewn1qCS6cbhB5m/ukgDQQUOiuwh6W+nH1XtjcbR1tVxAgJbEvsbAkkgEMHfTK6FiVhMQPcyPLYOBv7K3ygYqCCyuM+gO2lN9LN14l+J59/cyhtU7YhKO1vjo+m9Kxji+hg+GCYjW4vuh7C44iptfoHmXy47sMDZ6sjn1xvw3D+5J7R3/rXsKnfB8P6avUpBhltITyIHKEkqUxlMRYbuJc1B1p+2Ug5X6fD0Wua/GTGMEounFqBLsBmPkedR5+Lf8RwOMBcIZ9OBFP+AEevTJuCjJOZ15jYZsL9hRARQnE1IozgwdXDrkz5OdBTo7TXltq2dusy4Xn71rXdbZk7tWdAQy9BUd3aek7FbKI0Dqm2FEF/CONGFjf/M3pUKPBNfjTfW1GBdYBgY2xbLIewhdubKYLFbBMMwQV95z+DTw4C/FX5Xp4pGv/oLaIkoq9WpVepfSDZ08b/IJT+lwDbi3GLRw= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5/D/eOuY0XO7cp8LTuhR5w/5Z88Uibah4uO2R+Kl8sp+jZ9ewr77a8GXtMee?= =?us-ascii?Q?aqMu1ZlGbEL4KzVXUFamIAx3XQRdpEOK9MX3iokycbGZFmxTSCeG6fk/3lxw?= =?us-ascii?Q?keLRHcizrIEfzgwcZMyjyClaN0f+jh8OuD6BPFGM4I9OM3MmMU8fsbh7YcjJ?= =?us-ascii?Q?/B3XjySJmSQQUamAlJnBh35UWXIpBQRwgMp5Wa7DF9KiNLCOEFb5l3xDrPHy?= =?us-ascii?Q?JON/8jxxF1dflhipUETQW84CcDKymTF9yYktE5pfL3UIjaO4w4kfjMZK0glD?= =?us-ascii?Q?uhRxWJKhiA4Z+OSDVzJnNw2XI1hu5msysbXS9IIFcqKGb3vZ83Z6m9daz1Hj?= =?us-ascii?Q?2Y3g3sGRcrgJAB5+DKaRC/LJMsMgJkyX8pj2IoGOLT7StbAsRAC8ntzkRLzt?= =?us-ascii?Q?oQCc+aUTZ4AFa600ERcOQtd795tRA/FshJ8oQWtHwQJGz9+mFpvwkkcluozI?= =?us-ascii?Q?Ey8LWxxWtvK6IS/jck1zkzhWTEQYMWJSK5CUulCfqMKJA2vdSt+llDxAaZNS?= =?us-ascii?Q?cDww+1KN0owGrdrA8DwkUhereomizxbYeXpnHp6koGJqGioffFmESgnTp/Sx?= =?us-ascii?Q?ud0eZ2zn9ov5f9EzwwsoqWnuo4dXSXXaZbE5tIE7CD934l+Jt/nfU6066tiT?= =?us-ascii?Q?zJxR9Alp66jQrVCvbTEhha+gPAfnOAfXs9HPkVTz60GC/z5ph88m3J0kyhNM?= =?us-ascii?Q?J4vLjaVMpgKPkJ2BNjRmC1HRLSHaxjnW7CIR00fU34JDX6UmNRNN1giGzkRO?= =?us-ascii?Q?Sa29JASWut/Y5ho0BVTK78pfUrHguHkqC07iS3OI9D9Am5SAsiAjP50D3r0W?= =?us-ascii?Q?iR0sWhp6uyx1zRbl4He1lXPvMsGH1gaD6SZIFLIWus08ee7SKjZAhK6pvIrj?= =?us-ascii?Q?F1+SnTPtdJfAMuR8LIG+qkeVmpInLy1Gi0DYeosUfcgTL91x3xretMV4ILvv?= =?us-ascii?Q?XkbCSbZE3HgNCXzkhRbVkPPo/ibvWqrZuJgf9GlXIltq2c+miuY5l+07M9C9?= =?us-ascii?Q?L2JhfFOM8Z8oUtV6F0n/IGynyxEmiV1Cbu5Ku5398+O17tz4haHmlma7ZkE6?= =?us-ascii?Q?zL4E2SQGFihzQUtJT0deFypH0iAbJ3BwxzrZn8n1Vq1EI6vwfkWItS/Jl4uy?= =?us-ascii?Q?fNEl41o0BGBItyk9Onlbe+W+5W4cRyh0l1xoxPlWRFpzIP3bD2nSN7cDO6i7?= =?us-ascii?Q?4eco4f07Lsn83FWoEBcaKd07iINGGkw/AMpVzn6dpOXKNlBHhvaLt6vC8COY?= =?us-ascii?Q?Ozddm7QjaAltkK5AFa7dFxyTPanjeKY4Wau0isagK4xn6yBwc9ujyhoaH5Mv?= =?us-ascii?Q?cDrz+jloy/td3OYER4gd+SeQypBMW/mt1n8fw02UCJ3U8d9nc+408J+b7Ujo?= =?us-ascii?Q?vjfP+kzzZ3EHGBaV+0HSljKwYnDrRVqdVrpq1vFw7qx5caJ1HUaaLpD5Igkf?= =?us-ascii?Q?p35v1UlzyWgNixiMefpxyDdizbF7rfTUFbeI0+XOxdSpR2+41dGb3L/LAlXU?= =?us-ascii?Q?UUpDcCXADGk7y4Py/MQDpF1UyoNtBkmAsYNvy5kLJG/gAs+7ySqCuVfWSdtf?= =?us-ascii?Q?GF+F9X7ToMeqmd33z3L/8e9oyuKuHNr3hi8iaNJUlwPp5zv+CXcerRFzsXiE?= =?us-ascii?Q?XgGoKfx1FeRN3UJ1gUz3ZxL80hXJMHJulWGtBlQqStFO?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 377d9b95-d632-46d2-942a-08dbf26793ac X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2023 12:18:07.5801 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hw8RjOuVnYB9nPOzcJugTjfN0P91oa1RiNvrn1dPSrMLThcnoYtg36sggER57oEOhWV/M6b0VC7l7PPM4ypebA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB9013 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: sIyd3f4v1EZnsLByK75OCC23x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=v1KJGhfA; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chang, Abn= er > via groups.io > Sent: Tuesday, November 28, 2023 1:26 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy ; > Mike Maslenkin > Subject: [edk2-devel] [PATCH] RedfishPkg/HostInterfaceBmcUsbNic: Set defa= ult > Redfish service port >=20 > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. >=20 >=20 > From: Abner Chang >=20 > BZ #4607 > Create a PCD for the default Redfish service port. >=20 > Signed-off-by: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Cc: Mike Maslenkin > --- > RedfishPkg/RedfishPkg.dec | 8 ++++++-- > .../PlatformHostInterfaceBmcUsbNicLib.inf | 1 + > .../PlatformHostInterfaceBmcUsbNicLib.c | 2 +- > 3 files changed, 8 insertions(+), 3 deletions(-) >=20 > diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec > index e40538247c2..3ea9ff3ef7f 100644 > --- a/RedfishPkg/RedfishPkg.dec > +++ b/RedfishPkg/RedfishPkg.dec > @@ -141,12 +141,16 @@ > # specification for that. > # > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishServiceUuid|L"00000000-0000- > 0000-0000-000000000000"|VOID*|0x00001006 > + # Use PCD to declare the Redfish service port, default set to port 443= . > + # Platform can overide this value in platform DSC file. > + # > + > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishServicePort|443|UINT16|0x00001007 > # > # This PCD indicates that if BMC bootstrap credential service will be = disabled by > BIOS or not. > # > - > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishDisableBootstrapCredentialService|= FA > LSE|BOOLEAN|0x00001007 > + > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishDisableBootstrapCredentialService|= FA > LSE|BOOLEAN|0x00001008 > # > # The EFI_REST_EX_HTTP_CONFIG_DATA.SendReceiveTimeout value that > RedfishDiscoverDxe driver > # set to EFI_REST_EX_PROTOCOL. > # > - > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishSendReceiveTimeout|5000|UINT32|0 > x00001008 > + > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishSendReceiveTimeout|5000|UINT32|0 > x00001009 > diff --git > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterf= ac > eBmcUsbNicLib.inf > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterf= ac > eBmcUsbNicLib.inf > index f2c7d7fec89..838a1721a7a 100644 > --- > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterf= ac > eBmcUsbNicLib.inf > +++ > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterf= ac > eBmcUsbNicLib.inf > @@ -43,6 +43,7 @@ > [Pcd] > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishHostName ## CONSUMED > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishServiceUuid ## CONSUMED > + gEfiRedfishPkgTokenSpaceGuid.PcdRedfishServicePort ## CONSUMED >=20 > [Depex] > gIpmiProtocolGuid > diff --git > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterf= ac > eBmcUsbNicLib.c > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterf= ac > eBmcUsbNicLib.c > index 2938d54da65..7f295fe7f1c 100644 > --- > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterf= ac > eBmcUsbNicLib.c > +++ > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterf= ac > eBmcUsbNicLib.c > @@ -244,7 +244,7 @@ RedfishPlatformHostInterfaceProtocolData ( > ); >=20 > // RedfishServiceIpPort > - RedfishOverIpData->RedfishServiceIpPort =3D 0; > + RedfishOverIpData->RedfishServiceIpPort =3D PcdGet16 > (PcdRedfishServicePort); >=20 > // RedfishServiceVlanId > RedfishOverIpData->RedfishServiceVlanId =3D ThisInstance->VLanId; > -- > 2.37.1.windows.1 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111981): https://edk2.groups.io/g/devel/message/111981 Mute This Topic: https://groups.io/mt/102845949/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-