Re: [edk2-platforms][PATCH] ManageabilityPkg/IpmiCommandLib: Add IpmiCommandLib to package

["Nickle Wang" <nicklew@nvidia.com>]

Reviewed-by: Nickle Wang <nicklew@nvidia.com>

Regards,
Nickle

> -----Original Message-----
> From: abner.chang@amd.com <abner.chang@amd.com>
> Sent: Friday, May 5, 2023 1:24 PM
> To: devel@edk2.groups.io
> Cc: Isaac Oram <isaac.w.oram@intel.com>; Abdul Lateef Attar
> <abdattar@amd.com>; Nickle Wang <nicklew@nvidia.com>; Tinh Nguyen
> <tinhnguyen@os.amperecomputing.com>
> Subject: [edk2-platforms][PATCH] ManageabilityPkg/IpmiCommandLib: Add
> IpmiCommandLib to package
> 
> External email: Use caution opening links or attachments
> 
> 
> From: Abner Chang <abner.chang@amd.com>
> 
> BZ #: 4444
> Add IpmiCommandLib to ManageabilityPkg package.
> 
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Abdul Lateef Attar <abdattar@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
> ---
>  Features/ManageabilityPkg/ManageabilityPkg.dec      | 4 ++++
>  Features/ManageabilityPkg/Include/Manageability.dsc | 1 +
>  Features/ManageabilityPkg/ManageabilityPkg.dsc      | 1 +
>  3 files changed, 6 insertions(+)
> 
> diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec
> b/Features/ManageabilityPkg/ManageabilityPkg.dec
> index 6f58ab4f45..38813c5f48 100644
> --- a/Features/ManageabilityPkg/ManageabilityPkg.dec
> +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec
> @@ -18,6 +18,10 @@
>    Include
> 
>  [LibraryClasses]
> +  ##  @libraryclass IPMI command library
> +  #   Provide the help functions to send IPMI commands.
> +  IpmiCommandLib|Include/Library/IpmiCommandLib.h
> +
>    ##  @libraryclass Manageability Transport Library
>    #   Manageability Transport Library definitions
>    ManageabilityTransportLib|Include/Library/ManageabilityTransportLib.h
> diff --git a/Features/ManageabilityPkg/Include/Manageability.dsc
> b/Features/ManageabilityPkg/Include/Manageability.dsc
> index 5e7cdb885f..a432b0ff26 100644
> --- a/Features/ManageabilityPkg/Include/Manageability.dsc
> +++ b/Features/ManageabilityPkg/Include/Manageability.dsc
> @@ -7,6 +7,7 @@
>  ##
>  [LibraryClasses]
> 
> ManageabilityTransportHelperLib|ManageabilityPkg/Library/BaseManageability
> TransportHelperLib/BaseManageabilityTransportHelper.inf
> +
> IpmiCommandLib|ManageabilityPkg/Library/IpmiCommandLib/IpmiCommandLi
> b.inf
> 
>  [LibraryClasses.common.DXE_DRIVER]
> 
> PldmProtocolLib|ManageabilityPkg/Library/PldmProtocolLibrary/Dxe/PldmProt
> ocolLib.inf
> diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dsc
> b/Features/ManageabilityPkg/ManageabilityPkg.dsc
> index a0712d1c0a..e3baf27f2a 100644
> --- a/Features/ManageabilityPkg/ManageabilityPkg.dsc
> +++ b/Features/ManageabilityPkg/ManageabilityPkg.dsc
> @@ -49,6 +49,7 @@
> 
> ManageabilityPkg/Library/ManageabilityTransportKcsLib/Dxe/DxeManageability
> TransportKcs.inf
> 
> ManageabilityPkg/Library/ManageabilityTransportMctpLib/Dxe/DxeManageabili
> tyTransportMctp.inf
>    ManageabilityPkg/Library/PldmProtocolLibrary/Dxe/PldmProtocolLib.inf
> +  ManageabilityPkg/Library/IpmiCommandLib/IpmiCommandLib.inf
> 
>  [LibraryClasses]
> 
> ManageabilityTransportLib|ManageabilityPkg/Library/BaseManageabilityTransp
> ortNullLib/BaseManageabilityTransportNull.inf
> --
> 2.37.1.windows.1