From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 23B7DAC0E8D for ; Mon, 4 Dec 2023 07:19:40 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=4YFkkh4jl/xsJZ3vEI32LVfu5TLRaH1M+EmrV94/yrQ=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701674379; v=1; b=eBcUcDBhyU1bFKXRW5OsoClroxo1znbqSWkTvZeahhEWUeSaxbkW9zXUIC/pnVdWu71Dsj9u eWjGD6+V4zUZJxWZpXDcZco3j2LhmAj8ReB4Unra/bhCYXgE9KWHWN2cx5u6JDXqoz2D6eogXIU cyty0GMlH3ZxBiAynxvqC9kE= X-Received: by 127.0.0.2 with SMTP id OhNVYY7687511xdtpoqKo93p; Sun, 03 Dec 2023 23:19:39 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.66]) by mx.groups.io with SMTP id smtpd.web11.63707.1701674378954954348 for ; Sun, 03 Dec 2023 23:19:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SUotpH5A5pFdQJAHUcX0+iXtYTH68qxMlvi8Lb4IiwbeyJjvFw7B+oFHhbiwsSht0fnllABZT3nZLt+d1aMBwh1cjy41cLzqdP6iXyaXWswMKXlWcR3saHw+v+RF/Ikiq5zbYRK9acnmDRO4X9xAfK4UblbkTsDum3+xmF2LPNKM/47DCThVl111yrDpRci5TPpJ0NVfIEp9T8KEpvpEcaCQVZPMuprV/tnX7TCEPtMOi/vTDGbxd7z9tyPH+xAaK0kEpgTdWQQgMTMD09ICIOhUARuyDAuNpF+Xu0Gy9Ajb4F212F7Y1J8KhJhT/y63Pm4jBEqtYIdijcl/do/gcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=smCv2lDQWjv+Pj2iersR70+8gv8RY96uBwN8dJL5YFs=; b=M4kOHk3vjnuh0VOLje5v2AHr9tbX8msY9WEJsvZHm/fp33Y5V2HlK5RDC7xkT972KXD7kw9ORUZaL69T2KM+ryA5rxA3itDNdhZJ0WkTrbXGlTfwcQoETX+X5oa0sQqTRW3EjoF7s2P+u42duU3sNyKwNrI1Nm/uaTr2SoV/jl61CXDq0oisizEaVWYvH2t1TNlgdgoeRfNiAjYkwCO0cu3vNHJcgnM/Bym8pw7XMr5kG1VUMs8f14iPcodVNRfB3nRWZn4KJixetwJjxEwIT36+6sZAJ4iUvLdhpIarl/2y8ElkEjR4Sy/NYR86PxSz8G4oFffFzG1ganp0oAEFNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by PH7PR12MB5688.namprd12.prod.outlook.com (2603:10b6:510:130::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.33; Mon, 4 Dec 2023 07:19:35 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::a78e:602e:415c:4cb4]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::a78e:602e:415c:4cb4%3]) with mapi id 15.20.7046.033; Mon, 4 Dec 2023 07:19:35 +0000 From: "Nickle Wang via groups.io" To: "abner.chang@amd.com" , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Mike Maslenkin Subject: Re: [edk2-devel] [PATCH V3 8/9] RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect HI protocol record size Thread-Topic: [PATCH V3 8/9] RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect HI protocol record size Thread-Index: AQHaIPMHabc3yHcFhky7BTI8En7HCrCYwo1g Date: Mon, 4 Dec 2023 07:19:35 +0000 Message-ID: References: <20231127053107.1686-1-abner.chang@amd.com> <20231127053107.1686-9-abner.chang@amd.com> In-Reply-To: <20231127053107.1686-9-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|PH7PR12MB5688:EE_ x-ms-office365-filtering-correlation-id: 5cb39334-c608-4713-ee2e-08dbf4995e7a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 1J9VysFsKFzgsA9tOmuBGgbHY/iASDfmNkabjR0zXOLOQkKH8a0Tf+Gk7PWlHhXmJ4U+IDlxSFn8SC5bd5z0y/WF8maaaGhjy1YRIHnV3qmFaXlOnzyKHBmbaI5q9B3Lgq9icCrFPPn17x8567bKzIGCO/8iL5bdAnOp7AWMEHhrXpxsyeaUvJmZ3oJ49Xcy7aQTJG4cq7volJj8u8n/97OBG0qGA9/ZpIJNP5QzFvZ615mRMwJcHz9CztFrk1Om4JX2hfbGp0FP5aYvB2drINRp/qVjKs1Cih7d1OjQv4WaIE7CzdvTbBxXEexNi3EzVgAAvcYsG0az2psVqufH/4mK8QMJUuM/BLDOK3c3CTcMcCL86zldicsJOjzCP4QC3DOMu7+duWZ/mJyWXp4fephdp6YCxaf7rZDTzWcPCEOPfQ09+K7RDE32k2GG7LMDTCQD971K1BKHvMkXpDvsgmiCxx8/2n5gPXmnaFHFnHWSFauasGkt0okzEgGJkCSq9duj6NjCdJjchbqOR51B04/ObwV8Leu8BplNIY6e/2+ie1MXwonmpncFfrCqP6JAyce/TWy5Z0Q8tRnQgpldhIl/gNd0znbhPxTpBxXWIdpkQ0UfLyqhTrFh4mcdwseymC2uy+VyBwOGfUJk7ELHsaTef3rXPg8rdQJjH+6KCPHQT+DcV0/JLU3hrCGpatgZ x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?l5hNnIJrue3yYZx+J4Z3wSfw0vVaedTrmckcJkBacWkbBqvInQeUe5mhvGzz?= =?us-ascii?Q?AoYR63MQRpkoWr9R+WTBEOFtdTD9g3mR7yunrAaQJfHx+l5paoN7LhdHpVqq?= =?us-ascii?Q?qtAI5vc4TrDQcGhnIenPXYPEPpmBsV6yf+egfH50IVyd8bO1qawCy2h5B6VN?= =?us-ascii?Q?wW2hON4ZXkG1KDkM5r3aHvyii8xuyHTjiTM57bvrL9BbJJwemLerA7XGeYHQ?= =?us-ascii?Q?0CtcdqUyhe0F6zU9Q6GBu+Twhg9MdY7zpMKhc94pVBy+1pSnJftKlf/5gBqm?= =?us-ascii?Q?8m226Vpv5sf/YlukRx1xKKsjkmTOwdcdUcppweZV5iC9oWdTUPhjUDzgygsf?= =?us-ascii?Q?YQ8+ivTQP5c73XfMpZvDAQ0bnneS1zMG2soyN2Kp1I4DJRwI46PN9FSR08YJ?= =?us-ascii?Q?yJRM334AOsKbj6wH/6zz2sBX4wk51n/52pDZIQ51DgpwqRD+jnsCBBoVaKs8?= =?us-ascii?Q?bd8nm/JYRjDQUKG4KnWcU/ytY21J1MNfsBdsc15Cudw8vw0CnS4wFJw7QIfh?= =?us-ascii?Q?aaQpS/addQuGtLHE6QQRjz5eBV9LIBrvdy3w+Xu3H1wYUnnZ7mLRf8qw9LZh?= =?us-ascii?Q?Tr48mEJDH4m+EfJPPNxjyKqWBo4cLAnNUL5O5+Z3Z7+Xc6o0+AkgF8gDxmev?= =?us-ascii?Q?h1hesUOsr8O6PBh/PNZnchais/DcUtEMjnSsa5fV1cmsAIYi04w57PkeMLVQ?= =?us-ascii?Q?/O7WZ91xP9Q9DOv/1+xL07Gr5SYsBnBYDubkfR8wnGwB3YOh/0NBRjono9n4?= =?us-ascii?Q?OOwLExm5UT0GXqVzyBKaIimjHVO4wkJ+htDH9SsDyGUx+L2LfbOYRUHn5viP?= =?us-ascii?Q?ufwIRz1SewwG/Ui/lEIU7431WpntDAv2trjwqtwW8ooyT5kmFyO70GlccGX1?= =?us-ascii?Q?Xb2mB+ZnyqK57sU7jbSfvTvekA5HYwt0dwzbFRciHFqb56Ortp1fGvgj7FiX?= =?us-ascii?Q?wUjRBc86R5ZF+ouz2Be09AxCVV6xIx2X54oElvtIkQ4S3pK3zPBqZTWIHQTT?= =?us-ascii?Q?4osJSQd5BS1siXrbmaTcE/MIWxgRfhjLfxI/zj7xXqYu5UUoRH0rl8dKxiD6?= =?us-ascii?Q?FyfbrVqQZtuW/ygbzb9MttB7fWGUNkMzkGMZmNZFmNA3FW+LOko99k8w8OrQ?= =?us-ascii?Q?iCX8QdgVvGuzMQeRZ3Xi5pQKnGhKl6ayzyXjNo27Du2BKi1mK3EU/4C8F7Jo?= =?us-ascii?Q?eUyKCM3UMAx9ASJIak7wC3Wt6ozBNeDBBj+NV6sr0NEsY0XFROyY/HG2leu4?= =?us-ascii?Q?isrZhBJpc828RH6GmRPzbXytg/TGCatktVGBJSck0sxkXxf9moZJ/TuyOzWI?= =?us-ascii?Q?gPQFj1xIF2cv1BJ+0lRVoHmUOV8KZM65HtXzTHlv45WRf9qnxWMTXB0rYt+g?= =?us-ascii?Q?GfzskrYRhpSY4+7ENAfh0Gh1ohYTAKozC2TTcWX6bkyoF0vkQHe4VHOI8c0e?= =?us-ascii?Q?2Icqdp2sHzugtrkdJ48BL2VE1iuhXtJmGmm5QTw+m7uZshvIfBTDZBdpiZfT?= =?us-ascii?Q?gebuD35HRlmBo7cWMa5tjNQgIW0/CgKReIYq+8GPhLmFsVeiVFZbTyt3uX+h?= =?us-ascii?Q?t959m6Ef3Lg7ghe+IfCbRZLVS+N3zUT9HIYuEChHODrGWmfVlsGruDNXHQqc?= =?us-ascii?Q?zKl2/56AybQrXySBup4SssZWi0VuFjyfoOquj040v3r8?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5cb39334-c608-4713-ee2e-08dbf4995e7a X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Dec 2023 07:19:35.5154 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vcz82+71qDIz30ULDWSvREkhnPwnehsZwcK4pm2sygQlv2P8hAUWbVj4qQsBGn9qIlo0bnDNrwiWZ8Enaal3og== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5688 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: P5hvTGK2Ufm4SuNX5dxHnlRix7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=eBcUcDBh; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: abner.chang@amd.com > Sent: Monday, November 27, 2023 1:31 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy ; > Mike Maslenkin > Subject: [PATCH V3 8/9] RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect = HI > protocol record size >=20 > External email: Use caution opening links or attachments >=20 >=20 > From: Abner Chang >=20 > The size of structure must be minus with byte that is occupied by the ini= tial array. >=20 > Signed-off-by: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Cc: Mike Maslenkin > --- > .../PlatformHostInterfaceBmcUsbNicLib.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterf= ac > eBmcUsbNicLib.c > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterf= ac > eBmcUsbNicLib.c > index c4a71226e63..a1ce2dd3d93 100644 > --- > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterf= ac > eBmcUsbNicLib.c > +++ b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostI > +++ nterfaceBmcUsbNicLib.c > @@ -180,7 +180,7 @@ RedfishPlatformHostInterfaceProtocolData ( > HostNameLength =3D (UINT8)AsciiStrSize (HostNameString); > ThisProtocolRecord =3D (MC_HOST_INTERFACE_PROTOCOL_RECORD > *)AllocateZeroPool ( > sizeof > (MC_HOST_INTERFACE_PROTOCOL_RECORD) - 1 + > - sizeof > (REDFISH_OVER_IP_PROTOCOL_DATA) + > + > + sizeof (REDFISH_OVER_IP_PROTOCOL_DATA) - 1 + > HostNa= meLength > ); > if (ThisProtocolRecord =3D=3D NULL) { @@ -189,7 +189,7 @@ > RedfishPlatformHostInterfaceProtocolData ( > } >=20 > ThisProtocolRecord->ProtocolType =3D > MCHostInterfaceProtocolTypeRedfishOverIP; > - ThisProtocolRecord->ProtocolTypeDataLen =3D sizeof > (REDFISH_OVER_IP_PROTOCOL_DATA) + HostNameLength; > + ThisProtocolRecord->ProtocolTypeDataLen =3D sizeof > + (REDFISH_OVER_IP_PROTOCOL_DATA) -1 + HostNameLength; > RedfishOverIpData =3D (REDFISH_OVER_IP_PROTO= COL_DATA > *)&ThisProtocolRecord->ProtocolTypeData[0]; > // > // Fill up REDFISH_OVER_IP_PROTOCOL_DATA > -- > 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112015): https://edk2.groups.io/g/devel/message/112015 Mute This Topic: https://groups.io/mt/102824325/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-