From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E102A94145D for ; Wed, 21 Feb 2024 07:30:35 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=NSEogk96EwMrBfJGNU7E/5cVAqQnsvOgD8x/IKgTH5w=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708500634; v=1; b=Hfo2TV0TT122t5tGLNLiY3u+D4FDVfamF7BvRDTlSh6iFzh0MSidlHBhxHUakIEGe3PHiXNI p10RtvfSBe+C+tVGgyY4HmNuuQNY50u9EKY+jfXknqqKu8pU1hPJf8VpEVvEwGUEIT4YbopyQSG I+itKIScfsl0moerNqVBUn8g= X-Received: by 127.0.0.2 with SMTP id RUJUYY7687511xQAMJjX1mOX; Tue, 20 Feb 2024 23:30:34 -0800 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.51]) by mx.groups.io with SMTP id smtpd.web11.8093.1708500633885373156 for ; Tue, 20 Feb 2024 23:30:34 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U/za1/sjNHsfvJ04DZHANm5/NrcPqwaehdulH+00VKoCueG5f8ssYTW7/TL8GfAJ4jOIF/wECBw92FGUAOCtS1V7I46hdFc8I1UCUXECb3K0v9hr2QB44YWSXaRPS0rdN5V6C8e7k60I7Vn6ekBLQyGgTPxjr8iWeq5uI5uf8vl4XQcr9TayHtq/D1UuNpJyGHuhriYz3tn9WswfYTE/kWA9BsKRh4ixfCZda84zqugwb28Bv4HHf6KzBpg0QMpBfSz0BDaK+e8OhzzYZrq5kLbv1Sg+lueh7LklKHpEYeIH+mREf67StSeTgDWRkqKCqwwHzVFQZQIWMYvA+lCEFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C3SH7jsPH9QMosNrk6Rdht0clDMtdCVeVC5I+XAcg74=; b=P3GASiJXsQhu4eGDtSeMQJgIOja2QAA1ceMBRt1Ar5yVqoLyt2M5MNXHk8Srj2oEwwSBoBIjDCCCHRwNRvffNGw9qO4LE+/40/uWOxGumP4Y7dU95xs80MlNcRLqt8z5y2cbxx7HON5/cc+6M2+r7Rf1Hpsh31QG3/QMnq/f805ZGGf0QBQw+uaE3ct1iR8EviQ7tYTL/f/2tJLtk8ARSNdTu8QzFFDh61gI6tOm+xef4VKXRwGbPgWk1SX1BQEG5znNM++8kU70I+IYuf47a5yMrvZOY+KlCRvzymrG2mhYEvdXY03INrF9SC27s0BC0L0VPISFDsBk8ApyARBrsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by PH7PR12MB9150.namprd12.prod.outlook.com (2603:10b6:510:2eb::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.20; Wed, 21 Feb 2024 07:30:30 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::aa79:3ab0:fbcd:d61b]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::aa79:3ab0:fbcd:d61b%5]) with mapi id 15.20.7316.018; Wed, 21 Feb 2024 07:30:30 +0000 From: "Nickle Wang via groups.io" To: "devel@edk2.groups.io" , "mike.maslenkin@gmail.com" CC: Abner Chang , Igor Kulchytskyy Subject: Re: [edk2-devel] [PATCH 3/4] RedfishClientPkg/Bios: fix leak of GetPendingSettings URI. Thread-Topic: [edk2-devel] [PATCH 3/4] RedfishClientPkg/Bios: fix leak of GetPendingSettings URI. Thread-Index: AQHaZFrHXsvKa7dNAUeM/6f+D9ecyLEUZvXg Date: Wed, 21 Feb 2024 07:30:30 +0000 Message-ID: References: <20240221001303.57384-1-mike.maslenkin@gmail.com> <20240221001303.57384-4-mike.maslenkin@gmail.com> In-Reply-To: <20240221001303.57384-4-mike.maslenkin@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|PH7PR12MB9150:EE_ x-ms-office365-filtering-correlation-id: 0b74a00b-02ae-445e-74a8-08dc32aefb9f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 3ftqzqad2zKqSXtVf5yuOmxIucMXr/BkK26inCKmyN9mFlX1un102r03sOmtycqyySk9dKiDSRSDI36KRSXJltWx9+x090i+RsBQ9+KlwHulbekMUBY+pdi40PTtemR6vK7kuPruP4UQ4cM+1gIfSimmEu8dr+NNQbXobMn9o8EA9KXpw/Ly6tmXUD+TMnHGzBRZGd9UrxGD8FVL2tyb1s8Pkgzg/FyZppT2RAJp0XyMy/Ht4jF6/WqikSeIbPlUzj+Fz/TRmU18Y3S7ByH4AMm7THhFZGOw5lBiQT+sI0V3FCFjnYT/l6wr/S8QZDts17UE/0YBoGhrqYNxzWZI2IvcwVYoxe3W3V5jUuVwYsNry4NVpUbnCaWIE3wOkjRfSPHxvZ8OEvQjLT5cHWy0PbHKwQX+JvtURveyfNolnaD5y6NSheLOyZN5+JOEXKidrLUcYYVHs8NDdeURog92gz2YKV+/MFI7VG32AXWb8cDO3utwNU3SZEPLUu86duFqyq9hT5M7+akn6E18FLqLPDS+XCWqLIh2/Upy2y+nG10ijYewu/JtqW6lf4UiO4hkN7dWH1HTy9Oalom9jwrAhTzkHavg2wnm9PXD/p4YR9w= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?c6AE8DRE4RrxVp0+tczITwKEAZUpyC5jT4qGIEJw0mPUZQYwzfHZWGLLiNk5?= =?us-ascii?Q?QAdxH6bixGvxYH2VuP2WBy1gz0Kby+8Lon3uB7NWeY2/J3hKYmC1/IVEvTd4?= =?us-ascii?Q?ocJPaaT7dGu9Lczgtoc3YWYdo8n4JcDLyT5X8ltu4UHHwPtymFCdeV3DWeXS?= =?us-ascii?Q?b73cIaVzG5F1CJJLbilPr/I8bMFsmpOgx6Tnb6iVoxHPsd5rRr7bnkPCiNXF?= =?us-ascii?Q?6uQ8R9dj+6m5P8XD9TMTEmNFOtCj4FLIM4auDBVXIwABOKubeGASfOQ87zZo?= =?us-ascii?Q?IbC6uwam/HtNVW4JG/wmncrPp2Pm7862EYEopMgWHModBy/BkjYwekKgIvR9?= =?us-ascii?Q?IxpaZxD8wT5fwkwWwjRU2Y1YwllUhZVvlfAY4fkxms7/NfKtPJl60cKDtGkz?= =?us-ascii?Q?BHOK3HzdSW+/US+QrM/fvTwzs7U0JqEVSSb29rFxnn15lkzSgCBBxh8Lqrel?= =?us-ascii?Q?VbcYtQOYddhAXyMXP7ySe5vcoT6gG1ba6HW8EdogDpTHbnh0/gbMGoqGWpqj?= =?us-ascii?Q?SmqCZvuEuiRQ7eHx4Hf43emv6x8IeRM51BG1qCi2adKOGp1MjW71vPy2U/FD?= =?us-ascii?Q?ARMcVEYfZ4VGGk1vVJ+8D6VWomOJM8HtNyPYxAe6IUp7fr9DVzVJuED1Nc6w?= =?us-ascii?Q?x7B6V+xrAND3X8oanvT5vNNvNvfnbsTKaE2rIqRfeMM5tbYfDkEII5IuBv4J?= =?us-ascii?Q?yGpl/dRPtxZ6ZLyO3ZRy7WTrdO/L9qpfoFz2uXEaMtLC3hOx4rS43F3GN2hq?= =?us-ascii?Q?WaNeTbpeWQ2ScoD7HYJ/PrvhR3F4JxEWTEQz0pxvaTh3zrzOlmAek9qCteUM?= =?us-ascii?Q?pLbYUd1sX4XZ4XoTjvjQzR7Giqf46/0uXNnrJV/1Q5z1I4SdGdI7X3CRejDj?= =?us-ascii?Q?aKkVktkBfnb56HoK+S+QJufKRLO62mbo2euJ5xtxGW8H7k3NhDLSZLU2ljPS?= =?us-ascii?Q?IBeJ7XPA4rx1l7u6MF8XQE+PM0pDX9YQmiDsSJuSY7HlA54Ygzn6wXMoArH6?= =?us-ascii?Q?QPB2DztqsPX4hLqyrT+ghEIqDWY9elrWd9plvzX+fc8bNhOPdYLgToz7faDt?= =?us-ascii?Q?n+1iz9qHEcKZZyCkLMUcHI//yBor0DwCLAKryNQBTw6DEh5Qri8cWOKMI8uA?= =?us-ascii?Q?MOU7bYdCXhKAPgKoKFLeryNpbw2byfGoK/Q5PosvvaTCu/NBho3zImt7I6Gc?= =?us-ascii?Q?DsJwTxHeXurEat8ccbRBjdD44zpdcvX3YbYLsOgcvHOX8mmolSRp2uQ3KKji?= =?us-ascii?Q?Mh3p4WlXjDLTr+5DvbgVUDvXVxohW8u3cuqxv+746loJGsFoM9m2mjMHWOkT?= =?us-ascii?Q?ipbVM1FoSl+U7JrTJ7wYKgVK/lSCfYX+zAPpVMKpcNQ+CvXOCzg0Nh32eL/n?= =?us-ascii?Q?F8EH0Oc2OyrppniYIulsKQqsU8VhX5QAMTjjWp0ITymIiBU4+fr0G5YVdNZP?= =?us-ascii?Q?Z9NpvSpAe8imNXLdClp9hkh1C8VeD6871JCaRyjLntqEYynvE4pnUX4sWHe4?= =?us-ascii?Q?ef9FmMtKfzPWbPKlg2o2he0ygJgmt03n5f+qjRAw5yMOi5iDNSMmEMCi9RHg?= =?us-ascii?Q?Vlykq6dIGQc/Yc3XD8g=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b74a00b-02ae-445e-74a8-08dc32aefb9f X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2024 07:30:30.6635 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RnZKdnsoH5l14L2rrt+7EfPgfl3FsyZ4Up8DUpfXRyey8yt4tcZ9hDY6oxbTErhjuMfgkVUuwsMPjk5rlyJ0hQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9150 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 2efcEAFNhbUP7wLW0SAuN7KSx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Hfo2TV0T; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Mike > Maslenkin via groups.io > Sent: Wednesday, February 21, 2024 8:13 AM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Abner Chang > ; Nickle Wang ; Igor Kulchytskyy > > Subject: [edk2-devel] [PATCH 3/4] RedfishClientPkg/Bios: fix leak of > GetPendingSettings URI. >=20 > External email: Use caution opening links or attachments >=20 >=20 > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Mike Maslenkin > --- > RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > index 396ec22969b5..8548425c9c83 100644 > --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > @@ -132,6 +132,7 @@ RedfishResourceConsumeResource ( > // Check and see if "@Redfish.Settings" exist or not. >=20 > // >=20 > ZeroMem (&PendingSettingResponse, sizeof (REDFISH_RESPONSE)); >=20 > + PendingSettingUri =3D NULL; >=20 > Status =3D GetPendingSettings ( >=20 > Private->RedfishService, >=20 > Response.Payload, >=20 > @@ -206,6 +207,10 @@ RedfishResourceConsumeResource ( > FreePool (Etag); >=20 > } >=20 >=20 >=20 > + if (PendingSettingUri !=3D NULL) { >=20 > + FreePool (PendingSettingUri); >=20 > + } >=20 > + >=20 > return Status; >=20 > } >=20 >=20 >=20 > -- > 2.32.0 (Apple Git-132) >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#115687): https://edk2.groups.io/g/devel/message/11568= 7 > Mute This Topic: https://groups.io/mt/104479573/7129762 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [nicklew@nvidia.com] -= =3D-=3D- > =3D-=3D-=3D-=3D >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115717): https://edk2.groups.io/g/devel/message/115717 Mute This Topic: https://groups.io/mt/104479573/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-