public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nickle Wang via groups.io" <nicklew=nvidia.com@groups.io>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"abner.chang@amd.com" <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>, Nick Ramirez <nramirez@nvidia.com>
Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 0/3] introduce Redfish Resource Config2 protocol.
Date: Tue, 5 Mar 2024 03:22:42 +0000	[thread overview]
Message-ID: <MW4PR12MB7031EB82AE23226FFCD477E1D9222@MW4PR12MB7031.namprd12.prod.outlook.com> (raw)
In-Reply-To: <LV8PR12MB94521001E3F03843B831E0A4EA222@LV8PR12MB9452.namprd12.prod.outlook.com>

Hi Abner,

Per offline discussion, Redfish collection driver may use query parameter "expand" to get members data all together. And then Redfish collection driver can send these data to non-collection driver. Non-collection driver does not need to get data from BMC again and this saves time of communication between BIOS and BMC. This is very helpful when we are working on Redfish Boot Options collection, which may contains many boot options on system.

Regards,
Nickle

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang, Abner
> via groups.io
> Sent: Tuesday, March 5, 2024 10:27 AM
> To: Nickle Wang <nicklew@nvidia.com>; devel@edk2.groups.io
> Cc: Igor Kulchytskyy <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
> Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 0/3] introduce Redfish
> Resource Config2 protocol.
> 
> External email: Use caution opening links or attachments
> 
> 
> [AMD Official Use Only - General]
> 
> Hi Nickle,
> May I know what is the scenario on edk2 Redfish driver stack to use Resource
> Config2 protocol?
> 
> Thanks
> Abner
> 
> > -----Original Message-----
> > From: Nickle Wang <nicklew@nvidia.com>
> > Sent: Monday, March 4, 2024 9:27 PM
> > To: devel@edk2.groups.io
> > Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> > <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
> > Subject: [edk2-redfish-client][PATCH 0/3] introduce Redfish Resource
> > Config2 protocol.
> >
> > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> >
> >
> > Introduce EDKII Redfish Resource Config2 Protocol so that caller can
> > pass Redfish data to callee when caller uses "expand" query parameter
> > to get multiple Redfish resources all together. Then, callee does not
> > get Redfish resource from Redfish service again and save the
> > communication effort between BIOS and Redfish service.
> >
> > EdkIIRedfishConfigLib is updated to select Redfish Resource Config2
> > Protocol as first priority. If there is no Config2 protocol supported,
> > library will use config protocol automatically.
> >
> > Pull request is created:
> > https://github.com/tianocore/edk2-redfish-client/pull/80
> >
> > Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> > Cc: Abner Chang <abner.chang@amd.com>
> > Cc: Igor Kulchytskyy <igork@ami.com>
> > Cc: Nick Ramirez <nramirez@nvidia.com>
> >
> > Nickle Wang (3):
> >   RedfishClientPkg: introduce Redfish resource config2 protocol.
> >   RedfishClientPkg/Edk2RedfishResourceConfigLib: support config2
> >     protocol
> >   RedfishClientPkg/Features: support config2 protocol
> >
> >  RedfishClientPkg/RedfishClientPkg.dec         |   2 +
> >  .../EdkIIRedfishResourceConfigLib.inf         |   4 +-
> >  .../Library/EdkIIRedfishResourceConfigLib.h   |  33 +-
> >  .../EdkIIRedfishResourceConfig2Protocol.h     | 148 +++++++
> >  .../EdkIIRedfishResourceConfigInternal.h      |  44 ++
> >  .../Features/Bios/v1_0_9/Common/BiosCommon.c  |  14 +-
> >  .../BootOptionCollectionDxe.c                 |  14 +-
> >  .../ComputerSystemCollectionDxe.c             |  16 +-
> >  .../MemoryCollectionDxe/MemoryCollectionDxe.c |  16 +-
> >  .../EdkIIRedfishResourceConfigLib.c           | 391 ++++++++++++++----
> >  10 files changed, 565 insertions(+), 117 deletions(-)  create mode
> > 100644
> > RedfishClientPkg/Include/Protocol/EdkIIRedfishResourceConfig2Protocol.
> > h
> >  create mode 100644
> > RedfishClientPkg/Library/EdkIIRedfishResourceConfigLib/EdkIIRedfishRes
> > ourc
> > eConfigInternal.h
> >
> > --
> > 2.34.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116351): https://edk2.groups.io/g/devel/message/116351
Mute This Topic: https://groups.io/mt/104721505/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-03-05  3:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-04 13:26 [edk2-devel] [edk2-redfish-client][PATCH 0/3] introduce Redfish Resource Config2 protocol Nickle Wang via groups.io
2024-03-05  2:26 ` Chang, Abner via groups.io
2024-03-05  3:22   ` Nickle Wang via groups.io [this message]
2024-03-05  6:31     ` Chang, Abner via groups.io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW4PR12MB7031EB82AE23226FFCD477E1D9222@MW4PR12MB7031.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox