From: "Nickle Wang via groups.io" <nicklew=nvidia.com@groups.io>
To: "abner.chang@amd.com" <abner.chang@amd.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Igor Kulchytskyy <igork@ami.com>,
Mike Maslenkin <mike.maslenkin@gmail.com>
Subject: Re: [edk2-devel] [PATCH V3 2/9] RedfishPkg/RedfishHostInterfaceDxe: Add Redfish HI readiness notification
Date: Mon, 4 Dec 2023 07:16:18 +0000 [thread overview]
Message-ID: <MW4PR12MB7031F22D7D2A8B41A4CE0715D986A@MW4PR12MB7031.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20231127053107.1686-3-abner.chang@amd.com>
Reviewed-by: Nickle Wang <nicklew@nvidia.com>
Regards,
Nickle
> -----Original Message-----
> From: abner.chang@amd.com <abner.chang@amd.com>
> Sent: Monday, November 27, 2023 1:31 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>;
> Mike Maslenkin <mike.maslenkin@gmail.com>
> Subject: [PATCH V3 2/9] RedfishPkg/RedfishHostInterfaceDxe: Add Redfish HI
> readiness notification
>
> External email: Use caution opening links or attachments
>
>
> From: Abner Chang <abner.chang@amd.com>
>
> Introduce gEdkIIRedfishHostInterfaceReadyProtocolGuid
> and produce it when Redfish Host Interface is installed on system.
>
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: Mike Maslenkin <mike.maslenkin@gmail.com>
> ---
> RedfishPkg/RedfishPkg.dec | 3 +++
> .../RedfishHostInterfaceDxe.inf | 3 ++-
> .../RedfishHostInterfaceDxe.c | 18 ++++++++++++++++++
> 3 files changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec index
> 0f18865cea0..e40538247c2 100644
> --- a/RedfishPkg/RedfishPkg.dec
> +++ b/RedfishPkg/RedfishPkg.dec
> @@ -90,6 +90,9 @@
> ## Include/Protocol/EdkIIRedfishPlatformConfig.h
> gEdkIIRedfishPlatformConfigProtocolGuid = { 0X4D94A7C7, 0X4CE4, 0X4A84,
> { 0X88, 0XC1, 0X33, 0X0C, 0XD4, 0XA3, 0X47, 0X67 } }
>
> + # Redfish Host Interface ready notification protocol
> + gEdkIIRedfishHostInterfaceReadyProtocolGuid = { 0xC3F6D062, 0x3D38,
> + 0x4EA4, { 0x92, 0xB1, 0xE8, 0xF8, 0x02, 0x27, 0x63, 0xDF } }
> +
> [Guids]
> gEfiRedfishPkgTokenSpaceGuid = { 0x4fdbccb7, 0xe829, 0x4b4c, { 0x88, 0x87,
> 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }}
>
> diff --git a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.inf
> b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.inf
> index 1cdae149aad..f969e75463f 100644
> --- a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.inf
> +++ b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.inf
> @@ -43,7 +43,8 @@
> UefiLib
>
> [Protocols]
> - gEfiSmbiosProtocolGuid ## TO_START
> + gEfiSmbiosProtocolGuid ## TO_START
> + gEdkIIRedfishHostInterfaceReadyProtocolGuid ## PRODUCED
>
> [Depex]
> gEfiSmbiosProtocolGuid
> diff --git a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c
> b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c
> index 55a66decfc8..02d5f14bd20 100644
> --- a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c
> +++ b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c
> @@ -53,7 +53,9 @@ RedfishCreateSmbiosTable42 (
> SMBIOS_TABLE_TYPE42 *Type42Record;
> EFI_SMBIOS_PROTOCOL *Smbios;
> EFI_SMBIOS_HANDLE MemArrayMappedAddrSmbiosHandle;
> + EFI_HANDLE Handle;
>
> + Handle = NULL;
> //
> // Get platform Redfish host interface device type descriptor data.
> //
> @@ -226,6 +228,22 @@ RedfishCreateSmbiosTable42 (
> goto ON_EXIT;
> }
>
> + //
> + // Install Redfish Host Interface ready protocol.
> + //
> + Status = gBS->InstallProtocolInterface (
> + &Handle,
> + &gEdkIIRedfishHostInterfaceReadyProtocolGuid,
> + EFI_NATIVE_INTERFACE,
> + (VOID *)NULL
> + );
> + if (EFI_ERROR (Status)) {
> + DEBUG ((DEBUG_ERROR, "Failed to install
> gEdkIIRedfishHostInterfaceReadyProtocolGuid.\n"));
> + DEBUG ((DEBUG_ERROR, "PlatformConfigHandler driver may not be
> + triggered to acquire Redfish service.\n")); }
> +
> + // Set Status to EFI_SUCCESS that indicates SMBIOS 42 record was
> + installed // on the platform sucessfully.
> Status = EFI_SUCCESS;
>
> ON_EXIT:
> --
> 2.37.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112008): https://edk2.groups.io/g/devel/message/112008
Mute This Topic: https://groups.io/mt/102824317/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-12-04 7:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 5:30 [edk2-devel] [PATCH V3 0/9] Refine BMC USB NIC discovery and Redfish service enablement Chang, Abner via groups.io
2023-11-27 5:30 ` [edk2-devel] [PATCH V3 1/9] RedfishPkg/BmcUsbNicLib: Update BMC USB NIC searching algorithm Chang, Abner via groups.io
2023-12-01 23:27 ` Igor Kulchytskyy via groups.io
2023-11-27 5:31 ` [edk2-devel] [PATCH V3 2/9] RedfishPkg/RedfishHostInterfaceDxe: Add Redfish HI readiness notification Chang, Abner via groups.io
2023-12-04 7:16 ` Nickle Wang via groups.io [this message]
2023-11-27 5:31 ` [edk2-devel] [PATCH V3 3/9] RedfishPkg/RedfishConfigHandler: Use " Chang, Abner via groups.io
2023-12-04 7:17 ` Nickle Wang via groups.io
2023-11-27 5:31 ` [edk2-devel] [PATCH V3 4/9] RedfishPkg/RedfishConfigHandler: Correct the prototype of callback function Chang, Abner via groups.io
2023-12-04 7:17 ` Nickle Wang via groups.io
2023-11-27 5:31 ` [edk2-devel] [PATCH V3 5/9] RedfishPkg/RedfishDiscovery: Add more debug message Chang, Abner via groups.io
2023-12-04 7:18 ` Nickle Wang via groups.io
2023-11-27 5:31 ` [edk2-devel] [PATCH V3 6/9] RedfishPkg/RedfishDiscovery: Refine SMBIOS 42h code Chang, Abner via groups.io
2023-12-04 7:18 ` Nickle Wang via groups.io
2023-11-27 5:31 ` [edk2-devel] [PATCH V3 7/9] RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect reference of MAC address pointer Chang, Abner via groups.io
2023-12-04 7:19 ` Nickle Wang via groups.io
2023-11-27 5:31 ` [edk2-devel] [PATCH V3 8/9] RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect HI protocol record size Chang, Abner via groups.io
2023-12-04 7:19 ` Nickle Wang via groups.io
2023-11-27 5:31 ` [edk2-devel] [PATCH V3 9/9] RedfishPkg/HostInterfaceBmcUsbNic: Fix potential memory corruption issue Chang, Abner via groups.io
2023-12-04 7:20 ` Nickle Wang via groups.io
[not found] ` <179B63DFD0330B10.32091@groups.io>
2023-12-04 7:14 ` [edk2-devel] [PATCH V3 1/9] RedfishPkg/BmcUsbNicLib: Update BMC USB NIC searching algorithm Nickle Wang via groups.io
2023-12-04 7:18 ` [edk2-devel] [PATCH V3 0/9] Refine BMC USB NIC discovery and Redfish service enablement Mike Maslenkin
2023-12-04 9:08 ` Chang, Abner via groups.io
2023-12-04 10:59 ` Mike Maslenkin
2023-12-05 1:49 ` Chang, Abner via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR12MB7031F22D7D2A8B41A4CE0715D986A@MW4PR12MB7031.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox