From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6C57ED81163 for ; Tue, 16 Jan 2024 06:20:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=9ITGsqx2/spSwpIFBAV3vUafOEkjxbxEB9Ck3yNajGY=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705386007; v=1; b=iPAtsIQfvLqZ09Og2b86xJimVnCgvi5nTKitQkwecnDbQgxoxgC0rIePMKSv4DxEhLG3FBq6 D4DQDeco2ROURQjiYBAgd6c6jjPnGHOhxfj9a54TgxvuRZH/CBdTHGNiZVNgwHAVaOqAkhIRYqM RZpJmlhMbqMcT5qykIr2C4EY= X-Received: by 127.0.0.2 with SMTP id XsqmYY7687511xTNukUnCKQ9; Mon, 15 Jan 2024 22:20:07 -0800 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.42]) by mx.groups.io with SMTP id smtpd.web11.6441.1705386006324642524 for ; Mon, 15 Jan 2024 22:20:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WIx6F+CGMXuW6i1FOVAN4UKIeFdqNy4rBcFmRaZz+pXIQIT7FTSYFqWVh1vu+1s2e3N6Lk+klfjVeoh9tcKo9jJBmb3Y0gvigAUkJLck1wMlT47tveVw21n27n1HFqkLL2WqorZ6P3Bdy/2OBvqVCLRhZJouKOng0Y0BrmClFEcd89etPEe7nNqu+4lRigiJ/ExkdZDEsD4ZpGZGD7baa4ENVwDCWcqksSWe1XykzMAAZh44w8mDY9ttlyfic4pwHdBfVQi5sZqd2MQTjyWKSklaovR0uwV3Pxomvtjio+ZcmUVrPdObm2H3TQUnHLJskiyreEHrQZLyd/m3gxVoPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MahidDbQbaJWPsoeJKM4NFFhVdCcHTslbCFHjluipTc=; b=DY+mjdAtLdJ2Xm2WZhAV+snWqxcMjqrUuJujcg7fThIFJ/G0JFvHbYyV1HY+79iWcLR/3BJzb4VNeTOSccezcBOeWbJZb+5KSATCkyIZj8EfBSb3yp0fsRhqTrhHCKaFWQBVGj8YFGO9ECU//v1Qpm8C5moTqAk+wjX+0CuH6f88ITqvwcKfq0Dk12Ns2LoktKRIx2jvY+dYel07ozF3GLWlgMgJnZg10+wZ4soWWKEc/yKQXPodyXNVzDmQgtSWAEMnZQSLa1NH52+Z3gXno0H/q8OrrwohPSzdZGrbjTNFuDJ8Aunc67TtT5m66ELkqQ9/CpIS8sDLiVEl/OyukA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by IA1PR12MB7688.namprd12.prod.outlook.com (2603:10b6:208:420::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.23; Tue, 16 Jan 2024 06:20:03 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::a78e:602e:415c:4cb4]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::a78e:602e:415c:4cb4%3]) with mapi id 15.20.7181.020; Tue, 16 Jan 2024 06:20:02 +0000 From: "Nickle Wang via groups.io" To: "Chang, Abner" , "devel@edk2.groups.io" CC: Igor Kulchytskyy Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: Function to remove Redfish unchangeable properties Thread-Topic: [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: Function to remove Redfish unchangeable properties Thread-Index: AQHaRQc4HTeiDNjzZUSd1KJIVDmyR7DbylvggAAN14CAACV+MA== Date: Tue, 16 Jan 2024 06:20:02 +0000 Message-ID: References: <20240112032622.274-1-abner.chang@amd.com> <20240112032622.274-3-abner.chang@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=12749c01-9a2d-4b55-9ca2-fb359cfe09c7;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-01-16T04:04:39Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|IA1PR12MB7688:EE_ x-ms-office365-filtering-correlation-id: d6d554cf-89d2-47a4-4a31-08dc165b2cd1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: pf7UvpAiYqr+i/Bk4uqt7fiqe1ozf8OIqK5ZO/SYAsjpuIwaMSGyM4WvUwHaSzRqJ1BvaQVOAqUh3W/0Bcq0+0jEts0zMCYvaPUXKdj9Yhr5FBvycjCjEswQ4AnYmo0KYi9fN2uSDuuccPOvylCV1fi5SSbn9oHlwyEMCbIGpIwQ22TlemW0Qa2QLn09eGTYXKwUXjQFxE8TvtjaqjEV6WK2bngNTsYIjFdWe8gmG6fgqzfANBnmqjLUJK44kQgUxK/sQi2DKAUgMyXRao1T/fL5lbWhTm2VY4DOqud8JfrGHYkeOhdJCfnmJ9yqemZKq5C6fCHXokttSuawCyjeVr5+fE68pYMxeqSX5xoduYhkvcPk5QBtKTZwnybS+KmSJDKwgh1U3ZJFtAQag6jJB2ooRf/bNU/RVyjdKqJ1o6AjVLV1UV3j5tjRsA1iLUPRqlOJDXgPalWlLPALNy0VxUJz3RRQWyipTM0b9mRufNjUKRHsAtORRd2SThLoyTHwF8NRoV3IOLZPogg8EIwDE0jjelAUHcmHcC4/8CnfsrjDXWw3Y8WMJhIyvCTPH2OESLb2A0iUXbaJNyV7sKm8JOlSTp5bnATxwgpli6ynrC8bVbo6cTHNHNxe8tOd5bIL7UJUqIbvXDgIY73sO7RxLzYbmsi1tn/TuRuQPZFgNLA= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NxOu6b+i6j4suOt1HwuakfhQGA6DiENnsIb5dpDDXKuil2tGWkFI8s+tKu0I?= =?us-ascii?Q?2bVmjIQRMOGTz5g3NuzIY5e4h6q3GDfK0AHsy/sPHmrju0zkbIZnFUYDdNfb?= =?us-ascii?Q?tBQ5E5L2TU2pGvN65NszSllMmas6shskIB7DVI46MAr/lwm28ESVysgyAruy?= =?us-ascii?Q?9jUvoisCADMpnN9pzaBFrDxht8qI9Cip3nhmMdJ3Pfk0gBQTuJXC+wHPZ5KO?= =?us-ascii?Q?vHWMrUpfWbcyaMrEVswS5nct9MQu04MQZt8KWVmEOUhiJ+SVBPFpQltAcGjf?= =?us-ascii?Q?GKa+4V2r4+2D587jKDGjIEpOTKwDu6AcXEinSvrGtN7HQw8W6ZVmePlas9lz?= =?us-ascii?Q?e3JD6glM1ekZO7kObkFheWXEKk5Z2zKZYbKBxvz+YrMagz5ut2vXcLM92UpZ?= =?us-ascii?Q?+EKp27X83QQ6Xou+kPLb4QTgM+ihoET6Dmfr7b1tEm/G5lotK6rmBgNjs1YC?= =?us-ascii?Q?UOSV+lREbIpVt6TDRUPkUhqpszzr3ZPqn/naCNFJyDFpyTCBDJWmDuwqvBVF?= =?us-ascii?Q?Mb/zHlOsQZVFmGbbke6wpMrmT8SEIm+obqbxbm2x1KaKMVR2Llf9gIs7eK9C?= =?us-ascii?Q?LKwImlERbRBPB06VAb9RTPLLvFSgI6DN/8jyHqYMxMGFMLwmM7oqs3Gz4Ld9?= =?us-ascii?Q?pyHJ/Ci+YGjaBj73yeBcWwJvehK0edSk8SAWvQ3EBXopTY5Oy1X8+8i3XDEZ?= =?us-ascii?Q?lhmqpA2RfCg/d48R9f64BCfLtrq70ZgxWaft5gGZ4sDXIXL/1Cwub2+TDqgS?= =?us-ascii?Q?Q/xk4g1VMdxzLeUluBVAITEX7UyI4GsrGryBOHlMoZ8IOZdLI/axM+Qfjt5t?= =?us-ascii?Q?xifYuORwKUECQraUbXV9MmVPuGgV1tNuK8DXFAniY8qzUQa35y4EO4KIzOcC?= =?us-ascii?Q?D1q6+3tbVaPDdLonq+eHXLkSGI6aBu49Xe2ulk9ZHAJY4CvVt+y8ImZNHpyj?= =?us-ascii?Q?i2VCn9AV5hf/QzHVE0GJcW6VaZVyOQL2Vb6kq8vMHzxeTUCPZfwLZZIdjrs9?= =?us-ascii?Q?1DJ2d7Y76OzMa4Z70j/ReJUXcHvm/S1/QFv9IIi7UQ5lIaNxBhnlnOmTI1ZA?= =?us-ascii?Q?B2Fxtc3/Txm5K/ewVkSJdvEQ6+g/q9T1dTBC8WhH4odTmJppSRRchBEgsQ79?= =?us-ascii?Q?KDCsLCYHRLyNglMPJP+fqTNVdWdIwro4veai3RFVO7VIMELj0g46frPKUvPO?= =?us-ascii?Q?44SGNfJ6U5GJcXgXCJYQ/V0Hk9+a184dZrHsLxP9bzAHNW3/RNBDalnK9LSG?= =?us-ascii?Q?tfFvl2Ug2pOeHu51UL9uZUwCesBg7z9PXg3Qt5al+3tZkQ0ugQYoRBD4oZQ2?= =?us-ascii?Q?4zoyd1wHecgSN5+3cQGrEdEfGl1tuusjwSAqRSyeA3J2sX98oqfui6vAiE/F?= =?us-ascii?Q?G+7kSR7IfjKamubcJWc0umtnyGWNeHgUFAbBX/sX/L209AAD9S9znypprBrh?= =?us-ascii?Q?jXbm244AIyk6mCKm7XcewWYvuuPwo6UPcnu9yPLHvzR47Vft1fuK2ndmQUG1?= =?us-ascii?Q?e5+GPxdDxNova9+5I7HpTzCcBsUdeshwnhZi0RqKPd97nv4cZlfM+almc9Io?= =?us-ascii?Q?35I00IhFY+fB2Qvirt0X5UlvLl2vMhvyCf1IYC2yfCEAkga+s2u24Zh8+w/V?= =?us-ascii?Q?SkgAGIqkk78VcHjFTo17Apj9ysnRPYVw+9UVFYvjmmoi?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6d554cf-89d2-47a4-4a31-08dc165b2cd1 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2024 06:20:02.8912 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eXVM/R4o3hqY/7TLOIv8SVnNq6v17LJ+cfGHDK/JucFUmLW0dG5kUrrqA5x4yv4g2qwxw1blPzk4Sqfeyomr4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7688 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: bA8F8ryU31mTACzUEKUQLlFDx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=iPAtsIQf; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") > I didn't choose ReadOnly is because at BIOS perspective as a provider, we= still > update the read only property defined in schema such as BootOptions. Thus= I > thought to use ReadOnly is not quite accurate. How do you think? I see. Thanks for your explanation. Please fix the typos and keep the funct= ion name untouched. Regards, Nickle > -----Original Message----- > From: Chang, Abner > Sent: Tuesday, January 16, 2024 12:08 PM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Igor Kulchytskyy > Subject: RE: [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterL= ib: > Function to remove Redfish unchangeable properties >=20 > External email: Use caution opening links or attachments >=20 >=20 > [AMD Official Use Only - General] >=20 > > -----Original Message----- > > From: Nickle Wang > > Sent: Tuesday, January 16, 2024 11:18 AM > > To: Chang, Abner ; devel@edk2.groups.io > > Cc: Igor Kulchytskyy > > Subject: RE: [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/Converte= rLib: > > Function to remove Redfish unchangeable properties > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > I found typos. Please see below. > > > > Regards, > > Nickle > > > > > -----Original Message----- > > > From: abner.chang@amd.com > > > Sent: Friday, January 12, 2024 11:26 AM > > > To: devel@edk2.groups.io > > > Cc: Nickle Wang ; Igor Kulchytskyy > > > > > > Subject: [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterL= ib: > > > Function to remove Redfish unchangeable properties > > > > > > External email: Use caution opening links or attachments > > > > > > > > > From: Abner Chang > > > > > > Update RedfishCsCommon.c to add a function to remove Redfish > > unchangeable > > > properties. > > > > > > Signed-off-by: Abner Chang > > > Cc: Nickle Wang > > > Cc: Igor Kulchytskyy > > > --- > > > .../ConverterLib/include/RedfishCsCommon.h | 20 +++++++ > > > .../ConverterLib/src/RedfishCsCommon.c | 55 +++++++++++++++++= ++ > > > 2 files changed, 75 insertions(+) > > > > > > diff --git a/RedfishClientPkg/ConverterLib/include/RedfishCsCommon.h > > > b/RedfishClientPkg/ConverterLib/include/RedfishCsCommon.h > > > index e454ab0b73..f5278015aa 100644 > > > --- a/RedfishClientPkg/ConverterLib/include/RedfishCsCommon.h > > > +++ b/RedfishClientPkg/ConverterLib/include/RedfishCsCommon.h > > > @@ -104,6 +104,26 @@ DestoryCsMemory ( > > > RedfishCS_void *rootCs > > > ); > > > > > > +/** > > > + This function removes the unchangeable Redfish properties from > > > +JSON raw text > > > + The content in JsonString is left unmodified, the caller has to > > > +give enoungh > > > + memory pointed by NewJsonBuffer in the size of BufferSize. > > > + > > > + JsonString Input JSON raw string > > > + NewJsonBuffer Pointer to memory for the updated JSON raw string i= n > > > + size of BuufferSize. > > > + BuufferSize The buffer size of NewJsonBuffer > > > + > > > + Return RedfishCS_status. > > > + > > > +**/ > > > +RedfishCS_status > > > +RemoveUnchangeableProperties ( > > > + RedfishCS_char *JsonString, > > > + RedfishCS_char *NewJsonBuffer, > > > + RedfishCS_uint32 BuufferSize > > > + ); > > > > BufferSize. You have double 'u' above. And how about to use ReadOnly > > instead of "Unchangeable"? > Thanks for catching the typo. >=20 > I didn't choose ReadOnly is because at BIOS perspective as a provider, we= still > update the read only property defined in schema such as BootOptions. Thus= I > thought to use ReadOnly is not quite accurate. How do you think? >=20 > Abner >=20 > > > > > > > + > > > typedef struct _RedfishCS_char_Array RedfishCS_char_Array; > > > typedef struct _RedfishCS_int64_Array RedfishCS_int64_Array; > > > typedef struct _RedfishCS_bool_Array RedfishCS_bool_Array; > > > diff --git a/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c > > > b/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c > > > index fd31e5296b..c6996d7d5d 100644 > > > --- a/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c > > > +++ b/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c > > > @@ -1461,3 +1461,58 @@ CsEmptyPropLinkToJson ( > > > > > > return RedfishCS_status_success; > > > } > > > + > > > +/** > > > + This function removes the unchangeable Redfish properties from > > > +JSON raw text > > > + The content in JsonString is left unmodified, the caller has to > > > +give enoungh > > > + memory pointed by NewJsonBuffer in the size of BufferSize. > > > + > > > + JsonString Input JSON raw string > > > + NewJsonBuffer Pointer to memory for the updated JSON raw string i= n > > > + size of BuufferSize. > > > + BuufferSize The buffer size of NewJsonBuffer > > > + > > > + Return RedfishCS_status. > > > + > > > +**/ > > > +RedfishCS_status > > > +RemoveUnchangeableProperties ( > > > + RedfishCS_char *JsonString, > > > + RedfishCS_char *NewJsonBuffer, > > > + RedfishCS_uint32 BuufferSize > > > + ) > > > > > > BufferSize. You have double 'u' above. > > > > > > > +{ > > > + json_t *JsonObj; > > > + RedfishCS_char *TempChar; > > > + RedfishCS_status Status; > > > + > > > + if ((JsonString =3D=3D NULL) || (NewJsonBuffer =3D=3D NULL)) { > > > + return RedfishCS_status_invalid_parameter; > > > + } > > > + > > > + JsonObj =3D json_loads (JsonString, 0, NULL); if (JsonObj =3D=3D = NULL) { > > > + return RedfishCS_status_unknown_error; } > > > + > > > + json_object_del (JsonObj, "@odata.type"); json_object_del > > > + (JsonObj, "@odata.id"); json_object_del (JsonObj, "Id"); > > > + json_object_del (JsonObj, "Name"); > > > + > > > + TempChar =3D json_dumps ((json_t *)JsonObj, JSON_INDENT (2)); > > > + if (TempChar !=3D NULL) { > > > + if ((strlen (TempChar) + 1) > BuufferSize) { > > > + Status =3D RedfishCS_status_insufficient_memory; > > > + } else { > > > + memcpy (NewJsonBuffer, TempChar, strlen (TempChar) + 1); > > > + free (TempChar); > > > + Status =3D RedfishCS_status_success; > > > + } > > > + } else { > > > + Status =3D RedfishCS_status_unknown_error; > > > + } > > > + json_decref(JsonObj); > > > + return Status; > > > +} > > > + > > > -- > > > 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113865): https://edk2.groups.io/g/devel/message/113865 Mute This Topic: https://groups.io/mt/103676920/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-