From: "Nickle Wang via groups.io" <nicklew=nvidia.com@groups.io>
To: "abner.chang@amd.com" <abner.chang@amd.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Igor Kulchytskyy <igork@ami.com>
Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH V5 2/2] RedfishClientPkg/FeatureDriver: Use SetRedfishSettingsObjectsUri
Date: Tue, 26 Mar 2024 12:13:48 +0000 [thread overview]
Message-ID: <MW4PR12MB7031F77D82FDB6C2ADA46C50D9352@MW4PR12MB7031.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20240322144124.1671-2-abner.chang@amd.com>
Reviewed-by: Nickle Wang <nicklew@nvidia.com>
Regards,
Nickle
> -----Original Message-----
> From: abner.chang@amd.com <abner.chang@amd.com>
> Sent: Friday, March 22, 2024 10:41 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
> Subject: [edk2-redfish-client][PATCH V5 2/2] RedfishClientPkg/FeatureDriver:
> Use SetRedfishSettingsObjectsUri
>
> External email: Use caution opening links or attachments
>
>
> From: Abner Chang <abner.chang@amd.com>
>
> Use SetRedfishSettingsObjectsUri to set the config language for SettingsObject
> URI.
>
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Co-authored-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> ---
> RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 1 +
> RedfishClientPkg/Features/BootOption/v1_0_4/Dxe/BootOptionDxe.c | 1 +
> .../Features/ComputerSystem/v1_13_0/Dxe/ComputerSystemDxe.c | 1 +
> .../Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDxe.c | 1 +
> RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c | 1 +
> 5 files changed, 5 insertions(+)
>
> diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
> b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
> index 1ca920640a..bb64ef8625 100644
> --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
> +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
> @@ -141,6 +141,7 @@ RedfishResourceConsumeResource (
> );
> if (!EFI_ERROR (Status)) {
> DEBUG ((REDFISH_DEBUG_TRACE, "%a: @Redfish.Settings found: %s\n",
> __func__, PendingSettingUri));
> + SetRedfishSettingsObjectsUri (Private->Uri, PendingSettingUri);
> Private->Uri = PendingSettingUri;
> ExpectedResponse = &PendingSettingResponse;
> } else {
> diff --git a/RedfishClientPkg/Features/BootOption/v1_0_4/Dxe/BootOptionDxe.c
> b/RedfishClientPkg/Features/BootOption/v1_0_4/Dxe/BootOptionDxe.c
> index 7501c1a975..5a66fe59e0 100644
> --- a/RedfishClientPkg/Features/BootOption/v1_0_4/Dxe/BootOptionDxe.c
> +++ b/RedfishClientPkg/Features/BootOption/v1_0_4/Dxe/BootOptionDxe.c
> @@ -130,6 +130,7 @@ RedfishResourceConsumeResource (
> );
> if (!EFI_ERROR (Status)) {
> DEBUG ((REDFISH_BOOT_OPTION_DEBUG_TRACE, "%a: @Redfish.Settings
> found: %s\n", __func__, PendingSettingUri));
> + SetRedfishSettingsObjectsUri (Private->Uri, PendingSettingUri);
> Private->Uri = PendingSettingUri;
> ExpectedResponse = &PendingSettingResponse;
> } else {
> diff --git
> a/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Dxe/ComputerSystemD
> xe.c
> b/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Dxe/ComputerSystemD
> xe.c
> index 1235760a18..a0c71212b3 100644
> ---
> a/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Dxe/ComputerSystemD
> xe.c
> +++ b/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Dxe/ComputerSyste
> +++ mDxe.c
> @@ -133,6 +133,7 @@ RedfishResourceConsumeResource (
> );
> if (!EFI_ERROR (Status)) {
> DEBUG ((REDFISH_DEBUG_TRACE, "%a: @Redfish.Settings found: %s\n",
> __func__, PendingSettingUri));
> + SetRedfishSettingsObjectsUri (Private->Uri, PendingSettingUri);
> Private->Uri = PendingSettingUri;
> ExpectedResponse = &PendingSettingResponse;
> } else {
> diff --git
> a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDx
> e.c
> b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDx
> e.c
> index 5207362dac..494bf59dfc 100644
> ---
> a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDx
> e.c
> +++
> b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystem
> +++ Dxe.c
> @@ -134,6 +134,7 @@ RedfishResourceConsumeResource (
> );
> if (!EFI_ERROR (Status)) {
> DEBUG ((REDFISH_DEBUG_TRACE, "%a: @Redfish.Settings found: %s\n",
> __func__, PendingSettingUri));
> + SetRedfishSettingsObjectsUri (Private->Uri, PendingSettingUri);
> Private->Uri = PendingSettingUri;
> ExpectedResponse = &PendingSettingResponse;
> } else {
> diff --git a/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c
> b/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c
> index c4a363cdf5..f2c0a7735b 100644
> --- a/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c
> +++ b/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c
> @@ -134,6 +134,7 @@ RedfishResourceConsumeResource (
> );
> if (!EFI_ERROR (Status)) {
> DEBUG ((REDFISH_DEBUG_TRACE, "%a: @Redfish.Settings found: %s\n",
> __func__, PendingSettingUri));
> + SetRedfishSettingsObjectsUri (Private->Uri, PendingSettingUri);
> Private->Uri = PendingSettingUri;
> ExpectedResponse = &PendingSettingResponse;
> } else {
> --
> 2.37.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117113): https://edk2.groups.io/g/devel/message/117113
Mute This Topic: https://groups.io/mt/105086470/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-03-26 12:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 14:41 [edk2-devel] [edk2-redfish-client][PATCH V5 1/2] RedfishClientPkg: Set SettingsObject URI as the config language Chang, Abner via groups.io
2024-03-22 14:41 ` [edk2-devel] [edk2-redfish-client][PATCH V5 2/2] RedfishClientPkg/FeatureDriver: Use SetRedfishSettingsObjectsUri Chang, Abner via groups.io
2024-03-26 12:13 ` Nickle Wang via groups.io [this message]
2024-03-26 12:13 ` [edk2-devel] [edk2-redfish-client][PATCH V5 1/2] RedfishClientPkg: Set SettingsObject URI as the config language Nickle Wang via groups.io
2024-03-28 6:54 ` Chang, Abner via groups.io
[not found] ` <17C0DB2F6517C591.6770@groups.io>
2024-04-01 1:23 ` Chang, Abner via groups.io
2024-04-01 9:25 ` Mike Maslenkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR12MB7031F77D82FDB6C2ADA46C50D9352@MW4PR12MB7031.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox