From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A9F1BD81164 for ; Tue, 26 Mar 2024 12:13:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=dVixjS9NTkZkyho4XLo/KXudzqoZHeP9CoimElVChXQ=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1711455232; v=1; b=yWLVHNyRnRKR7odANTEkzJbkQ7weKoRb7oOW2OJsXZhNGyE5kVKilcdkQ7RBnPeCWmaYOvCR +UomfRGnajYltTs1OZfJwifvUUwRtlNaUVIVwMdAvMBFbEMT64zJyehj91Iq1fQEcTuAgg6elVd g29l7PXo3gmZs9cliREofWnNeIhaUtuNP16a4/ufZZqcQ4CUuxuvvLt7g3WBZpgXbHt6KIvREbR iqmOPHLyJghYLlNxMQ9f6e9TFmbS9xNKflzdwQkoo/1Zwz5GyAyguaREuOD5pIZsQVJ3LoSigbc EnZlygRHrWevavWOUKtGKkewBcCjYXq7G+rsNU+FuNsTA== X-Received: by 127.0.0.2 with SMTP id Zk4bYY7687511xpkz41iA9i1; Tue, 26 Mar 2024 05:13:52 -0700 X-Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.102]) by mx.groups.io with SMTP id smtpd.web11.7182.1711455231567931126 for ; Tue, 26 Mar 2024 05:13:51 -0700 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by IA0PR12MB8747.namprd12.prod.outlook.com (2603:10b6:208:48b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.32; Tue, 26 Mar 2024 12:13:48 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::fef9:2c9c:21b5:6f50]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::fef9:2c9c:21b5:6f50%2]) with mapi id 15.20.7409.031; Tue, 26 Mar 2024 12:13:48 +0000 From: "Nickle Wang via groups.io" To: "abner.chang@amd.com" , "devel@edk2.groups.io" CC: Igor Kulchytskyy Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH V5 2/2] RedfishClientPkg/FeatureDriver: Use SetRedfishSettingsObjectsUri Thread-Topic: [edk2-redfish-client][PATCH V5 2/2] RedfishClientPkg/FeatureDriver: Use SetRedfishSettingsObjectsUri Thread-Index: AQHafGccNcbii4cSGEyQ/2dqwLCP7rFJ9ULQ Date: Tue, 26 Mar 2024 12:13:48 +0000 Message-ID: References: <20240322144124.1671-1-abner.chang@amd.com> <20240322144124.1671-2-abner.chang@amd.com> In-Reply-To: <20240322144124.1671-2-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|IA0PR12MB8747:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: pdXDh8g49+iXPT2G5w9KWONnBgZ6JLoe02if4yQzpee4BvaJLQ/Rbh+1UMK5Ub5shwapxZ83NXSHfFi9ntx6PENy22SNekPg53nFmzEIM1wyl/IetpSuXqR5+B/h53ajVI1umAs7d+jso3sCZtK1nTvN+pWx3zddR5u/6C6fbsTGLnLlX93ncGD+xSQHvoWCmKrAHV8d7MyhtD1LLMhFpN1BBq39cJn2/6I9vECHpjx0Yb4agQT4n/OZrwomcoX/cGdougcLsIS9hZlcN6NBRIe24emZh12J/onkisNowFQtWvS+cij242cjRhxUyXq16VvtYxizfOepT18peDDACFK+8g5rNXhY/bEaTiAd3gxwgoQZaOArsUWh3Lb7fyPRyJWB0S9ORyK55sksd3HYR4ZjvI+eQcYPyMl07vg4NIS4vSqlzADSOh85AsVUVJ1Xk0O2YSRkIobh4zI6VBinkqQDJGatzOfdWBm4IBxwGbv0NukVTm+PLjaFxHYBFKVhvuKoT2M9vdPQBSqh9gB0Tfj09FrAJfqU/Hnfb25ZqguBrtVH7Jzpo2640WqFccJ9pYTaHsAUSDOXJK1Dg4oRXQTUklX32b7UgpFQUjVIogwXF5fjWiH9wpWf7EoIegsMNe5pI9FeCjr9j+h44V/sn897LCwPmA6i3aUCGcjxONs= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bhR1KR/eS5uzHHwEPBy0ed2FlfgDkZlqNziGBl4LPvb5gq/jWLotnQ5lINag?= =?us-ascii?Q?6uN0C5Fcl7axOiPV+UMXz+Mb6sf3XllY76yo2xASQAOGY5C2nyhErfdMQOg8?= =?us-ascii?Q?iwmFgEXmC7w9YBRqFClw+sNyWXuai3p5ZBAetG8ieQsEjCtU02T0y6U7Xyv4?= =?us-ascii?Q?TLFgjueKWUzeY6J1d4YOBdt8Wlv9zgG6XxUClurcqs3AlyxT9AnlknqxR8Ff?= =?us-ascii?Q?bENn8fAGRYC8BkNYyS6dSb8yALxRDoxxJa7VO7WuMOscDR5rrvJr7TlJOtSU?= =?us-ascii?Q?yRzb2+Qz/Eqx87iysddvFXOZQfyb6Nt1Sratur8R7HYwpP60lSJu8fxGsKnI?= =?us-ascii?Q?+r7OS/99L7eZdarDruCODclUQoB4zcmRtZNnab+Yc1z419g0IFw+RjxcHY/O?= =?us-ascii?Q?5iMupJgB9Z3NX5624oT4aIGev+tiOiw/EHAzWEwiP5MR3w8+Mpcl+XR5/lz5?= =?us-ascii?Q?Hv7KksS3CgN7rl9bN9o5A9ipHZyfwGjqE82fFBK9HlR4oDLG74j66wJNtiSV?= =?us-ascii?Q?0V2NwQaPM/exnH4YXdyU0k4fvMR4VUeKrwKhF7Mir1ChWAFda6ghYTNul5RG?= =?us-ascii?Q?ypDYTkiEcBbVlXjSve4oOQBzjL0PlK/IHpXc3dN4YVTZJ7Ew+3zBxxDzyUuM?= =?us-ascii?Q?TuVZNYU0dMDSzmbAgt4VpjvnDXmPLxgP4y5lsDWfxfBoPSc64ZwJ8QK24ECI?= =?us-ascii?Q?rfoOCK2gfCIcAVYaSCMnupM96bGL9goQcJEyGjdLcUoba2htQM2czatccrXj?= =?us-ascii?Q?4HZ8jxWx6hh2Dc7ONhOzWthlmxpnCpR+l4xPEd1jLsjj5WwRkEQV8jdzkq7J?= =?us-ascii?Q?4flSMgzMI6eM13FyPq1KhkhbX2haInqTg0fbCAv4KVzXDjlBxnUeiPhQxHRE?= =?us-ascii?Q?2qOfd1p8eeylIbwQo/qlZo0vkO8z54DgZTtSD6+dBD1PO+UB+MiWVoA9kbt2?= =?us-ascii?Q?M49GRpuLrO3rKV9rsRI/jw2MNsD76nAaZ+kAU7RPKTpNExlJJIk+7ioV2jfr?= =?us-ascii?Q?BQ25gWDQURsf/TXIoJ/8nxZPYLs2oxjYD4E64brNoFuDFo89OfX30IJrgjjZ?= =?us-ascii?Q?nauzhdQ/na9or2mEFXVHGMPVsuPj70ohF9UtHbS5iheajnzplHC31I4OdlMm?= =?us-ascii?Q?hHROJS2JQ4hwvjqD4fnhbxr4WMyLzNiMUm1YmYk4otvGbHfKiq1VDA6hI/9e?= =?us-ascii?Q?RziMD7LQX93xbrWX5zMP/uwQyhexiUjh4m/g42dXQdRophmbcurlf6r0/ewy?= =?us-ascii?Q?TsLWzQNPujUbaoR9w8O9auyhNrYaMG3Hl5JDb9Z0cQFp2mhILd3HalhQ9cBb?= =?us-ascii?Q?pFSggfB4fFGplKMFE/uM+hPxWCTw94A0fMg8KR0pug0/uFmkWbzoCuvPk0+b?= =?us-ascii?Q?H30UUVeTLlsGk4LhJFUYezIS6o+e2Ow53eJqNncRygipYLZPRVOgTxW/lFYM?= =?us-ascii?Q?/8cv9nEy5tU2niK6aFE833rNne37+FDceJX4x9gBMDpfzed+r1uX7Zgy98vz?= =?us-ascii?Q?+WN+07rlGb/I+kbkeKpquJkx6695DpMR5vA8hjbTzSrHDFbm6kmCpjoLSPPV?= =?us-ascii?Q?CjnQ+InkAS7WipuSzR0=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f202f38-0b5d-4aed-b462-08dc4d8e3118 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2024 12:13:48.3745 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MJ1LxYenizODjfm19D/jW6fNXRyDO5I+DTh3qAyKViFIzE8dkLMuzQ+2G5dv9zliy9nSM4lG92JTvubksb6yww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8747 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 26 Mar 2024 05:13:51 -0700 Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: zFzDYVMmUGqS58i8jnYzUccYx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=yWLVHNyR; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=pass (policy=none) header.from=groups.io Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: abner.chang@amd.com > Sent: Friday, March 22, 2024 10:41 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [edk2-redfish-client][PATCH V5 2/2] RedfishClientPkg/FeatureDriv= er: > Use SetRedfishSettingsObjectsUri >=20 > External email: Use caution opening links or attachments >=20 >=20 > From: Abner Chang >=20 > Use SetRedfishSettingsObjectsUri to set the config language for SettingsO= bject > URI. >=20 > Signed-off-by: Abner Chang > Co-authored-by: Nickle Wang > Cc: Igor Kulchytskyy > --- > RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 1 + > RedfishClientPkg/Features/BootOption/v1_0_4/Dxe/BootOptionDxe.c | 1 + > .../Features/ComputerSystem/v1_13_0/Dxe/ComputerSystemDxe.c | 1 + > .../Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDxe.c | 1 + > RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c | 1 + > 5 files changed, 5 insertions(+) >=20 > diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > index 1ca920640a..bb64ef8625 100644 > --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > @@ -141,6 +141,7 @@ RedfishResourceConsumeResource ( > ); > if (!EFI_ERROR (Status)) { > DEBUG ((REDFISH_DEBUG_TRACE, "%a: @Redfish.Settings found: %s\n", > __func__, PendingSettingUri)); > + SetRedfishSettingsObjectsUri (Private->Uri, PendingSettingUri); > Private->Uri =3D PendingSettingUri; > ExpectedResponse =3D &PendingSettingResponse; > } else { > diff --git a/RedfishClientPkg/Features/BootOption/v1_0_4/Dxe/BootOptionDx= e.c > b/RedfishClientPkg/Features/BootOption/v1_0_4/Dxe/BootOptionDxe.c > index 7501c1a975..5a66fe59e0 100644 > --- a/RedfishClientPkg/Features/BootOption/v1_0_4/Dxe/BootOptionDxe.c > +++ b/RedfishClientPkg/Features/BootOption/v1_0_4/Dxe/BootOptionDxe.c > @@ -130,6 +130,7 @@ RedfishResourceConsumeResource ( > ); > if (!EFI_ERROR (Status)) { > DEBUG ((REDFISH_BOOT_OPTION_DEBUG_TRACE, "%a: @Redfish.Settings > found: %s\n", __func__, PendingSettingUri)); > + SetRedfishSettingsObjectsUri (Private->Uri, PendingSettingUri); > Private->Uri =3D PendingSettingUri; > ExpectedResponse =3D &PendingSettingResponse; > } else { > diff --git > a/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Dxe/ComputerSystemD > xe.c > b/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Dxe/ComputerSystemD > xe.c > index 1235760a18..a0c71212b3 100644 > --- > a/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Dxe/ComputerSystemD > xe.c > +++ b/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Dxe/ComputerSyste > +++ mDxe.c > @@ -133,6 +133,7 @@ RedfishResourceConsumeResource ( > ); > if (!EFI_ERROR (Status)) { > DEBUG ((REDFISH_DEBUG_TRACE, "%a: @Redfish.Settings found: %s\n", > __func__, PendingSettingUri)); > + SetRedfishSettingsObjectsUri (Private->Uri, PendingSettingUri); > Private->Uri =3D PendingSettingUri; > ExpectedResponse =3D &PendingSettingResponse; > } else { > diff --git > a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDx > e.c > b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDx > e.c > index 5207362dac..494bf59dfc 100644 > --- > a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDx > e.c > +++ > b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystem > +++ Dxe.c > @@ -134,6 +134,7 @@ RedfishResourceConsumeResource ( > ); > if (!EFI_ERROR (Status)) { > DEBUG ((REDFISH_DEBUG_TRACE, "%a: @Redfish.Settings found: %s\n", > __func__, PendingSettingUri)); > + SetRedfishSettingsObjectsUri (Private->Uri, PendingSettingUri); > Private->Uri =3D PendingSettingUri; > ExpectedResponse =3D &PendingSettingResponse; > } else { > diff --git a/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c > b/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c > index c4a363cdf5..f2c0a7735b 100644 > --- a/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c > +++ b/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c > @@ -134,6 +134,7 @@ RedfishResourceConsumeResource ( > ); > if (!EFI_ERROR (Status)) { > DEBUG ((REDFISH_DEBUG_TRACE, "%a: @Redfish.Settings found: %s\n", > __func__, PendingSettingUri)); > + SetRedfishSettingsObjectsUri (Private->Uri, PendingSettingUri); > Private->Uri =3D PendingSettingUri; > ExpectedResponse =3D &PendingSettingResponse; > } else { > -- > 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117113): https://edk2.groups.io/g/devel/message/117113 Mute This Topic: https://groups.io/mt/105086470/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-