From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 06AA4AC0DCB for ; Wed, 27 Mar 2024 07:41:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=oZ/WDe51PPiJgx7BjBjgF77rDfF3S6hSKutbj804aEA=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1711525314; v=1; b=Ho+4hUn4tA2MoSfRYCiffbuFMI2nT+INdqMfqtmFfCB59Xqjn7P/iSDr9h7NGfa6qPCicltk aiODG0oShs1z/V/d4p0PvwL0XMghoWMJkr2iVhPoQUe2I0+j0LjalsZshO2bseQRXC/yUmG2m0X 2HbNTwkv+/he/Y/slJ1RhlOYQc5IRk2TqlDTkOyRSvtgZAHw8SbkwC67Sk18pY+WiCavK6MBTSS 1iCGXCyjW+GncjMNY3trITSJKfwCYwF5HSsNuqgGqswXBAnaEBOoIr514Eo07TR457lsN306SSv EcmeM2cP2yzh6Y5a4WJD6HpxAIU/A0191deHKxKuzkIrg== X-Received: by 127.0.0.2 with SMTP id Szu8YY7687511xxaYmCFDrdn; Wed, 27 Mar 2024 00:41:54 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.78]) by mx.groups.io with SMTP id smtpd.web11.31924.1711525313855020080 for ; Wed, 27 Mar 2024 00:41:54 -0700 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by SJ2PR12MB8158.namprd12.prod.outlook.com (2603:10b6:a03:4f7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.31; Wed, 27 Mar 2024 07:41:50 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::fef9:2c9c:21b5:6f50]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::fef9:2c9c:21b5:6f50%2]) with mapi id 15.20.7409.031; Wed, 27 Mar 2024 07:41:50 +0000 From: "Nickle Wang via groups.io" To: "abner.chang@amd.com" , "devel@edk2.groups.io" CC: Igor Kulchytskyy Subject: Re: [edk2-devel] [PATCH V2 0/6] [PATCH V2 0/5] Config language searching algorithm enhancement and the bug fixes Thread-Topic: [PATCH V2 0/6] [PATCH V2 0/5] Config language searching algorithm enhancement and the bug fixes Thread-Index: AQHaf5B2FPD4iHNDlkWUOfJWdy+6frFLNN9w Date: Wed, 27 Mar 2024 07:41:49 +0000 Message-ID: References: <20240326151503.106-1-abner.chang@amd.com> In-Reply-To: <20240326151503.106-1-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|SJ2PR12MB8158:EE_ x-ms-office365-filtering-correlation-id: a01e1a48-eca1-4785-d887-08dc4e315d03 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: vZzk4e8B7F2LRsOp9ipTp+KAprwPpEAmdK2QNdZa8bpt8OvaEOc5j4p43CceX0TfTWGxXz1RcJ2HHhqn5zL8yZUaG9ixM+kBP0nyNeUEz1fSsvlhaBHeOeDRbLRNx4atk4Bw9UL/9VaNdbBHmCcJSgwC49Y1gyGR1GqhqZOZNf5w4C8XuYgtOe390vMMXUOBwzC34Ul46Qz4bS8/1vnw+LM0XQEWeHT4dcqgGrZ292H8sGuZAp8yzVWbzurMQvJK3fB0S+wsRoFqP7aBfSrD7gwfrRUfKqV+QP6l6Jbn8hcdYr2ClPrkk8KQEyFfCCwbWmTxo9fbYn9HyFTARFJjSZvI8AgCAHSl/B0/ZUYDgB/gtXLznmu+WWk/9V4rrq8Boeh55mEctWYKf73M2j0HcY04+EVAL97f7sKGOK5D7/S/PM45Wv5EZ2uKWYIsMxVylXWKZBrolRzQaM6rCaHy3wUMjXNXM29lY7B6llbkMKQacZ4dIrCBt8wb6Lvkz1Ir1xxHbVevAB3PuVatgNeO7Bp+Zi4q3UQMHM0iUXpMmYSTX/BfxSaw/ss+1+KrRNV5qlT3OGIqm0t5sFj1TNaaediBH6BParA2JM5WYQS8Dk8NQZz6DpgEI6FULhq4gsBhMX/bEKmrZ0in9gXLx3ZRd2CzI/Z7IdqlDFeJmxp48S3WMb/UAcLhJXpqwQ69rUVvrVdUGmTQ82/iHwDEI8UnowA3nvtxN9CiNDzm15MpjWY= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0zSSQXD28cloC7qbU7or8NFPmtszPDvjDnWlA35wC+ZcAB986DQmGrExxCdh?= =?us-ascii?Q?pgXpu270ca9GzxW6cYd1qvltsxto8NyS7LzlzdBMHTE8cqB47JhrZSKLRQWt?= =?us-ascii?Q?yQB6vabGViW04GZHme0uXmoemLkz5FqRmJaUB4nkSvgGFuscIUJDV6nnxTjV?= =?us-ascii?Q?KD3ugwppVfhjaZyoSLZ6MQSfx4IUBMMvhir8HOC8wWeZQij4+c0cneNt08s6?= =?us-ascii?Q?s6JJOhJHYu/AjW0iSBovuaGaUh37tHGvGdBLE5SJXasoPHh47+O8wNxPdiTd?= =?us-ascii?Q?lpa8HWLUvQP3HDfYZYXVQy30A0twN8vnqVDpoufCkleUQVcteVBYDRY5M4lc?= =?us-ascii?Q?aMvV3AhDtdJZUIVqimFXRPAquQhxwNZa6d7ZsYHi9qamiyCPSoesxZCsk3r6?= =?us-ascii?Q?87E+HLjiuoStuRjK4lh+yW9kldU+dm5HdtshiXOgAVu2nndivwjnTRsiQckT?= =?us-ascii?Q?l4Zj5Pk9T4XBYIakKI9vaXaxQ2qekMDV3rjJDU6qbUxzlKLHdyBObRyjMnKE?= =?us-ascii?Q?A5/ZqHJoKf2N+8Qkmud1vOWmR9Nu8Jxl52SHuaycC76dS/M7EaINtAcd7/nU?= =?us-ascii?Q?mPkbFUPEZnhBEOLvjVRG87aE7hLaRgl1aeiFxZz7ltz/Qpuh+otah88mge95?= =?us-ascii?Q?vxUk9zu+AJVWtmmgwo0gW3wsEx6ZZ4JtfhBk7NZviwk7ktPllyrnV6/p1Jim?= =?us-ascii?Q?9wZZd07rxRqqi4Q9TSz2GyRmtpvjGFx0n1FLzrGg2F9TWlzNY8ZfU7ZKqWgV?= =?us-ascii?Q?b88KE+Ce2fSO7s+pmk9hkSQPObThFz5YwN6i/K1tp7jN2S48kJR/BhT5Iwz3?= =?us-ascii?Q?5SV3gjHHBorA2wGJWvidCq1ErOSDKVMsrgXRgqKv48bTObUaHX8Ym0qY2m/F?= =?us-ascii?Q?5eFLTTCQM/re2YxKgy/hLqMCREoMKCap7wi/WaqeyYvj6aiBvIqEq2lhLoMi?= =?us-ascii?Q?IM9gWzqW+thf8pJlmBo0JQMADqSfazj+TiU6o73dqprZdSWTcU06MHavNTx2?= =?us-ascii?Q?6s/9EjWg9hI1+rN4Odc8Fs6xSS8Ozce1E7HGk+pL5QUJaafL8eTcM4K8lpDn?= =?us-ascii?Q?cx2HQ0GeELerTSj7pb0/JCh+XtUJnQlIV5/2NApimlqD+eZWdUD/1bJp1C8l?= =?us-ascii?Q?f9r0uuDqGneZhjfhRWu3lxwMTIJJUEVmjtpAFU3sOWuJQyIAasN249EC9hyN?= =?us-ascii?Q?tnt9o/t9spkvwzqYFwD5U1S1jGu7+akKjY4kClbeGQNZDjDBb7/pMG9gn1Ri?= =?us-ascii?Q?Br72W6QjTsiVnGVkEQfbg3oiOce/htfRE4haI3CdFSVuhzqBTTnfhLJnJ9o3?= =?us-ascii?Q?r7xGopA2iurh3LsTZfCPZIUpU7W4OCBLSrLUo6pyp3/uR1Hc4zb8FfqgsbCx?= =?us-ascii?Q?nWsyDeP5X4KYP/iQCBr8vC2N9wbZHntzx75y4cbvmslFnGndj6F6ijTq2B1Q?= =?us-ascii?Q?Q9Vr9M41viJQHhTXsNzL4+wZQPaoSCpLmVxsqOMSsCfIP59F13XlNdHMn7T9?= =?us-ascii?Q?4HAOus+0MP6xoj6SNVZI+gFN3cTyCqYWnNlq8qInTSDKBIWxOdXN7pz0xQx9?= =?us-ascii?Q?7+re57/XjckSm0B/5qo=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a01e1a48-eca1-4785-d887-08dc4e315d03 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2024 07:41:50.0035 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UqpTWqAPnKNs177F656UTF8MLPL5TdwMBQSwKUO7g7sSQDqRS/JBtePVfR7hrT7/tt75w9ENn4GLlvaHfds4Hw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8158 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 27 Mar 2024 00:41:54 -0700 Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: hN8xE2GkplfBgyfnVIXckxAXx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=Ho+4hUn4; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io I have tested this patch series on my system and got a lot of performance i= mprovements too.=20 Great work, Abner! Regards, Nickle > -----Original Message----- > From: abner.chang@amd.com > Sent: Tuesday, March 26, 2024 11:15 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [PATCH V2 0/6] [PATCH V2 0/5] Config language searching algorith= m > enhancement and the bug fixes >=20 > External email: Use caution opening links or attachments >=20 >=20 > From: Abner Chang >=20 > PR # 5491 >=20 > In V2, add patch 6/6 contibuted by Nvidia for updating BIOS menu path > implementation based on the performance improvement. >=20 > In this patch set, > 1 We enhance the config language searching algorithm. > As the performance of searching config language using HII GetString is > pretty slow. For the example, 1800 HII BIOS options takes over 30 mins > to build up the metadata required for Redfish BIOS resource. With this > improvement, it only takes 4 seconds. >=20 > 2.Introduce the Redfish debug framework, there are three edk2 Redfish > debug scopes. > a. PcdDebugPrintErrorLevel, DEBUG_MANAGEABILITY to enable debug message > for edk2 Redfish. > b. PcdRedfishDebugCategory, enablement of individule edk2 Redfish > component. Currently we only support RedfishPlatformConfigDxe > module. > c. PcdRedfishPlatformConfigDebugProperty, edk2 Redfish module debug > scope. This PCD is used by RedfishPlatformConfigDxe debug enablement= . >=20 > 3 This patch set also fixes an issue that deletes HII string unexpectedly= . >=20 > Signed-off-by: Abner Chang > Co-authored-by: Nickle Wang > Cc: Igor Kulchytskyy >=20 > Abner Chang (4): > RedfishPkg/RedfishDebugLib: Introduce Redfish DEBUG macro > RedfishPkg/RedfishPlatformConfigDxe:Add RefishDebugLib support > RedfishPkg/RedfishPlatformConfigDxe: HII string is deleted > unexpectedly > EmulatorPkg/Redfish: Use edk2 Redfish debug PCDs >=20 > Nickle Wang (1): > RedfishPkg/RedfishPlatformConfigDxe: support menu path report >=20 > abnchang (1): > RedfishPkg/RedfishPlatformConfigDxe: Config language searching > optimization >=20 > RedfishPkg/RedfishPkg.dec | 24 + > EmulatorPkg/EmulatorPkg.dsc | 21 + > .../RedfishDebugLib/RedfishDebugLib.inf | 4 + > .../RedfishPlatformConfigDxe.inf | 8 + > RedfishPkg/Include/Library/RedfishDebugLib.h | 43 +- > .../RedfishPlatformConfigDxe.h | 48 +- > .../RedfishPlatformConfigImpl.h | 135 ++- > .../Library/RedfishDebugLib/RedfishDebugLib.c | 55 +- > .../RedfishPlatformConfigCapability.c | 58 ++ > .../RedfishPlatformConfigDxe.c | 89 +- > .../RedfishPlatformConfigImpl.c | 928 ++++++++++++++++-- > 11 files changed, 1240 insertions(+), 173 deletions(-) create mode 1006= 44 > RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigCapability.c >=20 > -- > 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117157): https://edk2.groups.io/g/devel/message/117157 Mute This Topic: https://groups.io/mt/105159781/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-