From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.40]) by mx.groups.io with SMTP id smtpd.web11.51396.1683211048378775431 for ; Thu, 04 May 2023 07:37:28 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=selector2 header.b=LQIIOrnM; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.93.40, mailfrom: nicklew@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YXA4BxCtrhbaxSgvnT7JwyFtZ6dzy5Fo9/gQMN0l/Evw8wNdLv5KQB/9Z5W6hvHpx4KPEtIKopvF6LH99mFZA92kMVDAZlC8zjJ8wPTt7k/xX1sqEhufNALUkiZFQ7n27zAvls9zvcLCEeHflRj2HCsig9Dqtrgjh6f0b+VdeucLHlICz3dylNH9LgUK1Kjj9wocYt48VN7zrKEdVQq07y2kFd8ROR4rq1DN0IKtE1JK4jQeNnLxxac8LUKWDsw4Ow5mmwtkm6KiB4B7O+34pWscqHMtBL7nyB3jEza/o9oz7r+8RsEHAXVwM0RdTBTp5sF3B+SKgktemuXCOg+hIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C4+WOAKCRJTanngV0EJGVA6ZpsIIWi+PlhzTZYbKGmU=; b=oBu8KU6Qtq5dA5W13gFw8PIM2zXYOTxZ8Y/uQ2fj+Dj9WQFTHqzR+PSdhaADbPhfx3TYPWcK2P11gxXjVGsjIFQglgl5MZ4XroQhKzL7oEEqNSckyhkUYdYxK5imYyb6nSp02tabgsNVz5MMKUFSTYuZvrUnqgHTcX0MSRXQ4sWituvR3O1SteTNSJwm4Mls1Hx0/r8hhOeb3ujSXkO3c7xhqgaFHRqFe07VB/scdShVyfTb4lFJ+kVB6O4VE099V5WevVdBaTQz4Gyr4nlWbaSq4J5JDVHxNV8sN3DWbmbZPO6n90QytTDfROdcTzbUG7f/tglg0ub12pvlCuVEmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C4+WOAKCRJTanngV0EJGVA6ZpsIIWi+PlhzTZYbKGmU=; b=LQIIOrnMnojathM4j+MHAdPaeBaik7Sdm5xHnj6coQTDiEapDwxbFXqxC3SfYaaq80/FfNJrtNYFRy4jPGfxgT9aPM4nfx8hTf9CBhX1UE0CLWar3qX42RdPylgQIqn9GpIUQ0uoeBm8tBd5pO4vcyxPmy22z4c8QEhugtAUbbjOOPzbB9fH/7cKpcizlZWI0314NlQeRRKTody/vqalTIs/m3tJhztkjpiMGlgNa3GL7AUVffH/dxgzXPRAZH2lVaS3cqiAegQ3YsMCk7j3YTgLFhWubWPFU663jDqRvcM++qdTbVxUGTJPswJtXifs+/3WZ5TlW0oOpZ7YeN+4vA== Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by SN7PR12MB8604.namprd12.prod.outlook.com (2603:10b6:806:273::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 14:37:26 +0000 Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::d9df:b45b:2cc1:f017]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::d9df:b45b:2cc1:f017%5]) with mapi id 15.20.6363.026; Thu, 4 May 2023 14:37:25 +0000 From: "Nickle Wang" To: "devel@edk2.groups.io" , Thejaswani Putta , Ray Ni , Zhichao Gao CC: Nick Ramirez Subject: Re: [edk2-devel] [PATCH] ShellPkg: Add a condition to print accurate type0 Bios Size in smbiosview. Thread-Topic: [edk2-devel] [PATCH] ShellPkg: Add a condition to print accurate type0 Bios Size in smbiosview. Thread-Index: AQHZdU0P0ogdmzKnd0SluNif11XUNq9KQKhw Date: Thu, 4 May 2023 14:37:25 +0000 Message-ID: References: <20230421010023.25867-1-tputta@nvidia.com> In-Reply-To: <20230421010023.25867-1-tputta@nvidia.com> Accept-Language: en-US X-Mentions: ray.ni@intel.com,zhichao.gao@intel.com X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|SN7PR12MB8604:EE_ x-ms-office365-filtering-correlation-id: 20767e9f-f0ad-47dc-3910-08db4cad1471 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nOeeYTOEMqNdHHk00MZz8yjSQV+V/8IwfKix0f7Cj8WUKtaQHadIQwJkmWDCFitPmAfyf+8gxtGXBkQC6tDsaA48z90AuAolhTCmaHnNi37gMzAO+PaqDbSBdFt1i8HIBr3btyNngM8aIFJxpZ6jjQVxYVpIw1Tf9Afa6Yd73Cn9UeUR+tnsaYh0MQI8052NH+pcofWq4jCMDIPrLYIF02lgl5nwuqgZdZBivXFh9NyKPWJZY+HJCDCKmVfYfvzairlszruqKEJJMnyJHchQSiK4KHjJHRt62XWDb4qvcnU1M30sl4myrtzDX/GncprC3BT/HxEFCIiYO/aapU9xVd6NWEY5mCJ78vXD3ktE77PFveZNAx2WH4BehshuTcgjRa3t/SP1bw8fr6eeq/LAaqQBddC7wMXcBzJxMtWSBBW6gVRqIkC2Zd4nHEuT9kW3p+vNw6H89sNJZumknFbjpFmQY5bJTNiUBVQ+sUqfLKoHsUC1uKueS8boZ5zDWCU4jwqedroMHR1xZZWJrFmSjERltq7b7LXpGhzsalKRW0CRdzYV7zEbqGxZMyJGys1XgjF76jh85cEPvGUdFeSHE2DcCeTk2GSuR+2G2ateu7k= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR12MB7031.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(366004)(376002)(346002)(396003)(136003)(451199021)(33656002)(66476007)(316002)(110136005)(76116006)(4326008)(66446008)(478600001)(66946007)(64756008)(7696005)(66556008)(966005)(86362001)(71200400001)(41300700001)(5660300002)(52536014)(55016003)(9326002)(8936002)(8676002)(2906002)(166002)(38070700005)(38100700002)(186003)(122000001)(107886003)(6506007)(53546011)(26005)(9686003)(83380400001)(66899021);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TFHMOzAUooqxx4o/Dms1gHdZ5KldJLuf2qM03V2nM/xRoaqVFWE63W8vAnaa?= =?us-ascii?Q?6526fPm8vboaxh2qDl8MNItg9pOoY9i4JzQC1R0nGgbUYv4+29Y4facU4axp?= =?us-ascii?Q?37/XlsJcwLD9DItDNVeduy2rGA9Rl1/x1z0d3GAIHpjag7KmmvjkAbK7D0b1?= =?us-ascii?Q?guVmUdRo15OQd0y/cvaw2/1DIDKuHMlTojn8kgxrAVCOynEVNajjQOCif87n?= =?us-ascii?Q?K1hb8+1duDlPuKSsAqpEJOJQQYZj4/ZdvsbggP4Ayu5FWe570w4imuUnNU3w?= =?us-ascii?Q?75QFWRI4RFfcaqH+R5PF1gZLw1TieRbkPy4hgS4XewIkFtT6lVnQfSFOyt8P?= =?us-ascii?Q?/PyEFaypXrPn6W4qi4GhpKoyppKVUwFy7UzeUMQrq8orsbmnsFi+MzQj+5lG?= =?us-ascii?Q?cCtyyl3btlabV9X2intVKN9FMdb1Bd6/t+I82+Xz8HHubY3vFUFwwHQbhref?= =?us-ascii?Q?dUgtLXVWlv6x7i8aP5xaksdsUGnQ+Lvz9cIzb6bIUQRxvTBWgx9RQy2dJuif?= =?us-ascii?Q?4jW5AII8dNLwDoO8qAjSMIZH2Bali0y3i1oXXrCP5IAV7FzMnflSEAxipjXs?= =?us-ascii?Q?QSAJY2GF2UIASQJiP0+2Go71FaTghF8cUvN9Zk5Vks8S7CEGmkDNAahRha1h?= =?us-ascii?Q?6hG4/uPcbC0LJJkMPEZ9qYFJaikzR6gdi2lwn8P492deeEd4Egd5WXo9lt5m?= =?us-ascii?Q?FQ6P8eGYsxpE2qbEqPSNCRBVpnlpoNfgaVGApMUD4TWl9nIlQOH6NYxdzdHW?= =?us-ascii?Q?eJOEAsTLOqRWI9Cnl3BmvGbjP51a+cTEWWsv5AmuMPlEotOxGe7djYum5tkS?= =?us-ascii?Q?xgy5dJ/DFx59yQIaQnoJ8N9uXy3qsHlN8zXouk+Ka+Tyt8jD3pn1/HvpjUV1?= =?us-ascii?Q?vfY0t9syJrVBTS91XcWKkNtCF8nNfp0U8sX8wlqnJrAgCzA5Pp1bjUzeX8Ly?= =?us-ascii?Q?cCn2tbq6nR4re7aLoyGuq2pONWod7x43hYge7o+JZJPjid3fv0LzOGFhgi+G?= =?us-ascii?Q?WuS+EqzZCmZlratIB2MLcoElqUCVlYf54AkRNlGqOoRIL6iW1D1NQoOCy0KJ?= =?us-ascii?Q?lZQ1X2BVKkOpeXG3aYWzLLqlO5s2LNscwUERn9RPQhPEXOx/PlO3zwQ/GutK?= =?us-ascii?Q?pbFRYQhEcH4vHQYswKceHcMxzQK878p/inTI0ItGW8yI6/TVR3q/EEXhGsVZ?= =?us-ascii?Q?ADv+eQT1ZpmgGC+ceTrzhGGzqMDVGdt/QTRWmH9Hk+9z3HhbBOlFIS8EE6Dy?= =?us-ascii?Q?vYIinsoTtcKT78vkMpGQisuLbIJA146u3b4rKpX0pXXWBiXbWWADwT2yV22H?= =?us-ascii?Q?ORKvO457uvTC/ZKfaY4eZgYC4xUXzLMsYyQwCN3rLdHP4QC26HrftJ1+FkDs?= =?us-ascii?Q?qAzxbYHxTu1pao0co+jSYIrgbxOdi1/Upyr/ehfk8SoIMeIil3Nmp6IwivVm?= =?us-ascii?Q?EQj2HrOEZXhmrSP+OlMwOM7xk1yMfLNL/nGdVphxTe1ngr3BuTBZpxkLVw3I?= =?us-ascii?Q?TaOOi5TNNjKjxC3SFMhdiE2OraZDFJO2KuUaV95QvtbjNsnr3ii8N0giZdOR?= =?us-ascii?Q?fbVpUftxjpYJyo2UbjU=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20767e9f-f0ad-47dc-3910-08db4cad1471 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2023 14:37:25.8726 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0K5ZPwMZMEzy2vXDd+YOebKFpYz0EaQVZMqTsSQlCF3FdrkFbQjzELI41gyQLGTVQM/jfIkmC3RObCSqkfcwIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8604 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR12MB7031FE10AEE2CE741DCDA324D96D9MW4PR12MB7031namp_" --_000_MW4PR12MB7031FE10AEE2CE741DCDA324D96D9MW4PR12MB7031namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi @Ray Ni, @Zhichao Gao, Could you please help to review this change? Thanks, Nickle > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Thejaswani > Putta via groups.io > Sent: Friday, April 21, 2023 9:00 AM > To: devel@edk2.groups.io > Cc: Ray Ni ; Zhichao Gao > Subject: [edk2-devel] [PATCH] ShellPkg: Add a condition to print accurate= type0 > Bios Size in smbiosview. > > External email: Use caution opening links or attachments > > > As per the SMBIOS spec, in smbios type0 table, if the Bios size is greate= r than > 16MB, extended bios size is used to update size information and bios size= is set > to 0xff. when this data is printed by smbiosview, both bios size and exte= nded > bios size is printed if the smbios version is beyond 3.1, which is incorr= ect as Bios > size is set to 0xff when rom size is more than 16MB. > > To fix this bug, added a condition to print bios size only when it is not= set to 0xff > or if the smbios version is older than 3.1. > > Signed-off-by: Thejaswani Putta > > Cc: Ray Ni > > Cc: Zhichao Gao > > --- > .../Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > index 1811cf0c44..5448abaa22 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > @@ -339,7 +339,9 @@ SmbiosPrintStructure ( > ShellPrintEx (-1, -1, L"BIOS Version: %a\n", LibGetSmbiosString (S= truct, > Struct->Type0->BiosVersion)); > ShellPrintEx (-1, -1, L"BIOS Starting Address Segment: 0x%x\n", St= ruct- > >Type0->BiosSegment); > ShellPrintEx (-1, -1, L"BIOS Release Date: %a\n", LibGetSmbiosStri= ng (Struct, > Struct->Type0->BiosReleaseDate)); > - ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > (STR_SMBIOSVIEW_PRINTINFO_BIOS_SIZE), gShellDebug1HiiHandle, 64 * > (Struct->Type0->BiosSize + 1)); > + if ((Struct->Type0->BiosSize !=3D 0xFF) || !(AE_SMBIOS_VERSION (0x= 3, 0x1))) { > + ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > (STR_SMBIOSVIEW_PRINTINFO_BIOS_SIZE), gShellDebug1HiiHandle, 64 * > (Struct->Type0->BiosSize + 1)); > + } > > DisplayBiosCharacteristics (ReadUnaligned64 ((UINT64 *)(UINTN)&(St= ruct- > >Type0->BiosCharacteristics)), Option); > > -- > 2.17.1 > > > >=20 > --_000_MW4PR12MB7031FE10AEE2CE741DCDA324D96D9MW4PR12MB7031namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi @Ray Ni, @Zhichao Gao,

 

Could you please help to review this change?=

 

Thanks,

Nickle

 

> -----Original Message-----

> From: devel@edk2.groups.io <devel@edk2.gr= oups.io> On Behalf Of Thejaswani

> Putta via groups.io

> Sent: Friday, April 21, 2023 9:00 AM

> To: devel@edk2.groups.io

> Cc: Ray Ni <ray.ni@intel.com>; Zhichao= Gao <zhichao.gao@intel.com>

> Subject: [edk2-devel] [PATCH] ShellPkg: Add = a condition to print accurate type0

> Bios Size in smbiosview.

>

> External email: Use caution opening links or= attachments

>

>

> As per the SMBIOS spec, in smbios type0 tabl= e, if the Bios size is greater than

> 16MB, extended bios size is used to update s= ize information and bios size is set

> to 0xff. when this data is printed by smbios= view, both bios size and extended

> bios size is printed if the smbios version i= s beyond 3.1, which is incorrect as Bios

> size is set to 0xff when rom size is more th= an 16MB.

>

> To fix this bug, added a condition to print = bios size only when it is not set to 0xff

> or if the smbios version is older than 3.1.<= /p>

>

> Signed-off-by: Thejaswani Putta <tputta@nvidia.com>

> Cc: Ray Ni <ray.ni@intel.c= om>

> Cc: Zhichao Gao <zhic= hao.gao@intel.com>

> ---

>  .../Library/UefiShellDebug1CommandsLib= /SmbiosView/PrintInfo.c | 4 +++-

>  1 file changed, 3 insertions(+), 1 del= etion(-)

>

> diff --git

> a/ShellPkg/Library/UefiShellDebug1CommandsLi= b/SmbiosView/PrintInfo.c

> b/ShellPkg/Library/UefiShellDebug1CommandsLi= b/SmbiosView/PrintInfo.c

> index 1811cf0c44..5448abaa22 100644

> --- a/ShellPkg/Library/UefiShellDebug1Comman= dsLib/SmbiosView/PrintInfo.c

> +++ b/ShellPkg/Library/UefiShellDebug1Comman= dsLib/SmbiosView/PrintInfo.c

> @@ -339,7 +339,9 @@ SmbiosPrintStructure (

>        Sh= ellPrintEx (-1, -1, L"BIOS Version: %a\n", LibGetSmbiosString (St= ruct,

> Struct->Type0->BiosVersion));

>        Sh= ellPrintEx (-1, -1, L"BIOS Starting Address Segment: 0x%x\n", Str= uct-

> >Type0->BiosSegment);

>        Sh= ellPrintEx (-1, -1, L"BIOS Release Date: %a\n", LibGetSmbiosStrin= g (Struct,

> Struct->Type0->BiosReleaseDate));

> -      ShellPrintHi= iEx (-1, -1, NULL, STRING_TOKEN

> (STR_SMBIOSVIEW_PRINTINFO_BIOS_SIZE), gShell= Debug1HiiHandle, 64 *

> (Struct->Type0->BiosSize + 1));

> +      if ((Struct-= >Type0->BiosSize !=3D 0xFF) || !(AE_SMBIOS_VERSION (0x3, 0x1))) {

> +        = ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN

> (STR_SMBIOSVIEW_PRINTINFO_BIOS_SIZE), gShell= Debug1HiiHandle, 64 *

> (Struct->Type0->BiosSize + 1));

> +      }

>

>        Di= splayBiosCharacteristics (ReadUnaligned64 ((UINT64 *)(UINTN)&(Struct-

> >Type0->BiosCharacteristics)), Option)= ;

>

> --

> 2.17.1

>

>

>

>

>

 

--_000_MW4PR12MB7031FE10AEE2CE741DCDA324D96D9MW4PR12MB7031namp_--