From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.122]) by mx.groups.io with SMTP id smtpd.web11.22846.1601853926464451590 for ; Sun, 04 Oct 2020 16:25:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=PLe+Y6FO; spf=pass (domain: microsoft.com, ip: 40.107.92.122, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c2u9CKHTfZ9j2ku9/FgZv+73yCYuwt6s+t/Gv1DfzeSTIJc5oOs+n9s0hYcMp9yrygZ0rNVilxqerHPHTJ9NF+C/Bt05HUxJcPeojzebbyPTn+TSsjKezC+n3diDiaJ+i/O1HRlYo93Z/pvpIFTXXyF2IiZWIu5Nk/sugpSkQdqiOFt/5grpzp3T+XxKdlFZdzpD+iE+4w95Ma+HuG79LdKkyVsHKmiKPU6h68dxIA65UpvoALxz5ylsu3qr6jLuPXehvCDx4k/cYP4Qv0Wdrp1lT+6tTWh0VlUtrHTWCWC8U3jOZWoM61f8j5fKflcU86IhLl7pHv55X4REhU+b3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c3t2aZPI0jQlJJqKa5FMH257YlDZxpmg0On3aSA4vRg=; b=P8q0oqfsxaB/QreXNuAqCEZju43aME7H0BMj3AjnWbzvOtf7Q14tIW0s2L3Zdba46t6e/M+xvaTJyatpmj0tvNsRQl5N3kAS1c7clT6k06h5oNH5RlU2D0ZMzAEwZehGOeRcqR6sk2XGHJQs10RXabtUtrXo0NUG6LR8cEMQHFmckkOqQ0Dlh8CEOmTjbOn1lPHYqQPqEIbFsKbltRfhjWWHp/0L7nPN7NZp2GrKXXfT01K9vSukHlm7rmQz5RJWFirWRCkDgb9tv+yn7sVvjtNKm5WiofryZSs8EASdvCpuvf51moyZgAx6aG+9HZ5k1f2tjotarf6lB33ZcVnTMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c3t2aZPI0jQlJJqKa5FMH257YlDZxpmg0On3aSA4vRg=; b=PLe+Y6FOT+mvFfm5aoi3kmG+DMho3TAwv0LSPkPW91izgJUXtY2RcMAwsqypw4fSNDO/6CP1sdNJF7Rp3v+o6j8t5wy9QdNveoMDmVMQuYOyuICzu9wVUZy6GVgYb+dWzHSz8J4CxHTc77E396Ca1/ZdE0TorB0PyenYBAfQqrw= Received: from MW4PR21MB1857.namprd21.prod.outlook.com (2603:10b6:303:74::12) by MW2PR2101MB1052.namprd21.prod.outlook.com (2603:10b6:302:a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.7; Sun, 4 Oct 2020 23:25:24 +0000 Received: from MW4PR21MB1857.namprd21.prod.outlook.com ([fe80::2967:7434:51bb:e234]) by MW4PR21MB1857.namprd21.prod.outlook.com ([fe80::2967:7434:51bb:e234%3]) with mapi id 15.20.3455.015; Sun, 4 Oct 2020 23:25:24 +0000 From: "Bret Barkelew" To: "devel@edk2.groups.io" Subject: Proposal to make EccCheck non-destructive Thread-Topic: Proposal to make EccCheck non-destructive Thread-Index: AQHWmqQ2baqh65fs7US5Dsw7jSdh5A== Date: Sun, 4 Oct 2020 23:25:24 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-10-04T23:15:14.0715495Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [174.21.66.203] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 8d5c778e-f26b-44e2-1411-08d868bcc565 x-ms-traffictypediagnostic: MW2PR2101MB1052: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1201; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UmvQ8y1PawhA7OEUjLy1ZDQWAaz0w8gMZ9vqnhqZSSnOj40l1lp4LAaVtfipXGJZ/JbqRvdawXQduzEHYIKKRMgxFohiw8QzMFAV1R08IdwdlhhfvWQ+KSW3p16jnVFM5ckxYg6/7mhcIhJRSdelTC/KQku0B+jPb6aAd52tqjCgGi0iVW5whTx+HTGdMmaywtFIUipaUW4FkFsKPCIjth9FU15MvYq/soK/h9eBw/3Rw+6OXXpRv/M+0HvUFa6ZiWVz0B3kuD/vv9EfehgF6vwu/GUoTn65IjDT7t8pN4OC2DTT7lFkXzuIDFZQsGvEwKDC2FnsLLIZ+EPPG71YH6SaSsHpE6euPn+9cUZ3ZKGoAve8JX4ky51Thzs0A/TNiNGhpzHrN1+Mf0DVlMqS152eBj+XZqQEeGlzE05T7uLpvT7eizkyEbHl9voJ+b2fj5va/vg7XLmu7MptabQvTA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR21MB1857.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(396003)(39860400002)(366004)(136003)(346002)(33656002)(478600001)(10290500003)(66446008)(86362001)(26005)(8990500004)(66556008)(9686003)(64756008)(83080400001)(7696005)(76116006)(186003)(66476007)(71200400001)(6916009)(6506007)(66946007)(316002)(5660300002)(55016002)(8936002)(83380400001)(2906002)(8676002)(52536014)(82960400001)(82950400001)(166002)(49343001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: E30TpKmDNJOx9kElSpFJrrtFvg+hl4cH7hGFoI43XIQE8EmFN2WNPFs6uusNerTD3Fnm9Ki0oFrttdepe9tWONBhRm0ydayWEFl850C/uVF+uXY7gYKFUtHev9cELc9cLhRfFJ39AazFYQgL/4VUlfRJEsKzHU0wBwylogAWEv2la0/YcZ7sHPGgtdggDp2TPjH6Bwkx4ZQGUk0BuyhQwwLBhls5Wx6kAlmIV2HVfXkiu8E8dyHWP0XaumMHF88OOdpJVy+tY3GqojOjXu14cp9W7lCMmOpDnrKV3z7rh247PGj3DIZ1oCE1zEs0SxUSJcdNNOK2jksczC/gsjEF4wDDepwO+3o2ZDSOuW6fq0XyD/+0zO7L7a9LR7tlrnctctxd+odMW/lv87lBZpPGBRMI4AhfT3yGhVK/U9Acif5ENIHKxCgTg9DpG0K/DqidsukVD5j3YtTCpExliRwy631agWsRag9NuBoux39I0+hIfHjRG+NYuQqttuMTbNNK+Wst+r6PAViwUz7uc6Q8yydek7ELfHReGLfKEaeELBB5XqF6wTrdfTHE4az8bDFyy7xiJmckWsAxAfUdDEeoZfabkRXH74f/vpwVg3z7R0W0F9X/miqHV8//oCctoKRcU/GrN9Cp2+1zwEu46wW2Xw== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR21MB1857.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d5c778e-f26b-44e2-1411-08d868bcc565 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2020 23:25:24.6397 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WkqsYDQ155mnVwhKP5ZeAsa8A6bQgnr9a0c154aZQ8ZuJ4lBKaqoQGcyOPS40l3VvIsXUKCOIHIjk3MeR6Sl/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1052 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR21MB18579E0E0CA438BB4BD5BC3FEF0F0MW4PR21MB1857namp_" --_000_MW4PR21MB18579E0E0CA438BB4BD5BC3FEF0F0MW4PR21MB1857namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable In regards to this bug: 2986 =96 EccCheck should not revert staged and local changes (tianocore.org= ) I have a proposal: 1. git diff --name-only .. 2. Copy list of changed files to a temp directory under Build/ * Perhaps something like Build/EccCheck or Build/EccCheckTemp 3. Remove files/directories that are in the exclusion list 4. Run EccCheck against that directory 5. Filter the report to remove the temp directory path so that the repor= ted errors are root-based paths The trade off of this approach is that EccCheck will run against multiple p= atches in aggregate, but =96 frankly =96 this isn=92t any different than th= e other CI plugins. The destructive nature of this plugin has caused headaches for everyone on = our team that has worked with the new codebase. We all use local CI to vali= date changes as we make them, and having to make =93test commits=94 just to= ensure our work doesn=92t go away isn=92t a satisfactory process. Thoughts? If this passes muster, I=92m happy to code up some quick patches = (if for no other reason than we can stage them in Mu while we=92re waiting = for full adoption). - Bret --_000_MW4PR21MB18579E0E0CA438BB4BD5BC3FEF0F0MW4PR21MB1857namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

In regards to this bug:

2986 =96 EccCheck should not revert staged and local changes = (tianocore.org)

 

I have a proposal:

  1. git diff --name-only <starting_commit>..<ending_commit/HEAD&= gt;
  2. Copy list of changed files to a temp directory under Build/
    1. Perhaps something like Build/EccCheck or Build/EccCheckTemp
  3. Remove files/directories that are in the exclusion list
  4. Run= EccCheck against that directory
  5. Filter the report to remove th= e temp directory path so that the reported errors are root-based paths
    6. =

 

The trade off of this approach is that EccCheck will= run against multiple patches in aggregate, but =96 frankly =96 this isn=92= t any different than the other CI plugins.

 

The destructive nature of this plugin has caused hea= daches for everyone on our team that has worked with the new codebase. We a= ll use local CI to validate changes as we make them, and having to make =93= test commits=94 just to ensure our work doesn=92t go away isn=92t a satisfactory process.

 

Thoughts? If this passes muster, I=92m happy to code= up some quick patches (if for no other reason than we can stage them in Mu= while we=92re waiting for full adoption).

 

- Bret

 

--_000_MW4PR21MB18579E0E0CA438BB4BD5BC3FEF0F0MW4PR21MB1857namp_--