From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.135]) by mx.groups.io with SMTP id smtpd.web12.4716.1600996988361179227 for ; Thu, 24 Sep 2020 18:23:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=D7aC4467; spf=pass (domain: microsoft.com, ip: 40.107.92.135, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J7s+3JI2zd8JCNdZO1xmYl8n3dHHp7bIbY2PpxBOFlzdy8lncX6PKhGT+8cvEjTIGe5KYsYyITNRtONBuYEF7Bcy5O0EJ6m2+OZzvd1t1M8yJGiZA7b+Yr7HMN9RNx3w3mDL6jtl2r7HX4zBma6sx0x615QZGWvEUZ5Rgave/J/+S6FINHtkeC1TG9C+C/oRnjs7LuEjIckqhRfyNN7s5G7oyYipwi8B6Eqvkd8/SSSapRzX3J2AJz85HyoRAJQR5WEP3XcrjXBtAEkwYeogghNRA9ypidpI+S2sSz5t1NgOHG+1wEj3l8vlO3w9DPSuLRWTzwqsk1WxEZacgdVfMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GI8Wxvu665eYdTao64tnYRGqCKUNM4U0VacdzxmvCrU=; b=STDLNo1aSgRPkJcxn1KffT17z1B/2BIZjASx04Y4oyQI/RJHbTqKX2qk8zjShuCZyZwlXlSva0TdDpL+RbL/iwcL42VI6NnL/Adby50GhpzxwITlSWA9poxhS8GVqmc6ARC4uKMBcw23oQfFKD9ZiZKy14tYMldC4F92lzVyS3O+P9iwX4u06GGkhU3E2FH9x6RsB1E/JYuCD/Bk6nN6SeyWRjk8nB1NYXPmCjj6dWERPGElPqamYB31+rC4KUJweyjnk7pMlX9B6g1hBcyAexZZavxdWuzBQqzP1gfn1UX/sH2b9HqLCL6EYlNKobNWyAy0ranKt6anNQITk/7v8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GI8Wxvu665eYdTao64tnYRGqCKUNM4U0VacdzxmvCrU=; b=D7aC4467tkK/w96VHjw2aTJOVXMWGRaEn2UAAUZW7i/n8MqvilVmyMNVtOmLl+NkEbWWEqAOBQNJXZGcedXKyQjruRRbbzAimoiKvrKbphiShp/yBbswGG/oQjuIpefsMOp2+QkZ4hlhDO+dMTNPpTeTBgj/lmf0Oxie7OteKyw= Received: from MW4PR21MB1857.namprd21.prod.outlook.com (2603:10b6:303:74::12) by MW2PR2101MB1834.namprd21.prod.outlook.com (2603:10b6:302:7::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.1; Fri, 25 Sep 2020 01:23:06 +0000 Received: from MW4PR21MB1857.namprd21.prod.outlook.com ([fe80::2967:7434:51bb:e234]) by MW4PR21MB1857.namprd21.prod.outlook.com ([fe80::2967:7434:51bb:e234%4]) with mapi id 15.20.3433.018; Fri, 25 Sep 2020 01:23:06 +0000 From: "Bret Barkelew" To: "devel@edk2.groups.io" Subject: ECC: Won't somebody PLEASE think of the... test structures. Thread-Topic: ECC: Won't somebody PLEASE think of the... test structures. Thread-Index: AQHWktooEicGg8j40UW1Z0xLUDeoVw== Date: Fri, 25 Sep 2020 01:23:06 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-09-25T01:21:14.2085667Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [174.21.140.128] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 1640a268-0b50-4efb-4bc7-08d860f18e89 x-ms-traffictypediagnostic: MW2PR2101MB1834: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1227; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IdnG4BRDhI+rShiz5NAgIBK4ojUxSrnS8bfBg5vFeym4SRcyHlQQIxm8o0OivnquiEjKLtD06yeYqtxQFMNKpGk+Cu1O8dGtAu0qETh+1ZD5CLpoxcYngAbfvgNz+e8x16/qdqq58s4TMgY8t1E8db+KmAF/UQlW5u0vOx0Obsu9L2s3U6se3yktJN6Iml0vDI+19EbzpzMfEzZc58umnrzgRyPlHYnjIVd5x23UKlfqd4OGxfiKYQcUec3Xqaiec952Qiypv1+yG7QyqXytaFRCTiiv4jXvg+lty41fOha5xhVPZOOblTwQq8pDj1sJjE9nRDCW3ToxHhHrRJZdQUFyLmR1rmXeIFNF5TcWYxBUMe674AuLzQbP7JVDoijO x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR21MB1857.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(136003)(39860400002)(396003)(366004)(26005)(66556008)(71200400001)(6506007)(76116006)(66446008)(186003)(4744005)(66476007)(64756008)(33656002)(7696005)(82960400001)(478600001)(52536014)(9686003)(2906002)(83380400001)(5660300002)(66946007)(8936002)(82950400001)(6916009)(10290500003)(86362001)(316002)(8676002)(8990500004)(55016002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: K8ga+JYOvDAKup5ijrxC2qLtCoECQEkK6MzDxvl3BWsBIbZFDPErOE79oFiNbKlHpZaoTnTzkpUqkC0YHqVrdpM15slEuVtnykxBkobR9q5QjKlcrdfo2V0m3Vc08jJ7NpYAPEg6F2363aGH8hP50X6TZHopT89kopOCwdK0KAry5wNcdcztdiIufRhb3EtS9azlcWqpUrLxnum2DXb+3kH7VZU+f0Vp2aTnJ0UFQGbHGJkTtgMJ+R0zb8FWzgZJk6ROCllwQQMmN2YoVATQG0VFwqQ4/1TNZgbhogQ7Er5t4EDorRn6gPsvsbM/X6cXcSPG/LjJtehL3rljHEPkhTSCdmGuQ+KI50Ivs0b/tdZ1DXzcQpyFXjSG/uoIuEz19iTdUf7Newzuu2qhgN1IUc/z+4luvUtthywn+7jv/1DCSMcCkHNSLMNCeA7yiKbtMWVlFtUuJ317X9l3ufwOpMBLqrFdW70ddbb67+78SpQ78JfSI5vUZxOOtcOGVCgcCInHdq82Efu4elnVxRgKNEcMk20tbKHkX/m8XYR6Rtyad/99WxK3hNaSux3+ypL4IuVmJFVM1eag3ZDHarygpaQSOcs5Gvd/3EfQjA9nFcvQ8orkzw5U3GwJnK3DxlvC03AlACWy5zWf9poZIV2iCQ== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR21MB1857.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1640a268-0b50-4efb-4bc7-08d860f18e89 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Sep 2020 01:23:06.5950 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pZDddTl9SFkwr80CsSLBS6xsAKlLR34nNp7ggVXRdQP/evouFivwunL12W4EJBBBUdOWz5cbOwGKvzugspuZFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1834 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR21MB1857D28E6D0D13E656200C1DEF360MW4PR21MB1857namp_" --_000_MW4PR21MB1857D28E6D0D13E656200C1DEF360MW4PR21MB1857namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable ERROR - EFI coding style error ERROR - *Error code: 5007 ERROR - *There should be no initialization of a variable as part of its dec= laration ERROR - *file: //home/corthon/_uefi/edk2_qemu_ci/edk2/MdeModulePkg/Library/= VariablePolicyLib/VariablePolicyUnitTest/VariablePolicyUnitTest.c ERROR - *Line number: 333 ERROR - *Variable Name: MatchCheckPolicy EccCheck no likey: SIMPLE_VARIABLE_POLICY_ENTRY ValidationPolicy =3D { { VARIABLE_POLICY_ENTRY_REVISION, sizeof(VARIABLE_POLICY_ENTRY) + sizeof(TEST_VAR_1_NAME), sizeof(VARIABLE_POLICY_ENTRY), TEST_GUID_1, TEST_POLICY_MIN_SIZE_NULL, TEST_POLICY_MAX_SIZE_NULL, TEST_POLICY_ATTRIBUTES_NULL, TEST_POLICY_ATTRIBUTES_NULL, VARIABLE_POLICY_TYPE_NO_LOCK }, TEST_VAR_1_NAME }; But you can=92t init this structure separately without addressing each fiel= d. Can a brother get an override? - Bret --_000_MW4PR21MB1857D28E6D0D13E656200C1DEF360MW4PR21MB1857namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

ERROR - EFI coding style error

ERROR - *Error code: 5007

ERROR - *There should be no initialization of a vari= able as part of its declaration

ERROR - *file: //home/corthon/_uefi/edk2_qemu_ci/edk= 2/MdeModulePkg/Library/VariablePolicyLib/VariablePolicyUnitTest/VariablePol= icyUnitTest.c

ERROR - *Line number: 333

ERROR - *Variable Name: MatchCheckPolicy

 

EccCheck no likey:

SIMPLE_VARIABLE_POLICY_ENTRY   ValidationP= olicy =3D {

    {

      VARIABLE_POLICY_ENTRY= _REVISION,

      sizeof(VARIABLE_POLIC= Y_ENTRY) + sizeof(TEST_VAR_1_NAME),

      sizeof(VARIABLE_POLIC= Y_ENTRY),

      TEST_GUID_1,

      TEST_POLICY_MIN_SIZE_= NULL,

      TEST_POLICY_MAX_SIZE_= NULL,

      TEST_POLICY_ATTRIBUTE= S_NULL,

      TEST_POLICY_ATTRIBUTE= S_NULL,

      VARIABLE_POLICY_TYPE_= NO_LOCK

    },

    TEST_VAR_1_NAME

  };

 

But you can=92t init this structure separately witho= ut addressing each field.

Can a brother get an override?

 

- Bret

 

--_000_MW4PR21MB1857D28E6D0D13E656200C1DEF360MW4PR21MB1857namp_--