If it’s only used in that package, I would suggest adding it to the CryptoPkg.ci.yaml file instead. If it’s likely to be used in multiple packages, the current patch looks good.

- Bret

From: Sami Mujawar
Sent: Tuesday, October 6, 2020 12:58 AM
To: Bret Barkelew; devel@edk2.groups.io
Cc: Ard Biesheuvel; leif@nuviainc.com; lersek@redhat.com; Matteo Carlini; Ben Adderson; nd
Subject: RE: [EXTERNAL] [edk2-devel] [PATCH v5 14/15] .python/SpellCheck: Add 'XIPFLAGS' to "words" section

Hi Bret,

Please find my response inline marked [SAMI].

Regards,

Sami Mujawar

From: Bret Barkelew <Bret.Barkelew@microsoft.com>
Sent: 05 October 2020 09:51 PM
To: devel@edk2.groups.io; Sami Mujawar <Sami.Mujawar@arm.com>
Cc: Sami Mujawar <Sami.Mujawar@arm.com>; Ard Biesheuvel <Ard.Biesheuvel@arm.com>; leif@nuviainc.com; lersek@redhat.com; Matteo Carlini <Matteo.Carlini@arm.com>; Ben Adderson <Ben.Adderson@arm.com>; nd <nd@arm.com>
Subject: RE: [EXTERNAL] [edk2-devel] [PATCH v5 14/15] .python/SpellCheck: Add 'XIPFLAGS' to "words" section

I’m assuming this is used across multiple packages?

[SAMI] This flag is also used in CryptoPkg\Library\OpensslLib. [/SAMI]

If so,

Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>

- Bret

From: Sami Mujawar via groups.io
Sent: Friday, October 2, 2020 2:14 PM
To: devel@edk2.groups.io
Cc: Sami Mujawar; ard.biesheuvel@arm.com; leif@nuviainc.com; lersek@redhat.com; Matteo.Carlini@arm.com; Ben.Adderson@arm.com; nd@arm.com
Subject: [EXTERNAL] [edk2-devel] [PATCH v5 14/15] .python/SpellCheck: Add 'XIPFLAGS' to "words" section

The EDKII Core CI reports spelling error for XIPFLAGS. The
XIPFLAGS are typically used to specify XIP options to the
compiler. e.g. GCC:*_*_*_CC_XIPFLAGS = -fno-jump-tables

Add 'XIPFLAGS' to "words" section in cspell.base.yaml file
to avoid spelling check error.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
---

Notes:
    v5:
     - No code changes, resending patch with v5 series.               [Sami]
       Ref: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F62162&amp;data=02%7C01%7CBret.Barkelew%40microsoft.com%7C09b7528fca35489670af08d867182f71%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637372700863446978&amp;sdata=VZm3wyCHnm9oV1HTuripLVGwPxvrLtmuXTDJk68ueCo%3D&amp;reserved=0

 .pytool/Plugin/SpellCheck/cspell.base.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.pytool/Plugin/SpellCheck/cspell.base.yaml b/.pytool/Plugin/SpellCheck/cspell.base.yaml
index 1ce5f6991104b83e41e769299b23cb3fa74c46e9..ad6f7ac06ad18efcd4ab9c2346356dfd6885d827 100644
--- a/.pytool/Plugin/SpellCheck/cspell.base.yaml
+++ b/.pytool/Plugin/SpellCheck/cspell.base.yaml
@@ -178,5 +178,6 @@
         "vcruntimed",
         "ucrtd",
         "msvcrtd",
+        "XIPFLAGS"
     ]
 }
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'