From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.96]) by mx.groups.io with SMTP id smtpd.web12.738.1602008325757760925 for ; Tue, 06 Oct 2020 11:18:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=dsh25yB4; spf=pass (domain: microsoft.com, ip: 40.107.243.96, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UP/O9iLKdaTRPHhffaM5Ds9Lrjmn3zXtgctKDzZncLXHbmCShUi1NoSi8tjpIClf/gJFuBFwFENRsfROfHGOvEjBQRmEqSmohmHWfG4TYsja5WgKQygYvAl2eAq2HrH4lrjSvQUTYufPNTc510GugDiK/WtoO4lKxCzTbIY5/dgfK7g8Clh7PCTbV+hTzf2hfezMih5ZiMHymgbnWYhebuyiTV2o8y/1wltXokyM2D1TcVRX4ArWRmvqiaXwZ9xT48UdjB3mEc3/LUAFVRPg5qCTo/emMdaqEmuslOYKjRxM0nwruSfRAUeRRJIcl5tvJ6PUKtexNcOu7AMwQDaxjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rtoP56JlstW0p9nXOoWlVcqooAWA6zo+loI6sSl//Yw=; b=dkC1udF8BPWz97JvR7POcTgE3Ys6cJTKeyLQSk4sVTIl8364D7XCbHitPpBWiCLjiRc25PuvArCoZMwszgbWwu/pdhaMI4OpYexWs1n/LhImtmqD2J0aaanp+p0iCyanpnZSz6vYZrU5yFADaCVMc47NUQLELxUJ3vuRJKH0PpO8S06WdF48kYASGN5GivvMINH2G+zwutYSQA3kVoAJKc/5r64mV4oKRSlnacgeewYNsYJdrtwXFkuExVO/BDW0EjRqi/pnUUQSiAyve0WpFWugIuWe5cUvd/B1zPUadUHfcmN/+CnB9i1mQxnaQKCQl3kz+kXJ3M7MiVaxYZuxcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rtoP56JlstW0p9nXOoWlVcqooAWA6zo+loI6sSl//Yw=; b=dsh25yB4yOb2D7AfMXEWBAcVpN8KlQ7X3PJQ6hd8DhUp+oWAdPPMMosrRx+JZuWkgT4riDQ2w+Px4g2LmShWPOC4eOBX44ECooSJLnKz2VKqAlv58ChrZWU87FKi14ParEMPVtqWua+ORgAwRVT2eiFZZHWednLpvfgF+nxnb84= Received: from MW4PR21MB1857.namprd21.prod.outlook.com (2603:10b6:303:74::12) by MWHPR21MB0509.namprd21.prod.outlook.com (2603:10b6:300:df::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.4; Tue, 6 Oct 2020 18:18:43 +0000 Received: from MW4PR21MB1857.namprd21.prod.outlook.com ([fe80::2967:7434:51bb:e234]) by MW4PR21MB1857.namprd21.prod.outlook.com ([fe80::2967:7434:51bb:e234%3]) with mapi id 15.20.3455.021; Tue, 6 Oct 2020 18:18:43 +0000 From: "Bret Barkelew" To: Sami Mujawar , "devel@edk2.groups.io" CC: Ard Biesheuvel , "leif@nuviainc.com" , "lersek@redhat.com" , Matteo Carlini , Ben Adderson , nd Subject: Re: [EXTERNAL] [edk2-devel] [PATCH v5 14/15] .python/SpellCheck: Add 'XIPFLAGS' to "words" section Thread-Topic: [EXTERNAL] [edk2-devel] [PATCH v5 14/15] .python/SpellCheck: Add 'XIPFLAGS' to "words" section Thread-Index: AQHWmQEOfMKA9sztAUyh2U/faDPyIamJgGQPgAC6dwCAAK0DxQ== Date: Tue, 6 Oct 2020 18:18:43 +0000 Message-ID: References: <20201002211409.43888-1-sami.mujawar@arm.com>,<20201002211409.43888-15-sami.mujawar@arm.com> , In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-10-05T20:50:46.9171461Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [174.21.66.203] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b8b77d81-08c7-4177-e3bd-08d86a244278 x-ms-traffictypediagnostic: MWHPR21MB0509: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WnRiZLN1+jLuzt3Dv+1NwVCQhz38qIrD712kHzQ/iw+u+ni27wLlXFGtF42GsJyES3gYI18fF1SH/9IJM/CEYrwZwP7tkvct41sJDMa1nZfGKwNnPjCHKm0PFeC2NFNXHoWP8/uwnB3syrCuQfznAOCRvG3Lb93rXcQ1cV/y2uBvHswNzzA/c6YT5DTvGj0clQBgM/Fyg5Gw5RuXwPpOfTdIes7ysSJfPdbv1PbgLB1361tzzBEsNP2xn5PzL/6dIiMOe3UD+7RUs6F/+ApwFHlovs+XHyUhO4lTCvg0n80NPqFz8S9Hcpl6TQmhG8IjlBXOWbAJ7JyZifhbXhHH5KI0iLtzYKW+sgfX5g3FTx/mW+c4HPOJhH5Ranc7JwhE6FIj1anejldtMGtStzTFnA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR21MB1857.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(396003)(366004)(346002)(376002)(54906003)(10290500003)(55016002)(66476007)(66446008)(9686003)(66556008)(5660300002)(64756008)(86362001)(26005)(966005)(83380400001)(53546011)(6506007)(166002)(7696005)(316002)(186003)(33656002)(478600001)(82950400001)(82960400001)(2906002)(66946007)(8936002)(8676002)(110136005)(76116006)(52536014)(71200400001)(8990500004)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: BUSXxN2KSWHLc5l+Sjy/PKZ651NAR+dF/5gClJ0d67Mskk+tpI1k3u/lHbknWJknvBVlRkpItndbt5Z0f9miYpixwk4FkeCLI2SwGlRzN/H6IN/Yu33YRGtAtO3qmlETXRoWt7BLvRpSPZFtKnSV3MI9lHdcPuhMN/GIDB/LTAyqv4lI5c5YdMWdYMXIuT8iLsQJiJiZuAUYU0q6s2RhKIJFCxOMomUQNCEQFdKJHmNFwx5Ah+ekHzT3V0D9EIWoazeDQAM87PTgUtR7yvfqE8PLvjFbDK4Jy37V2pAsKsdd9olckJwNM8EscIILbdFk90QI/IwyBXcsy49xP9ltEdK/3WXYULGHMHFiE+4GMYZwZCpdhubpUB+4XsT8yUGApeHIBXyZz0liI68vZFzlxifOL0r6rvwDkMhVe0/Q3KTCvG7R2Gr8yalueRSqt6YkR5OQedzbEE8SLUFfEM3dV6GncJbp0fpt/knpIg3ts5AlKPSu6ohEaewtOI0lmdAsGx3wBd9aDqu8ZvUDT/msCEfxx8h10tmKXGnrcbTxIz2ellLvx6FOnRDv4PVixJ9mve4TjX4yX31+K43Q8OJgA+quRntv6noxQsxfRWekDqkuzpXpRONstaSyuca1p4pneMA84k7VOI37FO6Zmo3wEA== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR21MB1857.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8b77d81-08c7-4177-e3bd-08d86a244278 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2020 18:18:43.7280 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6G5eCqM4NdAtGQYkvQQOr7Y2XhMXSUDsLNdmsvhoMd9jQD/tmJ3toqFt04x24TxkPbR9pMizMBnwe7AvPHQofQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0509 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR21MB1857ED0977D7368B415E814AEF0D0MW4PR21MB1857namp_" --_000_MW4PR21MB1857ED0977D7368B415E814AEF0D0MW4PR21MB1857namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable If it=92s only used in that package, I would suggest adding it to the Crypt= oPkg.ci.yaml file instead. If it=92s likely to be used in multiple packages= , the current patch looks good. - Bret From: Sami Mujawar Sent: Tuesday, October 6, 2020 12:58 AM To: Bret Barkelew; devel@edk2.groups.i= o Cc: Ard Biesheuvel; leif@nuviainc.com; lersek@redhat.com; Matteo C= arlini; Ben Adderson; nd Subject: RE: [EXTERNAL] [edk2-devel] [PATCH v5 14/15] .python/SpellCheck: = Add 'XIPFLAGS' to "words" section Hi Bret, Please find my response inline marked [SAMI]. Regards, Sami Mujawar From: Bret Barkelew Sent: 05 October 2020 09:51 PM To: devel@edk2.groups.io; Sami Mujawar Cc: Sami Mujawar ; Ard Biesheuvel ; leif@nuviainc.com; lersek@redhat.com; Matteo Carlini ; Ben Adderson ; nd Subject: RE: [EXTERNAL] [edk2-devel] [PATCH v5 14/15] .python/SpellCheck: = Add 'XIPFLAGS' to "words" section I=92m assuming this is used across multiple packages? [SAMI] This flag is also used in CryptoPkg\Library\OpensslLib. [/SAMI] If so, Reviewed-by: Bret Barkelew > - Bret From: Sami Mujawar via groups.io Sent: Friday, October 2, 2020 2:14 PM To: devel@edk2.groups.io Cc: Sami Mujawar; ard.biesheuvel@arm.com; leif@nuviainc.com; le= rsek@redhat.com; Matteo.Carlini@arm.com; Ben.Adderson@arm.com; n= d@arm.com Subject: [EXTERNAL] [edk2-devel] [PATCH v5 14/15] .python/SpellCheck: Add = 'XIPFLAGS' to "words" section The EDKII Core CI reports spelling error for XIPFLAGS. The XIPFLAGS are typically used to specify XIP options to the compiler. e.g. GCC:*_*_*_CC_XIPFLAGS =3D -fno-jump-tables Add 'XIPFLAGS' to "words" section in cspell.base.yaml file to avoid spelling check error. Signed-off-by: Sami Mujawar > Acked-by: Ard Biesheuvel > --- Notes: v5: - No code changes, resending patch with v5 series. [Sam= i] Ref: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A= %2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F62162&data=3D02%7C01%7CBre= t.Barkelew%40microsoft.com%7C09b7528fca35489670af08d867182f71%7C72f988bf86f= 141af91ab2d7cd011db47%7C1%7C0%7C637372700863446978&sdata=3DVZm3wyCHnm9o= V1HTuripLVGwPxvrLtmuXTDJk68ueCo%3D&reserved=3D0 .pytool/Plugin/SpellCheck/cspell.base.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.pytool/Plugin/SpellCheck/cspell.base.yaml b/.pytool/Plugin/S= pellCheck/cspell.base.yaml index 1ce5f6991104b83e41e769299b23cb3fa74c46e9..ad6f7ac06ad18efcd4ab9c2346= 356dfd6885d827 100644 --- a/.pytool/Plugin/SpellCheck/cspell.base.yaml +++ b/.pytool/Plugin/SpellCheck/cspell.base.yaml @@ -178,5 +178,6 @@ "vcruntimed", "ucrtd", "msvcrtd", + "XIPFLAGS" ] } -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' --_000_MW4PR21MB1857ED0977D7368B415E814AEF0D0MW4PR21MB1857namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

If it=92s only used in that package, I would sugges= t adding it to the CryptoPkg.ci.yaml file instead. If it=92s likely to be u= sed in multiple packages, the current patch looks good.

 

- Bret

 

From: Sami Mujawar
Sent: Tuesday, October 6, 2020 12:58 AM
To: Bret Barkelew; devel@edk2.groups.io
Cc: Ard Biesheuvel; <= a href=3D"mailto:leif@nuviainc.com"> leif@nuviainc.com; lersek@redhat.= com; Matteo Carlini; Ben Adderson; nd
Subject: RE: [EXTERNAL] [edk2-devel] [PATCH v5 14/15] .python/Spell= Check: Add 'XIPFLAGS' to "words" section

 

Hi Bret,

 

Please find my response inline marked [SAMI].

 

Regards,

 

Sami Mujawar

 

From: Bret Barkelew <Bret.Barkelew@micros= oft.com>
Sent: 05 October 2020 09:51 PM
To: devel@edk2.groups.io; Sami Mujawar <Sami.Mujawar@arm.com>=
Cc: Sami Mujawar <Sami.Mujawar@arm.com>; Ard Biesheuvel <A= rd.Biesheuvel@arm.com>; leif@nuviainc.com; lersek@redhat.com; Matteo Car= lini <Matteo.Carlini@arm.com>; Ben Adderson <Ben.Adderson@arm.com&= gt;; nd <nd@arm.com>
Subject: RE: [EXTERNAL] [edk2-devel] [PATCH v5 14/15] .python/Spell= Check: Add 'XIPFLAGS' to "words" section

 

I=92m assuming this is used across multiple package= s?

[SAMI] <= /span>This flag i= s also used in CryptoPkg\Library\OpensslLib. [/SAMI]

 

If so,

 

Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>

 

- Bret

 

From: Sami Mujawar via groups.io
Sent: Friday, October 2, 2020 2:14 PM
To: devel@edk2.groups.io
Cc: Sami Mujawar; ard.biesheuvel@arm.com; leif@nuvi= ainc.com; lersek@redhat.com; Matteo.Carlini@arm.com; Ben.Ad= derson@arm.com; nd@arm.com
Subject: [EXTERNAL] [edk2-devel] [PATCH v5 14/15] .python/SpellChec= k: Add 'XIPFLAGS' to "words" section

 

The EDKII Core CI re= ports spelling error for XIPFLAGS. The
XIPFLAGS are typically used to specify XIP options to the
compiler. e.g. GCC:*_*_*_CC_XIPFLAGS =3D -fno-jump-tables

Add 'XIPFLAGS' to "words" section in cspell.base.yaml file
to avoid spelling check error.

Signed-off-by: Sami Mujawar <sa= mi.mujawar@arm.com>
Acked-by: Ard Biesheuvel <ard= .biesheuvel@arm.com>
---

Notes:
    v5:
     - No code changes, resending patch with v5 series= .            &n= bsp;  [Sami]
       Ref: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk2.g= roups.io%2Fg%2Fdevel%2Fmessage%2F62162&amp;data=3D02%7C01%7CBret.Barkel= ew%40microsoft.com%7C09b7528fca35489670af08d867182f71%7C72f988bf86f141af91a= b2d7cd011db47%7C1%7C0%7C637372700863446978&amp;sdata=3DVZm3wyCHnm9oV1HT= uripLVGwPxvrLtmuXTDJk68ueCo%3D&amp;reserved=3D0

 .pytool/Plugin/SpellCheck/cspell.base.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.pytool/Plugin/SpellCheck/cspell.base.yaml b/.pytool/Plugin/S= pellCheck/cspell.base.yaml
index 1ce5f6991104b83e41e769299b23cb3fa74c46e9..ad6f7ac06ad18efcd4ab9c2346= 356dfd6885d827 100644
--- a/.pytool/Plugin/SpellCheck/cspell.base.yaml
+++ b/.pytool/Plugin/SpellCheck/cspell.base.yaml
@@ -178,5 +178,6 @@
         "vcruntimed",          "ucrtd",
         "msvcrtd",
+        "XIPFLAGS"
     ]
 }
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



 

 

--_000_MW4PR21MB1857ED0977D7368B415E814AEF0D0MW4PR21MB1857namp_--