From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.129]) by mx.groups.io with SMTP id smtpd.web09.3688.1616707197877761817 for ; Thu, 25 Mar 2021 14:19:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=FxFqcrLZ; spf=pass (domain: microsoft.com, ip: 40.107.236.129, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NF06uWmfzTWWvOyUp2nOM4wdOTLYUJnjy8CHtTjiKmf3eQgxe4TgP9nMllcBsywh+d8RpWrLJDQV3ChQkXlM/T5O+mP2oAmZTAO9q7NxCFz8LDXqgiLqXDE1kX19eQcEGyiA47UFNVbLCc/HdyYu5/0w0zW9Anrfg3b5k0vjQcJ/zpVzhibe89vEjeHicj6xvPs5f9v504LmX2pLZXLer5WG6tISCugO8/aLomp3cklQstdlw8Pc5Cpi3L1Z2zPAEdG1WXUse0StUtDT2DcBTo5LCBMcFnj1dChY6fUGDnuSYbNtQS0o8e/cMu8UF2vIFL4V/3AT0pg032XfQPVzPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7ktC8tNBLDRCVOjt0eSLPPJtJnx4GdyWfyc0lhjQO64=; b=YCS9cOM5doIqwiiS/wEqQ5KLc9zJQH40D2X439/U7jSEg+lbD0WtixUjgPmwb72sDMFHpsMQrOhnIynTWF4b3cAcbLQCVLwFdGYZOOh3L6ZwbhskfPMXfVAvB92bbp07ams9D5rKJ7YQh8XCqotexRcTa6BTTsUAArOSt9o0vLefHkWFm71kw6tBxD1Wh+ohqtdgJjCujQgz06tRuApztNw8ARqd8u3cMOTKhRcgXyxoV2Q4FwT2E8VIjcoB7XgrOXMkdG+dZaeS7j1yMXhFUJ2wBMzsuY3VcjZKzdOdEoGYVBCozym43VVaogr63x/TdD49Ytg0T1LphEgxHCAKOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7ktC8tNBLDRCVOjt0eSLPPJtJnx4GdyWfyc0lhjQO64=; b=FxFqcrLZ5ptpldueoTPJqanOgWwn4PQuUePZPpfnUvEEn8UajGPfpp9lsn/yu2dBzgbImhM/AP4hphd9mYa2JM7pLwwENcJaTCKcAfqIeqZoDDVWX+32AZLOkEIUVzmZca43f8bvqsx8+9wUis8SwKOiJ0DNTwiEh7A61sQJkr8= Received: from MW4PR21MB1907.namprd21.prod.outlook.com (2603:10b6:303:71::8) by MW2PR2101MB0923.namprd21.prod.outlook.com (2603:10b6:302:10::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.13; Thu, 25 Mar 2021 21:19:54 +0000 Received: from MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::adcb:b821:ee26:3348]) by MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::adcb:b821:ee26:3348%8]) with mapi id 15.20.3999.016; Thu, 25 Mar 2021 21:19:54 +0000 From: "Bret Barkelew" To: Laszlo Ersek CC: "devel@edk2.groups.io" , "mw@semihalf.com" Subject: Re: [EXTERNAL] Re: [edk2-devel] !!! DEPRECATED INTERFACE !!! VariableLockRequestToLock Thread-Topic: [EXTERNAL] Re: [edk2-devel] !!! DEPRECATED INTERFACE !!! VariableLockRequestToLock Thread-Index: AQHXIams0/gn8xdj3EuGiNu6/GVylKqVM7x4 Date: Thu, 25 Mar 2021 21:19:54 +0000 Message-ID: References: ,<6f7006b5-edf3-6caf-cb4b-68f95ece0fd0@redhat.com> In-Reply-To: <6f7006b5-edf3-6caf-cb4b-68f95ece0fd0@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-03-25T21:12:14.7919843Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [71.212.153.143] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 3a6cacfa-9171-46ab-4683-08d8efd3bc41 x-ms-traffictypediagnostic: MW2PR2101MB0923: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vwrBSf067eVY6d4KG7TahjJKBgk6BWjfGziLpHbPYyjset+aIB9y/9OHl9yVpE1Y4cWVAuulHmFxuzE5v0MgFsGelktSIP2BiXn7+O54bQyLYnmhWAVsgU9h/mZ7Ap19gJGs0SqJvNTa3738Ii13dL9VXZvXBVOCc1Ipp2f46aFc05UtwPamqGLcx6YRLoClo7yQWkTC74oP95gQvh9hNbHQsZqapmlg+RZwnMtxUOjUYtX5tQ8R7DI0TcbR74VnxG/aLQJKX7S8Evt7iUp4jzGO9jilkawDKmTUc+HYD0GPyQsN0Prd84I61p3DkIX+KkNz2p8Pym9R46gmSmtAKAYYhMUwTPkIOGprM+i76X4sPF8ohiCRQdjM53HLkHcSl9GVu1vSZVdhDIDqbK9wn6RJNMVczPu4vtPkQize/L39K4s7YqgnGoTC8pB2JJGfDiBx1JSElWBTaPp5aQlorEt2+/Rk6AIfRjuX8a5v/n2zAbb+GMEmorJXb7x/AUofniRH+kIXzrobllvLxxsdGNQlZYvfEJ3h2NMlSZE+1wlqnOQ76yrc4xdSDBk2n+U54zOdoHXh1uiwEb8PZ7numdP0G11hmfIFEiM7B2XvdqgAfGhs6JT50N4GWTo6U7pJYi5k7NiVOEZKq56Yf2UdgGBfI8r7ovhTZwd7H7KCK6bEFHIkauwj/jdZy9aeBdg/IdMlq2iZg5hXnm9UPLrSgHj4UA1a8ywTMKQmDwasxX+uZsZrQdaL2XBxKMDtv0Xg x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR21MB1907.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(136003)(366004)(396003)(376002)(39860400002)(346002)(7696005)(966005)(71200400001)(26005)(166002)(66946007)(76116006)(4326008)(186003)(66446008)(38100700001)(82950400001)(82960400001)(64756008)(83380400001)(53546011)(52536014)(6506007)(2906002)(55016002)(316002)(10290500003)(8676002)(5660300002)(86362001)(8990500004)(33656002)(54906003)(478600001)(66476007)(8936002)(6916009)(84040400003)(9686003)(66556008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?Windows-1252?Q?upHeCZXoBYFhVlQm1RMbRrtIFgG6fCGFwDG57AVg3VCejCBbdGvmxU7a?= =?Windows-1252?Q?QL25lCJyPW3aEUTgc/X3n3WKzIvRQVbWF3PZtHvXhz756MM4qSeSX4Rz?= =?Windows-1252?Q?BdcGcd8DDAyqCF4YDTk63qdkZ4Hc0W7G6QWxtG7CPcBXmFvFNdAzUkkz?= =?Windows-1252?Q?lrpfxdBh430pdPi+RUMB7xrvPkrobN0LfyI+5IZy31Fox3IkOHjMHpjW?= =?Windows-1252?Q?mR1SyR+KqORlzP4EfGkYFIE+UMk/XIPr4HcKHS6hflyYvAEBPEhy+gCy?= =?Windows-1252?Q?/Eu2c09AlGA5KNTabgTh3DM5AEmi5BfLntxT/zj5yaU4zv1nYlxjI2gJ?= =?Windows-1252?Q?snqzJlllG/AFPzTEpCcH/S6f+U8gTb2JreargV59g1UrtdW4/bzgNgC2?= =?Windows-1252?Q?p3+nAcys2PwTUt9rZjES0ZRpFPu0hEXhx0ekTqui9sH6g//dmjeaATIJ?= =?Windows-1252?Q?VsYo0m8JVHeaHOFElVvJqGYXjOY2QQhiTAN/GuKxy7w4TbMIG3a24AHQ?= =?Windows-1252?Q?+K6a5NMlPWu/iDw8hnFwjGrkTL7MryQVHikij2vtw3JlbewdBQ9AH/5N?= =?Windows-1252?Q?pcO1VmhAMtxJL+fA93LgVNE+5ESc7bUFFrAdc6punw1GawR38nF3idZd?= =?Windows-1252?Q?/1TKvSMmcQhKA7glHfvD6yq1KYPkePUUbj6sSKNluF3aJozYHpPA8DbU?= =?Windows-1252?Q?69rR3zCbJ+QUKfHpkn9IcM/xN7lvY0kP/U13LRlkhnGPCMUQsyWnJSXm?= =?Windows-1252?Q?s+1k49pMjSjH+CtLUjhilv2AL63c1eydbyCl/L2sdwmkKABicmrCKTsj?= =?Windows-1252?Q?snyqRp0bKqoCA1d9M4i2wwRdiwd//qxQnTeFQY/lzwd6cMhn2/nu0/Nf?= =?Windows-1252?Q?VSP+TLraYH37JRkCA3yZ3EkeE0C+Eiw1UJikuMyUd4N3aKAck7gaBA9D?= =?Windows-1252?Q?RRlaP0cIOrc47JXLD/Mjw486qjrVbXSn6NPV+gDP4Tq+5GjZSeFjy5sQ?= =?Windows-1252?Q?HialJqPZKZxPRxpDZW7zXKDjw2xx5w6s6uVcfxOthM7Ztfu/7BQ6RHsg?= =?Windows-1252?Q?QtNzV8R+6tSOx8T0vg7EUppIgrbTjNph2j9DnF8nikbhDj3On0JU7/5O?= =?Windows-1252?Q?4BmrIho+LIIieKWrE7hGsRmMQwzubSyypVRXRMk7z4UoztzcOtrtB3ld?= =?Windows-1252?Q?qfoHQ7NY7QLvtGOob6M2qB2XQOLolaVX+AiAgZ851aAwE/1Qyt+wyO2V?= =?Windows-1252?Q?BtNCggpu8vpPdU29wV2eiBkIhgB8DEkbDeVUSEYMmxl9zLsNUSW+Qhfe?= =?Windows-1252?Q?81ntmCKpKrVO+m+eNFBMCzRPrawExGOG1hZqt/QQ7cL5IfzowTmN2XuF?= =?Windows-1252?Q?Q0Cwclao50JyDWCg3/Pdn4a/CbSmaLLZnxQ15hZ6o5Vntv+frYjRv+CG?= =?Windows-1252?Q?mfbsqIIApCTQAcnq/5Bu+g=3D=3D?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR21MB1907.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a6cacfa-9171-46ab-4683-08d8efd3bc41 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2021 21:19:54.7531 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0mUYfMvSaQUXfyyrcB5gee3K38ayjwgm0Q7L+PFgegYdMnYDjzVv0Rye0QYqKntyFvLpvdfdxzxQqDNp96pbLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB0923 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR21MB190705ABEB4C79FAEE4A6BCCEF629MW4PR21MB1907namp_" --_000_MW4PR21MB190705ABEB4C79FAEE4A6BCCEF629MW4PR21MB1907namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Yes, this is expected behavior. The messages are to encourage code owners t= o move from using the VariableLockRequestToLock() interface to the Variable= Policy interface so that the RTL interface may be removed in the future. The correct solution is to find the offending code and submit a patch that= updates it to not use RTL. My guess is that this is the location that you= =92re hitting, if you=92re using the edk2 BdsDxe: https://github.com/tianocore/edk2/blob/4bf2a5b045ebf8b5e90d9210ad5190699bd= db592/MdeModulePkg/Universal/BdsDxe/BdsEntry.c#L723 I can try to submit a patch next week (I=92m slammed this week) to port th= is over to VariablePolicy. Note, however, that the messages are not affecting the functionality. They= = =92re purely nag messages. - Bret From: Laszlo Ersek Sent: Thursday, March 25, 2021 12:04 PM To: Bret Barkelew Cc: devel@edk2.groups.io; mw@semihalf.com Subject: [EXTERNAL] Re: [edk2-devel] !!! DEPRECATED INTERFACE !!! Variable= LockRequestToLock Hi Bret, can you help Marcin please? Thanks Laszlo On 03/25/21 10:19, Marcin Wojtas wrote: > Hi, > > When booting the latest edk2 on Marvell SoCs I get a number of prints as > below: > > !!! DEPRECATED INTERFACE !!! VariableLockRequestToLock() will go away so= on! > !!! DEPRECATED INTERFACE !!! Please move to use Variable Policy! > !!! DEPRECATED INTERFACE !!! Variable: 8BE4DF61-93CA-11D2-AA0D-00E098032= B8C > PlatformLangCodes > !!! DEPRECATED INTERFACE !!! VariableLockRequestToLock() will go away so= on! > !!! DEPRECATED INTERFACE !!! Please move to use Variable Policy! > !!! DEPRECATED INTERFACE !!! Variable: 8BE4DF61-93CA-11D2-AA0D-00E098032= B8C > LangCodes > ... > > I cleared variable storage, looked into code, compared VariablePolicy > library resolution to other platforms (it looks the same and was updated > along with all others in > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgith= ub.com%2Ftianocore%2Fedk2-platforms%2Fcommit%2F8034e3b2ae9470adb&data= =3D04%7C01%7Cbret.barkelew%40microsoft.com%7C98c3d9be0b2c4654874d08d8efc0c= db5%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637522958656548916%7CUnkno= wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC= I6Mn0%3D%7C1000&sdata=3DmwHi%2BAwmh5rh%2BAfdXBBx0ZXobV1bT1%2Bsi8%2BpcLx= VNsQ%3D&reserved=3D0), but > still don't see, how to get rid of those. > > Is it expected behavior? Any suggestions how to properly remove those > messages? > > Best regards, > Marcin > > >=20 > > > --_000_MW4PR21MB190705ABEB4C79FAEE4A6BCCEF629MW4PR21MB1907namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

Yes, this is expected behavior. The messages are to= encourage code owners to move from using the VariableLockRequestToLock() i= nterface to the VariablePolicy interface so that the RTL interface may be r= emoved in the future.

 

The correct solution is to find the offending code = and submit a patch that updates it to not use RTL. My guess is that this is= the location that you=92re hitting, if you=92re using the edk2 BdsDxe:

https://github.com/tianocore/edk2/blob/4bf2a5b045ebf8b5e90d9210= ad5190699bddb592/MdeModulePkg/Universal/BdsDxe/BdsEntry.c#L723

 

I can try to submit a patch next week (I=92m slamme= d this week) to port this over to VariablePolicy.

Note, however, that the messages are not affecting = the functionality. They=92re purely nag messages.

 

- Bret

 

From: Laszlo Ersek
Sent: Thursday, March 25, 2021 12:04 PM
To: Bret Barkelew
Cc: devel@edk2.groups.io; mw@semihalf.com
Subject: [EXTERNAL] Re: [edk2-devel] !!! DEPRECATED INTERFACE !!! V= ariableLockRequestToLock

 

Hi Bret,

can you help Marcin please?

Thanks
Laszlo

On 03/25/21 10:19, Marcin Wojtas wrote:
> Hi,
>
> When booting the latest edk2 on Marvell SoCs I get a number of prints= as
> below:
>
> !!! DEPRECATED INTERFACE !!! VariableLockRequestToLock() will go away= soon!
> !!! DEPRECATED INTERFACE !!! Please move to use Variable Policy!
> !!! DEPRECATED INTERFACE !!! Variable: 8BE4DF61-93CA-11D2-AA0D-00E098= 032B8C
> PlatformLangCodes
> !!! DEPRECATED INTERFACE !!! VariableLockRequestToLock() will go away= soon!
> !!! DEPRECATED INTERFACE !!! Please move to use Variable Policy!
> !!! DEPRECATED INTERFACE !!! Variable: 8BE4DF61-93CA-11D2-AA0D-00E098= 032B8C
> LangCodes
> ...
>
> I cleared variable storage, looked into code, compared VariablePolicy=
> library resolution to other platforms (it looks the same and was upda= ted
> along with all others in
> https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub= .com%2Ftianocore%2Fedk2-platforms%2Fcommit%2F8034e3b2ae9470adb&amp;data= = =3D04%7C01%7Cbret.barkelew%40microsoft.com%7C98c3d9be0b2c4654874d08d8efc0c= db5%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637522958656548916%7CUnkno= wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC= I6Mn0%3D%7C1000&amp;sdata=3DmwHi%2BAwmh5rh%2BAfdXBBx0ZXobV1bT1%2Bsi8%2B= pcLxVNsQ%3D&amp;reserved=3D0), but
> still don't see, how to get rid of those.
>
> Is it expected behavior? Any suggestions how to properly remove those=
> messages?
>
> Best regards,
> Marcin
>
>
>
>
>
>

 

--_000_MW4PR21MB190705ABEB4C79FAEE4A6BCCEF629MW4PR21MB1907namp_--