From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.110]) by mx.groups.io with SMTP id smtpd.web12.6818.1619753619253948375 for ; Thu, 29 Apr 2021 20:33:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=Ju4bW0p/; spf=pass (domain: microsoft.com, ip: 40.107.244.110, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Am8zX+VK7a2qUZ9qZJNzPuFXw3sKw6FalxTc63lJPlz63R+vsGnK3AIVfM4lDpXAGP7cpboj28Zcx8rI62EnSZC/d+a5EWZy8h0m5vbkOo+OUMNTrSJlH7EEyi8Va6cgVBrWEPDaq2QjaUt/ORWQFGbijVPoeQXBfSqw9k3XpENha1fCjtXbb50qsOlNTkCfu5kr7MTSAKyLIVGP1f0PIHhCl6gwnkMP/eLn9pcWrqXjcpyjvXjL9zQroIxf9n3pXuAHfawigaSuuMUZ1dIBh0mig4JnKyFNb88BVhzFdqoUUtc3GcA+p9Mdg0kX7FvC/CHHi7dft6QROSIJQNrJmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WiMVJScHyekarObF4tF7mvbkP9sYYsQSwyygaZ8CwIA=; b=KGlNcrHNIitReprqRF3to2FRsCV0ZK0dcW9r34sFqkntsi5hAEIY+esgJTYwEV/VxDZpzYVdjL969rVEW2ge1jT82stTVJqjssuiTYiGqsKCc7wtLNy63d0STIjI0SA/j4V4uQBDDaogZogtfYJu8GH+jWEwuegkE45jygm2Pr7RABo/PKc2ilR4TjSMRV91JrnMe4sG+WCrfcAs8JJaKQZeK624hphi8AOjun/GouOvoPtY1g6fZLVD5HZ2PemhEyg1i/yNhJdiv9O/FgZQvIhEnJg3O4AmFZCV22krL1uw1rAhxNXcp0PaTTKWTwVt9MHKWMQbgbmR6Mw6eNuuow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WiMVJScHyekarObF4tF7mvbkP9sYYsQSwyygaZ8CwIA=; b=Ju4bW0p/13HgX4NLMNc/JQufr8ewG2uT2C4yu879b1H+xF00ozTqb7GReDjOW+2xt37PCRJjqqy/2KUreaC3651L5UhB5KOuS1U1DA2bPMU1byBwwQ5uJ3zejbg7qaY6tde9XIsDypoWL7ZQ65a8VVZ/nJ0U10NAlYKgJx4pk7I= Received: from MW4PR21MB1907.namprd21.prod.outlook.com (2603:10b6:303:71::8) by MW4PR21MB1892.namprd21.prod.outlook.com (2603:10b6:303:78::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.1; Fri, 30 Apr 2021 03:33:38 +0000 Received: from MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::adcb:b821:ee26:3348]) by MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::adcb:b821:ee26:3348%8]) with mapi id 15.20.4108.016; Fri, 30 Apr 2021 03:33:38 +0000 From: "Bret Barkelew" To: Getnat Ejigu , "devel@edk2.groups.io" CC: "Kinney, Michael D" , Sean Brogan Subject: Re: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU Thread-Topic: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU Thread-Index: AQHXPR8zRUpGAoU+zUOjAh8NVZaKDarMaLeZ Date: Fri, 30 Apr 2021 03:33:38 +0000 Message-ID: References: <20210429174330.649415-1-getnatejigu@gmail.com>,<20210429174330.649415-2-getnatejigu@gmail.com> In-Reply-To: <20210429174330.649415-2-getnatejigu@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-04-30T03:32:43.1447336Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [174.21.95.19] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 66b5f7bc-339a-4052-03ae-08d90b88be1b x-ms-traffictypediagnostic: MW4PR21MB1892: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2089; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: D+FIMED1vBhR6A4EUSxVhdhGeE0S+zl3HtQ1NLnfyX67llxJ0861VDFX/o+mDF/kmYHgHj69zzvwSJM+5kgXW9CL3z4OkXaMJxyG6ZNcnQ0z9P37BZF2BYC8QQY2ITuY+eT4RKikIGLMdB7wo/hMZ8f6JOepU40CuNRswb3k5IUCNkzFsUpWwyjxuNfeQeXKFnMCWFXQ9HCTK+dRVJ83NCAz8vL2DBtA4tGR69OnJ4K0RbOqF+Zy3UdIlVmBr9tXGtdX2ADhsxI++elcY1YunkH/QgHJaNRiC586Zg3O4wxnuS1Zcfv/FzT4InxVQ3ByPAbmcNfRkrzCIPevkrQXxT9qi4sjik7iEIBd4tKO8g21efASU8dy0hRF3P1o1Qd8mE69AIvPgtcHQZMAf5zpvAtlldZfDWBW80F4SVgyvcjuIKR7oAbc2Q+CIpugFrBjHwRwPAjmw70iijmdA+OwwDI/gE2jG/L6JB2mCy6dRHQK4U5ba87nV/rmuLx1p7rXCjHFx9Ewg59thT1p4uLvKpjrjNqvmyNg/pSCsDcEo7KGl0d0RPFpu1F38fYJHVZHfvqzWtW5nhj6yFMni7sT3r495EbrQcuVI07PBuAQcVs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR21MB1907.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8990500004)(5660300002)(2906002)(478600001)(10290500003)(66946007)(86362001)(66476007)(66556008)(64756008)(66446008)(53546011)(76116006)(52536014)(6506007)(71200400001)(7696005)(82960400001)(110136005)(54906003)(82950400001)(316002)(186003)(38100700002)(33656002)(4326008)(8676002)(122000001)(26005)(107886003)(55016002)(9686003)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 2 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OZ5Ft6KsfeLeoYThAZWDfYiTfMFeS0SCVhKg+jZgH14VnN7RlP6613DrV69C?= =?us-ascii?Q?EUxovDcPredTaTABzE12SCOS5yU353YqH8M5TohOyBvYPpO0DSbOrRZRpAtc?= =?us-ascii?Q?B/VCdTkSXNSMzJnQT3PiS44IppJMpieLkUKGyYpSRW8V4PtD1ZCaqTUza2rN?= =?us-ascii?Q?c4pOsN9yK+2hNWV0LTm11ZfVRUZAuPUA6m1P6PGT/61oM3zJ2zHOomSxd2aW?= =?us-ascii?Q?uI/Xs2xZ27Xm6+g7TBs8GzvYfWYv9Inv+BCiCJvhSYGaA90f2Ndk2UVCCywt?= =?us-ascii?Q?/MLr4YsZHrWDGyAby48eeGGYrmw+IBnQjM9VJAUqLtHBGjLhbBE6eCo9HYrU?= =?us-ascii?Q?UnhtcNbSHoh6Fnx8Y76j9wED4bPb1Tt/8xCBKMV2eGw8H+EVdA+SEKn5n/7s?= =?us-ascii?Q?qLBhIOhHzh8bzknT03WiwThgiaF53wGKS+E7+BOEMiuKTdfJg4Lqjm88qrqh?= =?us-ascii?Q?xy0ui2PA1Kv/PNMTUMqBlYSPSDKn+af4H8R7t39EMDPZZCYww4quNUax8sGO?= =?us-ascii?Q?WpEKMPLlMsAt6Hpt2gFq/C4R8BvzhMHp3coLVkGJ2wxCld42hHIW6E0C25bc?= =?us-ascii?Q?wv+/2XrYXZu7crPnGnNThf4bZ2k9hKi65phHcTw4jd6rjDjc1c/R16zIZU0V?= =?us-ascii?Q?Ju0bmSndFetm9dNCmBPE34oQLP2H2EoLVaHrPjPfA6FZioGofKiNnzUOuuwr?= =?us-ascii?Q?zcKheZHSSROBwbzBq71Jn94mQXlTOW4CoTxTaQ6TPnfWmZZ3oRlJZDCeHhEA?= =?us-ascii?Q?6okq5hIqw1gPfOsGqmMcL/lN7itE8AapGOIoR4VEWgTrMWxTmspumUyuMpa7?= =?us-ascii?Q?xVRW4gQENHTZLr5VNvyGOeQ+4WN8WfGMa3ndsKmgpe0af+iDTehe3oa2DA2p?= =?us-ascii?Q?3Fcu/AIpifG1/7kEQPSvvHroXzYdUcEWSHCVvXX/R06pqUw5lB0tKwscCBcp?= =?us-ascii?Q?XjDqh3FtuYgU5IiII60MLb0Jjrx8/ULBmAKgYgWb?= x-ms-exchange-antispam-messagedata-1: tvJNC4Sw5dDSfEUNH6+NJnY2BK0y50MKQms2lDGCDui+QGDWZcM614TevKtgCwCaof7s/4Wk+gmTSeFoybG031VC2E4jDdDKPT0sHTMt6H62qI6Evzi9u5g92DyyD1SJV4UNCglCbaJ+71XwW/UdnATOrYVTns5Fi+hYIVinyNw5h3/0VyBKmDPnrZpk6ZjzAJ9gXTq1v5XSIUbS/8EgZYfcKLJEiWDJat+qqyt4tr6etAfjEFgzLuySz+kfBseiPK+VP4lz+GYDdaejgdEbOJ3nRcfzR+IDZV39o+wgFXghRBjIBqz27kbNn3Ns9nU1jK/XE3PNdpP1ItWEoCjo+ZqzpvHFzD+4JdJvhPV+qjUe1Q== MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR21MB1907.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66b5f7bc-339a-4052-03ae-08d90b88be1b X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2021 03:33:38.1031 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /K+giVsuB86Aa8brJeo1Iojfzc1VxZAl0mQKVaYk0INLzsJJNO8LGjXtgITxBqtKJFAz5rFzxJhY9JAFi4Q9fg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR21MB1892 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR21MB19071624635CE31EC2F48C35EF5E9MW4PR21MB1907namp_" --_000_MW4PR21MB19071624635CE31EC2F48C35EF5E9MW4PR21MB1907namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This change should also be made in: UnitTestFrameworkPkg\Library\UnitTestResultReportLib\UnitTestResultReportLi= bDebugLib.c UnitTestFrameworkPkg\Library\UnitTestResultReportLib\UnitTestResultReportLi= b.c (for the prototype) - Bret From: Getnat Ejigu Sent: Thursday, April 29, 2021 10:43 AM To: devel@edk2.groups.io Cc: Kinney, Michael D; Sean Brogan; Bret Barkelew Subject: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test h= angs when running in OVMF/QEMU Sample unit tests in UnitTestFrameworkPkg hangs when running in OVMF/QEMU environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI to ReportPrint() function that use VA_ARGS. Signed-off-by: Getnat Ejigu Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew --- UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportL= ibConOut.c | 1 + 1 file changed, 1 insertion(+) diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestR= esultReportLibConOut.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportL= ib/UnitTestResultReportLibConOut.c index cfb0c5972bd1..db5402d6a210 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLibConOut.c +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLibConOut.c @@ -12,6 +12,7 @@ #include VOID +EFIAPI ReportPrint ( IN CONST CHAR8 *Format, ... -- 2.25.1 --_000_MW4PR21MB19071624635CE31EC2F48C35EF5E9MW4PR21MB1907namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

This change should also be made in:

UnitTestFrameworkPkg\Library\UnitTestResultReportLib= \UnitTestResultReportLibDebugLib.c

UnitTestFrameworkPkg\Library\UnitTestResultReportLib= \UnitTestResultReportLib.c (for the prototype)

 

- Bret

 

From: Getnat Ejigu
Sent: Thursday, April 29, 2021 10:43 AM
To: devel@edk2.groups.io=
Cc: Kinney, Michael D<= /a>; Sean Brogan; Bret Barkel= ew
Subject: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit= test hangs when running in OVMF/QEMU

 

Sample unit tests in = UnitTestFrameworkPkg hangs when running in OVMF/QEMU
environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI to ReportPrint() function that use VA_ARGS.

Signed-off-by: Getnat Ejigu <getnatejigu@gmail.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
 UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLibConOut.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestR= esultReportLibConOut.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportL= ib/UnitTestResultReportLibConOut.c
index cfb0c5972bd1..db5402d6a210 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLibConOut.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLibConOut.c
@@ -12,6 +12,7 @@
 #include <Library/DebugLib.h>

 

 VOID

+EFIAPI

 ReportPrint (

   IN CONST CHAR8  *Format,

   ...

--
2.25.1

 

--_000_MW4PR21MB19071624635CE31EC2F48C35EF5E9MW4PR21MB1907namp_--