From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.124]) by mx.groups.io with SMTP id smtpd.web08.7622.1628006010286095698 for ; Tue, 03 Aug 2021 08:53:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=cO4A6ggK; spf=pass (domain: microsoft.com, ip: 40.107.223.124, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EhSEJ0KG7TCG3Jludew/3sbXp3m1QhCZKMQ6HDTsfng5KWyQZEptAQVUBXkeL/II4BZ3z6d7vxewim/DEofPH+sh2bwMthbNP6y9wpdRJLiti6CUSV2wYfTLhqIOWOQmvJ09Q/5brbY5A4ncMYD/XURY+5a8N/NVOPY3nLQ3CD9Ce0Zhp5SUiwsbRNgylgIyKO7YeIbFODpa4VilEeatxsFyXeiQ2M5AluAkSWMW5JFadAlSGNZrtqe/GIplHVj4sDT2fnte5R/RRwHqsxFwir8b0Dv3QX0DH/MzNa1YwSfZ5kYGvJKBLLt2mm5uOQE58TVX8vd9+WpiBN5IFIXeJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mS0ZqgGMYpqa914KBVmOQHt75K7dq1Lx/o1V1iXuNPk=; b=QLHPPTnIIDRyHGG/X2vM524IZuZ1VCx7H4NRk42vJ9kpOsT0XslIfGiuSmnvyHuijgsjDcbQ8cou5HXY3ulAHmvuCpAFXFEQGzEqgG6QNXTOyEHDV5iF88pNLTYFHnD8bfrj63bA9zjLhigaIZhV4T/DmgUEl5RNIWmbsbok06mDlT/mF6KX9gyhAQ0J1iA8IvrE+QngDK4qxI18V1DoPqK7D7vxdsTCw3j5jYvou6s3ea7ZZX+G47QuFp8udcKeOkNYK8/05kbjt1nHast/EcP7Vgw+/lU8VoIbf9qTSeiwhzFvJzGvpnaDOy7U1WyjNYDqr8ujC9OrPlOaHIJJGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mS0ZqgGMYpqa914KBVmOQHt75K7dq1Lx/o1V1iXuNPk=; b=cO4A6ggKSG92tkgWJrCx17WrFBkWcZSY3BzQ2lP37E+jPALaCxWDTEaeatUB7Wxbsk0u7+nBi3Dibt9YM7XPikUXthzK96Gj7sy1JT4oscrY7aPUj6hJGM5rztbDpMlUfe0b0RVwaPOE8TCOPGOOOcfsrUnZ7yORFzuSRpW8zEM= Received: from MW4PR21MB1907.namprd21.prod.outlook.com (2603:10b6:303:71::8) by MW4PR21MB1940.namprd21.prod.outlook.com (2603:10b6:303:72::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.2; Tue, 3 Aug 2021 15:53:26 +0000 Received: from MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::6877:2031:ebb9:6a5f]) by MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::6877:2031:ebb9:6a5f%3]) with mapi id 15.20.4415.002; Tue, 3 Aug 2021 15:53:26 +0000 From: "Bret Barkelew" To: "devel@edk2.groups.io" , Samer El-Haj-Mahmoud , "Nelson, Eric" , G Edhaya Chandran , "gaojie@byosoft.com.cn" , "Kinney, Michael D" CC: Samer El-Haj-Mahmoud Subject: Re: Proposing a new area of the edk2-test repository Thread-Topic: Proposing a new area of the edk2-test repository Thread-Index: AddhbD/jx+sU+OEET2KEtVurFZp1QgAMtQmQAB1RQDABk5dlwAADbvTAAAGI+IAADovgLQMTMe5wA7j5TkABIc3nUAAFwKRO Date: Tue, 3 Aug 2021 15:53:26 +0000 Message-ID: References: , In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-06-24T04:24:07.1039521Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 058e8573-d48b-4641-7fb5-08d95696d4b3 x-ms-traffictypediagnostic: MW4PR21MB1940: x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PigBXC7p8G1QMC586HhPKy6AoaC1L5cY2KgBvynIIJxwfOdAQYK7XydM3D9SvwV7ZNPU9GKWJ8EvhRdF0fQpw6NY8IaxKO9huhZg+US5D/7TKtpY+kxHHHSvINtPmMRma7gSiEFYsvHje70U+MbRFlEB196S95ny/iC0IyNwhirYzYeTBf1wIXBIaaK4C/i+zcTorWFyJ2o2gHlr4kjk64hqyDbvNeNBL1vbAjnfy7piksnDj5ixKF8WM1pThAuPgzvFPqtHSPHCoVzy1YzGF9qvL5OoscofQdUIA9r/cGBVudjwi+gdcLcqMz8EOtaKOMq+twNGDVVP7fO6WDx7nfifmPtpTGUHjan4m1bw7zq+NNNYXNaXgpkMJOUUVHzNSOaU933odoJ0L+iaSNJouJJx23ocA8Vu2HoiwIUdYInekv0ka8VfUh1xoPoRaVo08mxqWefxISXT9upNMyGW+TRb/q4NZMnSYMmv+UEAI9x2dILgjB/RH50TtWRuQ5qQxuJSjFJFoycffOm3jp+R///4lEvvJps3ICIQxpG2/qRDqgyAhpw8XLmVHTNfgRRoN/iH2xORXegtN8E6dHFVZAFosHVUWWchCFws+qFih4qA+56noHHgnCqKw3W7LI4kKxCBfEuHFxdC4EDgMLw5MQAVoAJx4eZstePU6kgNBbvUIn/+jUS7YGvgLBWFcnXuwg0JbWpUAKPD+IVE8wkWzDxMF41bZjw+Xglal0+2kaNrr2RRS8iSnfL4rZb8C48m99U6lsz8ajLcf8IKOjktlOyeh6JfnNF4mPJHaHSB/nODMgsBCuSNS6WLoZXq0seFrrv5+ct6EnKjDZIpMeqemQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR21MB1907.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(30864003)(82950400001)(8990500004)(33656002)(8936002)(99936003)(82960400001)(5660300002)(110136005)(508600001)(52536014)(66476007)(6506007)(966005)(86362001)(53546011)(10290500003)(71200400001)(122000001)(26005)(76236003)(38070700005)(9686003)(83380400001)(38100700002)(55016002)(186003)(166002)(8676002)(4326008)(66556008)(76116006)(7696005)(19627235002)(66946007)(64756008)(66616009)(2906002)(66446008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?1BlotqgNyhWgytemfWkQASd7ITtwIrt/jHx6dqmpwbyJm5J9JahqrDEf?= =?Windows-1252?Q?ZoPKfOfjdiyERG6yxn6bdDgQqa1jbl6Dxpk4ibRGyLw5lc35dA+Q/J2J?= =?Windows-1252?Q?Oc/xqRiAs4hEsU4LQlvDJQGqk6k1sCZS/Td+ylx921Dd919ceoB3/9o5?= =?Windows-1252?Q?2EKt0Z33mvrMlaiGuCE4Blqi1Qc7BnVlxxzNzznpQFzS73wnravEoV4H?= =?Windows-1252?Q?ND+fD57hYELJu18SH7+dGNNDBST9kAuw0HNvEyRv78YHxz3Hf21hAxXR?= =?Windows-1252?Q?6gEGnyhajwk9xoeZYypF42BWbi4opWlR2BcShAlC0/TyeglfN3l58mov?= =?Windows-1252?Q?VyaCBVpEm/74jB11znliycjQi+jiEsKLQVKN9qOy7RL8dAyuogAOP89z?= =?Windows-1252?Q?Mfv0aEqhEi8eeuYQtb00QhmSMkIVSWq96byB+3Bx9J+KyJg9MlIe/NCt?= =?Windows-1252?Q?SGrxoXf51MoBpSWKcF2U6t8ia1T8g+EaXj78g1/0wGPh/w3Bild5I0n0?= =?Windows-1252?Q?tYviLQhlCQhSsnzkqEbfnPuQgh1qveLZjTYI38NDz4kInP25LDde5aJg?= =?Windows-1252?Q?VAhPu4IBSlPRHyiGwp4OLaSX//4zGmmeyegXA4TZmHiCAymtbI7daHSs?= =?Windows-1252?Q?H91kNVtYMXBMBogEC05nKyKtaIbhGNySdqwwq6dLQK6m6FDZJP+i/Cye?= =?Windows-1252?Q?z4GfG2GgnYjHXAU5qeG/RI6ezeQJBVwv96Iu7TGKv4LmzDPUv52QCslb?= =?Windows-1252?Q?f6IK4f+0E4UohpHHoW7GDGRRz9bCato6453p81wv46kXZASYqlhoIkT+?= =?Windows-1252?Q?SvpQ3weZ+WRSI69aGL7a1wFs0YJ94uiW+8sfmQaAqejx/6H5h+TJ3I9S?= =?Windows-1252?Q?ZAnd1k/22qoiupE50wcCk7pddLkZgUzRyujdQkXu9gi0xndJnz0ADvAh?= =?Windows-1252?Q?s4/gnc4+HlFHmVyfIFIUjDlZRPwxxZLhOC+Y9FFfJ2GxHkeF70XE1rqR?= =?Windows-1252?Q?5yVyBqkbrI9/JAkNsBULmLbLE36Q06AntRrzCIxiyXe+N9bmgU178SaG?= =?Windows-1252?Q?lS5E8UFhjNfoVBUJc98ZAGZvarSqs8feAWYeRFzi9jL9OWoQfz63yQzE?= =?Windows-1252?Q?+LHXrI15ADA+x3he6u4z/fIyEPNGpUlGvGRSCYFIcjbXVr3jkf7W4qy0?= =?Windows-1252?Q?tCTgeikajzFuntVK4Li9lyezG6AgjtIAiJXOBctMqsfuHGRosZ6+ZSse?= =?Windows-1252?Q?gLQ0u/b5378VBTBABAsj+TtOx60dhlOX+G3P0eEZyi6s/uvuyI7pKcfr?= =?Windows-1252?Q?lEH8TZiC0ZsaJGDQa2wP1itmI4JaK/5bFJ9elBTItEF/0jzJbudxzML+?= =?Windows-1252?Q?I59bIWP12tq3uGLSlXQRyVXpTUB3X86Y3lXxd7W/verFYaLsJKzWV1t0?= =?Windows-1252?Q?y1bpPm6TaI8riBPJNF3vTg=3D=3D?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR21MB1907.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 058e8573-d48b-4641-7fb5-08d95696d4b3 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2021 15:53:26.1968 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6BmIBtpUv4xWXjQVlq+Ivd/DD4F//YsmgNexXPR2/lUeXZhVdwSxbeAZbl1fP5MgYwnmsN17aC2qG79Zm3+8lQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR21MB1940 X-Groupsio-MsgNum: 78613 Content-Language: en-US Content-Type: multipart/related; boundary="_004_MW4PR21MB190739DA02A456BDEA9A9F82EFF09MW4PR21MB1907namp_"; type="multipart/alternative" --_004_MW4PR21MB190739DA02A456BDEA9A9F82EFF09MW4PR21MB1907namp_ Content-Type: multipart/alternative; boundary="_000_MW4PR21MB190739DA02A456BDEA9A9F82EFF09MW4PR21MB1907namp_" --_000_MW4PR21MB190739DA02A456BDEA9A9F82EFF09MW4PR21MB1907namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Yeah, go for the patch. - Bret From: Samer El-Haj-Mahmoud via groups.io Sent: Tuesday, August 3, 2021 6:10 AM To: Nelson, Eric; Bret Barkelew; devel@edk2.groups.io;= G Edhaya Chandran; gaojie@byosoft.com.cn; Kinney, Michael D Cc: Samer El-Haj-Mahmoud Subject: [EXTERNAL] Re: [edk2-devel] Proposing a new area of the edk2-test= repository I would think just sending the code contribution patch is sufficient. From: Nelson, Eric Sent: Wednesday, July 28, 2021 3:05 PM To: Samer El-Haj-Mahmoud ; Bret Barkelew ; devel@edk2.groups.io; G Edhaya Chandran ; gaojie@byosoft.com.cn; Kinney, Michael D Subject: RE: Proposing a new area of the edk2-test repository Adding ResumeOK.efi tool under /edk2-test/test-tools/TestToolsPkg would be= great. Should I propose this in the RFC and DEVEL mailing lists as a next step? Thanks, __e From: Samer El-Haj-Mahmoud > Sent: Friday, July 9, 2021 1:12 PM To: Bret Barkelew >; devel@edk2.groups.io; Nelson, Eric = >; G Edhaya Chandran >; gaojie@byosoft.com= .cn; Kinney, Michael D > Subject: RE: Proposing a new area of the edk2-test repository Interesting, thanks for sharing Bret. Some of those tests seem to be x64 s= pecific (SMM tests), and some can be more generic like MorLockTestApp Like I said earlier, I am not against adding test tools to edk2-test. That= in fact is welcomed, especially if their usefulness in validating the solu= tions extend beyond specific implementations. What would a good tree structure look like to accommodate misc tools? Toda= y we have /edk2-test/uefi-sct/SctPkg How about something like this? /edk2-test/test-tools/TestToolsPkg or /edk2-test/ TestToolsPkg The =93ResumeOK=94 can be placed there Any other ideas? From: Bret Barkelew > Sent: Thursday, June 24, 2021 12:25 AM To: devel@edk2.groups.io; eric.nelson@intel.c= om; Samer El-Haj-Mahmoud >; G Edhaya Chandran >; gaojie@byosoft.com.cn; Kinney, Michael D > Subject: RE: Proposing a new area of the edk2-test repository Fun fact! Mu also has a number of apps and things that we could work on mo= ving to EDK2 if there were a suitable location. Right now, many of them are= here: mu_plus/UefiTestingPkg at release/202102 =B7 microsoft/mu_plus (github.com= ) - Bret From: Nelson, Eric via groups.io Sent: Wednesday, June 23, 2021 3:38 PM To: Samer El-Haj-Mahmoud; G Edhaya Ch= andran; gaojie@byosoft.com.cn; devel@edk2.groups.io; Kinney= , Michael D Subject: [EXTERNAL] Re: [edk2-devel] Proposing a new area of the edk2-test= repository I have created a few other internal apps that build under WinTestPkg, alth= ough ResumeOK.efi is the only one I have received permissions to release so= urces for at this time. And yes, they are primarily intended for validating Windows requirements. I had some issues with my apps, needing to use different libraries than Md= eModulePkg, and found it easier to create my own package, and use the libs = I want. __e From: Samer El-Haj-Mahmoud > Sent: Wednesday, June 23, 2021 1:56 PM To: Nelson, Eric >; G = Edhaya Chandran >; = gaojie@byosoft.com.cn; devel@edk2.groups.io Cc: Samer El-Haj-Mahmoud > Subject: RE: Proposing a new area of the edk2-test repository +edk2 list I am not against adding additional test tools to edk2-test. Just feel like= there is a need to organize and have a strategy, rather than just use edk2= -test as a dumping group of miscellaneous tools. There is already a place for apps under https://github.com/tianocore/edk2/= tree/master/MdeModulePkg/Application We also have a number of EDK2 misc applications that use edk2-libc in http= s://github.com/tianocore/edk2-libc/tree/master/AppPkg/Applications A couple of questions: * Do you expect more apps from WinTestPkg to be contributed to TianoCo= re? And are they all around testing specific Windows requirements? If so, t= hen having an edk2-test/WinTestPkg makes sense to me, as you will have a co= llection of useful testing app targeting specific area. * But what about other OSes? * If this is a one-off test app and other WinTestPkg apps are not goin= g to be contributed, then does it make sense to put this under MdeModulePkg= /Application ? From: Nelson, Eric > Sent: Wednesday, June 23, 2021 3:10 PM To: G Edhaya Chandran >; gaojie@byosoft.com.cn Cc: Samer El-Haj-Mahmoud > Subject: RE: Proposing a new area of the edk2-test repository Hi Edhay, Do you have any more questions? What do you think of creating another directory in edk2-test, for other te= st apps, in addition to uefi-sct, such as ResumeOK.efi? Thanks, __e From: Nelson, Eric Sent: Tuesday, June 15, 2021 12:00 PM To: G Edhaya Chandran >; gaojie@byosoft.com.cn Cc: Samer El-Haj-Mahmoud > Subject: RE: Proposing a new area of the edk2-test repository Hi Edhay, ResumeOK.efi is a tool I wrote from the HelloWorld example, that validates= Windows resume from S4 requirements, specifically that the memory-map run-= time memory regions don=92t change, and secondly that PCI devices don=92t d= isappear from the system, both conditions would cause Windows to fail to re= sume from S4. You install the tool to the root of the ESP, and set it as the default/top= entry in the boot manager, and launch it. (Disable Secure Boot.) It runs warm, cold, and 60s ACPI RTC wake cycles, infinitely looking for e= rrors. ResumeOK.efi writes a file to the root of the ESP, ResumeOK.map, which con= tains the ACPI Facs->HardwareSignature, a list of the PCI devices in the sy= stem, and a copy of its memory map, from the first time it runs. During each test pass, it runs a barrage of tests: 1. Free memory test =96 does the available memory match the memory map = saved in ResumeOK.map 2. HW signature check =96 does the system still have the same HW signat= ure as saved in the ResumeOK.map 3. Allocation test =96 all the available memory is allocated, and then = the memory map is checked if the run-time regions match ResumeOK.map. If any of the tests fail, then the new/missing PCI devices are listed (HW = signature fail case), or the memory descriptor that changed, it=92s locatio= n, and current and previous type and size. I have received permission from Intel to *try* to release the source under= Edk2-test. I=92ve included a 64-bit binary, if you want to give it a test drive. Make sure Secure Boot is off. Also, it is required to manually delete any ResumeOK.map on the ESP, befor= e beginning a new test pass. The tool also supports a host of EFI Shell commands: Resumeok.efi MEMMAP =96 displays Windows coalesced view of the current mem= ory map ResumeOK.efi ROKMAP =96 displays Windows coalesced view of the memory save= d in ResumeOK.map ResumeOK.efi RTDATA =96 displays an analysis of RT_Data pool usage ResumeOK.efi NORESET =96 run one test pass, but suppress automatic SX cycl= ing These are the files that build it: Edk2\WinTestPkg\Application Edk2\WinTestPkg\WinTestPkg.dec Edk2\WinTestPkg\WinTestPkg.dsc Edk2\WinTestPkg\Application\ResumeOK Edk2\WinTestPkg\Application\ResumeOK\AcpiTbl.c Edk2\WinTestPkg\Application\ResumeOK\AcpiTbl.h Edk2\WinTestPkg\Application\ResumeOK\AppSupport.c Edk2\WinTestPkg\Application\ResumeOK\BitMap.c Edk2\WinTestPkg\Application\ResumeOK\BitMap.h Edk2\WinTestPkg\Application\ResumeOK\EfiFileLib.c Edk2\WinTestPkg\Application\ResumeOK\EfiFileLib.h Edk2\WinTestPkg\Application\ResumeOK\pci.c Edk2\WinTestPkg\Application\ResumeOK\Pci.h Edk2\WinTestPkg\Application\ResumeOK\ResumeOK.c Edk2\WinTestPkg\Application\ResumeOK\ResumeOK.h Edk2\WinTestPkg\Application\ResumeOK\ResumeOK.inf Edk2\WinTestPkg\Application\ResumeOK\ResumeOK.uni Edk2\WinTestPkg\Application\ResumeOK\ResumeOKExtra.uni Edk2\WinTestPkg\Application\ResumeOK\RtData.c Edk2\WinTestPkg\Application\ResumeOK\TimeBaseLib.c Thanks, __e From: G Edhaya Chandran > Sent: Monday, June 14, 2021 9:36 PM To: Nelson, Eric >; ga= ojie@byosoft.com.cn Cc: Samer El-Haj-Mahmoud > Subject: RE: Proposing a new area of the edk2-test repository Hi Eric, Thanks for reaching out to us. Can we get more details of the tool? Is this tool already open sourced or could you send us the basic documenta= tion pertaining to it. With Warm Regards, Edhay From: Nelson, Eric > Sent: 15 June 2021 04:23 To: gaojie@byosoft.com.cn; G Edhaya Chandran= > Subject: Proposing a new area of the edk2-test repository Hello SCT maintainers, I=92m looking to release source to a UEFI validation tool that has been a = big hit with platform BIOS validation teams, so it can help other PC vendor= s. My coworker Michael Kinney suggested I reach out to you directly about the= idea of creating a new top level directory in the edk2-test repro for othe= r test apps, and I could be maintainer. What do you think of creating another directory in edk2-test, for other te= st apps, in addition to uefi-sct? Thanks! __e IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in= any medium. Thank you. IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in= any medium. Thank you. IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in= any medium. Thank you. IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in= any medium. Thank you. --_000_MW4PR21MB190739DA02A456BDEA9A9F82EFF09MW4PR21MB1907namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

Yeah, go for the patch.

 

- Bret

 

From: Samer El-Haj-Mahmou= d via groups.io
Sent: Tuesday, August 3, 2021 6:10 AM
To: Nelson, Eric; Bret Barkelew; devel@edk2.grou= ps.io; G Edhaya Chandran; gaojie@byosoft.com.cn; K= inney, Michael D
Cc: Samer El-Haj-Ma= hmoud
Subject: [EXTERNAL] Re: [edk2-devel] Proposing a new area of the ed= k2-test repository

 

I would think just sending the code contribution pa= tch is sufficient.

 

 

From: Nelson, Eric <eric.nelson@intel.com= >
Sent: Wednesday, July 28, 2021 3:05 PM
To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Bret= Barkelew <Bret.Barkelew@microsoft.com>; devel@edk2.groups.io; G Edha= ya Chandran <Edhaya.Chandran@arm.com>; gaojie@byosoft.com.cn; Kinney,= Michael D <michael.d.kinney@intel.com>
Subject: RE: Proposing a new area of the edk2-test repository<= /o:p>

 

 

Adding ResumeOK.efi tool under /edk2-test/test-tool= s/TestToolsPkg would be great.

 

Should I propose this in the RFC and DEVEL mailing = lists as a next step?

 

Thanks,

__e

 

 

From: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Sent: Friday, July 9, 2021 1:12 PM
To: Bret Barkelew <Bret.Barkelew@microsoft.com>; devel@edk2.groups.io; Nelson, = Eric <eric.nelson@intel.com= >; G Edhaya Chandran <Edha= ya.Chandran@arm.com>; gaojie@byosoft.com.cn; Kinney= , Michael D <michael.d.kin= ney@intel.com>
Subject: RE: Proposing a new area of the edk2-test repository<= /o:p>

 

Interesting, thanks for sharing Bret. Some of those= tests seem to be x64 specific (SMM tests), and some can be more generic li= ke MorLockTestApp

 

Like I said earlier, I am not against adding test t= ools to edk2-test. That in fact is welcomed, especially if their usefulness= in validating the solutions extend beyond specific implementations.

 

What would a good tree structure look like to accom= modate misc tools? Today we have

 

/edk2-test/uefi-sct/SctPkg

 

How about something like this?

/edk2-test/test-tools/TestToolsPkg

or /edk2-test/ TestToolsPkg

 

The =93ResumeOK=94 can be placed there

 

Any other ideas?

 

 

From: Bret Barkelew <Bret.Barkelew@microsoft.com>
Sent: Thursday, June 24, 2021 12:25 AM
To: devel@edk2.groups.io; eric.nelson@intel.com; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; G Edhaya Ch= andran <Edhaya.Chandran@arm.c= om>; gaojie@byosoft.com.cn; Kinney= , Michael D <michael.d.kin= ney@intel.com>
Subject: RE: Proposing a new area of the edk2-test repository<= /o:p>

 

Fun fact! Mu also has a number of apps and things t= hat we could work on moving to EDK2 if there were a suitable location. Righ= t now, many of them are here:

mu_plus/UefiTes= tingPkg at release/202102 =B7 microsoft/mu_plus (github.com)

 

- Bret

 

From: Nelson, Eric via groups.io
Sent: Wednesday, June 23, 2021 3:38 PM
To: Samer El-Haj-Ma= hmoud; G Edhaya Chandran; gaojie@byosoft.com.cn; devel@e= dk2.groups.io; Kinney, Michael D
Subject: [EXTERNAL] Re: [edk2-devel] Proposing a new area of the ed= k2-test repository

 

 

I have created a few other internal apps that build= under WinTestPkg, although ResumeOK.efi is the only one I have received pe= rmissions to release sources for at this time.

And yes, they are primarily intended for validating= Windows requirements.

I had some issues with my apps, needing to use diff= erent libraries than MdeModulePkg, and found it easier to create my own pac= kage, and use the libs I want.

 

__e

 

 

From: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Sent: Wednesday, June 23, 2021 1:56 PM
To: Nelson, Eric <eric.= nelson@intel.com>; G Edhaya Chandran <Edhaya.Chandran@arm.com>; gaojie@byosoft.com.cn; devel@edk2.groups.io
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Subject: RE: Proposing a new area of the edk2-test repository<= /o:p>

 

+edk2 list

 

I am not against adding additional test tools to ed= k2-test. Just feel like there is a need to organize and have a strategy, ra= ther than just use edk2-test as a dumping group of miscellaneous tools.

 

There is already a place for apps under https://github.com/tianocore/edk2/tree/maste= r/MdeModulePkg/Application

 

We also have a number of EDK2 misc applications tha= t use edk2-libc in https://github.com/tianocore/edk2-libc/tree/= master/AppPkg/Applications

 

A couple of questions:

  • Do you expect more apps from WinTestPkg to be contributed to TianoCo= re? And are they all around testing specific Windows requirements? If so, t= hen having an edk2-test/WinTestPkg makes sense to me, as you will have a collection of useful testing app targetin= g specific area.
    • But what about other OSes?
  • If this is a one-off test app and other WinTestPkg apps are not goin= g to be contributed, then does it make sense to put this under MdeModulePkg= /Application ?

 

 

 

From: Nelson, Eric <eric.nelson@intel.com>
Sent: Wednesday, June 23, 2021 3:10 PM
To: G Edhaya Chandran <Edhaya.Chandran@arm.com>; gao= jie@byosoft.com.cn
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com= >
Subject: RE: Proposing a new area of the edk2-test repository<= /o:p>

 

 

Hi Edhay,

 

Do you have any more questions?

What do you think of creating another directory in = edk2-test, for other test apps, in addition to uefi-sct, such as ResumeOK.e= fi?

 

Thanks,

__e

 

 

From: Nelson, Eric
Sent: Tuesday, June 15, 2021 12:00 PM
To: G Edhaya Chandran <Edhaya.Chandran@arm.com>; gao= jie@byosoft.com.cn
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com= >
Subject: RE: Proposing a new area of the edk2-test repository<= /o:p>

 

 

Hi Edhay,

 

ResumeOK.efi is a tool I wrote from the HelloWorld = example, that validates Windows resume from S4 requirements, specifically t= hat the memory-map run-time memory regions don=92t change, and secondly tha= t PCI devices don=92t disappear from the system, both conditions would cause Windows to fail to resume from S4.

 

You install the tool to the root of the ESP, and se= t it as the default/top entry in the boot manager, and launch it.  (Di= sable Secure Boot.)

 

It runs warm, cold, and 60s ACPI RTC wake cycles, i= nfinitely looking for errors.

 

ResumeOK.efi writes a file to the root of the ESP, = ResumeOK.map, which contains the ACPI Facs->HardwareSignature, a list of= the PCI devices in the system, and a copy of its memory map, from the firs= t time it runs.

 

During each test pass, it runs a barrage of tests:<= o:p>

 

  1. Free memory test =96 does the available memory match the memory map = saved in ResumeOK.map
  2. HW signature check =96 does t= he system still have the same HW signature as saved in the ResumeOK.map
  3. Allocation test =96 all the available memory is allocated= , and then the memory map is checked if the run-time regions match ResumeOK= .map.

 

If any of the tests fail, then the new/missing PCI = devices are listed (HW signature fail case), or the memory descriptor that = changed, it=92s location, and current and previous type and size.

 

I have received permission from Intel to *try* to release the source under Edk2-test.

 

I=92ve included a 64-bit binary, if you want to giv= e it a test drive.

 

Make sure Secure Boot is off.

Also, it is required to manually delete any ResumeO= K.map on the ESP, before beginning a new test pass.

 

The tool also supports a host of EFI Shell commands= :

 

Resumeok.efi MEMMAP =96 = displays Windows coalesced view of the current memory map

ResumeOK.efi ROKMAP =96 = displays Windows coalesced view of the memory saved in ResumeOK.map

ResumeOK.efi RTDATA =96 = displays an analysis of RT_Data pool usage

ResumeOK.efi NORESET =96= run one test pass, but suppress automatic SX cycling

 

These are the files that build it:

 

Edk2\WinTestPkg\Application

Edk2\WinTestPkg\WinTestPkg.dec

Edk2\WinTestPkg\WinTestPkg.dsc

Edk2\WinTestPkg\Application\ResumeOK

Edk2\WinTestPkg\Application\ResumeOK\AcpiTbl.c=

Edk2\WinTestPkg\Application\ResumeOK\AcpiTbl.h=

Edk2\WinTestPkg\Application\ResumeOK\AppSupport.c

Edk2\WinTestPkg\Application\ResumeOK\BitMap.c<= /o:p>

Edk2\WinTestPkg\Application\ResumeOK\BitMap.h<= /o:p>

Edk2\WinTestPkg\Application\ResumeOK\EfiFileLib.c

Edk2\WinTestPkg\Application\ResumeOK\EfiFileLib.h

Edk2\WinTestPkg\Application\ResumeOK\pci.c

Edk2\WinTestPkg\Application\ResumeOK\Pci.h

Edk2\WinTestPkg\Application\ResumeOK\ResumeOK.c

Edk2\WinTestPkg\Application\ResumeOK\ResumeOK.h

Edk2\WinTestPkg\Application\ResumeOK\ResumeOK.inf

Edk2\WinTestPkg\Application\ResumeOK\ResumeOK.uni

Edk2\WinTestPkg\Application\ResumeOK\ResumeOKExtra.= uni

Edk2\WinTestPkg\Application\ResumeOK\RtData.c<= /o:p>

Edk2\WinTestPkg\Application\ResumeOK\TimeBaseLib.c<= o:p>

 

Thanks,

__e

 

 

From: G Edhaya Chandran <Edhaya.Chandran@ar= m.com>
Sent: Monday, June 14, 2021 9:36 PM
To: Nelson, Eric <eric.nelson@intel.com>; gao= jie@byosoft.com.cn
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com= >
Subject: RE: Proposing a new area of the edk2-test repository<= /o:p>

 

Hi Eric,

 

    Thanks for reaching out to us.

Can we get more details of the tool?

 

Is this tool already open sourced or could you send= us the basic documentation pertaining to it.

 

With Warm Regards,
Edhay

 

 

From: Nelson, Eric <eric.nelson@intel.com>
Sent: 15 June 2021 04:23
To: gaojie@byosoft.com.cn; G Edhaya Chandran <Edhaya.Chandr= an@arm.com>
Subject: Proposing a new area of the edk2-test repository

 

 

Hello SCT maintainers,

 

I=92m looking to release source to a UEFI validatio= n tool that has been a big hit with platform BIOS validation teams, so it c= an help other PC vendors.

 

My coworker Michael Kinney suggested I reach out to= you directly about the idea of creating a new top level directory in the e= dk2-test repro for other test apps, and I could be maintainer.

 

What do you think of creating another directory in = edk2-test, for other test apps, in addition to uefi-sct?

 

Thanks!

__e

 

IMPORTANT NOTICE: The contents of this email and an= y attachments are confidential and may also be privileged. If you are not t= he intended recipient, please notify the sender immediately and do not disc= lose the contents to any other person, use it for any purpose, or store or copy the information in any medium. T= hank you.

IMPORTANT NOTICE: The contents of this email and an= y attachments are confidential and may also be privileged. If you are not t= he intended recipient, please notify the sender immediately and do not disc= lose the contents to any other person, use it for any purpose, or store or copy the information in any medium. T= hank you.

 

IMPORTANT NOTICE: The contents of this email and an= y attachments are confidential and may also be privileged. If you are not t= he intended recipient, please notify the sender immediately and do not disc= lose the contents to any other person, use it for any purpose, or store or copy the information in any medium. T= hank you.

IMPORTANT NOTICE: The contents of this email and an= y attachments are confidential and may also be privileged. If you are not t= he intended recipient, please notify the sender immediately and do not disc= lose the contents to any other person, use it for any purpose, or store or copy the information in any medium. T= hank you.

 

--_000_MW4PR21MB190739DA02A456BDEA9A9F82EFF09MW4PR21MB1907namp_-- --_004_MW4PR21MB190739DA02A456BDEA9A9F82EFF09MW4PR21MB1907namp_ Content-Type: image/png; name="C2F6CDC17C7F4FAAACB21F17EC085096.png" Content-Description: C2F6CDC17C7F4FAAACB21F17EC085096.png Content-Disposition: inline; filename="C2F6CDC17C7F4FAAACB21F17EC085096.png"; size=140; creation-date="Tue, 03 Aug 2021 15:53:25 GMT"; modification-date="Tue, 03 Aug 2021 15:53:25 GMT" Content-ID: Content-Transfer-Encoding: base64 iVBORw0KGgoAAAANSUhEUgAAAsQAAAABCAYAAADZ77itAAAAAXNSR0IArs4c6QAAAARnQU1BAACx jwv8YQUAAAAJcEhZcwAADsMAAA7DAcdvqGQAAAAhSURBVEhL7cMBDQAACAMg+5cygQkeRoMIG9WT VVXVn7MHYi5moJeByLMAAAAASUVORK5CYII= --_004_MW4PR21MB190739DA02A456BDEA9A9F82EFF09MW4PR21MB1907namp_--