From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (NAM02-BL2-obe.outbound.protection.outlook.com [40.107.75.108]) by mx.groups.io with SMTP id smtpd.web12.1761.1616437526824454892 for ; Mon, 22 Mar 2021 11:25:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=MLM7zf1v; spf=pass (domain: microsoft.com, ip: 40.107.75.108, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WOTPgpbW9IbAsB5Axvcuf4Tjd8pWjlGF1ycl5ViBCfx0RnMSU5HAkuCq2602u2jhz9Y2l9O2+SFyV5b9LKgAG1l1htf40EsIFY7H8veqe6CW7yL0X/yhoQJziRKrO5ob8qnbhSNpKrLk6j1Sve7iunWGIKHfxh6DaPlsxKafI7AIhFfwlXgFUAaGwpxBVBB3PIXo1eh1FnZZgdtb1cyS/YbRHHKLYW4u2L359pPDyJDjPVfaR7wrCuqPTXOi4FxSal88GXxX/8xn3JtdKWGrAxCV1rJ5KEHolngRekeR8irn2Pnc0Z2d3t6I60Gj2tsIE4DKjlbLgN6H2xdL95SEGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YrrjrYlBi5459LAP87+57wjXBHXiRPJ8ZptZcwVGSkQ=; b=GWGT0SO7yeuLKhA9zsGXLpeOkueMUm7WmsZP57IkPgn93nQjiTv5iGKj7MqXX+yYD2qoUOYigPeSRICRuYbxlvAmVYOIP0oMM5fG3Z1ot6KlZhlH8k4D5WN79jdzkwS2mi7GTes2kLj8a6Clre/DeOzyeOKKxSuuVi8J42Zv5p3Uv3V0Uzoy6ql41GVu2cotxrcgjC4/0sx6cffU95rWylKR31H+eVlq3yg/lGR/n6sqUQzXhXsco/cn/MOHQxeUqJA9d4/1LXnYwAiAepo3uQmt4WF7QWiaLnGk7zsKjNXJO+FD+7xZO7OoF6/71tan61IWuEr3E1+GBMgqgcKelw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YrrjrYlBi5459LAP87+57wjXBHXiRPJ8ZptZcwVGSkQ=; b=MLM7zf1vPREIzZXCj+r8zgKMCeKOUY+cUjvA1jVCc3AG0xUFvdIsKlNPUBcuFtNKJfDEFTh/Nohk8qTBDfTgXg9QWEdMPP8YB9+v4Rg7EDH49a30U/WXeHionWgpJrCO92UnzOP1ThmOlXG/VlkbuM16CkIZUdXmEkHhVUTdHWY= Received: from MW4PR21MB1907.namprd21.prod.outlook.com (2603:10b6:303:71::8) by MW4PR21MB1905.namprd21.prod.outlook.com (2603:10b6:303:7e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.1; Mon, 22 Mar 2021 18:25:25 +0000 Received: from MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::adcb:b821:ee26:3348]) by MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::adcb:b821:ee26:3348%8]) with mapi id 15.20.3999.005; Mon, 22 Mar 2021 18:25:25 +0000 From: "Bret Barkelew" To: Dandan Bi , "devel@edk2.groups.io" CC: "Kinney, Michael D" , Sean Brogan Subject: Re: [EXTERNAL] [patch V2 27/29] UnitTestFrameworkPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib Thread-Topic: [EXTERNAL] [patch V2 27/29] UnitTestFrameworkPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib Thread-Index: AQHXHvLbOJcmucF+kUuI2H+dRaEnjKqQU3E2 Date: Mon, 22 Mar 2021 18:25:25 +0000 Message-ID: References: <20210322080941.6780-1-dandan.bi@intel.com>,<20210322080941.6780-28-dandan.bi@intel.com> In-Reply-To: <20210322080941.6780-28-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-03-22T18:25:00.8511658Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [71.212.153.143] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5880cb66-4353-4830-b519-08d8ed5fdca0 x-ms-traffictypediagnostic: MW4PR21MB1905: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aLKt9RkypzngoyCDbxmpSxNh/0yGEiNJN53CLm8Ik814fLX57UQXQCmCvQT/ODiCIWHftQqfnT+uO9YVIiLwnO5+Vki0uWIVgl+jChGqnD5o+PSXrOC/YFyNXnHMzJP7zdmdi/xC4HQZJLXilmGeEtCTWJ/O7tIx/xVZ7bFGCCmtq8IO0R5Q5nwuJe1nx34mVor1WGGgicgDMGPl0JY9W8Wq3eOkJ06gVtEdQ41ZxOuLP9MzC+mq1yLYT3fgnCDF/3EzzDhU7L6oJFt4jdrIS0YRHsVvDSMvBJwg1aCWCEQzgeTir/ho7xxZNKUhHyO3JM7ckYgjRBELeI5dZOOskDNohfupddDtu0oQp7jGR1R5BtYElYsLltAxxt/9QKs22DT7izj53JAZNX5DgSaniWyqM5c/v8/nqztos9DKJoiXAbaejrVicFIankmgOFE5Em7PfxQNXSIO10iPk0riASIwkEK232lWsWDpGRLBKKe/3BoGDHU3ws7G4efIsEXyS2YvNoUQoPumwuBLmaJ6bEFIuxoQ8FJ9sXo+MPbQZ0vMIxIPbt7LTL/yJFFB28L4yFHGoNRiBLhEXURWjz+TXM8mlo3fiMMcNIMhG0292Kao7/NaugEOMwUQSXxTXgfNlIkoyGHtu/Q/c1Gy+ZNlExoYbWJGGjgAaSKnpCAHrRflsCnrjZojgDgQkZB2mIjj+cu21B0xyHPavmX/35GNQ6TVIRSfjp2cldPEIzGiOBLyeCCBOD8N0YDz19E5lPTN x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR21MB1907.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(376002)(346002)(39860400002)(136003)(396003)(82960400001)(186003)(82950400001)(166002)(6506007)(8676002)(10290500003)(7696005)(8990500004)(966005)(110136005)(26005)(86362001)(33656002)(316002)(53546011)(478600001)(8936002)(2906002)(54906003)(38100700001)(66476007)(107886003)(83380400001)(55016002)(71200400001)(4326008)(52536014)(5660300002)(66446008)(66556008)(66946007)(9686003)(64756008)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?Windows-1252?Q?1Ea6zOYiBNIHG/2Oh1G7K7gKKHbCyKkQxDRnEyk+wnGJvICOhht2ptJw?= =?Windows-1252?Q?5hZzyQW8khXcrhzHQtrhxbpIAM2WufA1pf6xCYtALrz3HdVZrqiolPLa?= =?Windows-1252?Q?WbNHccNB3gEfH4I5x+LBs+D4xmhnxo2SlDorAwwCogs/bjJwpYVgHoLT?= =?Windows-1252?Q?eFTh1ZaGfR8EDFP46tJtsVQQpIMpBFW3oa7cUEjnktK+VypXqdgZ0OWW?= =?Windows-1252?Q?R3Qx0Hr5w/W5D47XntJXiFS7DM6+UPSFplyfU1CqevEaKVrEQ7GZRyN8?= =?Windows-1252?Q?vZp+hagwfIyo3Tmc26VjRxP7cwerlN5gDJFTrsNz5lg7+W2xlfXKUyF9?= =?Windows-1252?Q?L/tf8qsTt5mnLkmeIl0cgep1N+/IajaRIWMQ1z+an59GvJBO2/vWlm73?= =?Windows-1252?Q?5nHWjjlgcX5zXrOKsd3KwfHBFN250vxf4V7jRq+E48GAl4YPij6vo1oV?= =?Windows-1252?Q?sHqIU6HmESX/Cb9iFlYABXWJMb/1PoZqMNpImGenRqEYuQmVKIIs3i3Y?= =?Windows-1252?Q?HKVtHcBU/2/sh2HVSP4deV4Pk7donhEAJqSXbIeXP6MD+9agwrhmg7fF?= =?Windows-1252?Q?CdQtIyfQCgMeVzylgHKs5KANrepg1/LK/5LawhSodzHL3VHHL/9AuPeV?= =?Windows-1252?Q?U7qkuTfp9wXs8CIm0t0JG41cCWv25BP8ph1CEcerGn3yn/3Lvf5kAyC5?= =?Windows-1252?Q?qSnuI4UUHFcYtRPZK2GeWeb5A3MWLThdulNIPzIgusk/hzy/LsjeLNhJ?= =?Windows-1252?Q?OXTogOM8Gr9DzufUVEDKYrIyHiqzr4X0+vdUqL1xOBOo5CiutsiO39XK?= =?Windows-1252?Q?KHl0it8QrUmdSbY6NmKkExOI+0eFlkfGivDsEIAnvwBf4H7v7h7VTdJM?= =?Windows-1252?Q?XEmTfDK+yPKj1GQRd4Ak0m5idso6y8meseTmWZKio8m0JuLfbXcMjQ0b?= =?Windows-1252?Q?uo9uIEGQEXFpOMcegGO5CtIwBewEkVhf78s4QB3cOIfyOKtGMF/gbBlY?= =?Windows-1252?Q?sa1E+YomXwI32r2YkHcKHaJyS9i4kpO8eMPDcIJlZSaf3d3RZxM0mdl2?= =?Windows-1252?Q?4UHhIUucZWwHcqJOD/TkOg7fwW6Wq7YWjmh6wg+OInOL5QkgSVGdnEDJ?= =?Windows-1252?Q?Cs1MqthxgKX75il4I0fDjwRouBVphzjz9+INKM/A9kIvWDTn2QO/CZVt?= =?Windows-1252?Q?4JB+yzO/+5Hd1x1uuUg3GjZAj7dK29rhef+hBzNxfG2C+t7AjqRvcdB7?= =?Windows-1252?Q?5mN33500krUrpeam/Qc/nHGt1sLY08qthXDzdC6Vi130GekKyEWcw5Q3?= =?Windows-1252?Q?vbzqKS/HpSisGz1GwgshwDaqpEgS5HhM/ahCHEMiJgCW1gwBMnqvt+Gb?= =?Windows-1252?Q?5aquJz6K1eK+wnA4iEwIAcKW8WtKTynAdVddgM2Dk+ACRKWshAMdPBT2?= =?Windows-1252?Q?plOlH0qgfP6NxPjDH70UXA=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR21MB1907.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5880cb66-4353-4830-b519-08d8ed5fdca0 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2021 18:25:25.1603 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aQMzFBAsDmxXzwCXK9cs7exJuxNZbmsEGGH3+TCVOOZu+yfcbG2i4Dw7QzWa5lIZchxsDItZB0VreAbqEOERKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR21MB1905 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR21MB190744432FDB4B1DBB51FAFBEF659MW4PR21MB1907namp_" --_000_MW4PR21MB190744432FDB4B1DBB51FAFBEF659MW4PR21MB1907namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Is there a PR somewhere that has a branch with all these changes applied? I= =92d like to poke around a little. Thanks! - Bret From: Dandan Bi Sent: Monday, March 22, 2021 1:10 AM To: devel@edk2.groups.io Cc: Kinney, Michael D; Sean Brogan; Bret Barkelew Subject: [EXTERNAL] [patch V2 27/29] UnitTestFrameworkPkg: Consume MdeLibs.= dsc.inc for RegisterFilterLib REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbu= gzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3246&data=3D04%7C01%7CBret.B= arkelew%40microsoft.com%7C77dd99e3296941afb9b408d8ed09fd3c%7C72f988bf86f141= af91ab2d7cd011db47%7C1%7C0%7C637519974445661033%7CUnknown%7CTWFpbGZsb3d8eyJ= WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&= sdata=3DoDafPDNi1k2MRYGrp%2Frhy1dB43tk%2B0YwF8%2FxdLqBXt8%3D&reserved= =3D0 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for RegisterFilterLibNull which will be consumed by IoLib and BaseLib. Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Dandan Bi --- UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc b/Unit= TestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc index 8adf690098..4adb98aff5 100644 --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc @@ -1,14 +1,16 @@ ## @file # UnitTestFrameworkPkg DSC include file for target based test DSC # -# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.
+# Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent # ## [LibraryClasses] + !include MdePkg/MdeLibs.dsc.inc + # # Entry point # PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntry= Point.inf -- 2.18.0.windows.1 --_000_MW4PR21MB190744432FDB4B1DBB51FAFBEF659MW4PR21MB1907namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

Is there a PR somewhere that has a branch with all t= hese changes applied? I=92d like to poke around a little.

 

Thanks!

 

- Bret

 

From: Dandan Bi
Sent: Monday, March 22, 2021 1:10 AM
To: devel@edk2.groups.io=
Cc: Kinney, Michael D<= /a>; Sean Brogan; Bret Barkel= ew
Subject: [EXTERNAL] [patch V2 27/29] UnitTestFrameworkPkg: Consume M= deLibs.dsc.inc for RegisterFilterLib

 

REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzill= a.tianocore.org%2Fshow_bug.cgi%3Fid%3D3246&amp;data=3D04%7C01%7CBret.Ba= rkelew%40microsoft.com%7C77dd99e3296941afb9b408d8ed09fd3c%7C72f988bf86f141a= f91ab2d7cd011db47%7C1%7C0%7C637519974445661033%7CUnknown%7CTWFpbGZsb3d8eyJW= IjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&a= mp;sdata=3DoDafPDNi1k2MRYGrp%2Frhy1dB43tk%2B0YwF8%2FxdLqBXt8%3D&amp;res= erved=3D0

MdeLibs.dsc.inc was added for some basic/default library
instances provided by MdePkg and RegisterFilterLibNull Library
was also added into it as the first version of MdeLibs.dsc.inc.

So update platform dsc to consume MdeLibs.dsc.inc for
RegisterFilterLibNull which will be consumed by IoLib and BaseLib.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc b/Unit= TestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc
index 8adf690098..4adb98aff5 100644
--- a/UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc
+++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc
@@ -1,14 +1,16 @@
 ## @file
 # UnitTestFrameworkPkg DSC include file for target based test DSC
 #
-# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.<BR= >
+# Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.<BR= >
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #
 ##
 
 [LibraryClasses]
+  !include MdePkg/MdeLibs.dsc.inc
+
   #
   # Entry point
   #
   PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.in= f
   UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiD= riverEntryPoint.inf
--
2.18.0.windows.1

 

--_000_MW4PR21MB190744432FDB4B1DBB51FAFBEF659MW4PR21MB1907namp_--