From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.119]) by mx.groups.io with SMTP id smtpd.web09.183.1621629797385936928 for ; Fri, 21 May 2021 13:43:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=duagK2xP; spf=pass (domain: microsoft.com, ip: 40.107.236.119, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QKrOS+L16qusQlInkrljd87rq6LW48hr7RPhzP2lcQW/hLGCNiT/0uDlk8Jhj7qyzrc4ZdtAobx253Uznbt0Rddo1ecU6D56NgEwZ4yB2B04dzcbU19YXosgLnyrVjq3IwxjkpopbtpV8b551yPqBZEeweMMA5J/OylwqFZGbLFjwCR+CfeMp5pEG3iSRpPCopPZzaUWwjNTF59FUKQ9h2EaGBwGv5lecRJ72dSoRiOQkHYDR+59ILev/YwUWwhSJLO5yT2r5P9Ti02SA1PNULdmWCaYE+2t0tFMauKL2FbKBpNN3ncd88z+wOX6W6xv/uZOAfO+wo/cCrTyeE5SuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nY+ecPqex0+3xFefZfZC8EssBLEVlCXdHASxSsQFI60=; b=VKWwDciRErYxZnEx9v/e3eXFO9gVGeAWl1RABW6cQSTnyX6ylXbQ5OlsM994PuaybWg55oy0TqakEe/NMDRaoho0ESZfl8Sk0cxboZ79o9bQiNTUlqxLDbWulMEbeF/HUPQ4MmAIeOpb/YArEjNYfyjJl18ZrjHWZjWSvN/Z4txwaewgoH1PY6h9Qrg2SuVmjin0mMG1Mzj2ioRZRBBZSqDfUp+VGags1Tf32UA2rLjKmS2/cjD7nhxyaedxxTbibi7vK3ZdYYVrSwBKxpS6NRRgbk/tCjYTBal+Qm5So6sLI7nsveAERkl6Hne/Z0Z5bRewlhj8/gVob3m/bZNJoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nY+ecPqex0+3xFefZfZC8EssBLEVlCXdHASxSsQFI60=; b=duagK2xPyKM8r2nzA7T7u4Arc6OT1bCVXRbDwCu/IArDu5ho948Wigr7cg8ITpjPMVJ1fhOyJeQUXqRZq0KkP8AeWiXos4ITMcDyolwHEdi8GeUPpX3JU0V0NNKajfSytl2EtxZ8ePdjjbERWKbwkLvOCue1LbjPaP7YFLJA+Sc= Received: from MW4PR21MB1907.namprd21.prod.outlook.com (2603:10b6:303:71::8) by MW4PR21MB1923.namprd21.prod.outlook.com (2603:10b6:303:7c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.7; Fri, 21 May 2021 20:43:15 +0000 Received: from MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::adcb:b821:ee26:3348]) by MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::adcb:b821:ee26:3348%9]) with mapi id 15.20.4150.027; Fri, 21 May 2021 20:43:15 +0000 From: "Bret Barkelew" To: Laszlo Ersek , edk2-devel-groups-io CC: Hao A Wu , Jian J Wang , Liming Gao , "Kinney, Michael D" , =?Windows-1252?Q?Philippe_Mathieu-Daud=E9?= Subject: Re: [EXTERNAL] [edk2-stable202105 PATCH] MdeModulePkg/VariableLock: downgrade compatibility warnings to DEBUG_WARN Thread-Topic: [EXTERNAL] [edk2-stable202105 PATCH] MdeModulePkg/VariableLock: downgrade compatibility warnings to DEBUG_WARN Thread-Index: AQHXToGUiJIcjBggu0KALTgyYjFLgaruZoz0 Date: Fri, 21 May 2021 20:43:15 +0000 Message-ID: References: <20210521204037.11980-1-lersek@redhat.com> In-Reply-To: <20210521204037.11980-1-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-05-21T20:42:14.1611444Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [71.212.153.42] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c9766311-f370-47fd-fba4-08d91c990ebc x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: H8aGrZQ0z4G3RqLVZMFTWkipH3YpQ+i0Zi9Kf87aoYaCjHADnzHIaKp+KZKiSAhuoqcinBjCU4QithWj864BcTf9v5HompXUBiiCdXK9zYRnTx20d6rwqmfyFqReRQ1VQPL1Lp/TevJyIz23+kd/SWmFUadHcasL2gWAm/xxL6JqiteNy67bSv2slEyOppeffHEbQwEgUPcCYyYl6G83LitfoBk98ncYXVnb/Vsx9K3PG04nhJaMHhhfv5AUumHJ5Liz+rfslNLB90rp5mKXCD1rXMFUk7fxxD7mKpRgbjty353S2NGly8ZqQYEBOul8uLBhHYakth9oko2YaYi4L4S8jDGHwNEmzA7xJcpAMPAp8Knxc4/WvkYlbFvoazlDM4LdwU6JwRYn9gmRpuGNqcSrLArDq61gppoGoOhuWu+2ix9VVkIyIZdqsJh/WJTJXebvHE6IjKSDlfv6jXMESvR6S3jkUJO3mhmzLY97L2A38DDQMzYJ3+wfnLBlFmHcdwAkyDuPb5c4v9pSsC76yiKGj4MfqdEHRFsEIyZHY322DZyl6XAD9L2KjV75FwjNG56IVzaBkAiW0wgufqAWSQFny4pxVt8+UpRatHLX6xXcF2yH4Cs3G1da6NeA2iV9bKsIM+iv6W9j3Le94MXQmB6GbyD9hbpLuEVFZ+CmUZMNsjKIYe9j5z2/L/yQ2Wc5IpvYsxLEbJRucbSFqEbd6ezrADg9EPu/r50zv7nxwSQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR21MB1907.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(76116006)(186003)(66446008)(64756008)(38100700002)(83380400001)(110136005)(86362001)(4001150100001)(122000001)(66946007)(166002)(82960400001)(82950400001)(66556008)(66476007)(8990500004)(2906002)(71200400001)(26005)(9686003)(8936002)(54906003)(5660300002)(478600001)(53546011)(33656002)(10290500003)(316002)(6506007)(55016002)(8676002)(966005)(4326008)(7696005)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 2 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?bwfJL5bm8m3dBA/eASr3Uw0TIhXg8a6+hlBXqBHmZswKQkDRcq2a16oQ?= =?Windows-1252?Q?bpowbUySnQt/BhgjVjPeesS2O8X1mHnucYNxd/YRQiQrfw3iN8pVuGM/?= =?Windows-1252?Q?Qo6qlSi2EYeGG2QgjyQscYb7aAsAsNRLcemtKdziLW+s22WoQHuyLDR0?= =?Windows-1252?Q?QRDxa6MH3Pjk0iKqgHwUYQVS9B+e8n9WWj5B0rqiOS+ih3dqc6UPMpgd?= =?Windows-1252?Q?lS5IiqZ0cohEMNn2FLYJzHNR3bVQ2rh9X2uI30NTzFC/qPNBM+aH5b1l?= =?Windows-1252?Q?w581Cj/e50Lp7xJu0dythqk8I/vBBLqcFMTBQB9TixO6YOVu6AmAMuL2?= =?Windows-1252?Q?D+FaVgb4Am2tMP/cA8wY1zWt1Jn/MLtymzrHL3uxaFMtE+MqlKVcuF+3?= =?Windows-1252?Q?1sZcIOGXsYJKjfHScE86uQlcQ8EDt0Tu+UrZb/5YxHg4lyD38t4ZiZdW?= =?Windows-1252?Q?iBE0voIEP3lXMj/FlZwoV5f6f52PtRlvrXdU/6C8YJ8+YG11iLZSPOqk?= =?Windows-1252?Q?DS+qCPunZSRP8m1uRsfF4oNRAGbq/eAzS6eU3tloK7f88FQCQ92cyQRn?= =?Windows-1252?Q?A6fhCSPMKG2m8suUuEOv7JHqWyJnBFo65gwGgPXLHG+KQmKHdenPdDcO?= =?Windows-1252?Q?jkKpJTPjTlB2OA7NesKrhjdylp6lnmu/aKtkqzZR628w7LaS5TSU5CsX?= =?Windows-1252?Q?41R0ZpcAb2riSyWkYkBrqL0yiAFCdMV6vyClEn5195x2fcNz6lfVibC6?= =?Windows-1252?Q?HVn3h1be66G3zm9Cdg/hbxmzG4PQPjwlk/tIRCAAzlMm4CgJ77Xa6mer?= =?Windows-1252?Q?7b74rcFal+d2rkJp2pMQc9foZzBC9cNtx/QajQaR5gcn59Il8XduIrr+?= =?Windows-1252?Q?hM8gKe8YhjlCbibt8LLMMGhTVGX2zc68vKRzka2d1OjTn9e9Vi1Iw6Wk?= =?Windows-1252?Q?akwcR3Y2YbffTpjMcGs/AutqAvz8zWvZhZZ+ru86SRKOhbXaZsl5DbLs?= =?Windows-1252?Q?uTxCkQoLdd6xskoltiufWOoDTa4Vig/wOxKoiomaTTcssg/k?= x-ms-exchange-antispam-messagedata-1: EPlyQLiWUolz2ltm8JHrj8RKa92CEv2SX+aJydr/YMI9OxGTmR6EG6PieQhAgT8NQ4yYyLjjZr2/wUeqtpJyDK2vnpiWnL9tZ4FmZDlbx5WPY+JfVtI50hV/kToI224G15eap9xtOGs3aLc1blWHZH84uv2spkx5zeuhbrXSdBoh8LQGkunCklLpmhYYpj0wGtn1y3R9XTbmPtjWw0gmL3SgWkIKRAzIT7RL0i+onI/JWRjpk+pI39eB/WcDvnXQbFMsUU6/zYaoR7Pn2L1sguvO+HQ6X98Asqal9uPckLsLOsNDtJphSxuthAzU9PmW7s8jRoeApq4en4vtKNuHGIShiUiJ6lFAY1hX3YuVHV+zOQ== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR21MB1907.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9766311-f370-47fd-fba4-08d91c990ebc X-MS-Exchange-CrossTenant-originalarrivaltime: 21 May 2021 20:43:15.1251 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8B/5uB2wyK7lsyuWUZBtLxDmaxPwUYoQNuMSZJOVEsSuRlKZHKjCWQnfmgqjJbK4oQNvDBRAvrU9KPeSYOVI/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR21MB1923 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR21MB19076EE492DCF7C3776DE051EF299MW4PR21MB1907namp_" --_000_MW4PR21MB19076EE492DCF7C3776DE051EF299MW4PR21MB1907namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bret Barkelew bret.barkelew@microsoft.com I don=92t regret making it ERROR at first because now no one can claim to h= ave not been warned when the interface drops, but I agree that lowering to = WARN now is prudent. - Bret From: Laszlo Ersek Sent: Friday, May 21, 2021 1:40 PM To: edk2-devel-groups-io Cc: Bret Barkelew; Hao A Wu; Jian J Wang; Liming Gao; Kinney, Michael D; Philippe Mathieu-Daud=E9 Subject: [EXTERNAL] [edk2-stable202105 PATCH] MdeModulePkg/VariableLock: do= wngrade compatibility warnings to DEBUG_WARN Commit a18a9bde36d2 ("MdeModulePkg/Variable/RuntimeDxe: Restore Variable Lock Protocol behavior", 2020-12-15), for bug 3111, added two such sets of debug messages that: (a) are relevant for developers, (b) yet should not necessarily poke end-users, because no functionality suffers in practice. Both message sets are in function VariableLockRequestToLock(): the first is a generic interface deprecation warning; the second is the double-locking situation, which we permit for compatibility (return status EFI_SUCCESS). Both message sets should be emitted with the DEBUG_WARN mask, not the most serious DEBUG_ERROR mask. On some platforms, the serial console carries both terminal traffic, and grave (DEBUG_ERROR-only) log messages. On such platforms, both message sets may be perceived as a nuisance by end-users, as there is nothing they can do, and there's nothing they *should* do -- in practice, nothing malfunctions. (Such a platform is ArmVirtQemu, built with "-D DEBUG_PRINT_ERROR_LEVEL=3D0x80000000".) Cc: Bret Barkelew Cc: Hao A Wu Cc: Jian J Wang Cc: Liming Gao Cc: Michael D Kinney Cc: Philippe Mathieu-Daud=E9 Ref: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbu= gzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3410&data=3D04%7C01%7Cbret.b= arkelew%40microsoft.com%7Ca7ff677adbc34cf62f0608d91c98b5b9%7C72f988bf86f141= af91ab2d7cd011db47%7C1%7C0%7C637572264482965812%7CUnknown%7CTWFpbGZsb3d8eyJ= WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&= sdata=3D2WuJ06k2ViIR6JnQVRmsGdsnYjmOrPUtGD82thYLe%2FU%3D&reserved=3D0 Fixes: a18a9bde36d2ffc12df29cdced1efa1f8f9f2021 Signed-off-by: Laszlo Ersek --- MdeModulePkg/Universal/Variable/RuntimeDxe/VariableLockRequestToLock.c | 1= 0 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableLockRequest= ToLock.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableLockRequestTo= Lock.c index 7d87e50efdcd..4e1efef9a7e4 100644 --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableLockRequestToLock.= c +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableLockRequestToLock.= c @@ -48,9 +48,9 @@ VariableLockRequestToLock ( EFI_STATUS Status; VARIABLE_POLICY_ENTRY *NewPolicy; - DEBUG ((DEBUG_ERROR, "!!! DEPRECATED INTERFACE !!! %a() will go away soo= n!\n", __FUNCTION__)); - DEBUG ((DEBUG_ERROR, "!!! DEPRECATED INTERFACE !!! Please move to use Va= riable Policy!\n")); - DEBUG ((DEBUG_ERROR, "!!! DEPRECATED INTERFACE !!! Variable: %g %s\n", V= endorGuid, VariableName)); + DEBUG ((DEBUG_WARN, "!!! DEPRECATED INTERFACE !!! %a() will go away soon= !\n", __FUNCTION__)); + DEBUG ((DEBUG_WARN, "!!! DEPRECATED INTERFACE !!! Please move to use Var= iable Policy!\n")); + DEBUG ((DEBUG_WARN, "!!! DEPRECATED INTERFACE !!! Variable: %g %s\n", Ve= ndorGuid, VariableName)); NewPolicy =3D NULL; Status =3D CreateBasicVariablePolicy( @@ -69,13 +69,13 @@ VariableLockRequestToLock ( // // If the error returned is EFI_ALREADY_STARTED, we need to check the // current database for the variable and see whether it's locked. If i= t's - // locked, we're still fine, but also generate a DEBUG_ERROR message s= o the + // locked, we're still fine, but also generate a DEBUG_WARN message so= the // duplicate lock can be removed. // if (Status =3D=3D EFI_ALREADY_STARTED) { Status =3D ValidateSetVariable (VariableName, VendorGuid, 0, 0, NULL= ); if (Status =3D=3D EFI_WRITE_PROTECTED) { - DEBUG ((DEBUG_ERROR, " Variable: %g %s is already locked!\n", Ven= dorGuid, VariableName)); + DEBUG ((DEBUG_WARN, " Variable: %g %s is already locked!\n", Vend= orGuid, VariableName)); Status =3D EFI_SUCCESS; } else { DEBUG ((DEBUG_ERROR, " Variable: %g %s can not be locked!\n", Ven= dorGuid, VariableName)); -- 2.19.1.3.g30247aa5d201 --_000_MW4PR21MB19076EE492DCF7C3776DE051EF299MW4PR21MB1907namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

Reviewed-by: Bret Barkelew bret.barkelew@microsoft.com

 

I don=92t regret making it ERROR at first because no= w no one can claim to have not been warned when the interface drops, but I = agree that lowering to WARN now is prudent.

 

- Bret

 

From: Laszlo Ersek
Sent: Friday, May 21, 2021 1:40 PM
To: edk2-devel-groups-io=
Cc: Bret Barkelew= ; Hao A Wu; Jian J Wang; Liming Gao; Kinney, Micha= el D; Philippe Mathieu-Daud=E9
Subject: [EXTERNAL] [edk2-stable202105 PATCH] MdeModulePkg/VariableL= ock: downgrade compatibility warnings to DEBUG_WARN

 

Commit a18a9bde36d2 (= "MdeModulePkg/Variable/RuntimeDxe: Restore Variable
Lock Protocol behavior", 2020-12-15), for bug 3111, added two such set= s of
debug messages that:

(a) are relevant for developers,

(b) yet should not necessarily poke end-users, because no functionality
suffers in practice.

Both message sets are in function VariableLockRequestToLock(): the first is a generic interface deprecation warning; the second is the
double-locking situation, which we permit for compatibility (return status<= br> EFI_SUCCESS).

Both message sets should be emitted with the DEBUG_WARN mask, not the most<= br> serious DEBUG_ERROR mask. On some platforms, the serial console carries
both terminal traffic, and grave (DEBUG_ERROR-only) log messages. On such platforms, both message sets may be perceived as a nuisance by end-users, as there is nothing they can do, and there's nothing they *should* do -- in practice, nothing malfunctions.

(Such a platform is ArmVirtQemu, built with "-D
DEBUG_PRINT_ERROR_LEVEL=3D0x80000000".)

Cc: Bret Barkelew <bret.barkelew@microsoft.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Philippe Mathieu-Daud=E9 <philmd@redhat.com>
Ref: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzill= a.tianocore.org%2Fshow_bug.cgi%3Fid%3D3410&amp;data=3D04%7C01%7Cbret.ba= rkelew%40microsoft.com%7Ca7ff677adbc34cf62f0608d91c98b5b9%7C72f988bf86f141a= f91ab2d7cd011db47%7C1%7C0%7C637572264482965812%7CUnknown%7CTWFpbGZsb3d8eyJW= IjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&a= mp;sdata=3D2WuJ06k2ViIR6JnQVRmsGdsnYjmOrPUtGD82thYLe%2FU%3D&amp;reserve= d=3D0
Fixes: a18a9bde36d2ffc12df29cdced1efa1f8f9f2021
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 MdeModulePkg/Universal/Variable/RuntimeDxe/VariableLockRequestToLock.= c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableLockRequest= ToLock.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableLockRequestTo= Lock.c
index 7d87e50efdcd..4e1efef9a7e4 100644
--- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableLockRequestToLock.= c
+++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableLockRequestToLock.= c
@@ -48,9 +48,9 @@ VariableLockRequestToLock (
   EFI_STATUS        &nbs= p;    Status;
   VARIABLE_POLICY_ENTRY  *NewPolicy;
 
-  DEBUG ((DEBUG_ERROR, "!!! DEPRECATED INTERFACE !!! %a() will g= o away soon!\n", __FUNCTION__));
-  DEBUG ((DEBUG_ERROR, "!!! DEPRECATED INTERFACE !!! Please move= to use Variable Policy!\n"));
-  DEBUG ((DEBUG_ERROR, "!!! DEPRECATED INTERFACE !!! Variable: %= g %s\n", VendorGuid, VariableName));
+  DEBUG ((DEBUG_WARN, "!!! DEPRECATED INTERFACE !!! %a() will go= away soon!\n", __FUNCTION__));
+  DEBUG ((DEBUG_WARN, "!!! DEPRECATED INTERFACE !!! Please move = to use Variable Policy!\n"));
+  DEBUG ((DEBUG_WARN, "!!! DEPRECATED INTERFACE !!! Variable: %g= %s\n", VendorGuid, VariableName));
 
   NewPolicy =3D NULL;
   Status =3D CreateBasicVariablePolicy(
@@ -69,13 +69,13 @@ VariableLockRequestToLock (
     //
     // If the error returned is EFI_ALREADY_STARTED, w= e need to check the
     // current database for the variable and see wheth= er it's locked. If it's
-    // locked, we're still fine, but also generate a DEBUG_= ERROR message so the
+    // locked, we're still fine, but also generate a DEBUG_= WARN message so the
     // duplicate lock can be removed.
     //
     if (Status =3D=3D EFI_ALREADY_STARTED) {
       Status =3D ValidateSetVariable (Variab= leName, VendorGuid, 0, 0, NULL);
       if (Status =3D=3D EFI_WRITE_PROTECTED)= {
-        DEBUG ((DEBUG_ERROR, "&nbs= p; Variable: %g %s is already locked!\n", VendorGuid, VariableName));<= br> +        DEBUG ((DEBUG_WARN, " = ; Variable: %g %s is already locked!\n", VendorGuid, VariableName));          Status =3D EFI_SUCCESS;        } else {
         DEBUG ((DEBUG_ERROR, "= ;  Variable: %g %s can not be locked!\n", VendorGuid, VariableNam= e));
--
2.19.1.3.g30247aa5d201

 

--_000_MW4PR21MB19076EE492DCF7C3776DE051EF299MW4PR21MB1907namp_--