From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (NAM04-MW2-obe.outbound.protection.outlook.com [40.107.101.110]) by mx.groups.io with SMTP id smtpd.web11.1476.1616697314142718625 for ; Thu, 25 Mar 2021 11:35:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=YCl+OShF; spf=pass (domain: microsoft.com, ip: 40.107.101.110, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AFlzw1JiN0k4fBIzEQokNSbpchH/Pc9VA/fFXAQDb3BZBvHy/rr+L6/G3dgIjlAJX+BhksMvUwZUha9ssgHbhHgR5l/Z5EuODblN7sg5PZxJ3nCQJL+UzJpPJeJF3YfhsryEBmknQBZxxauOaPsUO7trHQoOQVBsBu5DghblQK6sdF4Yx3HQEHqtuGsTuYaOz84BkQ5E1fZqMq5O0evZqBiYVfcI2g+oC5HFPA2Q7v59Oqs1bVRGWZx/SZtf9BSych77/k0zxNejgyMNFQo3CJvNDL58hkehCEihqLNV3B4SdVPKnQsoZJQSbAFXy0FRz5BcXdVwqucQ0Ub8HES2yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h30xA47khErfz2EcqaFwyeGy+Jay/8Wvy9NK7LWBhIQ=; b=Q8cAQkglyPy+Tv9P0nE/CPlEWxRmdzN0xCeqoq+0mDE+3cjjeUUddkbbibs+/P0pRezQEguxaRTWkrTykTpfXUM7vAfyrUSfo00NGd/bOrLU+Vr1uxwSafH3prCQaoe1uy8466lkDMgqX4aCG36DFmxcMuQp4fwjVW5mMNscRsWvUMPbjsNT7MAYszfp4VeSwqUAPuGXG4dbsObmg9oMAPqWSGxTK5FXZXD7iBfQPFfbwT0ciFHWeT91vDWnjC0WpPzXaY+rqVDTiq+xhP6SY4RJuHqDVFnw+71bJxFBG+9awfS3dlUphIq9lRbsCPRRHODkuctYeUOMHqeWMfJlEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h30xA47khErfz2EcqaFwyeGy+Jay/8Wvy9NK7LWBhIQ=; b=YCl+OShFyNp20AKA3jMBlb9JKXh1yjS2EsYgj+tvwN2M/6JNi8hrpWuNFLZHeNVp2cqWN02OlbeS1CpStSEtEFmxra7ZKBj3l/NGjNjAa1kcQMvtgvxIQf/TfVe0yrlpo+vrH+WI7xWtHOK7gAJMYN3YpDlu9cdy7N/Kbp5PaKE= Received: from MW4PR21MB1907.namprd21.prod.outlook.com (2603:10b6:303:71::8) by MW4PR21MB2001.namprd21.prod.outlook.com (2603:10b6:303:68::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.1; Thu, 25 Mar 2021 18:35:12 +0000 Received: from MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::adcb:b821:ee26:3348]) by MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::adcb:b821:ee26:3348%8]) with mapi id 15.20.3999.016; Thu, 25 Mar 2021 18:35:12 +0000 From: "Bret Barkelew" To: "Bi, Dandan" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , Sean Brogan Subject: Re: [EXTERNAL] [patch V2 27/29] UnitTestFrameworkPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib Thread-Topic: [EXTERNAL] [patch V2 27/29] UnitTestFrameworkPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib Thread-Index: AQHXHvLbOJcmucF+kUuI2H+dRaEnjKqQU3E2gAB8TVCABD0t1Q== Date: Thu, 25 Mar 2021 18:35:12 +0000 Message-ID: References: <20210322080941.6780-1-dandan.bi@intel.com>,<20210322080941.6780-28-dandan.bi@intel.com> , In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-03-22T18:25:00.8511658Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [71.212.153.143] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: dc6a7c81-36de-49f5-00b0-08d8efbcba22 x-ms-traffictypediagnostic: MW4PR21MB2001: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GWTHvfPa8xJ/YFBsolhObhje9lTsqd1FaJn296lA6cdZeNqMlh/giTKMrsdx4yk7uhS8ajn3rWth39EVLR6YqlAhnpmnd5405vx/01q0fyHRRxQs4R3WIlACPDiMapPMDP4fxiSI/A7tOPk3Id/M2hcd7CueIOXmW/75GWB3p59PktpdEQw5ctKT0jFIj3A/N8REIMMtoW8JcdzWthGzBVLsl9wwI6wSykmJfUTaI2utGaUvFrkdo68dOuua4DFq8prLAI/aBEVQCjbRXxKyU6Nj9+9glnYi4ho9avnhTXFl9ZPdzYqVmIYFn32vI1zkxENwUPl1xJCES8TiBDWjDSFAJncu4HYZkin0jYnzfIXDp/GJr/WgjY0gs+f2y+MRDLZr8svVIBl/LmHUQB7Xi579FijsvrSpVk1EPX0Hv1YRHv0kWFBwEofn5fxZ8hXp4+JAZn4kGrvYculKfvGagt5Lz6dz9euyxv+efMDGf8z63WLJI1yYBNeFB0f0CG+ECGWweVB/RZELEbjRfR659xLrR984vnuHYzUeWrgIMkEroZTFqIot21mthZLnMceVYfLMMjzbZW6ESuOhQmirSr9iUIqF2XgZZcRdVjw3Bs5SbXbS47eRCV6/4zvQE8XHRc7SFZfYbkD+h9b66ttSFALQg+fbzZZohYvcMuzZxTaApfElAaTcIUfiz6zVzMsYxCep6xWsU+D/Kxaazs7Vnfy4GnCWbdS/E2yuffy3dH7e5S7TN/vlR6g0U06zSN0M x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR21MB1907.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(376002)(39860400002)(136003)(396003)(5660300002)(186003)(26005)(86362001)(82960400001)(82950400001)(107886003)(54906003)(10290500003)(38100700001)(6506007)(66556008)(55016002)(83380400001)(33656002)(166002)(4326008)(110136005)(52536014)(53546011)(478600001)(8990500004)(64756008)(8676002)(66946007)(66446008)(9686003)(7696005)(316002)(76116006)(71200400001)(966005)(2906002)(66476007)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?Windows-1252?Q?NhrkgjNE73Iarx6lKgUC6jpSnNf1zkjm8J5jc75o2BM87+47GxPQ7wxs?= =?Windows-1252?Q?b3jwfQXB99IYIXWGdAlDCEzURmnGsDGYFI6eTntAD1idaZJZ/2OWiOLc?= =?Windows-1252?Q?50/QMQbblf59LC+yuVvR6hHhRCjvtc38+3JUu8NCpz9i9eI89TC6LDja?= =?Windows-1252?Q?15CPGEgnm8+yRZPIgVutYDv+lUg7SB90eBM8ZscTo77saGeSGrmhY1NI?= =?Windows-1252?Q?HB6BQ14d6fQpwFoCdwcY/hrzyy1aNBB1bEbVMpZw5+spAGbxUmXlM8Ku?= =?Windows-1252?Q?yfze0GCumX7lUR+X6vaD4P1q7AzweFoMK7q2RDHrIJuit25YWc+r8KPF?= =?Windows-1252?Q?Utl1Q/Wi8sN2kNqNpcmQM4cJ5TZvz1//4Xkcy1Bsb5sOYj885ltd+apw?= =?Windows-1252?Q?edRhf70STnuk8YTBYdg6pXsOFLkWqChvMOM3ZZEa4yTqIvVf8um1zEzH?= =?Windows-1252?Q?ZwvrmRdUPK3lWCorIIiZG9BibnjLs5coh5HncH4yw2OET0lcChLVvALe?= =?Windows-1252?Q?sj0nZrnT/14VaIu7SPluzarhQ2ESJNuV+yczG9PiCdjj8SYZvRnRLfo5?= =?Windows-1252?Q?NkS9rECnCTkFd1R2Km+2fhR3GNINdxxWBC7tonYtwuS5ruL06GA90Y5W?= =?Windows-1252?Q?jvUxCM/74DxM2L1qQn2ApTdu/soPAkbNTNlGFwSuX1UWRLXWKZngBbcC?= =?Windows-1252?Q?2i36tHQPx6f2dZicaCBsoeeim3+wYgeQsRLb+PJO/K2zq3BqQKI9kYXN?= =?Windows-1252?Q?J+HHKUwGb9cCLoHU6t2/pEBQkRAY86Ct4neAC+BMZ80jCwfcY5+dbwuG?= =?Windows-1252?Q?FufEyGDjT31kwj9eBbG/kDu2Eyt6HsMNDh17wbUg0Q8kBJUlkP1xzV6i?= =?Windows-1252?Q?e0CcCw/OPzrHa8Bnq6O9pT+VChBbOD26Q/W73vbAhPJ9cYPfj4xZ6Prj?= =?Windows-1252?Q?hhVMmit8hlNoFWtmvrIgPDozypLzLL7XHrejbdjf71WmwFBeAjNedYnx?= =?Windows-1252?Q?wHyVeO83zQRuLyKsi3U7eAgK7djXb6Z5nFOkogmzEuwq501zucs/IS7i?= =?Windows-1252?Q?23o+pN7ImKze3TF1DJ9aFOKvEVu6uCw98a2Ys/nDN5OmIJMkpOFWGge3?= =?Windows-1252?Q?csQIQzTJ+uRRTN2Q0PIgLb9dbfiiRO0g0dJuSu+y6qZaIEvPSCBk7BBe?= =?Windows-1252?Q?PwGZHoIvFoAxfQWwUQKSwDik77VU3eikT5QXaYDSMLHH+N6M8TYObM1E?= =?Windows-1252?Q?MoA0csRaT3Fo0abWLVfA0h3tXoVhWem5DhfnxNPfdh206Dv6/Y9u4UIg?= =?Windows-1252?Q?5H0YnX4caIud88hrn0qQu0JFC/73YgpStbnXvXDfqlbr4VPJ9yeYt4xG?= =?Windows-1252?Q?Kp778yG3dEXKSraAwSsNyqSNRBAH2cQ/r3mpsAMkpKNxEp1p1h9sutaY?= =?Windows-1252?Q?094w09XENO60miP9yA3uFw=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR21MB1907.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc6a7c81-36de-49f5-00b0-08d8efbcba22 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2021 18:35:12.7391 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7+ABdzIfQXduT/KGutqonplU60u3/GWo8xynpRIDc68bQZYqaI5UgIO9Jp673C9lKRM5RkEp8WuTjUGOYfFMPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR21MB2001 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR21MB19077255E9B4F02A5BD6D9C3EF629MW4PR21MB1907namp_" --_000_MW4PR21MB19077255E9B4F02A5BD6D9C3EF629MW4PR21MB1907namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Thanks, Dandan! Apologies if this has already been asked, but is this necessary because C d= oesn=92t have any options for symbol namespacing? In other words, would it be just as easy to do this with a new implementati= on of IoLib if we didn=92t have to worry about the symbol collisions? - Bret From: Bi, Dandan Sent: Monday, March 22, 2021 6:52 PM To: Bret Barkelew; devel@edk2.groups.io= Cc: Kinney, Michael D; Sean Brogan Subject: RE: [EXTERNAL] [patch V2 27/29] UnitTestFrameworkPkg: Consume MdeL= ibs.dsc.inc for RegisterFilterLib Hi Bret, Here is the branch and PR I just created for this change, please help revie= w. Thanks. https://github.com/dandanbi/edk2/tree/RegisterFilterLibV2 https://github.com/tianocore/edk2/pull/1509 Thanks, Dandan From: Bret Barkelew Sent: Tuesday, March 23, 2021 2:25 AM To: Bi, Dandan ; devel@edk2.groups.io Cc: Kinney, Michael D ; Sean Brogan Subject: RE: [EXTERNAL] [patch V2 27/29] UnitTestFrameworkPkg: Consume MdeL= ibs.dsc.inc for RegisterFilterLib Is there a PR somewhere that has a branch with all these changes applied? I= =92d like to poke around a little. Thanks! - Bret From: Dandan Bi Sent: Monday, March 22, 2021 1:10 AM To: devel@edk2.groups.io Cc: Kinney, Michael D; Sean Brogan; Bret Barkelew Subject: [EXTERNAL] [patch V2 27/29] UnitTestFrameworkPkg: Consume MdeLibs.= dsc.inc for RegisterFilterLib REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbu= gzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3246&data=3D04%7C01%7CBret.B= arkelew%40microsoft.com%7C77dd99e3296941afb9b408d8ed09fd3c%7C72f988bf86f141= af91ab2d7cd011db47%7C1%7C0%7C637519974445661033%7CUnknown%7CTWFpbGZsb3d8eyJ= WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&= sdata=3DoDafPDNi1k2MRYGrp%2Frhy1dB43tk%2B0YwF8%2FxdLqBXt8%3D&reserved= =3D0 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for RegisterFilterLibNull which will be consumed by IoLib and BaseLib. Cc: Michael D Kinney > Cc: Sean Brogan > Cc: Bret Barkelew > Signed-off-by: Dandan Bi > --- UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc b/Unit= TestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc index 8adf690098..4adb98aff5 100644 --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc @@ -1,14 +1,16 @@ ## @file # UnitTestFrameworkPkg DSC include file for target based test DSC # -# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.
+# Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent # ## [LibraryClasses] + !include MdePkg/MdeLibs.dsc.inc + # # Entry point # PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntry= Point.inf -- 2.18.0.windows.1 --_000_MW4PR21MB19077255E9B4F02A5BD6D9C3EF629MW4PR21MB1907namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

Thanks, Dandan!

 

Apologies if this has already been asked, but is thi= s necessary because C doesn=92t have any options for symbol namespacing?

In other words, would it be just as easy to do this = with a new implementation of IoLib if we didn=92t have to worry about the s= ymbol collisions?

 

- Bret

 

From: Bi, Dandan
Sent: Monday, March 22, 2021 6:52 PM
To: Bret Barkelew= ; devel@edk2.groups.io
Cc: Kinney, Michael D<= /a>; Sean Brogan
Subject: RE: [EXTERNAL] [patch V2 27/29] UnitTestFrameworkPkg: Consu= me MdeLibs.dsc.inc for RegisterFilterLib

 

Hi Bret,

 

Here is the branch and PR I just created for this ch= ange, please help review. Thanks.

https://github.com/dandanbi/edk2= /tree/RegisterFilterLibV2

https://github.com/tianocore/edk2/pull/1509

 

 

 

Thanks,

Dandan

 

From: Bret Barkelew <Bret.Barkelew@microso= ft.com>
Sent: Tuesday, March 23, 2021 2:25 AM
To: Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Sean Broga= n <sean.brogan@microsoft.com>
Subject: RE: [EXTERNAL] [patch V2 27/29] UnitTestFrameworkPkg: Consu= me MdeLibs.dsc.inc for RegisterFilterLib

 

Is there a PR somewhere that has a branch with all t= hese changes applied? I=92d like to poke around a little.

 

Thanks!

 

- Bret

 

From: = Dandan Bi
Sent: Monday, March 22, 2021 1:10 AM
To: devel@edk2.groups.io=
Cc: Kinney, Michael D<= /a>; Sean Brogan; Bret Barkel= ew
Subject: [EXTERNAL] [patch V2 27/29] UnitTestFrameworkPkg: Consume M= deLibs.dsc.inc for RegisterFilterLib

 

REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzill= a.tianocore.org%2Fshow_bug.cgi%3Fid%3D3246&amp;data=3D04%7C01%7CBret.Ba= rkelew%40microsoft.com%7C77dd99e3296941afb9b408d8ed09fd3c%7C72f988bf86f141a= f91ab2d7cd011db47%7C1%7C0%7C637519974445661033%7CUnknown%7CTWFpbGZsb3d8eyJW= IjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&a= mp;sdata=3DoDafPDNi1k2MRYGrp%2Frhy1dB43tk%2B0YwF8%2FxdLqBXt8%3D&amp;res= erved=3D0

MdeLibs.dsc.inc was added for some basic/default library
instances provided by MdePkg and RegisterFilterLibNull Library
was also added into it as the first version of MdeLibs.dsc.inc.

So update platform dsc to consume MdeLibs.dsc.inc for
RegisterFilterLibNull which will be consumed by IoLib and BaseLib.

Cc: Michael D Kinney <mich= ael.d.kinney@intel.com>
Cc: Sean Brogan <sean.broga= n@microsoft.com>
Cc: Bret Barkelew <Bret.B= arkelew@microsoft.com>
Signed-off-by: Dandan Bi <dandan.= bi@intel.com>
---
 UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc b/Unit= TestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc
index 8adf690098..4adb98aff5 100644
--- a/UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc
+++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc
@@ -1,14 +1,16 @@
 ## @file
 # UnitTestFrameworkPkg DSC include file for target based test DSC
 #
-# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.<BR= >
+# Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.<BR= >
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #
 ##
 
 [LibraryClasses]
+  !include MdePkg/MdeLibs.dsc.inc
+
   #
   # Entry point
   #
   PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.in= f
   UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiD= riverEntryPoint.inf
--
2.18.0.windows.1

 

 

--_000_MW4PR21MB19077255E9B4F02A5BD6D9C3EF629MW4PR21MB1907namp_--