From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.107.96.131]) by mx.groups.io with SMTP id smtpd.web08.4691.1625698825623522921 for ; Wed, 07 Jul 2021 16:00:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=hd1WmMGS; spf=pass (domain: microsoft.com, ip: 40.107.96.131, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ec4WiaacMvClQy6aupXWsEGpdCq6CZ24bVKMoMmd3dbA37UFXxZRk5eD+nkHAUsyp/SkpAmvesiUXdCygvW5zFmpdjNP4agnb542mtOTK4bRVQXnawyem1wla+6U6m7EuOjWkinTfVrHwaoWivXjijLzKXRNPQnCr7WV/49ok/KzMtnVyC7JZsOch18TozineGQuTFSJXMCiULJi34+x+BgtvgeYs4hZjoZwaJAIFg5JHyJPEzZIdEgF1lUZhELVEBTxpWcU6omi+/SrEIsYC6VFzYwNXN5z67qZ27EsBlffLZ9rwf72ZhcQ+/CPCVsw8gfDVKvkpb9u6nhah42q2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BVO4dRQFpl6WGKhhGMGp5S09GE0YMln2JhJpx+IzmYs=; b=Prqs78gvnfqwB2WO1cDRfSYks0aNU8N0zyZrTjmiidBeaiuxqXyrv0GM0O3yL1YD5eskQ9WPnVNcQ0O9JR0oG8XqLAif2FyA4+eOhKNg2Xj0kbgZpgahNHq3SvZwmR32eYnXWv/g5360sGj/57CaXkgzKKoiLPPBlwPD6JJ2TMNqJJ9fR4P4UwSbewHAaF6s/OsnH3aABtiUH7iA/HiREK6fO1sQRI2HR05hA2ZPLMPnVIta59PMclcPeOdWIe6d05fN4Tw3nrOCFC9+wT34SzZL1LUQS/SAdC5JthR3i4V2cAYoHMTf4YRnSi1xrM+RXd42IPnaa0YzYnY5XMQpWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BVO4dRQFpl6WGKhhGMGp5S09GE0YMln2JhJpx+IzmYs=; b=hd1WmMGSEMjXPgm70VSh/3QE409YQRWe9Dyu5PiY0VA56uIVHgK30sSctQ4EQfQ2bllR8fbhd5jxKDMA60v0jVA5RMI7g10+JwPs97qMowkHfKmJAoh1BzPJKEfb0tTXsijyOYiu2gt1TjbkXC+pAFQfznrx1DJsIULpQ/Xo81c= Received: from MW4PR21MB1907.namprd21.prod.outlook.com (2603:10b6:303:71::8) by MW2PR2101MB1113.namprd21.prod.outlook.com (2603:10b6:302:a::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.3; Wed, 7 Jul 2021 23:00:17 +0000 Received: from MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::dff:779b:e14b:8086]) by MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::dff:779b:e14b:8086%3]) with mapi id 15.20.4331.010; Wed, 7 Jul 2021 23:00:17 +0000 From: "Bret Barkelew" To: "devel@edk2.groups.io" , "Kinney, Michael D" CC: Liming Gao , Zhiguang Liu Subject: Re: [EXTERNAL] [edk2-devel] [Patch 1/1] MdePkg/Include: Add STATIC_ASSERT for L'' and L"" strings Thread-Topic: [EXTERNAL] [edk2-devel] [Patch 1/1] MdePkg/Include: Add STATIC_ASSERT for L'' and L"" strings Thread-Index: AQHXc4GG2NOArlMddUGmqTZsbNNpy6s4IGXT Date: Wed, 7 Jul 2021 23:00:17 +0000 Message-ID: References: <20210707224310.1665-1-michael.d.kinney@intel.com> In-Reply-To: <20210707224310.1665-1-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-07-07T22:59:13.1377554Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 392a46d3-0356-4b4e-bedd-08d9419afd05 x-ms-traffictypediagnostic: MW2PR2101MB1113: x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DEtGnOTTNTQT9KrwZc44zEQx7vLKIN9C86nmlfjpbuPOg6uSl/Ayj+3j14fF2YKHtyRXcKMjk4ZksX8wkJ6P0DZcpIL5fTUaiISl2UVHRovLCjzwzY6tFWL8qBM8wzhvBYhQQ5fQmZ5ZzKHnT6vxaImXJsle1L1Hayu+eB7q2Q/xq64Trby77xUApC1ZMRD6cEKnD3SwFBtTVXKkYt/bLmvi92E5PITEKxMZEYw/2F/JeZH4uL7rg44n4/7kB7LSGZyYUDI7MNASkzJPG/jx/Vt/ofBMC+nGT/jglUoTo5OJNLqAvVrfTfEoHwWZElfT+Msvpeqa66156nzRhRQYIG4RzKPwMVot8m14k8Z9pvMgdEsAKDJveehGngGFWgzSqdkHg6fqjRnYcXMauYQeG6obN3jBthQsED+TZoGBYEmpzoh1zgtOR8elYMDyAdQa+OYaDIZi61zqc/W3cb09VQn/esFIGKrOJgmKiestsMZ7yRStwVYquMG9T81nqcJEqRY2TPIsZcjGO7WnDeQeCHFHBhdQSJSMkxzC2xBmVM4OwpS5MWCTWAvxifweMDZJmbpHzo2vZri74gZjrSceKWhpIHNkAAIXyq3uGozcR3TbjFdQ89pbyopH28JlZYApMPHOjNjr0E38rD7I1HJQB2n7mWQk0B5hekrgMVImJz7xGef4oPyxywjtNosxfkhzoChXoX1o1WzaHGUeDevbvVx2BXVNPpxgdxvklFS6NZA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR21MB1907.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(9686003)(76116006)(166002)(71200400001)(8676002)(4326008)(86362001)(10290500003)(122000001)(8990500004)(55016002)(38100700002)(8936002)(478600001)(82950400001)(26005)(2906002)(186003)(52536014)(66476007)(110136005)(5660300002)(64756008)(66446008)(6506007)(54906003)(7696005)(33656002)(966005)(66556008)(66946007)(53546011)(83380400001)(82960400001)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?iWpb4gcGfb4YDKd1vfamdbkQJuRpxclFxHKhV1177L/uhoP4CxezByYs?= =?Windows-1252?Q?hXVQ+0mlyyOW+66LSW0TJ2lG/Om3EaR/lcS3dDQDBnTS6akwiD/DRDUe?= =?Windows-1252?Q?Bfv17daiVH6WFfshdZ9r7YpQ7AHXYWF2EJ78sJOKuXZKA4frWxbW4POB?= =?Windows-1252?Q?aXAr2poQ4HNdpvxHbeUwXXhoCzw/tgMzi4D+o2UnuFfb2LaDJd3oIRwt?= =?Windows-1252?Q?ZBQoQ6yU4XcoEvy4ZwuUrMuGCfIt4ULb7PmU0Uk6KqyyyqpoA2+fV+7q?= =?Windows-1252?Q?FixKu6JF5yslzP61UWbbKEZrfLwTotWm12KGwzayW5iyfUKrKDnr4UnM?= =?Windows-1252?Q?zKHfM3AuhKeoLXD3ehCNbWp9NpZr3mPln+2jgiHzO8kXxBG2WAZ2yOEE?= =?Windows-1252?Q?3IufuMW2WVlmZGl0MAP8An0ih6LVmUnZ6lxlKWEnysMEA6epIUDLzpeM?= =?Windows-1252?Q?F0UXQAxQdcS53WJkDrVkkmXklWbTG0vI90uvr24AR376m0+U066hGiLf?= =?Windows-1252?Q?5CqUTiWAeimpvbGXBQb8g7fXNHcn5S+U+Z/9FsmUgUxY72Ano9KfWOtp?= =?Windows-1252?Q?4zZGSH/HpdAUDJSrGf4i7EDwHrIcFDRkBq9H536J87ij8eUwikGjNZHG?= =?Windows-1252?Q?46wmzyq9ReGpLoZ5tZUFW5oFqzspZElkdHHmZaj+m0ikd/9E3uQ0FnL5?= =?Windows-1252?Q?34Z0SXumTHdXAZQ6ToAtx0F9IOMb//58/y4Qn/uK8D1jtKdt8DiLwCRI?= =?Windows-1252?Q?4+0VqybMdA6z/w95OavARUi0QIUoSRELFfWsP+Uhvg5O61WdUHgByRqj?= =?Windows-1252?Q?uzlFFmtt2rEhbUpI1Mm9v0c6FWZPZpRJjK5y+9SVeCYqE9j4+QJ+l0dJ?= =?Windows-1252?Q?I0f61HuV/hffMYlQCaT7m5ZkkcF9ERcA33XGEs3+UKIG0X1/TNxnRZ5I?= =?Windows-1252?Q?ClCPHnRHidEcwqxU1p1cJH5TTQxA5nFif2u+k6gWnZGF+B2HKC21BW6V?= =?Windows-1252?Q?fraR8TjLB5PWFBi0UEfQ232psJRhqCyVvLMt7xTtfPulo/UbMSefocA4?= =?Windows-1252?Q?pjlOEpE3ybK6ajqz5uBDa0OD2N+ETt4HOWD7EHv/kdtQTIyLU5gz/Lm4?= =?Windows-1252?Q?MyzDH4gfo3gy+VzLrkl9I3dYw63hCDilxJ0uHshk3dl0JVG4ORhJKIAj?= =?Windows-1252?Q?XHEn6kAaHphTY+RE3jmxkuUspxf/+XtMvSmTogMsd6WDq/QCEC/pwfJF?= =?Windows-1252?Q?RcRC2WKeqECkhYsp9lRYtIlHHHSPvtGRxM5wJu2HoIQByq4iK2eX4570?= =?Windows-1252?Q?SUUxkuA7NHvMxCm/IReaAOtSncHOnBB6oxJ2VYwPdepPf0vDk/bI06AZ?= =?Windows-1252?Q?939Fqr96HY5qqivQm5gQUowk0Kk+eRqDS+dKsbAaczH1lGkz0Ud9gcbj?= =?Windows-1252?Q?Znk+u7ZD1VLkG36y9PCz7w=3D=3D?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR21MB1907.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 392a46d3-0356-4b4e-bedd-08d9419afd05 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2021 23:00:17.4212 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: v0SnZha2VepeteXfBuGFQWs3AlQri0wHdOzrsrfhdBDsmMcrrHEdowIGKvzX2rEVgvOJlW1cGGItW1xmVnOkZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1113 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR21MB1907777218130443DE71DC0EEF1A9MW4PR21MB1907namp_" --_000_MW4PR21MB1907777218130443DE71DC0EEF1A9MW4PR21MB1907namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable I like it. Do you have an extra space after the (L=92A=92) and (L=94A=94)? Reviewed-by: Bret Barkelew - Bret From: Michael D Kinney via groups.io Sent: Wednesday, July 7, 2021 3:43 PM To: devel@edk2.groups.io Cc: Liming Gao; Zhiguang Liu Subject: [EXTERNAL] [edk2-devel] [Patch 1/1] MdePkg/Include: Add STATIC_AS= SERT for L'' and L"" strings Add STATIC_ASSERT() macros to verify that the compiler is configured correctly for the use of L'' and L"" strings. Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Michael D Kinney --- MdePkg/Include/Base.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h index 8e4271f6eaf5..2da08b0c787f 100644 --- a/MdePkg/Include/Base.h +++ b/MdePkg/Include/Base.h @@ -6,7 +6,7 @@ environment. There are a set of base libraries in the Mde Package that = can be used to implement base modules. -Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
+Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.
Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -821,6 +821,8 @@ STATIC_ASSERT (sizeof (INT64) =3D=3D 8, "sizeof (INT= 64) does not meet UEFI Specifi STATIC_ASSERT (sizeof (UINT64) =3D=3D 8, "sizeof (UINT64) does not meet = UEFI Specification Data Type requirements"); STATIC_ASSERT (sizeof (CHAR8) =3D=3D 1, "sizeof (CHAR8) does not meet U= EFI Specification Data Type requirements"); STATIC_ASSERT (sizeof (CHAR16) =3D=3D 2, "sizeof (CHAR16) does not meet = UEFI Specification Data Type requirements"); +STATIC_ASSERT (sizeof (L'A') =3D=3D 2, "sizeof (L'A') does not meet UE= FI Specification Data Type requirements"); +STATIC_ASSERT (sizeof (L"A") =3D=3D 4, "sizeof (L\"A\") does not meet = UEFI Specification Data Type requirements"); // // The following three enum types are used to verify that the compiler -- 2.32.0.windows.1 --_000_MW4PR21MB1907777218130443DE71DC0EEF1A9MW4PR21MB1907namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

I like it.

Do you have an extra space after the (L=92A=92) and= (L=94A=94)?

 

Reviewed-by: Bret Barkelew <bret.barkelew@micros= oft.com>

 

- Bret

 

From: Michael D Kinney via = groups.io
Sent: Wednesday, July 7, 2021 3:43 PM
To: devel@edk2.groups.io
Cc: Liming Gao; Zhiguang Liu
Subject: [EXTERNAL] [edk2-devel] [Patch 1/1] MdePkg/Include: Add ST= ATIC_ASSERT for L'' and L"" strings

 

Add STATIC_ASSERT() = macros to verify that the compiler is
configured correctly for the use of L'' and L"" strings.

Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 MdePkg/Include/Base.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h
index 8e4271f6eaf5..2da08b0c787f 100644
--- a/MdePkg/Include/Base.h
+++ b/MdePkg/Include/Base.h
@@ -6,7 +6,7 @@
   environment. There are a set of base libraries in the Mde Pac= kage that can
   be used to implement base modules.
 
-Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR&= gt;
+Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR&= gt;
 Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.&= lt;BR>
 SPDX-License-Identifier: BSD-2-Clause-Patent
 
@@ -821,6 +821,8 @@ STATIC_ASSERT (sizeof (INT64)   =3D=3D 8, &q= uot;sizeof (INT64) does not meet UEFI Specifi
 STATIC_ASSERT (sizeof (UINT64)  =3D=3D 8, "sizeof (UINT64)= does not meet UEFI Specification Data Type requirements");
 STATIC_ASSERT (sizeof (CHAR8)   =3D=3D 1, "sizeof (CH= AR8) does not meet UEFI Specification Data Type requirements");
 STATIC_ASSERT (sizeof (CHAR16)  =3D=3D 2, "sizeof (CHAR16)= does not meet UEFI Specification Data Type requirements");
+STATIC_ASSERT (sizeof (L'A')    =3D=3D 2, "sizeof (L'= A') does not meet UEFI Specification Data Type requirements");
+STATIC_ASSERT (sizeof (L"A")    =3D=3D 4, "= sizeof (L\"A\") does not meet UEFI Specification Data Type requir= ements");
 
 //
 // The following three enum types are used to verify that the compil= er
--
2.32.0.windows.1





 

--_000_MW4PR21MB1907777218130443DE71DC0EEF1A9MW4PR21MB1907namp_--