From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from na01-obe.outbound.protection.outlook.com (na01-obe.outbound.protection.outlook.com [52.101.61.15]) by mx.groups.io with SMTP id smtpd.web10.445.1635882368179994867 for ; Tue, 02 Nov 2021 12:46:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=VyLLi8fG; spf=pass (domain: microsoft.com, ip: 52.101.61.15, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GbhR0aVCESMUA2HPnnmQNxgjsLTrbCtlExwRui+lD8gpBc9qi6Zv9bi0PBWkol24xrkq1XyRqXi9c6bJ9/o47DW9iXmcAo/ickLj41oISOBx8LGgTGJXPnPu+EmhqQEozEzF34AM3OLO1hFLTPDSC1+aUZ6XbtRCrF4GvO/QWYLFFOCPfQ3bbYENTXb5/838/eY7D3sqqZWyliRfyVK+BRuWhKbSWdS8RkSycZzb0oMETJR5wxqaScDuRJ3eig8Hburd9jvX9bwTli8ugng65kl7/M79OfgzKEltQkIegRULugag/EgazmQUH7r+YnlIh9J9gnJ4vaQdU6Vq+tiUiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NhO5QXACV8iB+XJ6KawUYQemM8ZVsMUKkkidoiejQuY=; b=i/45dcj8ImzStfZTN8DTw9T+5Ez/povYAz98YWpaCV2Tq2Skz93RYR5NrKNh5ietBPIC8Rf1qaxdeKNxTjQq5ymMP6OSXVcWxha2X4uGYOUzK7EJLtFcTt7r0wj7flEf2CtPMXzElQOj+b+RrG9bGADnmA3gwZryndqHgxd51MfWfbLsoUTj0ZHl+MYe3GJovzCI1QU6a6w1lV5rgrHN4fvZLo6rBn89gmVZKzVbpiJtaDG2C8jCSrB+bfI4Vqvym5j/rdi6pnhF3isLUSml7Ez2+lvh9U+6eT+42Pllr6e9YqDsL82Spdeq/fdPTQy/dHuxZb6XJulAgnhGuBwxSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NhO5QXACV8iB+XJ6KawUYQemM8ZVsMUKkkidoiejQuY=; b=VyLLi8fGxc/uaIlOjylUe8RAHA7vrmGrSHi6vMkSawofcxLLDq6bWOQIZYlgGdP5PQ7Zmqh8hwWhlK18JHog45s2PEF+spaMa9T8qepDZKG5Uu0mkzzpZ2hO3cU8hhA1gXo/QV5sEB9/jB6Vvz3Qg7owPWU64lrL0xVFmKLJhhw= Received: from MW4PR21MB1907.namprd21.prod.outlook.com (2603:10b6:303:71::8) by MWHPR21MB0800.namprd21.prod.outlook.com (2603:10b6:300:128::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.3; Tue, 2 Nov 2021 19:45:59 +0000 Received: from MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::7d8b:5fc0:be80:ab1f]) by MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::7d8b:5fc0:be80:ab1f%5]) with mapi id 15.20.4690.003; Tue, 2 Nov 2021 19:45:59 +0000 From: "Bret Barkelew" To: "devel@edk2.groups.io" , "Lindholm, Leif" , "brbarkel@microsoft.com" CC: "devel@edk2.groups.io" , Ard Biesheuvel , "Feng, Bob C" , Liming Gao , "Chen, Yuwei" , Sean Brogan Subject: Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 06/16] ArmPkg and BaseTools: Move the GccLto binaries from ArmPkg to BaseTools Thread-Topic: [EXTERNAL] Re: [edk2-devel] [PATCH v1 06/16] ArmPkg and BaseTools: Move the GccLto binaries from ArmPkg to BaseTools Thread-Index: AQHXz8/B0lhCRbvDIUaAWS5CdF+Z8qvwpNFY Date: Tue, 2 Nov 2021 19:45:59 +0000 Message-ID: References: <20211101195648.6420-1-brbarkel@microsoft.com> <20211101195648.6420-7-brbarkel@microsoft.com> <20211102095514.o5ermrxjikklgy3n@leviathan> In-Reply-To: <20211102095514.o5ermrxjikklgy3n@leviathan> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-11-02T19:45:42.1871436Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 556bd39a-6f9d-4e6d-5bd7-08d99e3964f4 x-ms-traffictypediagnostic: MWHPR21MB0800: x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:972; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XUdv8NMLd1agnTrBMwaNHrR4TiNs7f0jPo0DcPeNiA24W9WdbQlWS50AC8f/MXzkpjhciAOdtsNaSOdZL5Xav9bw4QAp0JcG8ArtkVJFP2bUabZ6hanMImIzf+NVcfkj+FFQBOZZrB48WYVX+jEYL288ohA3jR8co7A8o6H50ta7Y3oCnSbKeRqb8MzuvTV+ipZLzlDRe4wDBZXg2vSfOPXM9ddws0jCw/qDKRrgHRIc49yP7vqsWL6NsyxGx/OdagClm/8rEGrtaDnwBLhL8zi3qG/8phN/C329DwT94KR0nOQLiD8eB6pzxvPn0pZrEYJcMsYuqX5j876t4hdWwi0ZLoShK+FDoix/zAcb1+n20SYK1o1IvRJ2avfsyJT9DYUJnxJDFFJFCRG/P06ob4JVTVauEK09VEXE1rcujy2AiOmfNl7GqBqQkWTX4+VjVOgirXrtyTVqmNCBAW4BCB6IPXUS5wiqmeLvn88drGsvzV7oQEiL9Ayea8cV6ZsLeRvsDx4oU17ymBbbHxNYVHlt3e4BVuuky1+uq+jHXAyBfDesI0UV2GEVUZI5dGpTjhjh4AD8vv+14dwAXjVe9j2CTnO6JgeXzOpSed7Y+syO20KY/7lWpforItK261Xy66/DGijlJ/aIdozCei+6+mUGuswunsu3AV8KkC/x+6EynDsTspJokU++6JLg+5GJ9EU+jo3sbSsQwF18lyEWh1YstAXt6zOev/9NRTjP0wrk5A1cypEc6Iu0DTRMCa8T1of7QgIrEP2eTf2ksX/wq8aBsCZQv4QbCQ5foCmBRIzJvmyRHaH5tDxshAkMqmgv x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR21MB1907.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38100700002)(6506007)(9686003)(55016002)(52536014)(7696005)(122000001)(54906003)(66946007)(10290500003)(53546011)(107886003)(4326008)(30864003)(2906002)(508600001)(82950400001)(66556008)(82960400001)(110136005)(66476007)(64756008)(66446008)(5660300002)(71200400001)(316002)(76116006)(8990500004)(86362001)(186003)(8936002)(26005)(166002)(966005)(19627235002)(33656002)(8676002)(38070700005)(83380400001)(491001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zx7ZV0chIeKY8wzL5wXdrtOH0ikzgGHwLcD61YowP8St7W7l9qGSpe04/h7E?= =?us-ascii?Q?J7Lf+L1vqkkJu5nY7MXXvjtzxLF8qEYsEBgyt4bqF+d+5vUm/KC+E20EEUZ5?= =?us-ascii?Q?8rlfxsiZMaupxZhOJnJtSObWQWdz2TreFDvHqkEpEhq2S7735EeUU6E5KXt6?= =?us-ascii?Q?jXZoRomubJIZZdG9Wye+mJ5MzKNevZjmXlmY7aDhB690pM8kZRWv04YUOeyt?= =?us-ascii?Q?aAXjkNHIbUE8kqDFeLgPgo5O+vGAyopdOqI33re5nd3NZLBiYFuDh2eqeyXo?= =?us-ascii?Q?eXtv1a51PCUNNUpRDSuTd36JVJX2kzl4KpZsme1yOkHKnzEMdt6o5jofzcnB?= =?us-ascii?Q?etTC+mF/SwYAjRzaSylH9tYqHL89f17CdV8uio8jHFBqt/TkQmyTh0NjMBNw?= =?us-ascii?Q?1Czvk7RalWx6SDuyol7Nezo+t5No4Y4FO0Dcram5/cZJkCfC/g6XnNZxqO7G?= =?us-ascii?Q?uYdGQsDvdCaMZh5v9bmDnN/RWEG7JFrV8Gyc+MjAimCi/A5HStddoHz/0VsW?= =?us-ascii?Q?Xzk9uVE5T4XD6bM2Qjj5Qzk3K1VivfFCCaT45bYnMRtqQSJRJydJcKwjaW50?= =?us-ascii?Q?w2EncxA7O7uthxxkdiMXjQ1iEICtDsCSdF8Vp5J6RjbXnEy6d3NFkLbU2/HF?= =?us-ascii?Q?84ybKXvL253mvCbt27nnprBklW3W7w0aKMHYW9Onbv8/l6maHTJ7PbUvf3uH?= =?us-ascii?Q?aiskQRvBiD7/mt+zrv38NG90fctU0Vbp6rgdSqaKmlLtLLbnvbS2bc58j1DT?= =?us-ascii?Q?MgwAITwCGgLNHn2PtXD5xkmvQ5sab1p1LVBaNf+JG8kkIAAWB6C+gc9icj7n?= =?us-ascii?Q?K4/wIE37Iyygm+jDmwkKMhPTt+c3PscOfKa1kI5qyGMMZD5HIbQRy28IsSPr?= =?us-ascii?Q?DbKp7Og2y6okAhRFC44uNIGjBX7eLeEHT33FG+VblPrv7cwlEG2qyQZG66Tq?= =?us-ascii?Q?ihBaTEsNfisYoXM5Lv0797Eu8mHDbFSV1JEwF0jlFfSzeq3ZL0W8NJtClqbl?= =?us-ascii?Q?weczpjt5fl47mM3KMNgjKyiQjNFRt292ujMWDVs2K0V8xGkZCfBfVdmG15NV?= =?us-ascii?Q?6kesUXHwtu4H4FxDBStVqY1pC9FCBoQ0Iqaq2aVfjb5YUMRIBkFFBNAa4vne?= =?us-ascii?Q?nv9sgNvh4Js6ZkFrxqdFt5NaR8YJZq7K3gPHELHVUecMrjiz8jcOhX7C5bab?= =?us-ascii?Q?qwwhzFeHd4++zcGB2y1ZFAOhs0HVrCkKw0bHwLdVYmN+9DclFo5PIAYM4UJL?= =?us-ascii?Q?jlB62TCvgOaC/lpgAHDjKfzI0eyxFJnLkSGg720diXS4t748yj3aS/kmbv8C?= =?us-ascii?Q?e90n6OgskWGREMFy3TRwjooFq9cdHYOu1MQm1MQ9XvznVAgBJGiOZRcdLCqS?= =?us-ascii?Q?I9f8lM08WOD9iAbQDQaULqe/nE/yrQ7ueubZKhEcbZvRbW4JI6f7ur6A9kci?= =?us-ascii?Q?Xn6+PSr6pS7eddugWiZgDJwo3fIVyMT4kDK7C3f3EUgHb4v8tJg99OzwmMyZ?= =?us-ascii?Q?jDh3O05MPVHAiTKy1zLCVIn/K/Ih2J+EBUkgdrp3iy3TjjIvh01jGE5oXrOy?= =?us-ascii?Q?zbDID/XvJ330qFg3LLWCQUy7nBA27vbxhNrTD+Rs8LVUpcjfantO/3DJaeMg?= =?us-ascii?Q?xvXXePi28zCf38+MXOd/9mgMIUaGFOZQrfYECOg55hXX?= MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR21MB1907.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 556bd39a-6f9d-4e6d-5bd7-08d99e3964f4 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2021 19:45:59.3098 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Wvn+bWD/UCkzp1lEhH37M0kh0lJaLpGcEa7jqlkEIP5KiByTiSaTSW+Fe3wm4iL7cSUVPi6nIK6oDaudSyRD4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0800 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR21MB190778AA9DD1678F80BC1A9BEF8B9MW4PR21MB1907namp_" --_000_MW4PR21MB190778AA9DD1678F80BC1A9BEF8B9MW4PR21MB1907namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Good call. Maintainers, your opinion? - Bret From: Leif Lindholm via groups.io Sent: Tuesday, November 2, 2021 2:55 AM To: brbarkel@microsoft.com Cc: devel@edk2.groups.io; Ard Biesheuvel; Feng, Bob C; Lim= ing Gao; Chen, Yuwei; Sean Brogan Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v1 06/16] ArmPkg and BaseTools:= Move the GccLto binaries from ArmPkg to BaseTools On Mon, Nov 01, 2021 at 12:56:38 -0700, brbarkel@microsoft.com wrote: > From: Bret Barkelew > > This aligns better with Mu's philosophy around dependency structuring > and is one of the steps to enable Basecore to have zero CI dependencies > on other Mu repos. > > REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2F= bugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3650&data=3D04%7C01%7Cbret= .barkelew%40microsoft.com%7Cc9129586336447a44c3908d99de6e1d1%7C72f988bf86f1= 41af91ab2d7cd011db47%7C1%7C0%7C637714437251132216%7CUnknown%7CTWFpbGZsb3d8e= yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&am= p;sdata=3DijjQG1L4fScVxSn5nIBQGrFHLVtNbuTfd0YYLGdw8sg%3D&reserved=3D0 > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Bob Feng > Cc: Liming Gao > Cc: Yuwei Chen > Cc: Sean Brogan > Signed-off-by: Bret Barkelew No objections to this for any of my use-cases, but I'd like for one of the BaseTools maintainers to comment on whether this breaks anything with regards to EDK_TOOLS_PATH, or if we can finally get rid of that and replace it with $WORKSPACE/BaseTools globally. / Leif > --- > {ArmPkg/Library =3D> BaseTools/Bin}/GccLto/liblto-aarch64.a | Bin > {ArmPkg/Library =3D> BaseTools/Bin}/GccLto/liblto-aarch64.s | 0 > {ArmPkg/Library =3D> BaseTools/Bin}/GccLto/liblto-arm.a | Bin > {ArmPkg/Library =3D> BaseTools/Bin}/GccLto/liblto-arm.s | 0 > BaseTools/Conf/tools_def.template | 19 ++++++++= ++--------- > 5 files changed, 10 insertions(+), 9 deletions(-) > > diff --git a/ArmPkg/Library/GccLto/liblto-aarch64.a b/BaseTools/Bin/GccLt= o/liblto-aarch64.a > similarity index 100% > rename from ArmPkg/Library/GccLto/liblto-aarch64.a > rename to BaseTools/Bin/GccLto/liblto-aarch64.a > diff --git a/ArmPkg/Library/GccLto/liblto-aarch64.s b/BaseTools/Bin/GccLt= o/liblto-aarch64.s > similarity index 100% > rename from ArmPkg/Library/GccLto/liblto-aarch64.s > rename to BaseTools/Bin/GccLto/liblto-aarch64.s > diff --git a/ArmPkg/Library/GccLto/liblto-arm.a b/BaseTools/Bin/GccLto/li= blto-arm.a > similarity index 100% > rename from ArmPkg/Library/GccLto/liblto-arm.a > rename to BaseTools/Bin/GccLto/liblto-arm.a > diff --git a/ArmPkg/Library/GccLto/liblto-arm.s b/BaseTools/Bin/GccLto/li= blto-arm.s > similarity index 100% > rename from ArmPkg/Library/GccLto/liblto-arm.s > rename to BaseTools/Bin/GccLto/liblto-arm.s > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def= .template > index 2e6b382ab623..cd8899d24d4a 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -15,7 +15,8 @@ > # 2.00 - Initial version with changes for CI > # - Change RC path to use plugin > # > -#!VERSION=3D2.00 > +# 2.10 - Move GccLto files to a tools path to be more repository layout = agnostic > +#!VERSION=3D2.10 > > IDENTIFIER =3D Default TOOL_CHAIN_CONF > > @@ -2386,10 +2387,10 @@ RELEASE_GCC5_X64_DLINK_FLAGS =3D DEF(GCC5_X64= _DLINK_FLAGS) -flto -Os > *_GCC5_ARM_CC_XIPFLAGS =3D DEF(GCC5_ARM_CC_XIPFLAGS) > > DEBUG_GCC5_ARM_CC_FLAGS =3D DEF(GCC5_ARM_CC_FLAGS) -flto -Wno-u= nused-but-set-variable -Wno-unused-const-variable > - DEBUG_GCC5_ARM_DLINK_FLAGS =3D DEF(GCC5_ARM_DLINK_FLAGS) -flto -Os= -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-arm -Wl,-plugin-opt=3D-pass-thr= ough=3D-llto-arm > + DEBUG_GCC5_ARM_DLINK_FLAGS =3D DEF(GCC5_ARM_DLINK_FLAGS) -flto -Os= -L$(WORKSPACE)/BaseTools/Bin/GccLto -llto-arm -Wl,-plugin-opt=3D-pass-thro= ugh=3D-llto-arm > > RELEASE_GCC5_ARM_CC_FLAGS =3D DEF(GCC5_ARM_CC_FLAGS) -flto -Wno-u= nused-but-set-variable -Wno-unused-const-variable > -RELEASE_GCC5_ARM_DLINK_FLAGS =3D DEF(GCC5_ARM_DLINK_FLAGS) -flto -Os= -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-arm -Wl,-plugin-opt=3D-pass-thr= ough=3D-llto-arm > +RELEASE_GCC5_ARM_DLINK_FLAGS =3D DEF(GCC5_ARM_DLINK_FLAGS) -flto -Os= -L$(WORKSPACE)/BaseTools/Bin/GccLto -llto-arm -Wl,-plugin-opt=3D-pass-thro= ugh=3D-llto-arm > > NOOPT_GCC5_ARM_CC_FLAGS =3D DEF(GCC5_ARM_CC_FLAGS) -O0 > NOOPT_GCC5_ARM_DLINK_FLAGS =3D DEF(GCC5_ARM_DLINK_FLAGS) -O0 > @@ -2420,11 +2421,11 @@ RELEASE_GCC5_ARM_DLINK_FLAGS =3D DEF(GCC5_ARM= _DLINK_FLAGS) -flto -Os -L$(WORKS > *_GCC5_AARCH64_CC_XIPFLAGS =3D DEF(GCC5_AARCH64_CC_XIPFLAGS) > > DEBUG_GCC5_AARCH64_CC_FLAGS =3D DEF(GCC5_AARCH64_CC_FLAGS) -flto -W= no-unused-but-set-variable -Wno-unused-const-variable > - DEBUG_GCC5_AARCH64_DLINK_FLAGS =3D DEF(GCC5_AARCH64_DLINK_FLAGS) -flto= -Os -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-aarch64 -Wl,-plugin-opt=3D-= pass-through=3D-llto-aarch64 -Wno-lto-type-mismatch > + DEBUG_GCC5_AARCH64_DLINK_FLAGS =3D DEF(GCC5_AARCH64_DLINK_FLAGS) -flto= -Os -L$(WORKSPACE)/BaseTools/Bin/GccLto -llto-aarch64 -Wl,-plugin-opt=3D-p= ass-through=3D-llto-aarch64 -Wno-lto-type-mismatch > DEBUG_GCC5_AARCH64_DLINK_XIPFLAGS =3D -z common-page-size=3D0x20 > > RELEASE_GCC5_AARCH64_CC_FLAGS =3D DEF(GCC5_AARCH64_CC_FLAGS) -flto -W= no-unused-but-set-variable -Wno-unused-const-variable > -RELEASE_GCC5_AARCH64_DLINK_FLAGS =3D DEF(GCC5_AARCH64_DLINK_FLAGS) -flto= -Os -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-aarch64 -Wl,-plugin-opt=3D-= pass-through=3D-llto-aarch64 -Wno-lto-type-mismatch > +RELEASE_GCC5_AARCH64_DLINK_FLAGS =3D DEF(GCC5_AARCH64_DLINK_FLAGS) -flto= -Os -L$(WORKSPACE)/BaseTools/Bin/GccLto -llto-aarch64 -Wl,-plugin-opt=3D-p= ass-through=3D-llto-aarch64 -Wno-lto-type-mismatch > RELEASE_GCC5_AARCH64_DLINK_XIPFLAGS =3D -z common-page-size=3D0x20 > > NOOPT_GCC5_AARCH64_CC_FLAGS =3D DEF(GCC5_AARCH64_CC_FLAGS) -O0 > @@ -2681,11 +2682,11 @@ DEFINE CLANG38_ARM_DLINK_FLAGS =3D DEF(CLANG38_= ARM_TARGET) DEF(GCC_ARM_DLINK_FLA > *_CLANG38_ARM_CC_XIPFLAGS =3D DEF(GCC_ARM_CC_XIPFLAGS) > > DEBUG_CLANG38_ARM_CC_FLAGS =3D DEF(CLANG38_ARM_CC_FLAGS) $(ARCHCC_= FLAGS) $(PLATFORM_FLAGS) -flto -O1 > - DEBUG_CLANG38_ARM_DLINK_FLAGS =3D DEF(CLANG38_ARM_DLINK_FLAGS) -flto = -Wl,-O1 -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-arm -Wl,-plugin-opt=3D-p= ass-through=3D-llto-arm > + DEBUG_CLANG38_ARM_DLINK_FLAGS =3D DEF(CLANG38_ARM_DLINK_FLAGS) -flto = -Wl,-O1 -L$(WORKSPACE)/BaseTools/Bin/GccLto -llto-arm -Wl,-plugin-opt=3D-pa= ss-through=3D-llto-arm > NOOPT_CLANG38_ARM_CC_FLAGS =3D DEF(CLANG38_ARM_CC_FLAGS) $(ARCHCC_= FLAGS) $(PLATFORM_FLAGS) -O0 > NOOPT_CLANG38_ARM_DLINK_FLAGS =3D DEF(CLANG38_ARM_DLINK_FLAGS) > RELEASE_CLANG38_ARM_CC_FLAGS =3D DEF(CLANG38_ARM_CC_FLAGS) $(ARCHCC_= FLAGS) $(PLATFORM_FLAGS) -flto -O3 > -RELEASE_CLANG38_ARM_DLINK_FLAGS =3D DEF(CLANG38_ARM_DLINK_FLAGS) -flto = -Wl,-O3 -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-arm -Wl,-plugin-opt=3D-p= ass-through=3D-llto-arm > +RELEASE_CLANG38_ARM_DLINK_FLAGS =3D DEF(CLANG38_ARM_DLINK_FLAGS) -flto = -Wl,-O3 -L$(WORKSPACE)/BaseTools/Bin/GccLto -llto-arm -Wl,-plugin-opt=3D-pa= ss-through=3D-llto-arm > > ################## > # CLANG38 AARCH64 definitions > @@ -2727,11 +2728,11 @@ DEFINE CLANG38_AARCH64_DLINK_FLAGS =3D DEF(CLANG= 38_AARCH64_TARGET) DEF(GCC_AARCH6 > *_CLANG38_AARCH64_CC_XIPFLAGS =3D DEF(GCC_AARCH64_CC_XIPFLAGS) > > DEBUG_CLANG38_AARCH64_CC_FLAGS =3D DEF(CLANG38_AARCH64_CC_FLAGS) $(= ARCHCC_FLAGS) $(PLATFORM_FLAGS) -flto -O1 > - DEBUG_CLANG38_AARCH64_DLINK_FLAGS =3D DEF(CLANG38_AARCH64_DLINK_FLAGS)= -flto -Wl,-O1 -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-aarch64 -Wl,-plug= in-opt=3D-pass-through=3D-llto-aarch64 > + DEBUG_CLANG38_AARCH64_DLINK_FLAGS =3D DEF(CLANG38_AARCH64_DLINK_FLAGS)= -flto -Wl,-O1 -L$(WORKSPACE)/BaseTools/Bin/GccLto -llto-aarch64 -Wl,-plugi= n-opt=3D-pass-through=3D-llto-aarch64 > NOOPT_CLANG38_AARCH64_CC_FLAGS =3D DEF(CLANG38_AARCH64_CC_FLAGS) $(= ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O0 > NOOPT_CLANG38_AARCH64_DLINK_FLAGS =3D DEF(CLANG38_AARCH64_DLINK_FLAGS) > RELEASE_CLANG38_AARCH64_CC_FLAGS =3D DEF(CLANG38_AARCH64_CC_FLAGS) $(= ARCHCC_FLAGS) $(PLATFORM_FLAGS) -flto -O3 > -RELEASE_CLANG38_AARCH64_DLINK_FLAGS =3D DEF(CLANG38_AARCH64_DLINK_FLAGS)= -flto -Wl,-O3 -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-aarch64 -Wl,-plug= in-opt=3D-pass-through=3D-llto-aarch64 > +RELEASE_CLANG38_AARCH64_DLINK_FLAGS =3D DEF(CLANG38_AARCH64_DLINK_FLAGS)= -flto -Wl,-O3 -L$(WORKSPACE)/BaseTools/Bin/GccLto -llto-aarch64 -Wl,-plugi= n-opt=3D-pass-through=3D-llto-aarch64 > > ########################################################################= ############ > # > -- > 2.31.1.windows.1 > --_000_MW4PR21MB190778AA9DD1678F80BC1A9BEF8B9MW4PR21MB1907namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Good call. Maintainers, your opinion?

 

- Bret

 

From: Leif Lindholm via groups.io=
Sent: Tuesday, November 2, 2021 2:55 AM
To: brbarkel@microsoft.com Cc: devel@edk2.groups.io= ; Ard Biesheuvel; Feng, Bob C= ; Liming Gao; Chen, Yuwei; Sean Brogan
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v1 06/16] ArmPkg and Bas= eTools: Move the GccLto binaries from ArmPkg to BaseTools

 

On Mon, Nov 01, 2021 = at 12:56:38 -0700, brbarkel@microsoft.com wrote:
> From: Bret Barkelew <brbarkel@microsoft.com>
>
> This aligns better with Mu's philosophy around dependency structuring<= br> > and is one of the steps to enable Basecore to have zero CI dependencie= s
> on other Mu repos.
>
> REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzill= a.tianocore.org%2Fshow_bug.cgi%3Fid%3D3650&amp;data=3D04%7C01%7Cbret.ba= rkelew%40microsoft.com%7Cc9129586336447a44c3908d99de6e1d1%7C72f988bf86f141a= f91ab2d7cd011db47%7C1%7C0%7C637714437251132216%7CUnknown%7CTWFpbGZsb3d8eyJW= IjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&a= mp;sdata=3DijjQG1L4fScVxSn5nIBQGrFHLVtNbuTfd0YYLGdw8sg%3D&amp;reserved= =3D0
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Bret Barkelew <bret.barkelew@microsoft.com>

No objections to this for any of my use-cases, but I'd like for one of
the BaseTools maintainers to comment on whether this breaks anything
with regards to EDK_TOOLS_PATH, or if we can finally get rid of that
and replace it with $WORKSPACE/BaseTools globally.

/
    Leif

> ---
>  {ArmPkg/Library =3D> BaseTools/Bin}/GccLto/liblto-aarch64.a |= Bin
>  {ArmPkg/Library =3D> BaseTools/Bin}/GccLto/liblto-aarch64.s |=    0
>  {ArmPkg/Library =3D> BaseTools/Bin}/GccLto/liblto-arm.a =     | Bin
>  {ArmPkg/Library =3D> BaseTools/Bin}/GccLto/liblto-arm.s =     |   0
>  BaseTools/Conf/tools_def.template     &= nbsp;           &nbs= p;       |  19 ++++++++++---------
>  5 files changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/ArmPkg/Library/GccLto/liblto-aarch64.a b/BaseTools/Bin/Gc= cLto/liblto-aarch64.a
> similarity index 100%
> rename from ArmPkg/Library/GccLto/liblto-aarch64.a
> rename to BaseTools/Bin/GccLto/liblto-aarch64.a
> diff --git a/ArmPkg/Library/GccLto/liblto-aarch64.s b/BaseTools/Bin/Gc= cLto/liblto-aarch64.s
> similarity index 100%
> rename from ArmPkg/Library/GccLto/liblto-aarch64.s
> rename to BaseTools/Bin/GccLto/liblto-aarch64.s
> diff --git a/ArmPkg/Library/GccLto/liblto-arm.a b/BaseTools/Bin/GccLto= /liblto-arm.a
> similarity index 100%
> rename from ArmPkg/Library/GccLto/liblto-arm.a
> rename to BaseTools/Bin/GccLto/liblto-arm.a
> diff --git a/ArmPkg/Library/GccLto/liblto-arm.s b/BaseTools/Bin/GccLto= /liblto-arm.s
> similarity index 100%
> rename from ArmPkg/Library/GccLto/liblto-arm.s
> rename to BaseTools/Bin/GccLto/liblto-arm.s
> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_= def.template
> index 2e6b382ab623..cd8899d24d4a 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -15,7 +15,8 @@
>  # 2.00 - Initial version with changes for CI
>  #      - Change RC path to use plugin >  #
> -#!VERSION=3D2.00
> +# 2.10 - Move GccLto files to a tools path to be more repository layo= ut agnostic
> +#!VERSION=3D2.10
> 
>  IDENTIFIER =3D Default TOOL_CHAIN_CONF
> 
> @@ -2386,10 +2387,10 @@ RELEASE_GCC5_X64_DLINK_FLAGS   =   =3D DEF(GCC5_X64_DLINK_FLAGS) -flto -Os
>  *_GCC5_ARM_CC_XIPFLAGS       =     =3D DEF(GCC5_ARM_CC_XIPFLAGS)
> 
>    DEBUG_GCC5_ARM_CC_FLAGS     = ;   =3D DEF(GCC5_ARM_CC_FLAGS) -flto -Wno-unused-but-set-variable= -Wno-unused-const-variable
> -  DEBUG_GCC5_ARM_DLINK_FLAGS     =3D DEF(GCC= 5_ARM_DLINK_FLAGS) -flto -Os -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-arm= -Wl,-plugin-opt=3D-pass-through=3D-llto-arm
> +  DEBUG_GCC5_ARM_DLINK_FLAGS     =3D DEF(GCC= 5_ARM_DLINK_FLAGS) -flto -Os -L$(WORKSPACE)/BaseTools/Bin/GccLto -llto-arm = -Wl,-plugin-opt=3D-pass-through=3D-llto-arm
> 
>  RELEASE_GCC5_ARM_CC_FLAGS      &nb= sp; =3D DEF(GCC5_ARM_CC_FLAGS) -flto -Wno-unused-but-set-variable -Wno-unus= ed-const-variable
> -RELEASE_GCC5_ARM_DLINK_FLAGS     =3D DEF(GCC5_ARM= _DLINK_FLAGS) -flto -Os -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-arm -Wl,= -plugin-opt=3D-pass-through=3D-llto-arm
> +RELEASE_GCC5_ARM_DLINK_FLAGS     =3D DEF(GCC5_ARM= _DLINK_FLAGS) -flto -Os -L$(WORKSPACE)/BaseTools/Bin/GccLto -llto-arm -Wl,-= plugin-opt=3D-pass-through=3D-llto-arm
> 
>    NOOPT_GCC5_ARM_CC_FLAGS     = ;   =3D DEF(GCC5_ARM_CC_FLAGS) -O0
>    NOOPT_GCC5_ARM_DLINK_FLAGS     = =3D DEF(GCC5_ARM_DLINK_FLAGS) -O0
> @@ -2420,11 +2421,11 @@ RELEASE_GCC5_ARM_DLINK_FLAGS   =   =3D DEF(GCC5_ARM_DLINK_FLAGS) -flto -Os -L$(WORKS
>  *_GCC5_AARCH64_CC_XIPFLAGS       = =3D DEF(GCC5_AARCH64_CC_XIPFLAGS)
> 
>    DEBUG_GCC5_AARCH64_CC_FLAGS    =3D DE= F(GCC5_AARCH64_CC_FLAGS) -flto -Wno-unused-but-set-variable -Wno-unused-con= st-variable
> -  DEBUG_GCC5_AARCH64_DLINK_FLAGS =3D DEF(GCC5_AARCH64_DLINK_FLAG= S) -flto -Os -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-aarch64 -Wl,-plugin= -opt=3D-pass-through=3D-llto-aarch64 -Wno-lto-type-mismatch
> +  DEBUG_GCC5_AARCH64_DLINK_FLAGS =3D DEF(GCC5_AARCH64_DLINK_FLAG= S) -flto -Os -L$(WORKSPACE)/BaseTools/Bin/GccLto -llto-aarch64 -Wl,-plugin-= opt=3D-pass-through=3D-llto-aarch64 -Wno-lto-type-mismatch
>    DEBUG_GCC5_AARCH64_DLINK_XIPFLAGS =3D -z common-page= -size=3D0x20
> 
>  RELEASE_GCC5_AARCH64_CC_FLAGS    =3D DEF(GCC5_AAR= CH64_CC_FLAGS) -flto -Wno-unused-but-set-variable -Wno-unused-const-variabl= e
> -RELEASE_GCC5_AARCH64_DLINK_FLAGS =3D DEF(GCC5_AARCH64_DLINK_FLAGS) -f= lto -Os -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-aarch64 -Wl,-plugin-opt= =3D-pass-through=3D-llto-aarch64 -Wno-lto-type-mismatch
> +RELEASE_GCC5_AARCH64_DLINK_FLAGS =3D DEF(GCC5_AARCH64_DLINK_FLAGS) -f= lto -Os -L$(WORKSPACE)/BaseTools/Bin/GccLto -llto-aarch64 -Wl,-plugin-opt= =3D-pass-through=3D-llto-aarch64 -Wno-lto-type-mismatch
>  RELEASE_GCC5_AARCH64_DLINK_XIPFLAGS =3D -z common-page-size=3D0x= 20
> 
>    NOOPT_GCC5_AARCH64_CC_FLAGS    =3D DE= F(GCC5_AARCH64_CC_FLAGS) -O0
> @@ -2681,11 +2682,11 @@ DEFINE CLANG38_ARM_DLINK_FLAGS   =3D= DEF(CLANG38_ARM_TARGET) DEF(GCC_ARM_DLINK_FLA
>  *_CLANG38_ARM_CC_XIPFLAGS      &nb= sp; =3D DEF(GCC_ARM_CC_XIPFLAGS)
> 
>    DEBUG_CLANG38_ARM_CC_FLAGS     = =3D DEF(CLANG38_ARM_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -flto -O1 > -  DEBUG_CLANG38_ARM_DLINK_FLAGS  =3D DEF(CLANG38_ARM_DLINK_= FLAGS) -flto -Wl,-O1 -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-arm -Wl,-pl= ugin-opt=3D-pass-through=3D-llto-arm
> +  DEBUG_CLANG38_ARM_DLINK_FLAGS  =3D DEF(CLANG38_ARM_DLINK_= FLAGS) -flto -Wl,-O1 -L$(WORKSPACE)/BaseTools/Bin/GccLto -llto-arm -Wl,-plu= gin-opt=3D-pass-through=3D-llto-arm
>    NOOPT_CLANG38_ARM_CC_FLAGS     = =3D DEF(CLANG38_ARM_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O0
>    NOOPT_CLANG38_ARM_DLINK_FLAGS  =3D DEF(CLANG38_= ARM_DLINK_FLAGS)
>  RELEASE_CLANG38_ARM_CC_FLAGS     =3D DEF(CLA= NG38_ARM_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -flto -O3
> -RELEASE_CLANG38_ARM_DLINK_FLAGS  =3D DEF(CLANG38_ARM_DLINK_FLAGS= ) -flto -Wl,-O3 -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-arm -Wl,-plugin-= opt=3D-pass-through=3D-llto-arm
> +RELEASE_CLANG38_ARM_DLINK_FLAGS  =3D DEF(CLANG38_ARM_DLINK_FLAGS= ) -flto -Wl,-O3 -L$(WORKSPACE)/BaseTools/Bin/GccLto -llto-arm -Wl,-plugin-o= pt=3D-pass-through=3D-llto-arm
> 
>  ##################
>  # CLANG38 AARCH64 definitions
> @@ -2727,11 +2728,11 @@ DEFINE CLANG38_AARCH64_DLINK_FLAGS  =3D D= EF(CLANG38_AARCH64_TARGET) DEF(GCC_AARCH6
>  *_CLANG38_AARCH64_CC_XIPFLAGS    =3D DEF(GCC_AARC= H64_CC_XIPFLAGS)
> 
>    DEBUG_CLANG38_AARCH64_CC_FLAGS    =3D= DEF(CLANG38_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -flto -O1<= br> > -  DEBUG_CLANG38_AARCH64_DLINK_FLAGS =3D DEF(CLANG38_AARCH64_DLIN= K_FLAGS) -flto -Wl,-O1 -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-aarch64 -= Wl,-plugin-opt=3D-pass-through=3D-llto-aarch64
> +  DEBUG_CLANG38_AARCH64_DLINK_FLAGS =3D DEF(CLANG38_AARCH64_DLIN= K_FLAGS) -flto -Wl,-O1 -L$(WORKSPACE)/BaseTools/Bin/GccLto -llto-aarch64 -W= l,-plugin-opt=3D-pass-through=3D-llto-aarch64
>    NOOPT_CLANG38_AARCH64_CC_FLAGS    =3D= DEF(CLANG38_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O0
>    NOOPT_CLANG38_AARCH64_DLINK_FLAGS =3D DEF(CLANG38_AA= RCH64_DLINK_FLAGS)
>  RELEASE_CLANG38_AARCH64_CC_FLAGS    =3D DEF(CLANG= 38_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -flto -O3
> -RELEASE_CLANG38_AARCH64_DLINK_FLAGS =3D DEF(CLANG38_AARCH64_DLINK_FLA= GS) -flto -Wl,-O3 -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-aarch64 -Wl,-p= lugin-opt=3D-pass-through=3D-llto-aarch64
> +RELEASE_CLANG38_AARCH64_DLINK_FLAGS =3D DEF(CLANG38_AARCH64_DLINK_FLA= GS) -flto -Wl,-O3 -L$(WORKSPACE)/BaseTools/Bin/GccLto -llto-aarch64 -Wl,-pl= ugin-opt=3D-pass-through=3D-llto-aarch64
> 
>  ################################################################= ####################
>  #
> --
> 2.31.1.windows.1
>




 

--_000_MW4PR21MB190778AA9DD1678F80BC1A9BEF8B9MW4PR21MB1907namp_--