RFC: Adding support for ARM (RNDR etc.) to RngDxe

RFC: Adding support for ARM (RNDR etc.) to RngDxe

[Rebecca Cran]

Currently, RngDxe in SecurityPkg only supports Intel, with RdRand support.


This RFC is to start a discussion about adding support for ARM.


I have a Git branch with support for the optional ARMv8.5 RNDR 
instruction at https://github.com/bcran/edk2/commits/bcran-rndr which 
moves the existing Intel support into a Rand directory, and adds code to 
support RNDR in a new AArch64 directory.

There are other RNG implementations available for ARM, including 
platform-specific approaches on Graviton 
(https://lwn.net/Articles/790304/) and other platforms, so a more 
thorough rearchitecting/redesign may be desired.


-- 
Rebecca Cran

Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe

[Samer El-Haj-Mahmoud]

[-- Attachment #1: Type: text/plain, Size: 1483 bytes --]

There is also the TRNG FW API, which is an architected SMC firmware interface:

https://developer.arm.com/documentation/den0098/latest/


________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Rebecca Cran via groups.io <rebecca=nuviainc.com@groups.io>
Sent: Tuesday, December 8, 2020, 11:33 PM
To: devel@edk2.groups.io
Cc: rfc@edk2.groups.io; Jiewen Yao; Rahul Kumar
Subject: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe

Currently, RngDxe in SecurityPkg only supports Intel, with RdRand support.


This RFC is to start a discussion about adding support for ARM.


I have a Git branch with support for the optional ARMv8.5 RNDR
instruction at https://github.com/bcran/edk2/commits/bcran-rndr which
moves the existing Intel support into a Rand directory, and adds code to
support RNDR in a new AArch64 directory.

There are other RNG implementations available for ARM, including
platform-specific approaches on Graviton
(https://lwn.net/Articles/790304/) and other platforms, so a more
thorough rearchitecting/redesign may be desired.


--
Rebecca Cran








IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

[-- Attachment #2: Type: text/html, Size: 2999 bytes --]

Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe

[Sami Mujawar]

[-- Attachment #1: Type: text/plain, Size: 2443 bytes --]

Hi All,

I am working on the TRNG FW API interface and will share more details for the discussion soon.
We had some thoughts about streamlining the RngDxe implementations and would like to share some diagrams for the discussion.
My diagrams are in Visio that I can export as JPG images. However, I am open to switching to any other suggested tool.

Hi Leif,

Can you suggest on how we can collaborate to share diagrams/documents, please?

Regards,

Sami Mujawar

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Samer El-Haj-Mahmoud via groups.io
Sent: 09 December 2020 04:48 AM
To: devel@edk2.groups.io
Cc: rfc@edk2.groups.io; Jiewen Yao <jiewen.yao@intel.com>; Rahul Kumar <rahul1.kumar@intel.com>
Subject: Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe

There is also the TRNG FW API, which is an architected SMC firmware interface:

https://developer.arm.com/documentation/den0098/latest/

________________________________
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> on behalf of Rebecca Cran via groups.io <rebecca=nuviainc.com@groups.io<mailto:rebecca=nuviainc.com@groups.io>>
Sent: Tuesday, December 8, 2020, 11:33 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: rfc@edk2.groups.io<mailto:rfc@edk2.groups.io>; Jiewen Yao; Rahul Kumar
Subject: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe

Currently, RngDxe in SecurityPkg only supports Intel, with RdRand support.


This RFC is to start a discussion about adding support for ARM.


I have a Git branch with support for the optional ARMv8.5 RNDR
instruction at https://github.com/bcran/edk2/commits/bcran-rndr which
moves the existing Intel support into a Rand directory, and adds code to
support RNDR in a new AArch64 directory.

There are other RNG implementations available for ARM, including
platform-specific approaches on Graviton
(https://lwn.net/Articles/790304/) and other platforms, so a more
thorough rearchitecting/redesign may be desired.


--
Rebecca Cran






IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


[-- Attachment #2: Type: text/html, Size: 7480 bytes --]

Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe

[Leif Lindholm]

Hi Sami,

JPGs work, but preferably published in a location where they're
unlikely to be deleted, and posted as URLs.

https://app.diagrams.net/ doesn't require a licensed application to
edit, and can be "saved to github" for example.

Please make sure to use the diagrams to support/clarify the mailing
list conversation rather than replacing it.

Best Regards,

Leif

On Thu, Dec 10, 2020 at 11:26:26 +0000, Sami Mujawar wrote:
> Hi All,
> 
> I am working on the TRNG FW API interface and will share more details for the discussion soon.
> We had some thoughts about streamlining the RngDxe implementations
> and would like to share some diagrams for the discussion.
> My diagrams are in Visio that I can export as JPG images. However, I
> am open to switching to any other suggested tool.
> 
> Hi Leif,
> 
> Can you suggest on how we can collaborate to share diagrams/documents, please?
> 
> Regards,
> 
> Sami Mujawar
> 
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Samer El-Haj-Mahmoud via groups.io
> Sent: 09 December 2020 04:48 AM
> To: devel@edk2.groups.io
> Cc: rfc@edk2.groups.io; Jiewen Yao <jiewen.yao@intel.com>; Rahul Kumar <rahul1.kumar@intel.com>
> Subject: Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe
> 
> There is also the TRNG FW API, which is an architected SMC firmware interface:
> 
> https://developer.arm.com/documentation/den0098/latest/
> 
> ________________________________
> From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> on behalf of Rebecca Cran via groups.io <rebecca=nuviainc.com@groups.io<mailto:rebecca=nuviainc.com@groups.io>>
> Sent: Tuesday, December 8, 2020, 11:33 PM
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> Cc: rfc@edk2.groups.io<mailto:rfc@edk2.groups.io>; Jiewen Yao; Rahul Kumar
> Subject: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe
> 
> Currently, RngDxe in SecurityPkg only supports Intel, with RdRand support.
> 
> 
> This RFC is to start a discussion about adding support for ARM.
> 
> 
> I have a Git branch with support for the optional ARMv8.5 RNDR
> instruction at https://github.com/bcran/edk2/commits/bcran-rndr which
> moves the existing Intel support into a Rand directory, and adds code to
> support RNDR in a new AArch64 directory.
> 
> There are other RNG implementations available for ARM, including
> platform-specific approaches on Graviton
> (https://lwn.net/Articles/790304/) and other platforms, so a more
> thorough rearchitecting/redesign may be desired.
> 
> 
> --
> Rebecca Cran
> 
> 
> 
> 
> 
> 
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
> 

Re: [edk2-rfc] [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe

[Yao, Jiewen]

Maybe you can upload the content to https://edk2.groups.io/g/devel/files/Designs, where we hold the design review ppt, etc.

I assume we want to discuss below two APIs implementation, right?
1) RngLib
2) EFI_RNG_PROTOCOL

Thank you
Yao Jiewen

> -----Original Message-----
> From: rfc@edk2.groups.io <rfc@edk2.groups.io> On Behalf Of Leif Lindholm
> Sent: Thursday, December 10, 2020 8:52 PM
> To: Sami Mujawar <Sami.Mujawar@arm.com>
> Cc: devel@edk2.groups.io; Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com>; Ard Biesheuvel <Ard.Biesheuvel@arm.com>;
> rebecca@nuviainc.com; rfc@edk2.groups.io; Yao, Jiewen
> <jiewen.yao@intel.com>; Kumar, Rahul1 <rahul1.kumar@intel.com>; nd
> <nd@arm.com>
> Subject: Re: [edk2-rfc] [edk2-devel] RFC: Adding support for ARM (RNDR etc.)
> to RngDxe
> 
> Hi Sami,
> 
> JPGs work, but preferably published in a location where they're
> unlikely to be deleted, and posted as URLs.
> 
> https://app.diagrams.net/ doesn't require a licensed application to
> edit, and can be "saved to github" for example.
> 
> Please make sure to use the diagrams to support/clarify the mailing
> list conversation rather than replacing it.
> 
> Best Regards,
> 
> Leif
> 
> On Thu, Dec 10, 2020 at 11:26:26 +0000, Sami Mujawar wrote:
> > Hi All,
> >
> > I am working on the TRNG FW API interface and will share more details for
> the discussion soon.
> > We had some thoughts about streamlining the RngDxe implementations
> > and would like to share some diagrams for the discussion.
> > My diagrams are in Visio that I can export as JPG images. However, I
> > am open to switching to any other suggested tool.
> >
> > Hi Leif,
> >
> > Can you suggest on how we can collaborate to share diagrams/documents,
> please?
> >
> > Regards,
> >
> > Sami Mujawar
> >
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Samer
> El-Haj-Mahmoud via groups.io
> > Sent: 09 December 2020 04:48 AM
> > To: devel@edk2.groups.io
> > Cc: rfc@edk2.groups.io; Jiewen Yao <jiewen.yao@intel.com>; Rahul Kumar
> <rahul1.kumar@intel.com>
> > Subject: Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to
> RngDxe
> >
> > There is also the TRNG FW API, which is an architected SMC firmware
> interface:
> >
> > https://developer.arm.com/documentation/den0098/latest/
> >
> > ________________________________
> > From: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> on behalf of
> Rebecca Cran via groups.io
> <rebecca=nuviainc.com@groups.io<mailto:rebecca=nuviainc.com@groups.io
> >>
> > Sent: Tuesday, December 8, 2020, 11:33 PM
> > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> > Cc: rfc@edk2.groups.io<mailto:rfc@edk2.groups.io>; Jiewen Yao; Rahul
> Kumar
> > Subject: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe
> >
> > Currently, RngDxe in SecurityPkg only supports Intel, with RdRand support.
> >
> >
> > This RFC is to start a discussion about adding support for ARM.
> >
> >
> > I have a Git branch with support for the optional ARMv8.5 RNDR
> > instruction at https://github.com/bcran/edk2/commits/bcran-rndr which
> > moves the existing Intel support into a Rand directory, and adds code to
> > support RNDR in a new AArch64 directory.
> >
> > There are other RNG implementations available for ARM, including
> > platform-specific approaches on Graviton
> > (https://lwn.net/Articles/790304/) and other platforms, so a more
> > thorough rearchitecting/redesign may be desired.
> >
> >
> > --
> > Rebecca Cran
> >
> >
> >
> >
> >
> >
> > IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended recipient,
> please notify the sender immediately and do not disclose the contents to
> any other person, use it for any purpose, or store or copy the information in
> any medium. Thank you.
> >
> 
> 
> 
> 

Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe

[Rebecca Cran]

On 12/10/20 4:26 AM, Sami Mujawar wrote:

> I am working on the TRNG FW API interface and will share more details 
> for the discussion soon.
> 
> We had some thoughts about streamlining the RngDxe implementations and 
> would like to share some diagrams for the discussion.
> 
> My diagrams are in Visio that I can export as JPG images. However, I am 
> open to switching to any other suggested tool.

Hi Sami,

I don't see any further discussions on this. Have you made any progress 
with sharing the design documents or scheduling a review?

-- 
Rebecca Cran

Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe

[Sami Mujawar]

Hi All,

I have shared some initial thoughts on the RNG implementation updates at https://edk2.groups.io/g/devel/files/Designs/2021/0116/EDKII%20-%20Proposed%20update%20to%20RNG%20implementation.pdf

Kindly let me know your feedback or if you have any queries.

Regards,

Sami Mujawar

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran via groups.io
Sent: 14 January 2021 09:05 PM
To: Sami Mujawar <Sami.Mujawar@arm.com>; devel@edk2.groups.io; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Ard Biesheuvel <Ard.Biesheuvel@arm.com>; leif@nuviainc.com
Cc: rfc@edk2.groups.io; Jiewen Yao <jiewen.yao@intel.com>; Rahul Kumar <rahul1.kumar@intel.com>; nd <nd@arm.com>
Subject: Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe

On 12/10/20 4:26 AM, Sami Mujawar wrote:

> I am working on the TRNG FW API interface and will share more details 
> for the discussion soon.
> 
> We had some thoughts about streamlining the RngDxe implementations and 
> would like to share some diagrams for the discussion.
> 
> My diagrams are in Visio that I can export as JPG images. However, I am 
> open to switching to any other suggested tool.

Hi Sami,

I don't see any further discussions on this. Have you made any progress 
with sharing the design documents or scheduling a review?

-- 
Rebecca Cran

Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe

[Rebecca Cran]

On 1/15/21 7:51 PM, Sami Mujawar wrote:

> I have shared some initial thoughts on the RNG implementation updates at https://edk2.groups.io/g/devel/files/Designs/2021/0116/EDKII%20-%20Proposed%20update%20to%20RNG%20implementation.pdf
> 
> Kindly let me know your feedback or if you have any queries.
The ARMv8.5 RNDRRS instruction appears to be missing from the diagram on 
page 11 - it has RngLib|RNDR, which is listed under PRNG, but RNDRRS 
returns a true random number. From the Arm ARM:

"Returns a 64-bit random number which is reseeded from the True
Random Number source immediately before the read of the random number."

-- 
Rebecca Cran

Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe

[Ard Biesheuvel]

On Wed, 10 Feb 2021 at 23:49, Rebecca Cran <rebecca@nuviainc.com> wrote:
>
> On 1/15/21 7:51 PM, Sami Mujawar wrote:
>
> > I have shared some initial thoughts on the RNG implementation updates at https://edk2.groups.io/g/devel/files/Designs/2021/0116/EDKII%20-%20Proposed%20update%20to%20RNG%20implementation.pdf
> >
> > Kindly let me know your feedback or if you have any queries.
> The ARMv8.5 RNDRRS instruction appears to be missing from the diagram on
> page 11 - it has RngLib|RNDR, which is listed under PRNG, but RNDRRS
> returns a true random number. From the Arm ARM:
>
> "Returns a 64-bit random number which is reseeded from the True
> Random Number source immediately before the read of the random number."
>

This is an unfortunate oversight in the architecture, but RNDRRS most
certainly does not return a true random number.

RNDR and RNDRRS both return the output of a DRBG (pseudo RNG), and the
only difference is the reseed rate: RNDRRS triggers a reseed on every
invocation, whereas RNDR triggers a reseed at an IMPDEF rate.

Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe

[Rebecca Cran]

Hi Sami,

I was wondering if you're still collecting feedback on the design, or if 
you have a plan and schedule for the implementation?

-- 
Rebecca Cran

On 1/15/21 7:51 PM, Sami Mujawar wrote:
> Hi All,
> 
> I have shared some initial thoughts on the RNG implementation updates at https://edk2.groups.io/g/devel/files/Designs/2021/0116/EDKII%20-%20Proposed%20update%20to%20RNG%20implementation.pdf
> 
> Kindly let me know your feedback or if you have any queries.
> 
> Regards,
> 
> Sami Mujawar
> 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran via groups.io
> Sent: 14 January 2021 09:05 PM
> To: Sami Mujawar <Sami.Mujawar@arm.com>; devel@edk2.groups.io; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Ard Biesheuvel <Ard.Biesheuvel@arm.com>; leif@nuviainc.com
> Cc: rfc@edk2.groups.io; Jiewen Yao <jiewen.yao@intel.com>; Rahul Kumar <rahul1.kumar@intel.com>; nd <nd@arm.com>
> Subject: Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe
> 
> On 12/10/20 4:26 AM, Sami Mujawar wrote:
> 
>> I am working on the TRNG FW API interface and will share more details
>> for the discussion soon.
>>
>> We had some thoughts about streamlining the RngDxe implementations and
>> would like to share some diagrams for the discussion.
>>
>> My diagrams are in Visio that I can export as JPG images. However, I am
>> open to switching to any other suggested tool.
> 
> Hi Sami,
> 
> I don't see any further discussions on this. Have you made any progress
> with sharing the design documents or scheduling a review?
> 

Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe

[Sami Mujawar]

[-- Attachment #1: Type: text/plain, Size: 3223 bytes --]

Hi Rebecca,

I have been working on the following modules (See slide 11 in “EDKII - Proposed update to RNG implementation.pdf<https://edk2.groups.io/g/devel/files/Designs/2021/0116/EDKII%20-%20Proposed%20update%20to%20RNG%20implementation.pdf>”):

  1.  TrngLib|FwTrnglib (Arm Firmware TRNG)
  2.  DrbgLib stack – with support for DrbgAlgorithmLib|CRT_DRBG & AesLib|ArmAesInstructionLib.



I plan to post patches for (a) in the next fortnight. Following this I plan to update the proposal with the interface definitions for the various library interfaces in the DrbgLib Stack.



I have not looked at RngLib|RNDR as I believe you were interested in implementing the part. Kindly let me know if you plan to implement this and the platform you would be using for testing. It looks like the FVP_Base_AEMv8A-AEMv8A and the FVP-RevC models support RNDR, so these could be used for testing as well. Please feel free to get in touch should you need any help with the model parameters or if you face any issues.


Regards,

Sami Mujawar

From: Rebecca Cran <rebecca@nuviainc.com>
Date: Tuesday, 20 April 2021 at 21:04
To: Sami Mujawar <Sami.Mujawar@arm.com>, devel@edk2.groups.io <devel@edk2.groups.io>, Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>, Ard Biesheuvel <Ard.Biesheuvel@arm.com>, leif@nuviainc.com <leif@nuviainc.com>
Cc: rfc@edk2.groups.io <rfc@edk2.groups.io>, Jiewen Yao <jiewen.yao@intel.com>, Rahul Kumar <rahul1.kumar@intel.com>, nd <nd@arm.com>, Jose Marinho <Jose.Marinho@arm.com>
Subject: Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe
Hi Sami,

I was wondering if you're still collecting feedback on the design, or if
you have a plan and schedule for the implementation?

--
Rebecca Cran

On 1/15/21 7:51 PM, Sami Mujawar wrote:
> Hi All,
>
> I have shared some initial thoughts on the RNG implementation updates at https://edk2.groups.io/g/devel/files/Designs/2021/0116/EDKII%20-%20Proposed%20update%20to%20RNG%20implementation.pdf
>
> Kindly let me know your feedback or if you have any queries.
>
> Regards,
>
> Sami Mujawar
>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran via groups.io
> Sent: 14 January 2021 09:05 PM
> To: Sami Mujawar <Sami.Mujawar@arm.com>; devel@edk2.groups.io; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Ard Biesheuvel <Ard.Biesheuvel@arm.com>; leif@nuviainc.com
> Cc: rfc@edk2.groups.io; Jiewen Yao <jiewen.yao@intel.com>; Rahul Kumar <rahul1.kumar@intel.com>; nd <nd@arm.com>
> Subject: Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe
>
> On 12/10/20 4:26 AM, Sami Mujawar wrote:
>
>> I am working on the TRNG FW API interface and will share more details
>> for the discussion soon.
>>
>> We had some thoughts about streamlining the RngDxe implementations and
>> would like to share some diagrams for the discussion.
>>
>> My diagrams are in Visio that I can export as JPG images. However, I am
>> open to switching to any other suggested tool.
>
> Hi Sami,
>
> I don't see any further discussions on this. Have you made any progress
> with sharing the design documents or scheduling a review?
>

[-- Attachment #2: Type: text/html, Size: 11357 bytes --]

Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe

[Rebecca Cran]

Thanks. Yes, I'll work on implementing the RngLib|RNDR part.
I'll be using Qemu's sbsa-ref platform for testing. I'll also look into 
using the FVP_Base_AEMv8A-AEMv8A too.

-- 
Rebecca Cran

On 4/22/21 3:30 AM, Sami Mujawar wrote:
> Hi Rebecca,
> 
> I have been working on the following modules (See slide 11 in “EDKII - 
> Proposed update to RNG implementation.pdf 
> <https://edk2.groups.io/g/devel/files/Designs/2021/0116/EDKII%20-%20Proposed%20update%20to%20RNG%20implementation.pdf>”):
> 
>  1. TrngLib|FwTrnglib (Arm Firmware TRNG)
>  2. DrbgLib stack – with support for DrbgAlgorithmLib|CRT_DRBG &
>     AesLib|ArmAesInstructionLib.
> 
> I plan to post patches for (a) in the next fortnight. Following this I 
> plan to update the proposal with the interface definitions for the 
> various library interfaces in the DrbgLib Stack.
> 
> I have not looked at RngLib|RNDR as I believe you were interested in 
> implementing the part. Kindly let me know if you plan to implement this 
> and the platform you would be using for testing. It looks like the 
> FVP_Base_AEMv8A-AEMv8A and the FVP-RevC models support RNDR, so these 
> could be used for testing as well. Please feel free to get in touch 
> should you need any help with the model parameters or if you face any 
> issues.
> 
> Regards,
> 
> Sami Mujawar
> 
> *From: *Rebecca Cran <rebecca@nuviainc.com>
> *Date: *Tuesday, 20 April 2021 at 21:04
> *To: *Sami Mujawar <Sami.Mujawar@arm.com>, devel@edk2.groups.io 
> <devel@edk2.groups.io>, Samer El-Haj-Mahmoud 
> <Samer.El-Haj-Mahmoud@arm.com>, Ard Biesheuvel <Ard.Biesheuvel@arm.com>, 
> leif@nuviainc.com <leif@nuviainc.com>
> *Cc: *rfc@edk2.groups.io <rfc@edk2.groups.io>, Jiewen Yao 
> <jiewen.yao@intel.com>, Rahul Kumar <rahul1.kumar@intel.com>, nd 
> <nd@arm.com>, Jose Marinho <Jose.Marinho@arm.com>
> *Subject: *Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to 
> RngDxe
> 
> Hi Sami,
> 
> I was wondering if you're still collecting feedback on the design, or if
> you have a plan and schedule for the implementation?
> 
> -- 
> Rebecca Cran
> 
> On 1/15/21 7:51 PM, Sami Mujawar wrote:
>  > Hi All,
>  >
>  > I have shared some initial thoughts on the RNG implementation updates 
> at 
> https://edk2.groups.io/g/devel/files/Designs/2021/0116/EDKII%20-%20Proposed%20update%20to%20RNG%20implementation.pdf 
> <https://edk2.groups.io/g/devel/files/Designs/2021/0116/EDKII%20-%20Proposed%20update%20to%20RNG%20implementation.pdf>
>  >
>  > Kindly let me know your feedback or if you have any queries.
>  >
>  > Regards,
>  >
>  > Sami Mujawar
>  >
>  > -----Original Message-----
>  > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of 
> Rebecca Cran via groups.io
>  > Sent: 14 January 2021 09:05 PM
>  > To: Sami Mujawar <Sami.Mujawar@arm.com>; devel@edk2.groups.io; Samer 
> El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Ard Biesheuvel 
> <Ard.Biesheuvel@arm.com>; leif@nuviainc.com
>  > Cc: rfc@edk2.groups.io; Jiewen Yao <jiewen.yao@intel.com>; Rahul 
> Kumar <rahul1.kumar@intel.com>; nd <nd@arm.com>
>  > Subject: Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to 
> RngDxe
>  >
>  > On 12/10/20 4:26 AM, Sami Mujawar wrote:
>  >
>  >> I am working on the TRNG FW API interface and will share more details
>  >> for the discussion soon.
>  >>
>  >> We had some thoughts about streamlining the RngDxe implementations and
>  >> would like to share some diagrams for the discussion.
>  >>
>  >> My diagrams are in Visio that I can export as JPG images. However, I am
>  >> open to switching to any other suggested tool.
>  >
>  > Hi Sami,
>  >
>  > I don't see any further discussions on this. Have you made any progress
>  > with sharing the design documents or scheduling a review?
>  >
> 

Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe

[Rebecca Cran]

Hi Sami,

I've been looking through the design document again, and was wondering 
if the work I previously did will just slot in?

Were you thinking the "RngLib|RNDR" would go into ArmPkg (since it's not 
labeled as being in BaseRngLib)? Or would it still make sense to 
refactor MdePkg/Library/BaseRngLib to support both x86 (using RDRAND) 
and aarch64 (using RNDR)?

-- 
Rebecca Cran 
 


On 4/22/21 3:30 AM, Sami Mujawar wrote:
> Hi Rebecca,
> 
> I have been working on the following modules (See slide 11 in “EDKII - 
> Proposed update to RNG implementation.pdf 
> <https://edk2.groups.io/g/devel/files/Designs/2021/0116/EDKII%20-%20Proposed%20update%20to%20RNG%20implementation.pdf>”):
> 
>  1. TrngLib|FwTrnglib (Arm Firmware TRNG)
>  2. DrbgLib stack – with support for DrbgAlgorithmLib|CRT_DRBG &
>     AesLib|ArmAesInstructionLib.
> 
> I plan to post patches for (a) in the next fortnight. Following this I 
> plan to update the proposal with the interface definitions for the 
> various library interfaces in the DrbgLib Stack.
> 
> I have not looked at RngLib|RNDR as I believe you were interested in 
> implementing the part. Kindly let me know if you plan to implement this 
> and the platform you would be using for testing. It looks like the 
> FVP_Base_AEMv8A-AEMv8A and the FVP-RevC models support RNDR, so these 
> could be used for testing as well. Please feel free to get in touch 
> should you need any help with the model parameters or if you face any 
> issues.
> 
> Regards,
> 
> Sami Mujawar
> 
> *From: *Rebecca Cran <rebecca@nuviainc.com>
> *Date: *Tuesday, 20 April 2021 at 21:04
> *To: *Sami Mujawar <Sami.Mujawar@arm.com>, devel@edk2.groups.io 
> <devel@edk2.groups.io>, Samer El-Haj-Mahmoud 
> <Samer.El-Haj-Mahmoud@arm.com>, Ard Biesheuvel <Ard.Biesheuvel@arm.com>, 
> leif@nuviainc.com <leif@nuviainc.com>
> *Cc: *rfc@edk2.groups.io <rfc@edk2.groups.io>, Jiewen Yao 
> <jiewen.yao@intel.com>, Rahul Kumar <rahul1.kumar@intel.com>, nd 
> <nd@arm.com>, Jose Marinho <Jose.Marinho@arm.com>
> *Subject: *Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to 
> RngDxe
> 
> Hi Sami,
> 
> I was wondering if you're still collecting feedback on the design, or if
> you have a plan and schedule for the implementation?
> 
> -- 
> Rebecca Cran
> 
> On 1/15/21 7:51 PM, Sami Mujawar wrote:
>  > Hi All,
>  >
>  > I have shared some initial thoughts on the RNG implementation updates 
> at 
> https://edk2.groups.io/g/devel/files/Designs/2021/0116/EDKII%20-%20Proposed%20update%20to%20RNG%20implementation.pdf 
> <https://edk2.groups.io/g/devel/files/Designs/2021/0116/EDKII%20-%20Proposed%20update%20to%20RNG%20implementation.pdf>
>  >
>  > Kindly let me know your feedback or if you have any queries.
>  >
>  > Regards,
>  >
>  > Sami Mujawar
>  >
>  > -----Original Message-----
>  > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of 
> Rebecca Cran via groups.io
>  > Sent: 14 January 2021 09:05 PM
>  > To: Sami Mujawar <Sami.Mujawar@arm.com>; devel@edk2.groups.io; Samer 
> El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Ard Biesheuvel 
> <Ard.Biesheuvel@arm.com>; leif@nuviainc.com
>  > Cc: rfc@edk2.groups.io; Jiewen Yao <jiewen.yao@intel.com>; Rahul 
> Kumar <rahul1.kumar@intel.com>; nd <nd@arm.com>
>  > Subject: Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to 
> RngDxe
>  >
>  > On 12/10/20 4:26 AM, Sami Mujawar wrote:
>  >
>  >> I am working on the TRNG FW API interface and will share more details
>  >> for the discussion soon.
>  >>
>  >> We had some thoughts about streamlining the RngDxe implementations and
>  >> would like to share some diagrams for the discussion.
>  >>
>  >> My diagrams are in Visio that I can export as JPG images. However, I am
>  >> open to switching to any other suggested tool.
>  >
>  > Hi Sami,
>  >
>  > I don't see any further discussions on this. Have you made any progress
>  > with sharing the design documents or scheduling a review?
>  >
> 

Re: [EXTERNAL] Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe

[Bret Barkelew]

[-- Attachment #1: Type: text/plain, Size: 6446 bytes --]

I vote the latter.

- Bret

From: Rebecca Cran via groups.io<mailto:rebecca=nuviainc.com@groups.io>
Sent: Monday, April 26, 2021 2:29 PM
To: Sami Mujawar<mailto:Sami.Mujawar@arm.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Samer El-Haj-Mahmoud<mailto:Samer.El-Haj-Mahmoud@arm.com>; Ard Biesheuvel<mailto:Ard.Biesheuvel@arm.com>; leif@nuviainc.com<mailto:leif@nuviainc.com>
Cc: rfc@edk2.groups.io<mailto:rfc@edk2.groups.io>; Yao, Jiewen<mailto:jiewen.yao@intel.com>; Rahul Kumar<mailto:rahul1.kumar@intel.com>; nd<mailto:nd@arm.com>; Jose Marinho<mailto:Jose.Marinho@arm.com>
Subject: [EXTERNAL] Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe

Hi Sami,

I've been looking through the design document again, and was wondering
if the work I previously did will just slot in?

Were you thinking the "RngLib|RNDR" would go into ArmPkg (since it's not
labeled as being in BaseRngLib)? Or would it still make sense to
refactor MdePkg/Library/BaseRngLib to support both x86 (using RDRAND)
and aarch64 (using RNDR)?

--
Rebecca Cran



On 4/22/21 3:30 AM, Sami Mujawar wrote:
> Hi Rebecca,
>
> I have been working on the following modules (See slide 11 in “EDKII -
> Proposed update to RNG implementation.pdf
> <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Ffiles%2FDesigns%2F2021%2F0116%2FEDKII%2520-%2520Proposed%2520update%2520to%2520RNG%2520implementation.pdf&amp;data=04%7C01%7Cbret.barkelew%40microsoft.com%7C676a9101f67845dbdc8908d908fa4cd1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637550693569385394%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=Q8ka83ReO2aG8yTVrgpTAVxczJVjl2JBH3ksHo2%2BSHk%3D&amp;reserved=0>”<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Ffiles%2FDesigns%2F2021%2F0116%2FEDKII%2520-%2520Proposed%2520update%2520to%2520RNG%2520implementation.pdf&amp;data=04%7C01%7Cbret.barkelew%40microsoft.com%7C676a9101f67845dbdc8908d908fa4cd1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637550693569385394%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=Q8ka83ReO2aG8yTVrgpTAVxczJVjl2JBH3ksHo2%2BSHk%3D&amp;reserved=0%3e”>):
>
>  1. TrngLib|FwTrnglib (Arm Firmware TRNG)
>  2. DrbgLib stack – with support for DrbgAlgorithmLib|CRT_DRBG &
>     AesLib|ArmAesInstructionLib.
>
> I plan to post patches for (a) in the next fortnight. Following this I
> plan to update the proposal with the interface definitions for the
> various library interfaces in the DrbgLib Stack.
>
> I have not looked at RngLib|RNDR as I believe you were interested in
> implementing the part. Kindly let me know if you plan to implement this
> and the platform you would be using for testing. It looks like the
> FVP_Base_AEMv8A-AEMv8A and the FVP-RevC models support RNDR, so these
> could be used for testing as well. Please feel free to get in touch
> should you need any help with the model parameters or if you face any
> issues.
>
> Regards,
>
> Sami Mujawar
>
> *From: *Rebecca Cran <rebecca@nuviainc.com>
> *Date: *Tuesday, 20 April 2021 at 21:04
> *To: *Sami Mujawar <Sami.Mujawar@arm.com>, devel@edk2.groups.io
> <devel@edk2.groups.io>, Samer El-Haj-Mahmoud
> <Samer.El-Haj-Mahmoud@arm.com>, Ard Biesheuvel <Ard.Biesheuvel@arm.com>,
> leif@nuviainc.com <leif@nuviainc.com>
> *Cc: *rfc@edk2.groups.io <rfc@edk2.groups.io>, Jiewen Yao
> <jiewen.yao@intel.com>, Rahul Kumar <rahul1.kumar@intel.com>, nd
> <nd@arm.com>, Jose Marinho <Jose.Marinho@arm.com>
> *Subject: *Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to
> RngDxe
>
> Hi Sami,
>
> I was wondering if you're still collecting feedback on the design, or if
> you have a plan and schedule for the implementation?
>
> --
> Rebecca Cran
>
> On 1/15/21 7:51 PM, Sami Mujawar wrote:
>  > Hi All,
>  >
>  > I have shared some initial thoughts on the RNG implementation updates
> at
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Ffiles%2FDesigns%2F2021%2F0116%2FEDKII%2520-%2520Proposed%2520update%2520to%2520RNG%2520implementation.pdf&amp;data=04%7C01%7Cbret.barkelew%40microsoft.com%7C676a9101f67845dbdc8908d908fa4cd1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637550693569385394%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=Q8ka83ReO2aG8yTVrgpTAVxczJVjl2JBH3ksHo2%2BSHk%3D&amp;reserved=0
> <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Ffiles%2FDesigns%2F2021%2F0116%2FEDKII%2520-%2520Proposed%2520update%2520to%2520RNG%2520implementation.pdf&amp;data=04%7C01%7Cbret.barkelew%40microsoft.com%7C676a9101f67845dbdc8908d908fa4cd1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637550693569385394%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=Q8ka83ReO2aG8yTVrgpTAVxczJVjl2JBH3ksHo2%2BSHk%3D&amp;reserved=0>
>  >
>  > Kindly let me know your feedback or if you have any queries.
>  >
>  > Regards,
>  >
>  > Sami Mujawar
>  >
>  > -----Original Message-----
>  > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Rebecca Cran via groups.io
>  > Sent: 14 January 2021 09:05 PM
>  > To: Sami Mujawar <Sami.Mujawar@arm.com>; devel@edk2.groups.io; Samer
> El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Ard Biesheuvel
> <Ard.Biesheuvel@arm.com>; leif@nuviainc.com
>  > Cc: rfc@edk2.groups.io; Jiewen Yao <jiewen.yao@intel.com>; Rahul
> Kumar <rahul1.kumar@intel.com>; nd <nd@arm.com>
>  > Subject: Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to
> RngDxe
>  >
>  > On 12/10/20 4:26 AM, Sami Mujawar wrote:
>  >
>  >> I am working on the TRNG FW API interface and will share more details
>  >> for the discussion soon.
>  >>
>  >> We had some thoughts about streamlining the RngDxe implementations and
>  >> would like to share some diagrams for the discussion.
>  >>
>  >> My diagrams are in Visio that I can export as JPG images. However, I am
>  >> open to switching to any other suggested tool.
>  >
>  > Hi Sami,
>  >
>  > I don't see any further discussions on this. Have you made any progress
>  > with sharing the design documents or scheduling a review?
>  >
>







[-- Attachment #2: Type: text/html, Size: 10737 bytes --]

Re: [EXTERNAL] Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe

[Sami Mujawar]

[-- Attachment #1: Type: text/plain, Size: 7295 bytes --]

Hi Rebecca,

I agree MdePkg/Library/BaseRngLib can be refactored to support both x86 and AArch64.
BaseRngLib would then be a RngLib instance that uses CPU instructions to provide random numbers.

Regards,

Sami Mujawar

From: Bret Barkelew <Bret.Barkelew@microsoft.com>
Date: Monday, 26 April 2021 at 22:45
To: devel@edk2.groups.io <devel@edk2.groups.io>, rebecca@nuviainc.com <rebecca@nuviainc.com>, Sami Mujawar <Sami.Mujawar@arm.com>, Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>, Ard Biesheuvel <Ard.Biesheuvel@arm.com>, leif@nuviainc.com <leif@nuviainc.com>
Cc: rfc@edk2.groups.io <rfc@edk2.groups.io>, Yao, Jiewen <jiewen.yao@intel.com>, Rahul Kumar <rahul1.kumar@intel.com>, nd <nd@arm.com>, Jose Marinho <Jose.Marinho@arm.com>
Subject: RE: [EXTERNAL] Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe
I vote the latter.

- Bret

From: Rebecca Cran via groups.io<mailto:rebecca=nuviainc.com@groups.io>
Sent: Monday, April 26, 2021 2:29 PM
To: Sami Mujawar<mailto:Sami.Mujawar@arm.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Samer El-Haj-Mahmoud<mailto:Samer.El-Haj-Mahmoud@arm.com>; Ard Biesheuvel<mailto:Ard.Biesheuvel@arm.com>; leif@nuviainc.com<mailto:leif@nuviainc.com>
Cc: rfc@edk2.groups.io<mailto:rfc@edk2.groups.io>; Yao, Jiewen<mailto:jiewen.yao@intel.com>; Rahul Kumar<mailto:rahul1.kumar@intel.com>; nd<mailto:nd@arm.com>; Jose Marinho<mailto:Jose.Marinho@arm.com>
Subject: [EXTERNAL] Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe

Hi Sami,

I've been looking through the design document again, and was wondering
if the work I previously did will just slot in?

Were you thinking the "RngLib|RNDR" would go into ArmPkg (since it's not
labeled as being in BaseRngLib)? Or would it still make sense to
refactor MdePkg/Library/BaseRngLib to support both x86 (using RDRAND)
and aarch64 (using RNDR)?

--
Rebecca Cran



On 4/22/21 3:30 AM, Sami Mujawar wrote:
> Hi Rebecca,
>
> I have been working on the following modules (See slide 11 in “EDKII -
> Proposed update to RNG implementation.pdf
> <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Ffiles%2FDesigns%2F2021%2F0116%2FEDKII%2520-%2520Proposed%2520update%2520to%2520RNG%2520implementation.pdf&amp;data=04%7C01%7Cbret.barkelew%40microsoft.com%7C676a9101f67845dbdc8908d908fa4cd1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637550693569385394%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=Q8ka83ReO2aG8yTVrgpTAVxczJVjl2JBH3ksHo2%2BSHk%3D&amp;reserved=0>”<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Ffiles%2FDesigns%2F2021%2F0116%2FEDKII%2520-%2520Proposed%2520update%2520to%2520RNG%2520implementation.pdf&amp;data=04%7C01%7Cbret.barkelew%40microsoft.com%7C676a9101f67845dbdc8908d908fa4cd1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637550693569385394%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=Q8ka83ReO2aG8yTVrgpTAVxczJVjl2JBH3ksHo2%2BSHk%3D&amp;reserved=0%3e”>):
>
>  1. TrngLib|FwTrnglib (Arm Firmware TRNG)
>  2. DrbgLib stack – with support for DrbgAlgorithmLib|CRT_DRBG &
>     AesLib|ArmAesInstructionLib.
>
> I plan to post patches for (a) in the next fortnight. Following this I
> plan to update the proposal with the interface definitions for the
> various library interfaces in the DrbgLib Stack.
>
> I have not looked at RngLib|RNDR as I believe you were interested in
> implementing the part. Kindly let me know if you plan to implement this
> and the platform you would be using for testing. It looks like the
> FVP_Base_AEMv8A-AEMv8A and the FVP-RevC models support RNDR, so these
> could be used for testing as well. Please feel free to get in touch
> should you need any help with the model parameters or if you face any
> issues.
>
> Regards,
>
> Sami Mujawar
>
> *From: *Rebecca Cran <rebecca@nuviainc.com>
> *Date: *Tuesday, 20 April 2021 at 21:04
> *To: *Sami Mujawar <Sami.Mujawar@arm.com>, devel@edk2.groups.io
> <devel@edk2.groups.io>, Samer El-Haj-Mahmoud
> <Samer.El-Haj-Mahmoud@arm.com>, Ard Biesheuvel <Ard.Biesheuvel@arm.com>,
> leif@nuviainc.com <leif@nuviainc.com>
> *Cc: *rfc@edk2.groups.io <rfc@edk2.groups.io>, Jiewen Yao
> <jiewen.yao@intel.com>, Rahul Kumar <rahul1.kumar@intel.com>, nd
> <nd@arm.com>, Jose Marinho <Jose.Marinho@arm.com>
> *Subject: *Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to
> RngDxe
>
> Hi Sami,
>
> I was wondering if you're still collecting feedback on the design, or if
> you have a plan and schedule for the implementation?
>
> --
> Rebecca Cran
>
> On 1/15/21 7:51 PM, Sami Mujawar wrote:
>  > Hi All,
>  >
>  > I have shared some initial thoughts on the RNG implementation updates
> at
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Ffiles%2FDesigns%2F2021%2F0116%2FEDKII%2520-%2520Proposed%2520update%2520to%2520RNG%2520implementation.pdf&amp;data=04%7C01%7Cbret.barkelew%40microsoft.com%7C676a9101f67845dbdc8908d908fa4cd1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637550693569385394%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=Q8ka83ReO2aG8yTVrgpTAVxczJVjl2JBH3ksHo2%2BSHk%3D&amp;reserved=0
> <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Ffiles%2FDesigns%2F2021%2F0116%2FEDKII%2520-%2520Proposed%2520update%2520to%2520RNG%2520implementation.pdf&amp;data=04%7C01%7Cbret.barkelew%40microsoft.com%7C676a9101f67845dbdc8908d908fa4cd1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637550693569385394%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=Q8ka83ReO2aG8yTVrgpTAVxczJVjl2JBH3ksHo2%2BSHk%3D&amp;reserved=0>
>  >
>  > Kindly let me know your feedback or if you have any queries.
>  >
>  > Regards,
>  >
>  > Sami Mujawar
>  >
>  > -----Original Message-----
>  > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Rebecca Cran via groups.io
>  > Sent: 14 January 2021 09:05 PM
>  > To: Sami Mujawar <Sami.Mujawar@arm.com>; devel@edk2.groups.io; Samer
> El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Ard Biesheuvel
> <Ard.Biesheuvel@arm.com>; leif@nuviainc.com
>  > Cc: rfc@edk2.groups.io; Jiewen Yao <jiewen.yao@intel.com>; Rahul
> Kumar <rahul1.kumar@intel.com>; nd <nd@arm.com>
>  > Subject: Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to
> RngDxe
>  >
>  > On 12/10/20 4:26 AM, Sami Mujawar wrote:
>  >
>  >> I am working on the TRNG FW API interface and will share more details
>  >> for the discussion soon.
>  >>
>  >> We had some thoughts about streamlining the RngDxe implementations and
>  >> would like to share some diagrams for the discussion.
>  >>
>  >> My diagrams are in Visio that I can export as JPG images. However, I am
>  >> open to switching to any other suggested tool.
>  >
>  > Hi Sami,
>  >
>  > I don't see any further discussions on this. Have you made any progress
>  > with sharing the design documents or scheduling a review?
>  >
>








[-- Attachment #2: Type: text/html, Size: 12284 bytes --]