回复: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202102

回复: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202102

[gaoliming]

[-- Attachment #1: Type: text/plain, Size: 2173 bytes --]

Hi, Stewards and All:

 So far, there are still three patch sets to be requested to catch this
stable tag. They are bug fixes, and pass code review in soft feature freeze
phase. Have you any comments for them?

 

1.      Fix two issue in ArmGicLib
(https://edk2.groups.io/g/devel/message/72175)

2.      Fix CET shadow stack token busy bit clear issue
(https://edk2.groups.io/g/devel/message/71864)

[Liming] this version uses DB for the instruction. BZ
https://bugzilla.tianocore.org/show_bug.cgi?id=3227 is create for future
enhancement. 

3.      Use XADD to avoid lock acquire/release
(https://edk2.groups.io/g/devel/message/71516)

 

Thanks

Liming

发件人: bounce+27952+71922+4905953+8761045@groups.io
<bounce+27952+71922+4905953+8761045@groups.io> 代表 gaoliming
发送时间: 2021年2月22日 16:23
收件人: devel@edk2.groups.io; announce@edk2.groups.io
抄送: 'Andrew Fish' <afish@apple.com>; 'Laszlo Ersek' <lersek@redhat.com>;
leif@nuviainc.com; 'Michael D Kinney' <michael.d.kinney@intel.com>; 'Soumya
Guptha' <soumya.k.guptha@intel.com>
主题: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202102

 

Hi, all

We will enter into Soft Feature Freeze phase. In this phase, the feature
under review will not be allowed to be merged. The feature passed review can
still be merged. 

 

The patch review can continue without break in edk2 community. If the patch
is sent before Soft Feature Freeze, and plans to catch this stable tag, the
patch contributor need reply to his patch and notify edk2 community. If the
patch is sent after Soft Feature Freeze, and plans to catch this stable tag,
please add edk2-stable202102 key words in the patch title and BZ, so the
community know this patch target and give the feedback.

 

Below is edk2-stable202102 tag planning
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Plannin
g Proposed Schedule

Date (00:00:00 UTC-8) Description

2020-11-27  Beginning of development

2021-02-15  Feature Planning Freeze

2021-02-22  Soft Feature Freeze

2021-03-01  Hard Feature Freeze

2021-03-05  Release

 

Thanks

Liming




[-- Attachment #2: Type: text/html, Size: 9419 bytes --]

Re: 回复: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202102

[Laszlo Ersek]

Hi Liming,

On 02/26/21 07:27, gaoliming wrote:
> Hi, Stewards and All:
> 
>  So far, there are still three patch sets to be requested to catch this
> stable tag. They are bug fixes, and pass code review in soft feature freeze
> phase. Have you any comments for them?
> 
>  
> 
> 1.      Fix two issue in ArmGicLib
> (https://edk2.groups.io/g/devel/message/72175)
> 
> 2.      Fix CET shadow stack token busy bit clear issue
> (https://edk2.groups.io/g/devel/message/71864)
> 
> [Liming] this version uses DB for the instruction. BZ
> https://bugzilla.tianocore.org/show_bug.cgi?id=3227 is create for future
> enhancement. 
> 
> 3.      Use XADD to avoid lock acquire/release
> (https://edk2.groups.io/g/devel/message/71516)

I agree that the first two patch sets are bugfixes, but I'm not entirely
convinced the third one is a bugfix as well -- it is a performance
optimization, to my understanding. Without that patch set, there is no
misbehavior, things are just slower.

The bugfixes can be merged of course; I wouldn't merge the 3rd series
however.

... I can see Ray pushed the first patch of the third series:
<https://edk2.groups.io/g/devel/message/72249>

I disagree with that. Here's an excerpt from the commit message:

  With this patch, OVMF when running in a 255 threads QEMU spends about
  one second to wakeup all APs. Original implementation needs more than
  10 seconds.

I wouldn't call the pre-patch behavior a bug.

And the review for "[PATCH v3 1/4] UefiCpuPkg/MpInitLib: Use XADD to
avoid lock acquire/release" only arrived (from Mike) after the SFF, so I
don't think it should have been pushed.

On the other hand, I also won't ask for a revert.

Thanks
Laszlo


> 
>  
> 
> Thanks
> 
> Liming
> 
> 发件人: bounce+27952+71922+4905953+8761045@groups.io
> <bounce+27952+71922+4905953+8761045@groups.io> 代表 gaoliming
> 发送时间: 2021年2月22日 16:23
> 收件人: devel@edk2.groups.io; announce@edk2.groups.io
> 抄送: 'Andrew Fish' <afish@apple.com>; 'Laszlo Ersek' <lersek@redhat.com>;
> leif@nuviainc.com; 'Michael D Kinney' <michael.d.kinney@intel.com>; 'Soumya
> Guptha' <soumya.k.guptha@intel.com>
> 主题: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202102
> 
>  
> 
> Hi, all
> 
> We will enter into Soft Feature Freeze phase. In this phase, the feature
> under review will not be allowed to be merged. The feature passed review can
> still be merged. 
> 
>  
> 
> The patch review can continue without break in edk2 community. If the patch
> is sent before Soft Feature Freeze, and plans to catch this stable tag, the
> patch contributor need reply to his patch and notify edk2 community. If the
> patch is sent after Soft Feature Freeze, and plans to catch this stable tag,
> please add edk2-stable202102 key words in the patch title and BZ, so the
> community know this patch target and give the feedback.
> 
>  
> 
> Below is edk2-stable202102 tag planning
> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Plannin
> g Proposed Schedule
> 
> Date (00:00:00 UTC-8) Description
> 
> 2020-11-27  Beginning of development
> 
> 2021-02-15  Feature Planning Freeze
> 
> 2021-02-22  Soft Feature Freeze
> 
> 2021-03-01  Hard Feature Freeze
> 
> 2021-03-05  Release
> 
>  
> 
> Thanks
> 
> Liming
> 
> 
> 
> 

Re: [EXTERNAL] Re: 回复: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202102

[Bret Barkelew]

[-- Attachment #1: Type: text/plain, Size: 6478 bytes --]

Did the NASM CI patch make it in? I never saw another response after v3.

- Bret

From: Laszlo Ersek via groups.io<mailto:lersek=redhat.com@groups.io>
Sent: Monday, March 1, 2021 7:29 AM
To: gaoliming<mailto:gaoliming@byosoft.com.cn>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; announce@edk2.groups.io<mailto:announce@edk2.groups.io>; 'Andrew Fish'<mailto:afish@apple.com>; leif@nuviainc.com<mailto:leif@nuviainc.com>; Kinney, Michael D<mailto:michael.d.kinney@intel.com>
Cc: 'Soumya Guptha'<mailto:soumya.k.guptha@intel.com>; Ni, Ray<mailto:ray.ni@intel.com>; w.sheng@intel.com<mailto:w.sheng@intel.com>; 'Ming Huang'<mailto:huangming@linux.alibaba.com>; Yao, Jiewen<mailto:jiewen.yao@intel.com>
Subject: [EXTERNAL] Re: 回复: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202102

Hi Liming,

On 02/26/21 07:27, gaoliming wrote:
> Hi, Stewards and All:
>
>  So far, there are still three patch sets to be requested to catch this
> stable tag. They are bug fixes, and pass code review in soft feature freeze
> phase. Have you any comments for them?
>
>
>
> 1.      Fix two issue in ArmGicLib
> (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F72175&amp;data=04%7C01%7Cbret.barkelew%40microsoft.com%7Ce5040db931b846722c3e08d8dcc6bb7d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637502093407405739%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=S%2FU2%2F2FBDDWs9T7gLK0vt7rcfiap1vD0LgR%2Flw55STA%3D&amp;reserved=0)
>
> 2.      Fix CET shadow stack token busy bit clear issue
> (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F71864&amp;data=04%7C01%7Cbret.barkelew%40microsoft.com%7Ce5040db931b846722c3e08d8dcc6bb7d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637502093407405739%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=bF9pY1HTiqIXCvps6Igp%2BAbZoBGd%2FiF5IDxOtvXd42k%3D&amp;reserved=0)
>
> [Liming] this version uses DB for the instruction. BZ
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3227&amp;data=04%7C01%7Cbret.barkelew%40microsoft.com%7Ce5040db931b846722c3e08d8dcc6bb7d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637502093407405739%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=mhgx1IHCmtA6ro0SquHX5D4Hw2nKhw9QG7qbrb1S1J8%3D&amp;reserved=0 is create for future
> enhancement.
>
> 3.      Use XADD to avoid lock acquire/release
> (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F71516&amp;data=04%7C01%7Cbret.barkelew%40microsoft.com%7Ce5040db931b846722c3e08d8dcc6bb7d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637502093407405739%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=ZMO70jJEJEdXhxY71X5oQUoDFhb9b957%2BCVcc0od9cc%3D&amp;reserved=0)

I agree that the first two patch sets are bugfixes, but I'm not entirely
convinced the third one is a bugfix as well -- it is a performance
optimization, to my understanding. Without that patch set, there is no
misbehavior, things are just slower.

The bugfixes can be merged of course; I wouldn't merge the 3rd series
however.

... I can see Ray pushed the first patch of the third series:
<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F72249&amp;data=04%7C01%7Cbret.barkelew%40microsoft.com%7Ce5040db931b846722c3e08d8dcc6bb7d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637502093407405739%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=x6%2B7EikSUlD%2BCCnnf10g3Knv9sibI3X62PxtP9snnO4%3D&amp;reserved=0>

I disagree with that. Here's an excerpt from the commit message:

  With this patch, OVMF when running in a 255 threads QEMU spends about
  one second to wakeup all APs. Original implementation needs more than
  10 seconds.

I wouldn't call the pre-patch behavior a bug.

And the review for "[PATCH v3 1/4] UefiCpuPkg/MpInitLib: Use XADD to
avoid lock acquire/release" only arrived (from Mike) after the SFF, so I
don't think it should have been pushed.

On the other hand, I also won't ask for a revert.

Thanks
Laszlo


>
>
>
> Thanks
>
> Liming
>
> 发件人: bounce+27952+71922+4905953+8761045@groups.io
> <bounce+27952+71922+4905953+8761045@groups.io> 代表 gaoliming
> 发送时间: 2021年2月22日 16:23
> 收件人: devel@edk2.groups.io; announce@edk2.groups.io
> 抄送: 'Andrew Fish' <afish@apple.com>; 'Laszlo Ersek' <lersek@redhat.com>;
> leif@nuviainc.com; 'Michael D Kinney' <michael.d.kinney@intel.com>; 'Soumya
> Guptha' <soumya.k.guptha@intel.com>
> 主题: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202102
>
>
>
> Hi, all
>
> We will enter into Soft Feature Freeze phase. In this phase, the feature
> under review will not be allowed to be merged. The feature passed review can
> still be merged.
>
>
>
> The patch review can continue without break in edk2 community. If the patch
> is sent before Soft Feature Freeze, and plans to catch this stable tag, the
> patch contributor need reply to his patch and notify edk2 community. If the
> patch is sent after Soft Feature Freeze, and plans to catch this stable tag,
> please add edk2-stable202102 key words in the patch title and BZ, so the
> community know this patch target and give the feedback.
>
>
>
> Below is edk2-stable202102 tag planning
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Ftianocore.github.io%2Fwiki%2FEDK-II-Release-Plannin&amp;data=04%7C01%7Cbret.barkelew%40microsoft.com%7Ce5040db931b846722c3e08d8dcc6bb7d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637502093407405739%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=tu%2BB0dokBdtWSwng9JMRuKP5H4ShjaYlP6kurBGHBjU%3D&amp;reserved=0
> g Proposed Schedule
>
> Date (00:00:00 UTC-8) Description
>
> 2020-11-27  Beginning of development
>
> 2021-02-15  Feature Planning Freeze
>
> 2021-02-22  Soft Feature Freeze
>
> 2021-03-01  Hard Feature Freeze
>
> 2021-03-05  Release
>
>
>
> Thanks
>
> Liming
>
>
>
>







[-- Attachment #2: Type: text/html, Size: 13173 bytes --]