From: "Bret Barkelew" <bret.barkelew@microsoft.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com>,
Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [EXTERNAL] [Patch 3/3] .azurepipelines: Remove FINISHED and FAILED states
Date: Thu, 8 Jul 2021 03:51:56 +0000 [thread overview]
Message-ID: <MW4PR21MB1907A06D137BA5F717F08B23EF199@MW4PR21MB1907.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20210708034902.1608-4-michael.d.kinney@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1823 bytes --]
Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>
- Bret
From: Michael D Kinney<mailto:michael.d.kinney@intel.com>
Sent: Wednesday, July 7, 2021 8:49 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Sean Brogan<mailto:sean.brogan@microsoft.com>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; Liming Gao<mailto:gaoliming@byosoft.com.cn>
Subject: [EXTERNAL] [Patch 3/3] .azurepipelines: Remove FINISHED and FAILED states
Remove 10 second delay workarounds for issues observed
when Mergify was originally enabled. These issues are
no longer present when GitHub branch protections are
used for status checks.
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
.../templates/pr-gate-build-job.yml | 20 -------------------
1 file changed, 20 deletions(-)
diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index 3f9a28024567..207acc76316f 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -67,23 +67,3 @@ jobs:
build_pkgs: $(Build.Pkgs)
build_targets: $(Build.Targets)
build_archs: ${{ parameters.arch_list }}
-
-- job: FINISHED
- dependsOn: Build_${{ parameters.tool_chain_tag }}
- condition: succeeded()
- steps:
- - checkout: none
- - script: |
- echo FINISHED
- sleep 10
- displayName: FINISHED
-
-- job: FAILED
- dependsOn: Build_${{ parameters.tool_chain_tag }}
- condition: failed()
- steps:
- - checkout: none
- - script: |
- echo FAILED
- sleep 10
- displayName: FAILED
--
2.32.0.windows.1
[-- Attachment #2: Type: text/html, Size: 4185 bytes --]
next prev parent reply other threads:[~2021-07-08 3:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 3:48 [Patch 0/3] Mergify Enhancements Michael D Kinney
2021-07-08 3:49 ` [Patch 1/3] BaseTools/Scripts: Ignore Mergify merge commits in PatchCheck.py Michael D Kinney
2021-07-08 3:55 ` [EXTERNAL] [edk2-devel] " Bret Barkelew
2021-07-09 5:30 ` Bob Feng
2021-07-08 3:49 ` [Patch 2/3] .mergify: Simplify Mergify rules using GitHub status checks Michael D Kinney
2021-07-08 3:55 ` [EXTERNAL] " Bret Barkelew
2021-07-08 3:49 ` [Patch 3/3] .azurepipelines: Remove FINISHED and FAILED states Michael D Kinney
2021-07-08 3:51 ` Bret Barkelew [this message]
2021-07-09 5:09 ` 回复: [edk2-devel] [Patch 0/3] Mergify Enhancements gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR21MB1907A06D137BA5F717F08B23EF199@MW4PR21MB1907.namprd21.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox