From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.106]) by mx.groups.io with SMTP id smtpd.web09.11760.1623774056352485718 for ; Tue, 15 Jun 2021 09:20:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=T1nNzEW9; spf=pass (domain: microsoft.com, ip: 40.107.244.106, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SbJzvDl26EXdb/sbYZceG81XN2YkqByZCNr+kds4ToStwmAnFa3A51tP+hogpgJ1hsaudc/nlTraFLoj0zLRVhP+/KBJbmK9DDo8tlxtDcb/KXj8jzu4KAZj06MLT5o3L/yJcWPsxEs0RxNn5R5PS8KoVaOuZgr2JpowsOUqDKf08J2IFgYgE9q8NFRul3FKqVujjMaLIGEyFS3pGkypgRaQrp1Ptpy2rZqCfARBjPaz6M4OaEdGFMB/6c7/ALIfvWYZMyiTAkueU2SDn1gw6lkt3DAgI5Mx5xDkCxee+fZadYM7huv1hTBIUD4JrqVKVUmp/ige6YdINXmGwBeZNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y4zbORpypLltUiKb3RHw83A+IfPHYjO7orjYBStK8L0=; b=Y+rCFTXX2CTbxBwFOBMPwVVsFv1ZXRtS1yV+6RaqxbdOLMIyK3l7pvCcf2z9JQ1DZf3xzNDlpHy14lCFhNV4rYLxQZTDs4uTEEx1FRL1BjcYCmd2wvLRW8Et2xncryqJD6f85O5MZWwTLw6fzocZvjggM0uT6g36ro8XovA5gApt/pg3aIkICq71B5E77RsFLxRHLteiHx6dR1HeZmSjrFeGUsaRiBABjApdoHEe8iMvLdrq5P6MOHeJYnwf4pys26s+mDhnB3sSQyz5Lh6IfKfCbJoyxTInf1mAhki5tcv/+zo07PIkkrCxSd6IZFlKU5ppSbCSfVMrsJX265/Owg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y4zbORpypLltUiKb3RHw83A+IfPHYjO7orjYBStK8L0=; b=T1nNzEW9cidfnzRgUZ7gKtkgfCJATChljm1PPpLGcTrL6eLpodsYN+df0sDsH6PBiUidtlJ0EM/2fpE3tMskjrMK9OHOG5ARyTXipg4FS0wf07FcyiV+RFj0UiTi5ROB5xC1QxLClU3WW31A3ojY923S/M6K/kzw/sq+qT4Wj7M= Received: from MW4PR21MB1907.namprd21.prod.outlook.com (2603:10b6:303:71::8) by MWHPR21MB0750.namprd21.prod.outlook.com (2603:10b6:300:76::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.3; Tue, 15 Jun 2021 16:20:53 +0000 Received: from MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::14e1:41ea:6f4:eb9e]) by MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::14e1:41ea:6f4:eb9e%3]) with mapi id 15.20.4264.005; Tue, 15 Jun 2021 16:20:53 +0000 From: "Bret Barkelew" To: Sean Brogan , "devel@edk2.groups.io" , "kuqin12@gmail.com" CC: Sean Brogan , "Kinney, Michael D" , Liming Gao Subject: Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 1/1] Pytool: SpellCheck: Defer path expansion in cspell parameters Thread-Topic: [EXTERNAL] Re: [edk2-devel] [PATCH v1 1/1] Pytool: SpellCheck: Defer path expansion in cspell parameters Thread-Index: AQHXYf+L03CW36Dm/0ivyYjK7QfTF6sVQMQl Date: Tue, 15 Jun 2021 16:20:53 +0000 Message-ID: References: <20210612050431.660-1-kuqin12@gmail.com> <20210612050431.660-2-kuqin12@gmail.com>, In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-06-15T16:20:39.7975735Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: outlook.com; dkim=none (message not signed) header.d=none;outlook.com; dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e2c76e34-3d94-4922-f511-08d930198c82 x-ms-traffictypediagnostic: MWHPR21MB0750: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1PpXTOPFgN052dk58e63OobUCE3B6VLX9JnJqtuZ0ohxH17dC+SSO00IZ4yoa2VARlmgiTuu21NsO7/J9q08+myytZ2S3J1pzn5Xc918eFBuMHB2F+QbIbS3yjh3Sm055xlOq704iThUDb912yaWfu7Gt90y/hnjrub8OXYEJEUFAKUVPBvU22Jxy//braWSd8lXN0Frf05h4PWLl6Y45I1Y5h3KmDktJxvupbz1RfJ/Gl4yv1I7g/laH2ZyKOrqeK7mnapDeNLPKEiyPgYgA2q8aLDQNUl0xr74TH8TaMl70WFE9QGcm5M7KXgToDNoLHhgDX/Y/2BQRaX2rtZZSHHbCb+B4y4F0qZretVMWE9Q34Df0FxlWlCkDoXu76t6t1kJWHPMN/+PN0N6YqSVPNDN7C8Nws0cQx+O/dMujEZFLAufvjD/kd9AumEJeZ7YJ9y1ROLwXBNAyNAkoI1tdz6r5B5FzTep/x9KUBYXr278tD1kK3Etxtlr8Z485rvVGOLhRSPT42KaWM/3JRYvMeLm6hJNnaYxRYnyFAXtsR2ei850oHwHToFUj/80dBzcVamdenal0qDOR4igfhogOaNHSzdPIO2GzgQ+EuFIpmo6icvd5uaNgjeSta7EzUe9B2XpuR5KlOMNINP9y8JlwmpegtPUFVi/2oTJndETxN/GrLbaNIpaBodEe+Pg5eJQ274YVTHw0c4k02JM0ZnjnsJQIgTkygleEvFpb1l+D7miGjxftVqKGhQrDkTKHs/GTYX2pbDRe8ls8ManhSBU/A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR21MB1907.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(316002)(4326008)(2906002)(33656002)(8990500004)(8676002)(110136005)(54906003)(10290500003)(9686003)(82960400001)(86362001)(26005)(5660300002)(166002)(55016002)(186003)(82950400001)(7696005)(76116006)(66946007)(66476007)(66446008)(66556008)(64756008)(122000001)(6506007)(53546011)(83380400001)(38100700002)(966005)(71200400001)(478600001)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?J96YxMLzr4/v+48wIAtdszMBMmLIrpgyHh6BmBgxlOhoRqpg1j5BDQmTfTeq?= =?us-ascii?Q?gWcAFhB6BY/hqtqR3QtSWhV9Pem7qTptPFjX6qjpXaTNUEpL4C8/MT47mDN7?= =?us-ascii?Q?rnq67IYBqCApiAUB974YduBFVUauDURycfilm23iAi3RmdDJbaESmwhx8pSe?= =?us-ascii?Q?SImZTHSmxIDsM7SD4tbutbN98eUh/bR8519oRnL8OZ1ngEGdoDr4xt/HgcyY?= =?us-ascii?Q?ODT5iCY5vgx9nb3lGE/9xMVmDN6WExnB6wb1CPGzWZyADIWZ1L23ch/YV1KF?= =?us-ascii?Q?jXEZOcpTQgc6xUESrIN8lI1aR7lZN3fjAwZd2gPqV0CW114nvXa82pisbM0Y?= =?us-ascii?Q?C3Si0gyaIvfqtLz0Vzc55xJ43tigZknGJ0LKv/j9ZdAWOvJ0dCHq8gjzgYTK?= =?us-ascii?Q?2ic0FpmisFTxeIohbZnXmMhgIH4yYzElFPThkhAqR+QyYv+83kRAStPfi8re?= =?us-ascii?Q?W1q4JvKrgE0mDFc2uXhd5NvT58CU6lRxdzXQ55V7+rZEDPndsW+I5a1f0g6u?= =?us-ascii?Q?sH9hAAuQqEtDpE9cLuQCwJEOtaYYbMY2lJGVtDxp1/2nEU8UrhXiAZxPLyxV?= =?us-ascii?Q?6N1ikXNYvCRQ/zxAiAZ8mUOz/Ub/RzvZ8O7Bu37gR+kEFcrMYiRuNi9kCy83?= =?us-ascii?Q?dezeMMHJsb8ErXxzTdl1VR960zURsaNhjKvkZjGvmMoYuMpcYTom2fzuhW3A?= =?us-ascii?Q?LBCM8SnUCOPs1ZJZx1d/CAL5sDCQ50dtVQqbCLammiTz8Uk5K8dWU/kzouIm?= =?us-ascii?Q?VQouFRHSWyqc0+2f6fQkResccrWhu3nqeZWKbJ33HTshmKNneiHhzEGpIKzs?= =?us-ascii?Q?6sScQSXkEkOgR1dfHA2ku+9tXhgcQttlf1IISwFVSkj82d9sOG//dwHfcuZC?= =?us-ascii?Q?phANQNE9jXLvtdBTTAxIMf9zWKcTTaU28c67dEmShx+ASc+1OM5x7xsWutbB?= =?us-ascii?Q?NKoW5JvBnHV6WIPuWnUzdLlr6vNXpO5mZS3eqEPzqex0DYbexlcUDDUTrCGb?= =?us-ascii?Q?QJer8YLQYnDgvc7lmNMbV8K06bTWiT4YnsTTpPJ9rTKZI965bGNRdmCRxgoc?= =?us-ascii?Q?jELeDAA6CHzVbqu9EeJTBESfO3Dx8TxRQUCAXdxjjs/aJzADSK/GD1kDByT+?= =?us-ascii?Q?NL4Zv4wSJ68m27RnsgrEAMFmhw4A/+GUdZEA0GH8xfSrbU4M+TZ/UTx29CH4?= =?us-ascii?Q?yKMQmYHY/t3qUeRU6+RxhImUPX8PhxekA09TLevtLkRtaCd4Fm01vxqgoDvQ?= =?us-ascii?Q?ZZghb+oYfEQ8Q7PKj8gA7ou3tzgEdMDdSVSrgK5o7AEdrK6yRYPL8BKUWZaU?= =?us-ascii?Q?G4Xriw9WBAz7FzI+/IqboUuUd5v48Po2HwIrBlkWYl4dbg=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR21MB1907.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2c76e34-3d94-4922-f511-08d930198c82 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2021 16:20:53.7910 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WnZMOWmL4lHGUkzap6E9N3GIPAgKqbGgL2tqJzU5fNEAwO0LV2QsW3ZeLqN/n3SbaMEgcOGLlZuG1IjhVIP4Aw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0750 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR21MB1907B10CA0867EE2E21D1573EF309MW4PR21MB1907namp_" --_000_MW4PR21MB1907B10CA0867EE2E21D1573EF309MW4PR21MB1907namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bret Barkelew - Bret From: Sean Brogan Sent: Tuesday, June 15, 2021 9:00 AM To: devel@edk2.groups.io; kuqin12@gmail.com Cc: Sean Brogan; Bret Barkelew; Kinney, Michael D; Liming Gao Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v1 1/1] Pytool: SpellCheck: Def= er path expansion in cspell parameters Please update the signed-off-by to include yours. Reviewed-by: Sean Brogan Thanks Sean On 6/11/2021 10:04 PM, Kun Qin wrote: > From: Sean Brogan > > REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2F= bugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3454&data=3D04%7C01%7CBret= .Barkelew%40microsoft.com%7C436f445e3f774d2549b608d930169d05%7C72f988bf86f1= 41af91ab2d7cd011db47%7C1%7C0%7C637593696216659744%7CUnknown%7CTWFpbGZsb3d8e= yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&am= p;sdata=3DpJiLG4bZ8gYR0MjDuNTmuT3NgRjq%2FZRMnTi1sT67VqM%3D&reserved=3D0 > > On Linux the shell expands the wildcard paths and causes multiple files > to be missed. This change adds additional quotes to defer expansion in > order to bring parity in cspell result. > > Cc: Sean Brogan > Cc: Bret Barkelew > Cc: Michael D Kinney > Cc: Liming Gao > > Signed-off-by: Sean Brogan > --- > .pytool/Plugin/SpellCheck/SpellCheck.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/.pytool/Plugin/SpellCheck/SpellCheck.py b/.pytool/Plugin/Spe= llCheck/SpellCheck.py > index 43365441b91c..97b240ef747c 100644 > --- a/.pytool/Plugin/SpellCheck/SpellCheck.py > +++ b/.pytool/Plugin/SpellCheck/SpellCheck.py > @@ -133,7 +133,8 @@ class SpellCheck(ICiBuildPlugin): > # > relpath =3D os.path.relpath(abs_pkg_path) > cpsell_paths =3D " ".join( > - [f"{relpath}/**/{x}" for x in package_relative_paths_to_spel= l_check]) > + # Double quote each path to defer expansion to cspell parame= ters > + [f'"{relpath}/**/{x}"' for x in package_relative_paths_to_sp= ell_check]) > > # Make the config file > config_file_path =3D os.path.join( > --_000_MW4PR21MB1907B10CA0867EE2E21D1573EF309MW4PR21MB1907namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Reviewed-by: Bret Barkelew <bret.barkelew@microso= ft.com>

 

- Bret

 

From: Sean Brogan
Sent: Tuesday, June 15, 2021 9:00 AM
To: devel@edk2.groups.io= ; kuqin12@gmail.com
Cc: Sean Brogan; Bret Barkelew; Kinney, Mi= chael D; Liming Gao
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v1 1/1] Pytool: SpellChe= ck: Defer path expansion in cspell parameters

 

Please update the signed-off-by to include yours.
Reviewed-by: Sean Brogan <sean.brogan@microsoft.com>

Thanks
Sean


On 6/11/2021 10:04 PM, Kun Qin wrote:
> From: Sean Brogan <sean.brogan@microsoft.com>
>
> REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzill= a.tianocore.org%2Fshow_bug.cgi%3Fid%3D3454&amp;data=3D04%7C01%7CBret.Ba= rkelew%40microsoft.com%7C436f445e3f774d2549b608d930169d05%7C72f988bf86f141a= f91ab2d7cd011db47%7C1%7C0%7C637593696216659744%7CUnknown%7CTWFpbGZsb3d8eyJW= IjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&a= mp;sdata=3DpJiLG4bZ8gYR0MjDuNTmuT3NgRjq%2FZRMnTi1sT67VqM%3D&amp;reserve= d=3D0
>
> On Linux the shell expands the wildcard paths and causes multiple file= s
> to be missed. This change adds additional quotes to defer expansion in=
> order to bring parity in cspell result.
>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>
> Signed-off-by: Sean Brogan <sean.brogan@microsoft.com>
> ---
>   .pytool/Plugin/SpellCheck/SpellCheck.py | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/.pytool/Plugin/SpellCheck/SpellCheck.py b/.pytool/Plugin/= SpellCheck/SpellCheck.py
> index 43365441b91c..97b240ef747c 100644
> --- a/.pytool/Plugin/SpellCheck/SpellCheck.py
> +++ b/.pytool/Plugin/SpellCheck/SpellCheck.py
> @@ -133,7 +133,8 @@ class SpellCheck(ICiBuildPlugin):
>           #
>           relpath = =3D os.path.relpath(abs_pkg_path)
>           cpsell_pat= hs =3D " ".join(
> -            [f= "{relpath}/**/{x}" for x in package_relative_paths_to_spell_check= ])
> +            # = Double quote each path to defer expansion to cspell parameters
> +            [f= '"{relpath}/**/{x}"' for x in package_relative_paths_to_spell_che= ck])
>  
>           # Make the= config file
>           config_fil= e_path =3D os.path.join(
>

 

--_000_MW4PR21MB1907B10CA0867EE2E21D1573EF309MW4PR21MB1907namp_--