From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.107.77.129]) by mx.groups.io with SMTP id smtpd.web12.35464.1618244625531525736 for ; Mon, 12 Apr 2021 09:23:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=ZvmnjtRb; spf=pass (domain: microsoft.com, ip: 40.107.77.129, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LtZpeza+ASfXpDjjTIOX06LqSqU56/EPNxQj9qufX7hj3RGI20QtwOA3nNW/W+UbnpJTVmXtdbCUfHI2dzoQJ7bfLto744QnY0bWcArevVckXyxTpK78hD9QltlqYqvgkVkIFyhfJpHD4JO/df+TxL0RYhXzFjI103B24FhDZ1WxWOp8trFKTurO7zRYBVQXgn2ZB0PZYD9dy7KC7lvE9eerf2ZCfAEVIGVpcRNvfKeBpaBNZ25f9xdtSbCOQpFVRURLFe+n7VYa+3rUPbDu/J35P6jlFZogKvV2yVblu4J9EytXjxZjmLb+r1GTJn2yJZL+qDW+SZFTs8DjbjXA7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7VuP+WuDp4v4Hf/ZbImMT4KEpCsJ/lG7QZsv3WrmQq4=; b=cpSLzjd/YYFRs4K9VtgsY2Nk0rqXposcRGrL0QtmGYtbAZg/cjWF/AjGDeh9jglAlso1OCFESzBQZ/m2EjcZMF3/QIFGdZop826gHGTgh/osFRVPfloa2WhDUpuBm58G6orPbDqOC6uVzESe0IhQsMuXWSD/J2mNku7rlZVEdLglb5IAS5C4EpJNzwgAcyTv4p6WhAMLyPfxGZ0kmQIz6YG0R4kkUPvtDcGnUYcZ4pqDQKJAcIzBvhZ4Qb684T3/FNLHLm+x1K7EPs0Gl1WlhrpyWyznKx9ddGpGZx/Y/ukxrpH0OakFRAJuBpoYz8KCOVVYTtB4ZIkSZ52KUk9mkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7VuP+WuDp4v4Hf/ZbImMT4KEpCsJ/lG7QZsv3WrmQq4=; b=ZvmnjtRbWB2eWIW173x7I6OUPsZCr8sYYRQwbnVSOkoa3sBB/Zqq+asgHHFQoG0zIxjpI5tNZO+N13+rCgLGM67sJgaZgSiwKL8NA7s3b2zvo229fnQWI/PPthXoPwPNuiMN6UAEpPyvRTsw6s1yD0dzvihz9dwBW2PmM8FMNYk= Received: from MW4PR21MB1907.namprd21.prod.outlook.com (2603:10b6:303:71::8) by MW4PR21MB1938.namprd21.prod.outlook.com (2603:10b6:303:7d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.2; Mon, 12 Apr 2021 16:23:43 +0000 Received: from MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::adcb:b821:ee26:3348]) by MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::adcb:b821:ee26:3348%8]) with mapi id 15.20.4065.005; Mon, 12 Apr 2021 16:23:43 +0000 From: "Bret Barkelew" To: "devel@edk2.groups.io" , "hao.a.wu@intel.com" , Bret Barkelew CC: "Wang, Jian J" Subject: Re: [PATCH v1 1/1] MdeModulePkg: Initialize temp variable in VarCheckPolicyLib Thread-Topic: [PATCH v1 1/1] MdeModulePkg: Initialize temp variable in VarCheckPolicyLib Thread-Index: AQHXL0Lh5NEZ4Mg/akW8HD7papYRe6qxEXi/ Date: Mon, 12 Apr 2021 16:23:43 +0000 Message-ID: References: <20210409182511.620-1-bret.barkelew@microsoft.com>, In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-04-12T16:22:12.9329987Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [174.21.70.23] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 63183ead-2924-49b0-59e8-08d8fdcf575c x-ms-traffictypediagnostic: MW4PR21MB1938: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: v0aeHg/yIfwGoy+WzS5Ni1a5JKy4q1yGxASgfJtSsledMIWnVlyzum3B2/r6fSEDhZ1NcqX4REyW04Mo6UJtquM/pWYl4aExakXRMmYYOYFzyHf06nZesAEuVVIcullhaMjtVRQim6/fBJOvDkM5hn9Pce7IOvJGD4SzLPbaV+9w9txwfj2akj49FeNZ67A5fvXlsc9l7Uu3+MQz81651KDvOz0dJ+1YTxmP00MSoPa5Vf2FQlZQvVKFUYrTN0I2TvRDWa61cRXASXrVZgEocinxTwbjOcfT2d25/Z2x7l7lM+DhXoBGGOl0LNWqGBM6MxkSHGPbd4yCuk5xjfnL8dksJrwLtfNK0FPO3SBFBeradddjiunvjyCj00toH6ui8NOa5pKN8edQaknvHUOEe2ORD2onr/ydYnBCvfz0nN4PTMd7th3IkZkV/M17XmdTKmgtYyikIvMQMVTGUzy94FPD78k00PW0rrzJvaiGRe6jzPPiYm4LN0uj3vfH9ni1oFVhDG83u/5cNuoc/EMTg/vj+RkLdLrLIM3slx/JSja3GPqWFUf/K/rI2eDqvZHrFOEVpSmRyygODxkYcIYFd33H8Tz4uMUt9jXAzW0R6qSszq8rUY7tvM2nbFnuz1XRzvRtyqLBp1bGGpGJBiTyryFOL+oHW1ig5wsTPhQLKwCy5CMLryvgkDZ+qJk9313A x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR21MB1907.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(376002)(136003)(366004)(396003)(346002)(966005)(38100700002)(82950400001)(71200400001)(478600001)(6506007)(76116006)(66446008)(4326008)(166002)(316002)(53546011)(186003)(66946007)(83380400001)(55016002)(9686003)(8676002)(8936002)(5660300002)(2906002)(33656002)(66556008)(8990500004)(110136005)(10290500003)(82960400001)(64756008)(7696005)(26005)(52536014)(86362001)(66476007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?AFd6sK6muJqx6VRFpueFARcuZ2AdFdaNuTP0fRQ6oVo3hCRazYE66U16ceuh?= =?us-ascii?Q?Vhl5H8ZBnSGWWHkb5ISSPLyaP0XGjqJaPQ89UL18TiC+hHCIiCqXTsqMxLIr?= =?us-ascii?Q?P/GUZO/9IMdvQ7EbwnQtrIpzzjkB0QwfWweNWeSBlW29t11MEE28/lx9v5jA?= =?us-ascii?Q?d1uNZsTt2koqdasEb8kfFE+NoiV5FX0hJoBMWPN2FGmylsFDdIudf3yC5MvU?= =?us-ascii?Q?+I4IFu2UJ4x8U+pBezEIhoHpUn6RcXwM3pBGT2Ge6tTTEP5z025q+lNnmsIF?= =?us-ascii?Q?jndOzVku1nuMqb9i/jUWHs7QHqoOAjTC0RJRB53BJLbKPuHXdgjcePjToFTL?= =?us-ascii?Q?RkSQemskwDAjuNoYTEByB942sddDxQRxY1jL2mTUPMrbzS9VwHZEr7Ztnos5?= =?us-ascii?Q?MGbrWMTe/iMdTf4k0ByCbr++n66ROu/skmlqyhguHsrgCaMA1yE3kjA5Aaij?= =?us-ascii?Q?pAxxRoMyMpkYHN5tazaBRZtcT37H2qMijPZXBdCJieM5g+t2HfPrvogGepqs?= =?us-ascii?Q?+PHtoOVaePdE+ZYjN1XOgW1AGOQ0T6nc3L2tycIcHSvFr6yqQPXp7LWaaz3L?= =?us-ascii?Q?Xln9Zvk0StTmFus5fWnZf3vwBRMrCry8E4AUDMEvwW/c5mp+wrIdcQMQfgG7?= =?us-ascii?Q?g+zXU0RmgN6irPmvYg4cL25jbax2HW0ySWzmw/p9ha3xtjw6Z5Q9ch2YPx+u?= =?us-ascii?Q?fLdeDQ/UiQhYEKlSO8kZOiU0VrfE5nwobfBXfCHUlu+rjbrJjmPC8OlVeU4F?= =?us-ascii?Q?P+RWiPfZbnNi3FfdbK/KHyAYxmJsGNXSF1gk9fgxGws+HAQqMLQuBbWLYKOR?= =?us-ascii?Q?Trp5RqluK6XUOgCIsos7/8e+GeWxn0XMJ97tYkpmNcBTDEZbZEpyEryjqvsN?= =?us-ascii?Q?gWWlusb9UInxG8g8M4A8hZ6Txmk37BRAm4FME87ksLe0sWxPc/gJw+nOaQ2U?= =?us-ascii?Q?CGWH50DfCq8BVm9S6z1HwGRjAgEh7YnUa3pSL7XP5ZIVl4tf3MGR6iLSbsj6?= =?us-ascii?Q?e58uPAjM+9KRf4DtDLRFNQEbLcE5ofFoRLlSP1lAyII0koAVVqVMpSEDi7/i?= =?us-ascii?Q?I6tBmtNoL6iaIZFQucQbaMhRywYW+zmkIchaJutP065Wxaabh6Zu8GblNxO4?= =?us-ascii?Q?5LeuNOad8+ziyM3nhv9HY0sGz/6QnsB1As+hiTGEWbYMjG/ZGdLvBH12OOXC?= =?us-ascii?Q?ee357BSqlHxhopE0uC50erZFZYNkJFZxQrwuJTUkyZEZZ7Ws0hnugDy5V1Ft?= =?us-ascii?Q?RifZ/JprOHFC6rgDSGW1q0w10oyDWU67UKIbGQkLi1rldixGIN0zOEqS9WvY?= =?us-ascii?Q?akd/1svXNrW+40jV8QzKu1egVJFb1wYk8GNx+afRUZeqSA=3D=3D?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR21MB1907.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63183ead-2924-49b0-59e8-08d8fdcf575c X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2021 16:23:43.7149 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Yjc6rDNxXNMU4IsXuwmIUPqjRPPtoAiFrhkciNzcOTlzGsY6WtNgpYEN9UpZSt/6b0T1cAkPt/NwhyM6eBAEfw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR21MB1938 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR21MB1907B72EF12891D70FBD003AEF709MW4PR21MB1907namp_" --_000_MW4PR21MB1907B72EF12891D70FBD003AEF709MW4PR21MB1907namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Looks like we have the requisite approvals. Shall I create a PR? - Bret From: Wu, Hao A via groups.io Sent: Sunday, April 11, 2021 7:23 PM To: Bret Barkelew; devel@edk2.groups.io Cc: Wang, Jian J Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Initiali= ze temp variable in VarCheckPolicyLib > -----Original Message----- > From: Bret Barkelew > Sent: Saturday, April 10, 2021 2:25 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > Subject: [PATCH v1 1/1] MdeModulePkg: Initialize temp variable in > VarCheckPolicyLib > > DumpVariablePolicy() will return EFI_INVALID_PARAMETER if the Buffer > pointer is NULL and the indirect Size is anything but 0. Since this Temp= Size > was not being initialized it is very likely that this sequence would not= return > the total buffer size as expected. > > Bugzilla: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A= %2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3310&data=3D04%7C01%= 7Cbret.barkelew%40microsoft.com%7Cdd597013a0874fa676f708d8fd5a02e2%7C72f988= bf86f141af91ab2d7cd011db47%7C1%7C0%7C637537910324146700%7CUnknown%7CTWFpbGZ= sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1= 000&sdata=3DqxCQ6vccJFzG8gH9qDBHD9xnl%2FCs3DdVUuMtHspanfY%3D&reserv= ed=3D0 > > Cc: Jian J Wang > Cc: Hao A Wu > Signed-off-by: Bret Barkelew > --- > MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c > b/MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c > index 14e1904e96d3..e50edb4ffc5a 100644 > --- a/MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c > +++ b/MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c > @@ -216,6 +216,7 @@ VarCheckPolicyLibMmiHandler ( > DumpParamsOut->TotalSize =3D 0; > DumpParamsOut->PageSize =3D 0; > DumpParamsOut->HasMore =3D FALSE; > + TempSize =3D 0; > SubCommandStatus =3D DumpVariablePolicy (NULL, &TempSize); Reviewed-by: Hao A Wu Best Regards, Hao Wu > if (SubCommandStatus =3D=3D EFI_BUFFER_TOO_SMALL && TempSize > = 0) { > mCurrentPaginationCommand =3D > VAR_CHECK_POLICY_COMMAND_DUMP; > -- > 2.28.0.windows.1 --_000_MW4PR21MB1907B72EF12891D70FBD003AEF709MW4PR21MB1907namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Looks like we have the requisite approvals. Shall I= create a PR?

 

- Bret

 

From: Wu, Hao A via groups.io Sent: Sunday, April 11, 2021 7:23 PM
To: Bret Barkelew; devel@edk2.groups.io
Cc: Wang, Jian J
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: I= nitialize temp variable in VarCheckPolicyLib

 

> -----Original M= essage-----
> From: Bret Barkelew <bret@corthon.com>
> Sent: Saturday, April 10, 2021 2:25 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.w= u@intel.com>
> Subject: [PATCH v1 1/1] MdeModulePkg: Initialize temp variable in
> VarCheckPolicyLib
>
> DumpVariablePolicy() will return EFI_INVALID_PARAMETER if the Buffer<= br> > pointer is NULL and the indirect Size is anything but 0. Since this T= empSize
> was not being initialized it is very likely that this sequence would = not return
> the total buffer size as expected.
>
> Bugzilla: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzil= la.tianocore.org%2Fshow_bug.cgi%3Fid%3D3310&amp;data=3D04%7C01%7Cbret.b= arkelew%40microsoft.com%7Cdd597013a0874fa676f708d8fd5a02e2%7C72f988bf86f141= af91ab2d7cd011db47%7C1%7C0%7C637537910324146700%7CUnknown%7CTWFpbGZsb3d8eyJ= WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&= amp;sdata=3DqxCQ6vccJFzG8gH9qDBHD9xnl%2FCs3DdVUuMtHspanfY%3D&amp;reserv= ed=3D0
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Signed-off-by: Bret Barkelew <bret.barkelew@microsoft.com>
> ---
>  MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c | 1 = +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib= .c
> b/MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c
> index 14e1904e96d3..e50edb4ffc5a 100644
> --- a/MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c
> +++ b/MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c
> @@ -216,6 +216,7 @@ VarCheckPolicyLibMmiHandler (
>          DumpParamsOut-&= gt;TotalSize =3D 0;
>          DumpParamsOut-&= gt;PageSize =3D 0;
>          DumpParamsOut-&= gt;HasMore =3D FALSE;
> +        TempSize =3D 0;
>          SubCommandStatu= s =3D DumpVariablePolicy (NULL, &TempSize);


Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


>          if (SubCommandS= tatus =3D=3D EFI_BUFFER_TOO_SMALL && TempSize > 0) {
>            mCu= rrentPaginationCommand =3D
> VAR_CHECK_POLICY_COMMAND_DUMP;
> --
> 2.28.0.windows.1





 

--_000_MW4PR21MB1907B72EF12891D70FBD003AEF709MW4PR21MB1907namp_--