From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (NAM04-MW2-obe.outbound.protection.outlook.com [40.107.101.130]) by mx.groups.io with SMTP id smtpd.web12.4281.1619817354404100766 for ; Fri, 30 Apr 2021 14:15:54 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=R6933pG1; spf=pass (domain: microsoft.com, ip: 40.107.101.130, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=An/RR6G9Pjpmi0Np88UKjtwyEZIovXTioFZl/qLCcNQAWCYJPGE0DzyMfY+WJygIoBGh6LUr56ZLxbJJc2BTWGw+faCxpxHjRMMDrFxUTDpdcq7CXqTYem8pYQPE14jQoyWfQ2CUr0UqRFSyBt+P9k47V3zKL9mXU2dKSsQbgBWIGTYo/33a/EzBZz0HcqeGUsAkELLC5z+c77BGAzkd5lHiW7VdBBDuMkVGUUJg1YL0n9GBm1xrJMvx6PeqZMrJW7g7S016vn6a3sWCmkcrDuf0YpPT0xeyUjqCjyDk9G9yTGYQKRwSUibBLAYVeAXKc9TBlWU4L2dWdDcurCp2nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cuBXGUn4c6v+Z03XXVw/v7YGIryN8Tbkrdu9qSBMExc=; b=Hnl2NLomgulFbEI0J30gjA7jf1I7U8Qdn8pyWeQU6ySE209Zk2xKs9snulEZOhowBMHnFTILNGv2mu8yksMtxP/C33XYSpFhqWtTV04z1XV6Q7/WDb/l+JPBEk01jZ9krV9fBWjdMmoyZcB00HZXnvPIRX45QkrXkIL8X0s+iA7ObymnlE4ZamRt8MR4n/yNsQs9SuP0BYGZ/tpiDDfX29Pr798Oa1LuLcqGghkkbexGpWYUN2Pghxp9Ki0Pl4VydLW0MMhAXSb694ZF3uIk5u4cLveNATI23sovjxcV3Mcqyx3srTJBodBKlO1QjaurmqNk/RuVx/EQGcuuisllMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cuBXGUn4c6v+Z03XXVw/v7YGIryN8Tbkrdu9qSBMExc=; b=R6933pG1A/v6iR7NNk4Jwed3kWQwIgCAyBowZzxf4br2psk55U801pRv+04Bzbh014MWzTPxNVfJAIriKuJfCmywooUFtJ8MtbdbK3caqAOv/kToCMZieivpVi+sdxfxwLR8cY5N8WDffVVG5U/u3aUcMLuc66FoAjoAKjOnWHE= Received: from MW4PR21MB1907.namprd21.prod.outlook.com (2603:10b6:303:71::8) by MWHPR21MB0749.namprd21.prod.outlook.com (2603:10b6:300:76::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.3; Fri, 30 Apr 2021 21:15:52 +0000 Received: from MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::adcb:b821:ee26:3348]) by MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::adcb:b821:ee26:3348%8]) with mapi id 15.20.4108.016; Fri, 30 Apr 2021 21:15:52 +0000 From: "Bret Barkelew" To: Getnat Ejigu , "devel@edk2.groups.io" CC: "Kinney, Michael D" , Sean Brogan Subject: Re: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU Thread-Topic: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU Thread-Index: AQHXPgTmttjaAu4s7EafIFhyMmIEcqrNj+Wm Date: Fri, 30 Apr 2021 21:15:52 +0000 Message-ID: References: <20210430210749.1112414-1-getnatejigu@gmail.com>,<20210430210749.1112414-2-getnatejigu@gmail.com> In-Reply-To: <20210430210749.1112414-2-getnatejigu@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-04-30T21:15:37.8718544Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [174.21.95.19] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8614b82d-7456-43e0-d1dc-08d90c1d22db x-ms-traffictypediagnostic: MWHPR21MB0749: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1923; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /4FcWqHQaBxjNR621CWk+WioLITf3r08MAca0s6U3HO1WMN9Rh1weszZSUeE6EaUFJNIYWN5c+r197et7qOqN0M3E5z2mJVjT0GHIJXLVyjj8gp9fI1YuJ1mHbIDpzmpE36Qg2nZncKSoR7+b0XPqkDV16svV9X5Cvg7tRpZYI7TTWFLOdQXW3Z6RSlbG0eR/v2TYbRe/KmmNe9z7+fh2rQABFUBMt42lvY7XIHKgEKWNGxDZL5GKWSYhpBlIEJikp3A7JVYLa3euaW4hYEzH60XtOCOopN+ao/mv79kpKl4tcr6xmm5kOmF5LM+4v1RUCtW1pWZCqq0SPzYIOWBJbVU7ttTUtNq7RrrcY+4H6MZ8XGy4LHneagZujjnfOTrKDBaIW1uPmGFfz+kt75bhiwcgYCy9VU4pLQ9LoK3xCPsFHXFzrRMplWqUEjp6Pa9XFvZoq6/v7T89I9WaJswiGHp0G26djGyD8wXC8DyE4gGy4zzFj+ROesIK1OYn6gsqS4XJXydTs4c75WXz3OeVvxUNP/gK1h/GqFpnl4v6tooPj1EAkBdOoLhsC67TmgecB3B1M2sJQBOAx2sAOWnwlSsc+ubr0qliYod2ZFxGWw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR21MB1907.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8990500004)(55016002)(38100700002)(52536014)(186003)(82960400001)(71200400001)(5660300002)(82950400001)(9686003)(76116006)(2906002)(122000001)(4326008)(64756008)(110136005)(8676002)(33656002)(107886003)(66556008)(26005)(54906003)(8936002)(316002)(66446008)(10290500003)(6506007)(7696005)(478600001)(53546011)(66946007)(66476007)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 2 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ys3pGhnRzTDUmiqh/87mBGxgaBoHApGmCjE810bXk51+VlAEpCNkOwAkycoI?= =?us-ascii?Q?n0srs6Nm5vkgwnB4KVfjBOmyFhiZE814q/H9npc2F3x1ifWm6/m/5Z2cU76p?= =?us-ascii?Q?C1VAPYl6PPIYTsaWyNvyQww7Ju7zBjrzXNn77ZqUY8a6OHKqLy0KwVGZ+qdv?= =?us-ascii?Q?r/iykJzQiHde4LedH+m+lBlP1HblhRwV6bGJIfBumZnwrT3K4Uz+SVGSVCxf?= =?us-ascii?Q?KEpj5P0+OliOzouy9g5FMOmL0wLRTs23hdiHRfh17sIa22ksKSJu8dFkuZ1n?= =?us-ascii?Q?keFpE2p1IUaFBD555YREOes9puemuoFp1ynTQFQJhkuiyBZeBHf8R4oQnHTo?= =?us-ascii?Q?g+dWeZv/Whk6rPWqc8iV6TTwsNWXikOMHkmtljjlhZytL9acN9p1mUnUPlW9?= =?us-ascii?Q?Xjt+3sKx8GELOVcmUaJYqDFvTQo+Ywu4B8z9D8if4E7UePiiOYBUyFDIndSv?= =?us-ascii?Q?bZ1DfLxSZB8Me+7vtGOXUtUzZD+aOhkxsih9mpZudZrQSTGhRmYPwaNjXxhq?= =?us-ascii?Q?qNCvn/olAGk6IB/YJz8gkHo/xFmj9arYDxdXlN9Hs0SgVpJZyJfTLHbk/E5H?= =?us-ascii?Q?lvmWrZhl3eAwd+nsZXx55Z3YFaW0kGPFifwDRwutB4qzl8wm3sh4ERFalEH7?= =?us-ascii?Q?HM/XROruSjqfyBr78z2PExLxQ54/9XTUvlpMuDI8GDKR8ncabDQpQYCRH3TC?= =?us-ascii?Q?tr07ihFKf8gHRfbc1N029o3Y1yJX39oMipb5AEyPgATjtz46Yz+oDA7fiPxV?= =?us-ascii?Q?k+CjP5h5pBVvDKLH7cYoesHE56HtXS4Rn/rPM2je7D6sZUoUuzavp2Jrk1A7?= =?us-ascii?Q?DSFhDN7q3v30rZKJOC8cVA5M5ImJdhlMAs8d94MfWPvdvL3U+jTIHXsFo4rf?= =?us-ascii?Q?31eu0XTZJfrHF0okv3YwN8cxOU3NYagp60f0Jet2bQTjn1OLlKnk3zJLuABn?= =?us-ascii?Q?ATwnohNJt7dAWPevHQi0/H+kCugRc9h6tkbJfrsm?= x-ms-exchange-antispam-messagedata-1: vOueUKNVPg4faCJbPUQQx99m3GjFV9D2mCGW/4k5Sfmn5ueXSqKVRMCM15+RnVLgarPDo7QA69v57kc6r3VnM33g4K7QqMug3r5Am+ElyrVvFDYvX0PgYuXuzT1mZykLgSoIZ2TKgEwR9kG8ubxToDxq2XJw3YT88so8K9OUKeHx1cuthM5MDmSa3t+7Yq3NXqSMhpn3VlnZ3sXSLzrScsDl3J29wT2VHG6LqMReaTJ28ZqN7GXYbpMhWHK7hEC3xbaroSj62NV84+teURVk551n0ZL6DSEhn//HJhIL1cerhhjGqd6n5NQaBbxx2lf2MbNyWZe9CJgQ/VR+VE3M8rupd5J6YlSXejzyfyF+/BvJaA== MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR21MB1907.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8614b82d-7456-43e0-d1dc-08d90c1d22db X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2021 21:15:52.7285 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /ybLxFsUuEbp90HrYBpGWjG50e8fIWuwMuFSj8vVW4C6KWBNMgOPHYcndjE1ro8Vt2/n+4YlSSJ/Es4QC7UtNw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0749 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR21MB1907C1740D8E151BFC845CC9EF5E9MW4PR21MB1907namp_" --_000_MW4PR21MB1907C1740D8E151BFC845CC9EF5E9MW4PR21MB1907namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bret Barkelew - Bret From: Getnat Ejigu Sent: Friday, April 30, 2021 2:07 PM To: devel@edk2.groups.io Cc: Kinney, Michael D; Sean Brogan; Bret Barkelew Subject: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test h= angs when running in OVMF/QEMU Sample unit tests in UnitTestFrameworkPkg hangs when running in OVMF/QEMU environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI to ReportPrint() function that use VA_ARGS. Signed-off-by: Getnat Ejigu Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew --- UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportL= ib.c | 1 + UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportL= ibConOut.c | 1 + UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportL= ibDebugLib.c | 1 + 3 files changed, 3 insertions(+) diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestR= esultReportLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/Uni= tTestResultReportLib.c index 66c9db457d80..7f7443a23391 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLib.c +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLib.c @@ -11,6 +11,7 @@ #include VOID +EFIAPI ReportPrint ( IN CONST CHAR8 *Format, ... diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestR= esultReportLibConOut.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportL= ib/UnitTestResultReportLibConOut.c index cfb0c5972bd1..db5402d6a210 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLibConOut.c +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLibConOut.c @@ -12,6 +12,7 @@ #include VOID +EFIAPI ReportPrint ( IN CONST CHAR8 *Format, ... diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestR= esultReportLibDebugLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultRepor= tLib/UnitTestResultReportLibDebugLib.c index 1402d0ef83e2..1d62c6a37117 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLibDebugLib.c +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLibDebugLib.c @@ -11,6 +11,7 @@ #include VOID +EFIAPI ReportPrint ( IN CONST CHAR8 *Format, ... -- 2.25.1 --_000_MW4PR21MB1907C1740D8E151BFC845CC9EF5E9MW4PR21MB1907namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Reviewed-by: Bret Barkelew <bret.barkelew@microso= ft.com>

 

- Bret

 

From: Getnat Ejigu
Sent: Friday, April 30, 2021 2:07 PM
To: devel@edk2.groups.io=
Cc: Kinney, Michael D<= /a>; Sean Brogan; Bret Barkel= ew
Subject: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit= test hangs when running in OVMF/QEMU

 

Sample unit tests in = UnitTestFrameworkPkg hangs when running in OVMF/QEMU
environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI to ReportPrint() function that use VA_ARGS.

Signed-off-by: Getnat Ejigu <getnatejigu@gmail.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
 UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLib.c         | 1 +
 UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLibConOut.c   | 1 +
 UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLibDebugLib.c | 1 +
 3 files changed, 3 insertions(+)

diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestR= esultReportLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/Uni= tTestResultReportLib.c
index 66c9db457d80..7f7443a23391 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLib.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLib.c
@@ -11,6 +11,7 @@
 #include <Library/DebugLib.h>

 

 VOID

+EFIAPI

 ReportPrint (

   IN CONST CHAR8  *Format,

   ...

diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestR= esultReportLibConOut.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportL= ib/UnitTestResultReportLibConOut.c
index cfb0c5972bd1..db5402d6a210 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLibConOut.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLibConOut.c
@@ -12,6 +12,7 @@
 #include <Library/DebugLib.h>

 

 VOID

+EFIAPI

 ReportPrint (

   IN CONST CHAR8  *Format,

   ...

diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestR= esultReportLibDebugLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultRepor= tLib/UnitTestResultReportLibDebugLib.c
index 1402d0ef83e2..1d62c6a37117 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLibDebugLib.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLibDebugLib.c
@@ -11,6 +11,7 @@
 #include <Library/DebugLib.h>

 

 VOID

+EFIAPI

 ReportPrint (

   IN CONST CHAR8  *Format,

   ...

--
2.25.1

 

--_000_MW4PR21MB1907C1740D8E151BFC845CC9EF5E9MW4PR21MB1907namp_--