From: "Bret Barkelew" <bret.barkelew@microsoft.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
Getnat Ejigu <getnatejigu@gmail.com>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
Date: Fri, 30 Apr 2021 21:16:18 +0000 [thread overview]
Message-ID: <MW4PR21MB1907CB70AB9D4B0E9C61D32DEF5E9@MW4PR21MB1907.namprd21.prod.outlook.com> (raw)
In-Reply-To: <MW4PR21MB1907C1740D8E151BFC845CC9EF5E9@MW4PR21MB1907.namprd21.prod.outlook.com>
[-- Attachment #1.1: Type: text/plain, Size: 3353 bytes --]
Mike,
Can you stage the PR for this? Thanks!
- Bret
From: Bret Barkelew via groups.io<mailto:bret.barkelew=microsoft.com@groups.io>
Sent: Friday, April 30, 2021 2:16 PM
To: Getnat Ejigu<mailto:getnatejigu@gmail.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Kinney, Michael D<mailto:michael.d.kinney@intel.com>; Sean Brogan<mailto:sean.brogan@microsoft.com>
Subject: Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>
- Bret
From: Getnat Ejigu<mailto:getnatejigu@gmail.com>
Sent: Friday, April 30, 2021 2:07 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Kinney, Michael D<mailto:michael.d.kinney@intel.com>; Sean Brogan<mailto:sean.brogan@microsoft.com>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>
Subject: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
Sample unit tests in UnitTestFrameworkPkg hangs when running in OVMF/QEMU
environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI
to ReportPrint() function that use VA_ARGS.
Signed-off-by: Getnat Ejigu <getnatejigu@gmail.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c | 1 +
UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c | 1 +
UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
index 66c9db457d80..7f7443a23391 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
@@ -11,6 +11,7 @@
#include <Library/DebugLib.h>
VOID
+EFIAPI
ReportPrint (
IN CONST CHAR8 *Format,
...
diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
index cfb0c5972bd1..db5402d6a210 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
@@ -12,6 +12,7 @@
#include <Library/DebugLib.h>
VOID
+EFIAPI
ReportPrint (
IN CONST CHAR8 *Format,
...
diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
index 1402d0ef83e2..1d62c6a37117 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
@@ -11,6 +11,7 @@
#include <Library/DebugLib.h>
VOID
+EFIAPI
ReportPrint (
IN CONST CHAR8 *Format,
...
--
2.25.1
[-- Attachment #1.2: Type: text/html, Size: 6555 bytes --]
[-- Attachment #2: BAA86E05D2984CAF898F06C6D6A0A521.png --]
[-- Type: image/png, Size: 140 bytes --]
next prev parent reply other threads:[~2021-04-30 21:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 21:07 [PATCH v1 0/1] Fix sample unit test hang issue in OVMF/QEMU Getnat Ejigu
2021-04-30 21:07 ` [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running " Getnat Ejigu
2021-04-30 21:15 ` [EXTERNAL] " Bret Barkelew
2021-04-30 21:16 ` Bret Barkelew [this message]
2021-05-04 0:28 ` [edk2-devel] " Michael D Kinney
2021-05-04 0:38 ` Michael D Kinney
2021-05-04 2:28 ` Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR21MB1907CB70AB9D4B0E9C61D32DEF5E9@MW4PR21MB1907.namprd21.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox