From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (NAM04-MW2-obe.outbound.protection.outlook.com [40.107.101.93]) by mx.groups.io with SMTP id smtpd.web10.4438.1619817380304649033 for ; Fri, 30 Apr 2021 14:16:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=c+dKHYlV; spf=pass (domain: microsoft.com, ip: 40.107.101.93, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VvfRa3nvckVMBs4lVTSE/3AhP2g5cUy9Ul2nPOvMg3YlY1RBAGt5kAhkDvv/0BacHTO0/JkdzqVo/755fH2tdsdWcYJC9QBAn3xbZ9nqgkSeQQGOsrsSN+0v3fXiJTPc6sEEd7UVDXBGDOKAUrwZk+Bn4Ty7qp7LPfvcKLI8AIjOWi93hYwALCXkkAL1d83SYQo+3C1lMOscJiUiPbUOLKdrM2IywDn1Llh1FCbyMSOe76c2KQxy0F3GjkyNgIYfcF7Ep8P5XJZDPD7klzDweRO6qd1o0EPBMWoZMCIv8qeSoe9tEVjYewYbymG+S6lEkRzCjZgteKNnuclsb5xs8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HwZgj65RZt06NdbFC/T03NCn/Z6gmG57E74hFDpVKbQ=; b=c3ZxaCy0tn52K9RTsEHvVDRDSMxlPdgYkJaQtqLibUt1dDFZrJoyzxVfq3etNjpUNiy8gDA5FBfnZ4oygVtz5W4nYnDQo2bOUv6oWFugmrFCS+lehO9HsftyXd7RCSeHm4nzUO3A7nJgnOR8sClGlFxgVCfXhRhWD6xnXW3bxa5mXPpe91fKUKNb9390K0qhY4iJxPW5U/0fIWLa5htDAoqGfzf0KWkbyDPDKROaRrghDLEm/V/zsfiJ6nQprsrTzPgtANgSPsc0ep3YGsGdWkfAgHaNPDDvbNaRJ2xFG26hRZ/Ws4s2G/UBh4kahbYO8spSLUnmXPJRcQ5FJJPFTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HwZgj65RZt06NdbFC/T03NCn/Z6gmG57E74hFDpVKbQ=; b=c+dKHYlVvby/3m0g5jeQq9+yzqyTiN3G1qd/iGrxG1WOBh9lqtvrj0OYvuS2CgXMUcGr5ClqP/QC+MMYRevLA4A2afSORhltFtH6EF+t7eEm9Pu176Pbp8wJzykPdk0Z3lBAovFECTBUQvVdc5AW5vAGLyY7mFxdcolpBvh4ugQ= Received: from MW4PR21MB1907.namprd21.prod.outlook.com (2603:10b6:303:71::8) by MWHPR21MB0749.namprd21.prod.outlook.com (2603:10b6:300:76::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.3; Fri, 30 Apr 2021 21:16:18 +0000 Received: from MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::adcb:b821:ee26:3348]) by MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::adcb:b821:ee26:3348%8]) with mapi id 15.20.4108.016; Fri, 30 Apr 2021 21:16:18 +0000 From: "Bret Barkelew" To: "devel@edk2.groups.io" , Getnat Ejigu CC: "Kinney, Michael D" , Sean Brogan Subject: Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU Thread-Topic: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU Thread-Index: AQHXPgTmttjaAu4s7EafIFhyMmIEcqrNj+WmgAAAIZI= Date: Fri, 30 Apr 2021 21:16:18 +0000 Message-ID: References: <20210430210749.1112414-1-getnatejigu@gmail.com>,<20210430210749.1112414-2-getnatejigu@gmail.com>, In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-04-30T21:15:37.8718544Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [174.21.95.19] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6460a3a1-930b-4ad0-4e0d-08d90c1d3266 x-ms-traffictypediagnostic: MWHPR21MB0749: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2733; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1Ek2L5QGADFxBm+4arm2VGv6bY0Cp0HnRzMnipVvEBFwWjeaMUN20MmhSxcQ6GKI9yro+fFX+wlzCf7tnRLbhgZrLinmeh2z5DfZUcWINbSqajf2/oh1eKIpFPuMH4Pljx7/L4U+gNAZ/GY2tP1JlWDZOU25YZjIRx77NwnTc0Yl60pqPC/NCwc3y9bP5EYyTv1kLsfsbm2wyLU2I3q8DOSRiq5hKDDnHGz8U1qoEDeypRBilXsCA1ZXblqG7S97OSaApislgecZbCIj6I1lQhJ+yHfklO7i5724PLf4cU+3J30zTZwR4ef56p2aHPiLW5EA87dMWXxN6KiY9kqHniSepGqAQO6xJe0HsdXZef5ShzuD+Pti2L/861ELVogDAIPfniOP5FWsmhMoNGFqWzXnb+HsJqDz4k+Cn618hUoy5kNMZGrLQh3D7lVz6cKqQ33rn7wPzQW3RK2VhDxXOJmDltd8vBAx04FCS6tsl3eNsNx9JLobhV4yO9Qy1QOs60/yRyZ2vOye5jjCjmxL+IKnKjGTUqUB7O2Wi17wiPfRc+C0xpA0x9We69eta52NGzaNHrkcmeaL55bxRiLbn6aD9yeaJf8PUrYx1UzqpuTxphr78ND4SvIyj90gekklOr4dU80OlaSOfVoG6jWQYki43J8xc4SnC3G3GCx87D/rr1l24MTf8iukgGf/BHrX x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR21MB1907.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8990500004)(55016002)(38100700002)(2940100002)(52536014)(186003)(82960400001)(99936003)(71200400001)(83380400001)(5660300002)(82950400001)(9686003)(76116006)(2906002)(166002)(122000001)(4326008)(64756008)(110136005)(8676002)(76236003)(33656002)(107886003)(66556008)(26005)(54906003)(8936002)(316002)(66446008)(10290500003)(6506007)(7696005)(478600001)(53546011)(66616009)(66946007)(66476007)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 2 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?shqJd511/M4vZpFi4MRPd1owlmq7xdSEn2hlj2tFHBoWc3oPsIBeq089c14y?= =?us-ascii?Q?mb5uBc57qs3tpXto1OEMq6QDHnx9HCSZLK1Jkrm5vvyBGG5czN1YxY+7CEgT?= =?us-ascii?Q?NmY+iAL5gmwd7CAqXtsejnx3GwIT+v0KsJK6CXtIQprfvsngRbow8oQySKLZ?= =?us-ascii?Q?28siKLzlmL6nVijGJzOSe0Cd4PW43K9mxETo5f2ap7/D3Mxl6FYlYffgQCOw?= =?us-ascii?Q?szwt3ISdOcNnteCRsZBrGvfU3006ina77gI1iGJ5KBTbdFFe88cM3M6s3yyQ?= =?us-ascii?Q?EMaIhgnnWBoDCvLvd5AfNFsZIW81CddfrBXpzjLAT+iLc2GC/cOX5YD612xG?= =?us-ascii?Q?7C7g3A/+GUtnj4RRKg3Ji9zYbDx90E6fWuxv8iiyDGlWnbsKM6H450ahnpPq?= =?us-ascii?Q?mTP188uXBN93eCfbch1YFgOjEc5A+LQOIResphlXzqAr0jL6Ti4YGmdp/ETx?= =?us-ascii?Q?T5wr/gVSeV/9ys6V2OnoJbc+TXwUtsZrJqCh+emkth3yn7WK4SaEVSD8deNu?= =?us-ascii?Q?NF5XVwVayntqJC+ASY2PXJ3fxEDioRiUdYNnrvyPjcKU4bB/QGrBZ/mURZPQ?= =?us-ascii?Q?5pX0pMOhdyF2btfoSsCwVnVPEkCJ9mctuJrZ4x6q3/39R3YrBV32Rb/M/dMQ?= =?us-ascii?Q?3S1qbVKKPav0trAJGw1R+85vR+er0TeF/4SASf53C69lVS5z3JrulhDkkkQU?= =?us-ascii?Q?ACcp6vuQkEFqqEhVgyMylswWHcQaRkZu4wjc7fFQMDDY3JPhNIzjQSg8Rl7C?= =?us-ascii?Q?nVUCJ8gYiFvrlE2oDOOU3c0ZqutlJ+MvN9F3RKa0WkfLGvnVV40CVtsPxoSV?= =?us-ascii?Q?j519355NCRDtccquDTdo8njRC73T09yqCfffi7c7dBm9caZT50h3zijyR0kB?= =?us-ascii?Q?O0X+sDNrldO+D47zBaEBfSguQQ5I0dvA6GIndiTAOzSKT3POttwhMItxGCCJ?= =?us-ascii?Q?XAqnTCg47Or9AXfkC3bhdCYx4F/y7ewkr8HC6Bs1?= x-ms-exchange-antispam-messagedata-1: XKYkSHxTDAQ9zEG1EE0j10GKLmBkvomn8tx/ZGQzXNJIqiIwPy+KWwtobReUPPeqsF7mTwMy8calPDT++s7V3oYpdw08y/R77cL1RiElhO33or1x5sCCQC1HiKt+YlN7/LUjZQUDPYjmeEEezQ9gCs35i78ZMHUxqE6SDctzMC5PsHwxlwIWKTdpa1ibXI4UgcEGGDmhtomVzDSapgX1JlJA1uFL4Aisc/z0aIx+7CFSllGZHR7cx0DSQqAnWKyFQurQPc82QAvjl2AHWjp4c4VQCtaXmFETnZCe1PSuVZlAvxDZxiWCOjWig84VyGC8V5Kmq8lUSrg1P/q7xTV18XGnbqV/tqi6Eygc3cVLjtuvzQ== MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR21MB1907.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6460a3a1-930b-4ad0-4e0d-08d90c1d3266 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2021 21:16:18.7332 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NhQWTkJgeaojWfKAwTg318BcftlJBfzmND1zKYqFiPdCcvZmhF7Bz6xZokwQZ6kgjIAl0XQnFQ0nJD+V0Apsgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0749 X-Groupsio-MsgNum: 74683 Content-Language: en-US Content-Type: multipart/related; boundary="_004_MW4PR21MB1907CB70AB9D4B0E9C61D32DEF5E9MW4PR21MB1907namp_"; type="multipart/alternative" --_004_MW4PR21MB1907CB70AB9D4B0E9C61D32DEF5E9MW4PR21MB1907namp_ Content-Type: multipart/alternative; boundary="_000_MW4PR21MB1907CB70AB9D4B0E9C61D32DEF5E9MW4PR21MB1907namp_" --_000_MW4PR21MB1907CB70AB9D4B0E9C61D32DEF5E9MW4PR21MB1907namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Mike, Can you stage the PR for this? Thanks! - Bret From: Bret Barkelew via groups.io Sent: Friday, April 30, 2021 2:16 PM To: Getnat Ejigu; devel@edk2.groups.io Cc: Kinney, Michael D; Sean Brogan Subject: Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: = Sample unit test hangs when running in OVMF/QEMU Reviewed-by: Bret Barkelew - Bret From: Getnat Ejigu Sent: Friday, April 30, 2021 2:07 PM To: devel@edk2.groups.io Cc: Kinney, Michael D; Sean Brogan; Bret Barkelew Subject: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test = hangs when running in OVMF/QEMU Sample unit tests in UnitTestFrameworkPkg hangs when running in OVMF/QEMU environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI to ReportPrint() function that use VA_ARGS. Signed-off-by: Getnat Ejigu Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew --- UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReport= Lib.c | 1 + UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReport= LibConOut.c | 1 + UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReport= LibDebugLib.c | 1 + 3 files changed, 3 insertions(+) diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTest= ResultReportLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/Un= itTestResultReportLib.c index 66c9db457d80..7f7443a23391 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultR= eportLib.c +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultR= eportLib.c @@ -11,6 +11,7 @@ #include VOID +EFIAPI ReportPrint ( IN CONST CHAR8 *Format, ... diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTest= ResultReportLibConOut.c b/UnitTestFrameworkPkg/Library/UnitTestResultReport= Lib/UnitTestResultReportLibConOut.c index cfb0c5972bd1..db5402d6a210 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultR= eportLibConOut.c +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultR= eportLibConOut.c @@ -12,6 +12,7 @@ #include VOID +EFIAPI ReportPrint ( IN CONST CHAR8 *Format, ... diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTest= ResultReportLibDebugLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultRepo= rtLib/UnitTestResultReportLibDebugLib.c index 1402d0ef83e2..1d62c6a37117 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultR= eportLibDebugLib.c +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultR= eportLibDebugLib.c @@ -11,6 +11,7 @@ #include VOID +EFIAPI ReportPrint ( IN CONST CHAR8 *Format, ... -- 2.25.1 --_000_MW4PR21MB1907CB70AB9D4B0E9C61D32DEF5E9MW4PR21MB1907namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Mike,

 

Can you stage the PR for this? Thanks!

 

- Bret

 

From: Bret Barkelew via gr= oups.io
Sent: Friday, April 30, 2021 2:16 PM
To: Getnat Ejigu; devel@edk2.groups.io
Cc: Kinney, Michael D= ; Sean Brogan
Subject: Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFramewo= rkPkg: Sample unit test hangs when running in OVMF/QEMU

 

Reviewed-by: Bret Barkelew <bret.barkelew@micros= oft.com>

 

- Bret

 

From: Getnat Ejigu
Sent: Friday, April 30, 2021 2:07 PM
To: devel@edk2.groups.io
Cc: Kinney, Michael D= ; Sean Brogan; Bret Barke= lew
Subject: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample uni= t test hangs when running in OVMF/QEMU

 

Sample unit tests in= UnitTestFrameworkPkg hangs when running in OVMF/QEMU
environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI<= br> to ReportPrint() function that use VA_ARGS.

Signed-off-by: Getnat Ejigu <getnatejigu@gmail.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
 UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultR= eportLib.c         | 1 +
 UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultR= eportLibConOut.c   | 1 +
 UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultR= eportLibDebugLib.c | 1 +
 3 files changed, 3 insertions(+)

diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTest= ResultReportLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/Un= itTestResultReportLib.c
index 66c9db457d80..7f7443a23391 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultR= eportLib.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultR= eportLib.c
@@ -11,6 +11,7 @@
 #include <Library/DebugLib.h>

 

 VOID

+EFIAPI

 ReportPrint (

   IN CONST CHAR8  *Format,

   ...

diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTest= ResultReportLibConOut.c b/UnitTestFrameworkPkg/Library/UnitTestResultReport= Lib/UnitTestResultReportLibConOut.c
index cfb0c5972bd1..db5402d6a210 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultR= eportLibConOut.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultR= eportLibConOut.c
@@ -12,6 +12,7 @@
 #include <Library/DebugLib.h>

 

 VOID

+EFIAPI

 ReportPrint (

   IN CONST CHAR8  *Format,

   ...

diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTest= ResultReportLibDebugLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultRepo= rtLib/UnitTestResultReportLibDebugLib.c
index 1402d0ef83e2..1d62c6a37117 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultR= eportLibDebugLib.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultR= eportLibDebugLib.c
@@ -11,6 +11,7 @@
 #include <Library/DebugLib.h>

 

 VOID

+EFIAPI

 ReportPrint (

   IN CONST CHAR8  *Format,

   ...

--
2.25.1

 

 

--_000_MW4PR21MB1907CB70AB9D4B0E9C61D32DEF5E9MW4PR21MB1907namp_-- --_004_MW4PR21MB1907CB70AB9D4B0E9C61D32DEF5E9MW4PR21MB1907namp_ Content-Type: image/png; name="BAA86E05D2984CAF898F06C6D6A0A521.png" Content-Description: BAA86E05D2984CAF898F06C6D6A0A521.png Content-Disposition: inline; filename="BAA86E05D2984CAF898F06C6D6A0A521.png"; size=140; creation-date="Fri, 30 Apr 2021 21:16:18 GMT"; modification-date="Fri, 30 Apr 2021 21:16:18 GMT" Content-ID: Content-Transfer-Encoding: base64 iVBORw0KGgoAAAANSUhEUgAAAsQAAAABCAYAAADZ77itAAAAAXNSR0IArs4c6QAAAARnQU1BAACx jwv8YQUAAAAJcEhZcwAADsMAAA7DAcdvqGQAAAAhSURBVEhL7cMBDQAACAMg+5cygQkeRoMIG9WT VVXVn7MHYi5moJeByLMAAAAASUVORK5CYII= --_004_MW4PR21MB1907CB70AB9D4B0E9C61D32DEF5E9MW4PR21MB1907namp_--