public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bret Barkelew" <bret.barkelew@microsoft.com>
To: "pierre.gondois@arm.com" <pierre.gondois@arm.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"sami.mujawar@arm.com" <Sami.Mujawar@arm.com>,
	"leif@nuviainc.com" <leif@nuviainc.com>,
	"ardb+tianocore@kernel.org" <ardb+tianocore@kernel.org>,
	Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [EXTERNAL] [PATCH v1 12/12] AzurePipelines: Add support for ArmPlatformPkg
Date: Mon, 26 Apr 2021 20:57:27 +0000	[thread overview]
Message-ID: <MW4PR21MB1907D5C301DDA56D8C3D6D81EF429@MW4PR21MB1907.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20210421122048.11729-13-Pierre.Gondois@arm.com>

[-- Attachment #1: Type: text/plain, Size: 1919 bytes --]

I think the TARGET name should be updated to TARGET_ARM_ARMPLATFORM.
Otherwise,

Reviewed by: Bret Barkelew <bret.barkelew@microsoft.com>

- Bret

From: pierre.gondois@arm.com<mailto:pierre.gondois@arm.com>
Sent: Wednesday, April 21, 2021 5:21 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; sami.mujawar@arm.com<mailto:Sami.Mujawar@arm.com>; leif@nuviainc.com<mailto:leif@nuviainc.com>; ardb+tianocore@kernel.org<mailto:ardb+tianocore@kernel.org>; Sean Brogan<mailto:sean.brogan@microsoft.com>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>
Subject: [EXTERNAL] [PATCH v1 12/12] AzurePipelines: Add support for ArmPlatformPkg

From: Pierre Gondois <Pierre.Gondois@arm.com>

Add an entry to build the ArmPlatformPkg in the CI.

Fixes: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3349&amp;data=04%7C01%7CBret.Barkelew%40microsoft.com%7C5d0e796c603443cba5cb08d904bffdf6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637546044920304051%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=A8udDEiGEU4kXwVm88lNlnOCJq4c65uW7R4n%2FYYGUCs%3D&amp;reserved=0
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
 .azurepipelines/templates/pr-gate-build-job.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index 837079e7bd97..16d197cde913 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -22,7 +22,7 @@ jobs:
   strategy:
     matrix:
       TARGET_ARM:
-        Build.Pkgs: 'ArmPkg'
+        Build.Pkgs: 'ArmPkg,ArmPlatformPkg'
         Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
       TARGET_MDE_CPU:
         Build.Pkgs: 'MdePkg,UefiCpuPkg'
--
2.17.1


[-- Attachment #2: Type: text/html, Size: 4699 bytes --]

      parent reply	other threads:[~2021-04-26 20:57 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-21 12:20 [PATCH v1 00/12] ArmPkg/ArmPlatformPkg CI enablement PierreGondois
2021-04-21 12:20 ` [PATCH v1 01/12] ArmPkg: Fix Ecc error 8003 PierreGondois
2021-04-22  9:40   ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 02/12] ArmPkg: Fix Ecc error 3002 in StandaloneMmMmuLib PierreGondois
2021-04-22  9:40   ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 03/12] ArmPkg: Add missing library headers to ArmPkg.dec PierreGondois
2021-04-21 19:13   ` [edk2-devel] " brbarkel
2021-04-26 16:40     ` PierreGondois
2021-04-26 20:58       ` [EXTERNAL] " Bret Barkelew
2021-04-22  9:51   ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 04/12] ArmPkg: Add OemMiscLibNull library to ArmPkg.dsc PierreGondois
2021-04-21 19:14   ` [edk2-devel] " brbarkel
2021-04-22  9:52   ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 05/12] ArmPkg: Correct small typos PierreGondois
2021-04-22  9:53   ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 06/12] ArmPkg: Add ArmPkg.ci.yaml PierreGondois
2021-04-22 10:02   ` Sami Mujawar
2021-04-27 14:30     ` PierreGondois
2021-04-21 12:20 ` [PATCH v1 07/12] ArmPlatformPkg: Add ArmPlatformPkg.ci.yaml PierreGondois
2021-04-22 10:05   ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 08/12] .pytool: Enable CI for ArmPkg PierreGondois
2021-04-22 10:07   ` Sami Mujawar
2021-04-26 20:54   ` [EXTERNAL] " Bret Barkelew
2021-04-21 12:20 ` [PATCH v1 09/12] .pytool: Enable CI for ArmPlatformPkg PierreGondois
2021-04-22 10:07   ` Sami Mujawar
2021-04-26 20:55   ` [EXTERNAL] " Bret Barkelew
2021-04-21 12:20 ` [PATCH v1 10/12] .pytool: Document LicenseCheck and EccCheck PierreGondois
2021-04-22 10:08   ` Sami Mujawar
2021-04-26 20:56   ` [EXTERNAL] " Bret Barkelew
2021-04-21 12:20 ` [PATCH v1 11/12] AzurePipelines: Add support for ArmPkg PierreGondois
2021-04-22 10:09   ` Sami Mujawar
2021-04-26 20:58   ` [EXTERNAL] " Bret Barkelew
2021-04-21 12:20 ` [PATCH v1 12/12] AzurePipelines: Add support for ArmPlatformPkg PierreGondois
2021-04-22 10:09   ` Sami Mujawar
2021-04-26 20:57   ` Bret Barkelew [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW4PR21MB1907D5C301DDA56D8C3D6D81EF429@MW4PR21MB1907.namprd21.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox